136176 2014-08-22 15:51:38 -0700 Rubber-banding in overflow:scroll regions does not work correctly with direction:rtl 2014-08-26 11:30:14 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin commit-queue esprehn+autocc glenn kondapallykalyan sam simon.fraser thorton oldest_to_newest 1030817 0 bdakin 2014-08-22 15:51:38 -0700 Rubber-banding in overflow:scroll regions does not work correctly with direction:rtl 1030818 1 237004 bdakin 2014-08-22 15:52:25 -0700 Created attachment 237004 Test case Test case that shows the bug. 1030822 2 237006 bdakin 2014-08-22 16:02:32 -0700 Created attachment 237006 Patch 1030826 3 237006 simon.fraser 2014-08-22 16:07:30 -0700 Comment on attachment 237006 Patch no tests? 1030841 4 bdakin 2014-08-22 16:48:55 -0700 (In reply to comment #3) > (From update of attachment 237006 [details]) > no tests? I'm not sure that I can write a test that will actually behave differently with this change, but I will give it a shot. 1031265 5 bdakin 2014-08-25 17:11:03 -0700 (In reply to comment #3) > (From update of attachment 237006 [details]) > no tests? I spent some time today trying to make a test for this, and I still have not figured out how to make a reliable test. The momentum events that Brent added are cool, but they don't seem to be 100% consistent for replicating rubber-banding. 1031266 6 bdakin 2014-08-25 17:13:22 -0700 http://trac.webkit.org/changeset/172945 1031270 7 237006 thorton 2014-08-25 17:28:41 -0700 Comment on attachment 237006 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237006&action=review > Source/WebCore/rendering/RenderLayer.cpp:2645 > + return IntRect(IntPoint(scrollPosition().x(), scrollPosition().y()), Why not just IntRect(scrollPosition(), ...)? No need for all this fun. 1031299 8 bdakin 2014-08-25 20:31:48 -0700 (In reply to comment #7) > (From update of attachment 237006 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237006&action=review > > > Source/WebCore/rendering/RenderLayer.cpp:2645 > > + return IntRect(IntPoint(scrollPosition().x(), scrollPosition().y()), > > Why not just IntRect(scrollPosition(), ...)? No need for all this fun. r=you to fix, Tim? 1031311 9 thorton 2014-08-25 21:03:52 -0700 Absolutely! 1031426 10 bdakin 2014-08-26 11:30:14 -0700 (In reply to comment #9) > Absolutely! r172965 :D 237004 2014-08-22 15:52:25 -0700 2014-08-22 15:52:25 -0700 Test case overflow-scroll-rtl.html text/html 457 bdakin PGJvZHkgc3R5bGU9ImhlaWdodDoyMDAwcHg7IHdpZHRoOjIwMDBweDsiPgoKPGRpdiBzdHlsZT0i d2lkdGg6MjAwcHg7IGhlaWdodDoyMDBweDsgYm9yZGVyOjJweCBzb2xpZCBibGFjazsgb3ZlcmZs b3c6c2Nyb2xsOyBkaXJlY3Rpb246cnRsOyI+CiAgICA8ZGl2IHN0eWxlPSJiYWNrZ3JvdW5kLWNv bG9yOnB1cnBsZTsgd2lkdGg6MTBweDsgaGVpZ2h0OjUwMHB4OyBib3JkZXI6MnB4IHNvbGlkIHJl ZDsiPjwvZGl2Pgo8L2Rpdj4KCjxkaXYgc3R5bGU9IndpZHRoOjIwMHB4OyBoZWlnaHQ6MjAwcHg7 IGJvcmRlcjoycHggc29saWQgYmxhY2s7IG92ZXJmbG93OnNjcm9sbDsgZGlyZWN0aW9uOnJ0bDsi PgogICAgPGRpdiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjpwdXJwbGU7IHdpZHRoOjUwMHB4OyBo ZWlnaHQ6MTBweDsgYm9yZGVyOjJweCBzb2xpZCByZWQ7Ij48L2Rpdj4KPC9kaXY+Cgo8L2JvZHk+ Cg== 237006 2014-08-22 16:02:32 -0700 2014-08-25 17:28:41 -0700 Patch for-review.txt text/plain 1924 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Mjg3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA4LTIyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSdWJiZXItYmFuZGluZyBpbiBvdmVy ZmxvdzpzY3JvbGwgcmVnaW9ucyBkb2VzIG5vdCB3b3JrIGNvcnJlY3RseSB3aXRoIGRpcmVjdGlv bjpydGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz NjE3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVz ZSBzY3JvbGxQb3NpdGlvbigpIGluc3RlYWQgb2Ygc2Nyb2xsWE9mZnNldCgpIGFuZCBzY3JvbGxZ T2Zmc2V0KCkgd2hpY2ggYm90aCBhZGQgCisgICAgICAgIGluIHRoZSBzY3JvbGxPcmlnaW4oKS4g T3RoZXIgaW1wbGVtZW50YXRpb25zIG9mIHZpc2libGVDb250ZW50UmVjdEludGVybmFsKCkgZG8g CisgICAgICAgIG5vdCBhZGQgaW4gdGhlIHNjcm9sbE9yaWdpbigpLCBzbyBSZW5kZXJMYXllcidz IHNob3VsZG4ndCBlaXRoZXIgaW4gb3JkZXIgdG8gYmUKKyAgICAgICAgY29uc2lzdGVudC4gVGhp cyBtYWtlcyBydWJiZXItYmFuZGluZyB3b3JrIGZvciBSVEwgYmVjYXVzZSAKKyAgICAgICAgU2Ny b2xsQW5pbWF0b3JNYWM6OnBpbm5lZEluRGlyZWN0aW9uKCkgYW5kIAorICAgICAgICBTY3JvbGxB bmltYXRvck1hYzo6YWJzb2x1dGVTY3JvbGxQb3NpdGlvbigpIGJvdGggcmV0dXJuIHRoZSBleHBl Y3QgdmFsdWVzIG5vdy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6dmlzaWJsZUNvbnRlbnRSZWN0SW50ZXJuYWwp OgorCiAyMDE0LTA4LTIyICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAg ICBBZGQgcHJvcGVyIHN1cHBvcnQgZm9yIGxldHRlci1zcGFjaW5nIHRvIGJvcG9tb2ZvIFJ1YnkK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkocmV2aXNpb24g MTcyODYyKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMjY0Miw3ICsyNjQyLDcgQEAgSW50UmVjdCBSZW5kZXJMYXllcjo6dmlz aWJsZUNvbnRlbnRSZWN0SQogICAgICAgICBob3Jpem9udGFsU2Nyb2xsYmFySGVpZ2h0ID0gKGhv cml6b250YWxTY3JvbGxiYXIoKSAmJiAhaG9yaXpvbnRhbFNjcm9sbGJhcigpLT5pc092ZXJsYXlT Y3JvbGxiYXIoKSkgPyBob3Jpem9udGFsU2Nyb2xsYmFyKCktPmhlaWdodCgpIDogMDsKICAgICB9 CiAgICAgCi0gICAgcmV0dXJuIEludFJlY3QoSW50UG9pbnQoc2Nyb2xsWE9mZnNldCgpLCBzY3Jv bGxZT2Zmc2V0KCkpLAorICAgIHJldHVybiBJbnRSZWN0KEludFBvaW50KHNjcm9sbFBvc2l0aW9u KCkueCgpLCBzY3JvbGxQb3NpdGlvbigpLnkoKSksCiAgICAgICAgICAgICAgICAgICAgSW50U2l6 ZShzdGQ6Om1heCgwLCBtX2xheWVyU2l6ZS53aWR0aCgpIC0gdmVydGljYWxTY3JvbGxiYXJXaWR0 aCksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGQ6Om1heCgwLCBtX2xheWVyU2l6ZS5o ZWlnaHQoKSAtIGhvcml6b250YWxTY3JvbGxiYXJIZWlnaHQpKSk7CiB9Cg==