136160 2014-08-22 10:39:00 -0700 Web Inspector: Fix CodeMirrorTokenTrackingController::_startTracking assertion 2014-08-26 17:53:07 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 saam saam commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1030750 0 saam 2014-08-22 10:39:00 -0700 This assertion fires often, but it doesn't indicate any kind of noteworthy error. _startTracking should either remove its assert if it wants to allow those that call it to call it regardless of if it's already tracking, or those that call _startTracking should only call it if _tracking is false. 1030751 1 webkit-bug-importer 2014-08-22 10:39:24 -0700 <rdar://problem/18103437> 1030752 2 236990 saam 2014-08-22 10:40:54 -0700 Created attachment 236990 patch I think this is the cause of the assertion constantly firing. 1030753 3 236991 saam 2014-08-22 10:42:13 -0700 Created attachment 236991 patch And this is another solution. 1030927 4 timothy 2014-08-23 09:00:34 -0700 That assert is pretty annoying. I think _mouseEntered should check. 1030938 5 saam 2014-08-23 19:17:13 -0700 (In reply to comment #4) > That assert is pretty annoying. I think _mouseEntered should check. I agree. I'll submit a patch to do this. 1031526 6 237187 saam 2014-08-26 17:15:37 -0700 Created attachment 237187 patch 1031527 7 237188 saam 2014-08-26 17:16:16 -0700 Created attachment 237188 patch 1031532 8 237188 commit-queue 2014-08-26 17:53:04 -0700 Comment on attachment 237188 patch Clearing flags on attachment: 237188 Committed r172991: <http://trac.webkit.org/changeset/172991> 1031533 9 commit-queue 2014-08-26 17:53:07 -0700 All reviewed patches have been landed. Closing bug. 236990 2014-08-22 10:40:54 -0700 2014-08-26 17:15:37 -0700 patch patch.diff text/plain 618 saam SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0Nv ZGVNaXJyb3JUb2tlblRyYWNraW5nQ29udHJvbGxlci5qcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yVG9rZW5U cmFja2luZ0NvbnRyb2xsZXIuanMJKHJldmlzaW9uIDE3MjgzMCkKKysrIFNvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JUb2tlblRyYWNraW5n Q29udHJvbGxlci5qcwkod29ya2luZyBjb3B5KQpAQCAtMjYxLDcgKzI2Miw4IEBAIFdlYkluc3Bl Y3Rvci5Db2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnQKIAogICAgIF9tb3VzZUVudGVyZWQ6IGZ1 bmN0aW9uKGV2ZW50KQogICAgIHsKLSAgICAgICAgdGhpcy5fc3RhcnRUcmFja2luZygpOworICAg ICAgICBpZiAoIXRoaXMuX3RyYWNraW5nKQorICAgICAgICAgICAgdGhpcy5fc3RhcnRUcmFja2lu ZygpOwogICAgIH0sCiAKICAgICBfbW91c2VMZWZ0OiBmdW5jdGlvbihldmVudCkK 236991 2014-08-22 10:42:13 -0700 2014-08-26 17:15:37 -0700 patch patch.diff text/plain 567 saam SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0Nv ZGVNaXJyb3JUb2tlblRyYWNraW5nQ29udHJvbGxlci5qcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yVG9rZW5U cmFja2luZ0NvbnRyb2xsZXIuanMJKHJldmlzaW9uIDE3MjgzMCkKKysrIFNvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JUb2tlblRyYWNraW5n Q29udHJvbGxlci5qcwkod29ya2luZyBjb3B5KQpAQCAtMTkzLDcgKzE5NCw2IEBAIFdlYkluc3Bl Y3Rvci5Db2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnQKIAogICAgIF9zdGFydFRyYWNraW5nOiBm dW5jdGlvbigpCiAgICAgewotICAgICAgICBjb25zb2xlLmFzc2VydCghdGhpcy5fdHJhY2tpbmcp OwogICAgICAgICBpZiAodGhpcy5fdHJhY2tpbmcpCiAgICAgICAgICAgICByZXR1cm47CiAK 237187 2014-08-26 17:15:37 -0700 2014-08-26 17:16:16 -0700 patch patch.diff text/plain 1499 saam SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyOTg3KQorKysgU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE0LTA4LTI2ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFdlYiBJbnNwZWN0b3I6IEZpeCBDb2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXI6Ol9z dGFydFRyYWNraW5nIGFzc2VydGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM2MTYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ2hlY2sgaWYgJ190cmFja2luZycgaXMgYWxyZWFkeSB0cnVlIGJlZm9y ZSBjYWxsaW5nICdfc3RhcnRUcmFja2luZycKKyAgICAgICAgdG8gcHJldmVudCB0aGUgYXNzZXJ0 aW9uIGZyb20gYWx3YXlzIGZpcmluZy4KKworCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250 cm9sbGVycy9Db2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVyLnByb3RvdHlwZS5f bW91c2VFbnRlcmVkKToKKwogMjAxNC0wOC0yNSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBbV2luXSBQYXNzIE9GRklDSUFMX0JVSUxEIGZsYWcgdG8gV2Vi SW5zcGVjdG9yVUkgYnVpbGQgcHJvY2VzcwpJbmRleDogU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVy LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Nv bnRyb2xsZXJzL0NvZGVNaXJyb3JUb2tlblRyYWNraW5nQ29udHJvbGxlci5qcwkocmV2aXNpb24g MTcyOTY5KQorKysgU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxl cnMvQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVyLmpzCSh3b3JraW5nIGNvcHkpCkBA IC0yNjEsNyArMjYxLDggQEAgV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUb2tlblRyYWNraW5nQ29u dAogCiAgICAgX21vdXNlRW50ZXJlZDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewotICAgICAgICB0 aGlzLl9zdGFydFRyYWNraW5nKCk7CisgICAgICAgIGlmICghdGhpcy5fdHJhY2tpbmcpCisgICAg ICAgICAgICB0aGlzLl9zdGFydFRyYWNraW5nKCk7CiAgICAgfSwKIAogICAgIF9tb3VzZUxlZnQ6 IGZ1bmN0aW9uKGV2ZW50KQo= 237188 2014-08-26 17:16:16 -0700 2014-08-26 17:53:04 -0700 patch patch.diff text/plain 1497 saam SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyOTg3KQorKysgU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTA4LTI2ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFdlYiBJbnNwZWN0b3I6IEZpeCBDb2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXI6Ol9z dGFydFRyYWNraW5nIGFzc2VydGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM2MTYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ2hlY2sgaWYgJ190cmFja2luZycgaXMgYWxyZWFkeSB0cnVlIGJlZm9y ZSBjYWxsaW5nICdfc3RhcnRUcmFja2luZycKKyAgICAgICAgdG8gcHJldmVudCB0aGUgYXNzZXJ0 aW9uIGZyb20gYWx3YXlzIGZpcmluZy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJv bGxlcnMvQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVyLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLkNvZGVNaXJyb3JUb2tlblRyYWNraW5nQ29udHJvbGxlci5wcm90b3R5cGUuX21v dXNlRW50ZXJlZCk6CisKIDIwMTQtMDgtMjUgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBs ZS5jb20+CiAKICAgICAgICAgW1dpbl0gUGFzcyBPRkZJQ0lBTF9CVUlMRCBmbGFnIHRvIFdlYklu c3BlY3RvclVJIGJ1aWxkIHByb2Nlc3MKSW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JUb2tlblRyYWNraW5nQ29udHJvbGxlci5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250 cm9sbGVycy9Db2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIuanMJKHJldmlzaW9uIDE3 Mjk2OSkKKysrIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJz L0NvZGVNaXJyb3JUb2tlblRyYWNraW5nQ29udHJvbGxlci5qcwkod29ya2luZyBjb3B5KQpAQCAt MjYxLDcgKzI2MSw4IEBAIFdlYkluc3BlY3Rvci5Db2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnQK IAogICAgIF9tb3VzZUVudGVyZWQ6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKLSAgICAgICAgdGhp cy5fc3RhcnRUcmFja2luZygpOworICAgICAgICBpZiAoIXRoaXMuX3RyYWNraW5nKQorICAgICAg ICAgICAgdGhpcy5fc3RhcnRUcmFja2luZygpOwogICAgIH0sCiAKICAgICBfbW91c2VMZWZ0OiBm dW5jdGlvbihldmVudCkK