136158 2014-08-22 10:17:11 -0700 [GTK] WebKit has a new required dependency on GnuTLS 2014-12-07 11:23:45 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson webkit-unassigned berto commit-queue dbates elima oleg_smirnov oldest_to_newest 1030747 0 mrobinson 2014-08-22 10:17:11 -0700 We should not be adding required dependencies, so WebCrypto should be disabled when GnuTLS is not found: -- WTF_USE_TILED_BACKING_STORE OFF -- ENABLE_PLUGIN_PROCESS_GTK2 .............. ON -- checking for module 'libsecret-1' -- package 'libsecret-1' not found -- Could NOT find LIBSECRET (missing: LIBSECRET_INCLUDE_DIRS LIBSECRET_LIBRARIES) CMake Error at /home/guijemont/.local/share/cmake-3.0/Modules/FindPackageHandleStandardArgs.cmake:136 (message): Could NOT find GnuTLS: Found unsuitable version "2.12.14", but required is at least "3.0.0" (found /usr/lib/x86_64-linux-gnu/libgnutls.so) Call Stack (most recent call first): /home/guijemont/.local/share/cmake-3.0/Modules/FindPackageHandleStandardArgs.cmake:341 (_FPHSA_FAILURE_MESSAGE) /home/guijemont/.local/share/cmake-3.0/Modules/FindGnuTLS.cmake:69 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) Source/cmake/OptionsGTK.cmake:383 (find_package) CMakeLists.txt:159 (include) 1036947 1 berto 2014-09-24 02:34:41 -0700 cmake only complains if you explicitly enable SUBTLE_CRYPTO and it fails to find the required dependencies. I understand that's the correct behavior. It is build-webkit that sets ENABLE_SUBTLE_CRYPTO by default, if you call cmake directly instead it works fine. So maybe we should disable subtle-crypto by default in build-webkit? 1051342 2 242286 oleg_smirnov 2014-11-29 16:53:03 -0800 Created attachment 242286 Patch 1053168 3 242286 berto 2014-12-07 09:33:04 -0800 Comment on attachment 242286 Patch The patch looks good to me, r+ anyone? 1053169 4 mrobinson 2014-12-07 09:42:12 -0800 If this if provided by the JHBuild, I don't think it's necessary. If it's not provided by the JHBuild, perhaps it should be? 1053171 5 berto 2014-12-07 09:52:13 -0800 Actually Tools/gtk/install-dependencies is already installing libgnutls-dev, so maybe there's nothing to fix here? WebCrypto is already disabled when we use cmake directly, so I don't think distributors/end users are really required to install gnutls. 1053177 6 mrobinson 2014-12-07 10:18:15 -0800 (In reply to comment #5) > Actually Tools/gtk/install-dependencies is already installing > libgnutls-dev, so maybe there's nothing to fix here? > > WebCrypto is already disabled when we use cmake directly, so I don't > think distributors/end users are really required to install gnutls. Probably it should be one of those features that's enabled only when the dependency is found. I think Safari is shipping it so we can probably start as well. 1053183 7 242754 berto 2014-12-07 10:32:37 -0800 Created attachment 242754 Patch Ok, here it goes 1053200 8 242754 commit-queue 2014-12-07 11:23:41 -0800 Comment on attachment 242754 Patch Clearing flags on attachment: 242754 Committed r176928: <http://trac.webkit.org/changeset/176928> 1053201 9 commit-queue 2014-12-07 11:23:45 -0800 All reviewed patches have been landed. Closing bug. 242286 2014-11-29 16:53:03 -0800 2014-12-07 10:32:37 -0800 Patch bug-136158-20141130035324.patch text/plain 1714 oleg_smirnov U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2NTgzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWFkMGE5NTNmMzg0NWYxOTNjMGRmZTVjYmQ1YzJiYjky NzZhZDk5Ny4uNDNmMmUxZDU2MmY3YmJmYjcwOTZlNDhmM2ZiM2U5NjlhN2RhOGNmYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTExLTI5ICBPbGVnIFNtaXJub3YgIDxvbGVnX3NtaXJub3ZAaG90bWFpbC5jb20+ CisKKyAgICAgICAgW0dUS10gV2ViS2l0IGhhcyBhIG5ldyByZXF1aXJlZCBkZXBlbmRlbmN5IG9u IEdudVRMUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM2MTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgbXJvYmluc29uQHdlYmtpdC5vcmcuCisKKyAg ICAgICAgRGlzYWJsZSBTVUJUTEVfQ1JZUFRPIGluIGRlZmF1bHQgY2F1c2Ugb2YgV2Via2l0IEdU SyBkZXBlbmRzIG9mIGxpYmdudXRsczI4LWRldiwKKyAgICAgICAgYnV0IFNVQlRMRV9DUllQVE8g bmVlZGVkIGxpYmdudXRscyAzLjAgdmVyc2lvbi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cGVybC9GZWF0dXJlTGlzdC5wbToKKwogMjAxNC0xMS0yOSAgQW5kZXJzIENhcmxzc29uICA8YW5k ZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIHdoZW4gY2FsbGluZyBXS1BhZ2VDbG9z ZSBvbiB0aGUgb3JpZ2luYXRlZCBwYWdlIGZyb20gd2l0aGluIGNyZWF0ZU5ld1BhZ2UgY2FsbGJh Y2sKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbQppbmRleCBhMTRlNjgxYTc5 NWU1NzE5MzMwOTcxMWZhZTMyY2ZkMTM0MzExM2RhLi44ZTY2MmRhNGZhMzYzMDM3OTgwMDRiMjBk ODQwNzUxODFkZWUyYzEwIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVh dHVyZUxpc3QucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBt CkBAIC0zNjksNyArMzY5LDcgQEAgbXkgQGZlYXR1cmVzID0gKAogICAgICAgZGVmaW5lID0+ICJF TkFCTEVfU1FMX0RBVEFCQVNFIiwgZGVmYXVsdCA9PiAxLCB2YWx1ZSA9PiBcJHNxbERhdGFiYXNl U3VwcG9ydCB9LAogCiAgICAgeyBvcHRpb24gPT4gInN1YnRsZS1jcnlwdG8iLCBkZXNjID0+ICJU b2dnbGUgV2ViQ3J5cHRvIFN1YnRsZS1DcnlwdG8gc3VwcG9ydCIsCi0gICAgICBkZWZpbmUgPT4g IkVOQUJMRV9TVUJUTEVfQ1JZUFRPIiwgZGVmYXVsdCA9PiAoaXNHdGsoKSB8fCBpc0FwcGxlTWFj V2ViS2l0KCkgfHwgaXNJT1NXZWJLaXQoKSksIHZhbHVlID0+IFwkc3VidGxlQ3J5cHRvIH0sCisg ICAgICBkZWZpbmUgPT4gIkVOQUJMRV9TVUJUTEVfQ1JZUFRPIiwgZGVmYXVsdCA9PiAoaXNBcHBs ZU1hY1dlYktpdCgpIHx8IGlzSU9TV2ViS2l0KCkpLCB2YWx1ZSA9PiBcJHN1YnRsZUNyeXB0byB9 LAogCiAgICAgeyBvcHRpb24gPT4gInN1aWQtbGludXgtc2FuZGJveCIsIGRlc2MgPT4gIlRvZ2ds ZSBzdWlkIHNhbmRib3ggZm9yIGxpbnV4IiwKICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX1NVSURf U0FOREJPWF9MSU5VWCIsIGRlZmF1bHQgPT4gMCwgdmFsdWUgPT4gXCRzdWlkTGludXhTYW5kYm94 IH0sCg== 242754 2014-12-07 10:32:37 -0800 2014-12-07 11:23:41 -0800 Patch 136158.diff text/plain 2307 berto ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5ZWE5ZDhmLi5hMDAxYzdm IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTQtMTItMDcgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXSBXZWJLaXQgaGFzIGEgbmV3IHJlcXVpcmVkIGRlcGVuZGVuY3kgb24gR251VExTCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYxNTgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZXRlY3QgaWYg R251VExTIGlzIGluc3RhbGxlZCBhbmQgZW5hYmxlIG9yIGRpc2FibGUgc3VidGxlIGNyeXB0bwor ICAgICAgICBzdXBwb3J0IGFjY29yZGluZ2x5LgorCisgICAgICAgICogU291cmNlL2NtYWtlL09w dGlvbnNHVEsuY21ha2U6CisKIDIwMTQtMTItMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIE1pc3NpbmcgQVBJIGRldGVjdGVkIGlu IEdPYmplY3QgRE9NIGJpbmRpbmdzIGFmdGVyIHIxNzY2MzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9j bWFrZS9PcHRpb25zR1RLLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKaW5k ZXggZjI2OTExMy4uNDU2Mjk5YSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsu Y21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKQEAgLTQ5LDYgKzQ5LDcg QEAgZmluZF9wYWNrYWdlKEdPYmplY3RJbnRyb3NwZWN0aW9uKQogZmluZF9wYWNrYWdlKE9wZW5H TCkKIGZpbmRfcGFja2FnZShFR0wpCiBmaW5kX3BhY2thZ2UoR2VvQ2x1ZTIgMi4xLjUpCitmaW5k X3BhY2thZ2UoR251VExTIDMuMC4wKQogCiBpZiAoTk9UIEdFT0NMVUUyX0ZPVU5EKQogICAgIGZp bmRfcGFja2FnZShHZW9DbHVlKQpAQCAtODYsNiArODcsMTYgQEAgaWYgKEVOQUJMRV9BQ0NFTEVS QVRFRF8yRF9DQU5WQVMgQU5EIE5PVChDQUlST19HTF9GT1VORCkpCiAgICAgbWVzc2FnZShGQVRB TF9FUlJPUiAiY2Fpcm8tZ2wgaXMgbmVlZGVkIGZvciBBY2NlbGVyYXRlZCAyRCBDYW52YXMgc3Vw cG9ydCIpCiBlbmRpZiAoKQogCitpZiAoR05VVExTX0ZPVU5EKQorICAgIFdFQktJVF9PUFRJT05f REVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TVUJUTEVfQ1JZUFRPIE9OKQorZWxzZSAoKQorICAg IFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TVUJUTEVfQ1JZUFRPIE9G RikKK2VuZGlmICgpCisKK2lmIChFTkFCTEVfU1VCVExFX0NSWVBUTyBBTkQgTk9UKEdOVVRMU19G T1VORCkpCisgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiU3VidGxlIGNyeXB0byBzdXBwb3J0IG5l ZWRzIEdudVRMUyAzLjAuMCIpCitlbmRpZiAoKQorCiBpZiAoR0VPQ0xVRTJfRk9VTkQgT1IgR0VP Q0xVRV9GT1VORCkKICAgICBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf R0VPTE9DQVRJT04gT04pCiBlbHNlICgpCkBAIC0xNDcsNyArMTU4LDYgQEAgV0VCS0lUX09QVElP Tl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1JFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FIE9OKQog V0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1NFQ0NPTVBfRklMVEVSUyBP RkYpCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU0hBUkVEX1dPUktF UlMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU1BFTExDSEVD SyBPTikKLVdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TVUJUTEVfQ1JZ UFRPIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9URU1QTEFU RV9FTEVNRU5UIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1RP VUNIX0VWRU5UUyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9V U0VSU0VMRUNUX0FMTCBPTikKQEAgLTM5NCw3ICs0MDQsMyBAQCBpZiAoQ01BS0VfTUFKT1JfVkVS U0lPTiBMRVNTIDMpCiAgICAgICAgIEZJTEVfUEVSTUlTU0lPTlMgT1dORVJfUkVBRCBPV05FUl9X UklURSBPV05FUl9FWEVDVVRFIEdST1VQX1JFQUQgR1JPVVBfRVhFQ1VURQogICAgICkKIGVuZGlm ICgpCi0KLWlmIChFTkFCTEVfU1VCVExFX0NSWVBUTykKLSAgICBmaW5kX3BhY2thZ2UoR251VExT IDMuMC4wIFJFUVVJUkVEKQotZW5kaWYgKCkK