136151 2014-08-22 02:03:11 -0700 [EFL] Unskip compositing test 2014-08-27 00:56:29 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim bunhere cdumez commit-queue esprehn+autocc glenn hw1008.kim kondapallykalyan lucas.de.marchi ossy ryuan.choi sergio simon.fraser oldest_to_newest 1030700 0 gyuyoung.kim 2014-08-22 02:03:11 -0700 SSIA 1030702 1 236976 gyuyoung.kim 2014-08-22 02:09:54 -0700 Created attachment 236976 Patch 1030878 2 236976 gyuyoung.kim 2014-08-22 20:48:16 -0700 Comment on attachment 236976 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236976&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:-298 > -#if !PLATFORM(IOS) && !PLATFORM(EFL) After adjust setContentsOpaque() again, almost compositing tests can be passed. 469 tests ran as expected, 51 didn't: Ryuan, should we keep this macro ? 1030879 3 237024 gyuyoung.kim 2014-08-22 20:51:02 -0700 Created attachment 237024 Patch 1031026 4 gyuyoung.kim 2014-08-24 21:41:51 -0700 CC'ing Ossy. 1031027 5 ryuan.choi 2014-08-24 21:46:00 -0700 (In reply to comment #3) > Created an attachment (id=237024) [details] > Patch OK. Looks fine to me. It was for the transparent webview (ewk_view_bg_color_set). Unfortunately, WebKitTestRunnder/Efl uses different composting path from general ewk_view. I agree that skipping composting/ is not for development. I will keep in mind of this intentional regression for the release until we fix the root cause. 1031552 6 gyuyoung.kim 2014-08-26 19:55:52 -0700 Ossy, could you take a look ? 1031608 7 237024 ossy 2014-08-27 00:19:30 -0700 Comment on attachment 237024 Patch rs=me 1031613 8 237024 commit-queue 2014-08-27 00:56:22 -0700 Comment on attachment 237024 Patch Clearing flags on attachment: 237024 Committed r172999: <http://trac.webkit.org/changeset/172999> 1031614 9 commit-queue 2014-08-27 00:56:29 -0700 All reviewed patches have been landed. Closing bug. 236976 2014-08-22 02:09:54 -0700 2014-08-22 20:50:56 -0700 Patch bug-136151-20140822180945.patch text/plain 2565 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTA2MGQwMzE1OTk2MzNm YmEzNDFkMDM4NzVhYzJlODcyMGZmNzA2NS4uNzQzZjE0ZDczMzQxNzI2M2JkYzY4YTJhNjdhODE2 MTlkZDBjNDY2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA4LTIyICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gVW5z a2lwIGNvbXBvc2l0aW5nIHRlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzNjE1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OmNyZWF0ZVByaW1hcnlHcmFwaGljc0xheWVy KToKKwogMjAxNC0wOC0yMSAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXggd2hlbiBSVUJCRVJfQkFORElORyBpcyBub3Qg ZW5hYmxlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ckJhY2tpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2lu Zy5jcHAKaW5kZXggODI1MTIwZDI2MGI4MTRmYjI4YzM4MzAzZWQwNjFjNWQ2ZTlmOWZiYy4uYzZh MmRjY2JkYTdlZGI3NmY4ZjU2MTk2NjBjNWNiMzViNzI3ZjQ2MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKQEAgLTI5NSw3ICsyOTUsNyBA QCB2b2lkIFJlbmRlckxheWVyQmFja2luZzo6Y3JlYXRlUHJpbWFyeUdyYXBoaWNzTGF5ZXIoKQog ICAgICAgICBtX2dyYXBoaWNzTGF5ZXItPmFkZENoaWxkKG1fY2hpbGRDb250YWlubWVudExheWVy LmdldCgpKTsKICAgICB9CiAKLSNpZiAhUExBVEZPUk0oSU9TKSAmJiAhUExBVEZPUk0oRUZMKQor I2lmICFQTEFURk9STShJT1MpCiAgICAgaWYgKG1faXNNYWluRnJhbWVSZW5kZXJWaWV3TGF5ZXIp IHsKICAgICAgICAgLy8gUGFnZSBzY2FsZSBpcyBhcHBsaWVkIGFib3ZlIHRoZSBSZW5kZXJWaWV3 IG9uIGlPUy4KICAgICAgICAgbV9ncmFwaGljc0xheWVyLT5zZXRDb250ZW50c09wYXF1ZSh0cnVl KTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCAyY2NiODQ1ODA0MDEwOTEzNjYyZDE4MWU2MTIzZTRjOTIxYTdjYTU4Li4xOTll NDBhZDY1OTY1MWQ0MjI2YWMzM2QyOGU5ZWQwNDc3ZWM2YzQ1IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTQtMDgtMjIgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXSBVbnNraXAgY29tcG9zaXRpbmcgdGVzdAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2MTUxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvVGVzdEV4cGVj dGF0aW9uczoKKwogMjAxNC0wOC0yMSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgog CiAgICAgICAgIEVuYWJsZSBTQVRVUkFURURfTEFZT1VUX0FSSVRITUVUSUMuCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDllNTFiMjYxMjBmYTc2MWRhMTUw YzUzMmVhNWM3OTY3M2NhODc5MGYuLjM1N2Y5ZmVmNjQyNzcwNWJlNzkzZjE3Yzg2YWMxNjVhMGEx MTk4ZDQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRp b25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zCkBAIC01 MzUsNyArNTM1LDYgQEAgd2Via2l0Lm9yZy9iLzEzMTA0NCBtZWRpYSBbIFNraXAgXQogCiAjIEEg bG90IG9mIGNyYXNoIGhhcHBlbiBzaW5jZSBidWlsZGJvdCBiYWdhbiB0byB1c2UgVWJ1bnR1IDEz LjEwLgogd2Via2l0Lm9yZy9iLzEzMTcyOSBiYXR0ZXJ5c3RhdHVzIFsgU2tpcCBdCi13ZWJraXQu b3JnL2IvMTMxNzI5IGNvbXBvc2l0aW5nIFsgU2tpcCBdCiB3ZWJraXQub3JnL2IvMTMxNzI5IGZh c3QvY2FudmFzL3dlYmdsIFsgU2tpcCBdCiB3ZWJraXQub3JnL2IvMTMxNzI5IGZhc3QvZXZlbnRz L3RvdWNoIFsgU2tpcCBdCiB3ZWJraXQub3JnL2IvMTMxNzI5IGh0dHAvdGVzdHMgWyBTa2lwIF0K 237024 2014-08-22 20:51:02 -0700 2014-08-27 00:56:22 -0700 Patch bug-136151-20140823125054.patch text/plain 2693 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzFlZjBjYjNkZTg5N2Zj M2ExZmI2ZGYyZGE2ZjQwMDFkZDZhOThlOC4uNWRkYzEwOGI2ZWVmMDA1MGZhODIzM2Y4Y2FjNTY0 YzJhMDQ4OGE1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA4LTIyICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gVW5z a2lwIGNvbXBvc2l0aW5nIHRlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzNjE1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6IFNldCB0cnVl IHRvIHNldENvbnRlbnRzT3BhcXVlKCkgdG8gc3VwcG9ydCBjb21wb3NpdGluZyB0ZXN0LgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjpjcmVhdGVQcmltYXJ5R3JhcGhpY3NM YXllcik6CisKIDIwMTQtMDgtMjIgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEtdIEFkZCB0aGUgV2F5bGFuZCBwcm90b2NvbCBleHRlbnNpb24KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKaW5kZXgg ODI1MTIwZDI2MGI4MTRmYjI4YzM4MzAzZWQwNjFjNWQ2ZTlmOWZiYy4uYzZhMmRjY2JkYTdlZGI3 NmY4ZjU2MTk2NjBjNWNiMzViNzI3ZjQ2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKQEAgLTI5NSw3ICsyOTUsNyBAQCB2b2lkIFJlbmRl ckxheWVyQmFja2luZzo6Y3JlYXRlUHJpbWFyeUdyYXBoaWNzTGF5ZXIoKQogICAgICAgICBtX2dy YXBoaWNzTGF5ZXItPmFkZENoaWxkKG1fY2hpbGRDb250YWlubWVudExheWVyLmdldCgpKTsKICAg ICB9CiAKLSNpZiAhUExBVEZPUk0oSU9TKSAmJiAhUExBVEZPUk0oRUZMKQorI2lmICFQTEFURk9S TShJT1MpCiAgICAgaWYgKG1faXNNYWluRnJhbWVSZW5kZXJWaWV3TGF5ZXIpIHsKICAgICAgICAg Ly8gUGFnZSBzY2FsZSBpcyBhcHBsaWVkIGFib3ZlIHRoZSBSZW5kZXJWaWV3IG9uIGlPUy4KICAg ICAgICAgbV9ncmFwaGljc0xheWVyLT5zZXRDb250ZW50c09wYXF1ZSh0cnVlKTsKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3 YmE5OGI2ZDY2ZWEyMWIzNjQyMjc5YWQ1NGQwYTdlYTVhMDI0Mzg2Li42NGY1ZTAzNGVjYmFjZDQ0 YzNiYjIxZmZkM2EwYTU4ZDQ4MzYxNGQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMDgt MjIgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBb RUZMXSBVbnNraXAgY29tcG9zaXRpbmcgdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2MTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9uczogVW5z a2lwIGNvbXBvc2l0aW5nIHRlc3RzLgorCiAyMDE0LTA4LTIxICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBBbmltYXRlZCBHSUZzIHNjcm9sbGVkIG91dCBvZiB2 aWV3IHN0aWxsIGNhdXNlIHRpdGxlYmFyIGJsdXIgdG8gdXBkYXRlLCBvbiB0dW1ibHIuY29tIHBh Z2UKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25z IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggOWU1MWIy NjEyMGZhNzYxZGExNTBjNTMyZWE1Yzc5NjczY2E4NzkwZi4uMzU3ZjlmZWY2NDI3NzA1YmU3OTNm MTdjODZhYzE2NWEwYTExOThkNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZs L1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBl Y3RhdGlvbnMKQEAgLTUzNSw3ICs1MzUsNiBAQCB3ZWJraXQub3JnL2IvMTMxMDQ0IG1lZGlhIFsg U2tpcCBdCiAKICMgQSBsb3Qgb2YgY3Jhc2ggaGFwcGVuIHNpbmNlIGJ1aWxkYm90IGJhZ2FuIHRv IHVzZSBVYnVudHUgMTMuMTAuCiB3ZWJraXQub3JnL2IvMTMxNzI5IGJhdHRlcnlzdGF0dXMgWyBT a2lwIF0KLXdlYmtpdC5vcmcvYi8xMzE3MjkgY29tcG9zaXRpbmcgWyBTa2lwIF0KIHdlYmtpdC5v cmcvYi8xMzE3MjkgZmFzdC9jYW52YXMvd2ViZ2wgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi8xMzE3 MjkgZmFzdC9ldmVudHMvdG91Y2ggWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi8xMzE3MjkgaHR0cC90 ZXN0cyBbIFNraXAgXQo=