136143 2014-08-21 19:02:34 -0700 Web Inspector: RetainPtr misuse, CFRunLoopSource leak 2014-08-21 20:22:40 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1030629 0 joepeck 2014-08-21 19:02:34 -0700 RetainPtr<T>::operator= does a +1. It looks like here there should be an adopt where there isn't: > Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.mm:239:5: warning > m_runLoopSource = CFRunLoopSourceCreate(nullptr, 1, &runLoopSourceContext); > ^ 1030630 1 webkit-bug-importer 2014-08-21 19:02:55 -0700 <rdar://problem/18097750> 1030631 2 236955 joepeck 2014-08-21 19:03:47 -0700 Created attachment 236955 [PATCH] Proposed Fix 1030644 3 236955 commit-queue 2014-08-21 20:22:38 -0700 Comment on attachment 236955 [PATCH] Proposed Fix Clearing flags on attachment: 236955 Committed r172845: <http://trac.webkit.org/changeset/172845> 1030645 4 commit-queue 2014-08-21 20:22:40 -0700 All reviewed patches have been landed. Closing bug. 236955 2014-08-21 19:03:47 -0700 2014-08-21 20:22:38 -0700 [PATCH] Proposed Fix fix-jsc-leak.patch text/plain 1772 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGZjZGIxNTAuLjA1NDFjMzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA4LTIxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmV0YWlu UHRyIG1pc3VzZSwgQ0ZSdW5Mb29wU291cmNlIGxlYWsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjE0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkb3B0IGEgQ3JlYXRlIGludG8gdGhlIFJldGFpblB0 ciB0byBhdm9pZCBsZWFraW5nLgorCisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJ bnNwZWN0b3JEZWJ1Z2dhYmxlQ29ubmVjdGlvbi5tbToKKyAgICAgICAgKEluc3BlY3Rvcjo6UmVt b3RlSW5zcGVjdG9yRGVidWdnYWJsZUNvbm5lY3Rpb246OnNldHVwUnVuTG9vcCk6CisKIDIwMTQt MDgtMTUgIEJyaWFuIEouIEJ1cmcgIDxidXJnQGNzLndhc2hpbmd0b24uZWR1PgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IHJld3JpdGUgQ29kZUdlbmVyYXRvckluc3BlY3RvciB0byBiZSBtb2R1 bGFyIGFuZCB0ZXN0YWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yRGVidWdnYWJsZUNvbm5lY3Rpb24ubW0gYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3JEZWJ1Z2dh YmxlQ29ubmVjdGlvbi5tbQppbmRleCA5YjJkMDA4Li4wYzNiOTA4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3JEZWJ1Z2dh YmxlQ29ubmVjdGlvbi5tbQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Jl bW90ZS9SZW1vdGVJbnNwZWN0b3JEZWJ1Z2dhYmxlQ29ubmVjdGlvbi5tbQpAQCAtMjM2LDcgKzIz Niw3IEBAIHZvaWQgUmVtb3RlSW5zcGVjdG9yRGVidWdnYWJsZUNvbm5lY3Rpb246OnNldHVwUnVu TG9vcCgpCiAgICAgbV9ydW5Mb29wID0gZGVidWdnZXJSdW5Mb29wOwogCiAgICAgQ0ZSdW5Mb29w U291cmNlQ29udGV4dCBydW5Mb29wU291cmNlQ29udGV4dCA9IHswLCB0aGlzLCBudWxscHRyLCBu dWxscHRyLCBudWxscHRyLCBudWxscHRyLCBudWxscHRyLCBudWxscHRyLCBudWxscHRyLCBSZW1v dGVJbnNwZWN0b3JIYW5kbGVSdW5Tb3VyY2VXaXRoSW5mb307Ci0gICAgbV9ydW5Mb29wU291cmNl ID0gQ0ZSdW5Mb29wU291cmNlQ3JlYXRlKG51bGxwdHIsIDEsICZydW5Mb29wU291cmNlQ29udGV4 dCk7CisgICAgbV9ydW5Mb29wU291cmNlID0gYWRvcHRDRihDRlJ1bkxvb3BTb3VyY2VDcmVhdGUo bnVsbHB0ciwgMSwgJnJ1bkxvb3BTb3VyY2VDb250ZXh0KSk7CiAKICAgICBDRlJ1bkxvb3BBZGRT b3VyY2UobV9ydW5Mb29wLmdldCgpLCBtX3J1bkxvb3BTb3VyY2UuZ2V0KCksIGtDRlJ1bkxvb3BE ZWZhdWx0TW9kZSk7CiAgICAgQ0ZSdW5Mb29wQWRkU291cmNlKG1fcnVuTG9vcC5nZXQoKSwgbV9y dW5Mb29wU291cmNlLmdldCgpLCBFdmVudExvb3A6OnJlbW90ZUluc3BlY3RvclJ1bkxvb3BNb2Rl KCkpOwo=