136140 2014-08-21 17:41:26 -0700 Possible RetainPtr misuse in WKScriptMessage.mm - could leak 2014-08-21 20:27:18 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned andersca commit-queue joepeck sam oldest_to_newest 1030606 0 joepeck 2014-08-21 17:41:26 -0700 RetainPtr<...>::operator= will +1. This looks like a possible missing adoptNS which could cause a leak: > Source/WebKit2/UIProcess/API/Cocoa/WKScriptMessage.mm:47:5: > _body = [body copy]; > ^ However, since _body is RetainPtr<id>, how does this even work? "id" doesn't necessary respond to retain/release/copy. It looks like this could come from -[JSValue toObject] which returns id, but probably could return id<NSObject>. 1030627 1 joepeck 2014-08-21 18:39:15 -0700 Maybe id is always guaranteed to at least be an NSObject. In that case we can just adoptNS. 1030634 2 236957 joepeck 2014-08-21 19:05:55 -0700 Created attachment 236957 [PATCH] Proposed Fix This is an untested fix. Seeing as we are arbitrarily calling -copy, then -retain/-release should be fine for now. 1030646 3 236957 commit-queue 2014-08-21 20:27:15 -0700 Comment on attachment 236957 [PATCH] Proposed Fix Clearing flags on attachment: 236957 Committed r172846: <http://trac.webkit.org/changeset/172846> 1030647 4 commit-queue 2014-08-21 20:27:18 -0700 All reviewed patches have been landed. Closing bug. 236957 2014-08-21 19:05:55 -0700 2014-08-21 20:27:15 -0700 [PATCH] Proposed Fix possible-fix.patch text/plain 1168 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzOGMyMmYyLi5mYmU4YjEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTQtMDgtMjEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBQb3NzaWJsZSBSZXRhaW5QdHIgbWlzdXNlIGluIFdLU2NyaXB0TWVzc2FnZS5tbSAt IGNvdWxkIGxlYWsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNjE0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkb3B0IGEgY29weSBpbnRvIGEgUmV0YWluUHRyIHRvIGF2b2lkIGxlYWtpbmcuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLU2NyaXB0TWVzc2FnZS5tbToKKyAgICAgICAg KC1bV0tTY3JpcHRNZXNzYWdlIF9pbml0V2l0aEJvZHk6d2ViVmlldzpmcmFtZUluZm86bmFtZTpd KToKKwogMjAxNC0wOC0xNSAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5j b20+CiAKICAgICAgICAgRml4IHBsdWdpbiB2aXNpYmlsaXR5IGNoZWNrLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1NjcmlwdE1lc3NhZ2UubW0gYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLU2NyaXB0TWVzc2FnZS5tbQppbmRl eCA3YzE3NDllLi5jZDVmOTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLU2NyaXB0TWVzc2FnZS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL1dLU2NyaXB0TWVzc2FnZS5tbQpAQCAtNDQsNyArNDQsNyBAQAogICAgIGlm ICghKHNlbGYgPSBbc3VwZXIgaW5pdF0pKQogICAgICAgICByZXR1cm4gbmlsOwogCi0gICAgX2Jv ZHkgPSBbYm9keSBjb3B5XTsKKyAgICBfYm9keSA9IGFkb3B0TlMoW2JvZHkgY29weV0pOwogICAg IF93ZWJWaWV3ID0gd2ViVmlldzsKICAgICBfZnJhbWVJbmZvID0gZnJhbWVJbmZvOwogICAgIF9u YW1lID0gYWRvcHROUyhbbmFtZSBjb3B5XSk7Cg==