136133 2014-08-21 15:27:37 -0700 Add a button to enable paint flashing in the web inspector 2014-08-21 16:49:48 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser graouts joepeck simon.fraser timothy webkit-bug-importer oldest_to_newest 1030569 0 simon.fraser 2014-08-21 15:27:37 -0700 Add a button to enable paint flashing in the web inspector 1030571 1 236939 simon.fraser 2014-08-21 15:28:45 -0700 Created attachment 236939 Patch 1030572 2 webkit-bug-importer 2014-08-21 15:29:25 -0700 <rdar://problem/18094974> 1030576 3 236939 timothy 2014-08-21 16:04:30 -0700 Comment on attachment 236939 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236939&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:36 > + paintFlashingImage = {src: "Images/PaintFlashing.svg", width: 16, height: 16}; This isn't needed since the two image paths are the same. > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:40 > + paintFlashingImage = {src: "Images/PaintFlashing.svg", width: 13, height: 13}; Ditto. > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:47 > + this._paintFlashingButtonNavigationItem = new WebInspector.ActivateButtonNavigationItem("paint-flashing", WebInspector.UIString("Enable paint flashing"), WebInspector.UIString("Disable paint flashing"), paintFlashingImage.src, paintFlashingImage.width, paintFlashingImage.height); You can use put the image path and size directly here. The width and height should always be 16 to match the SVG. 1030595 4 simon.fraser 2014-08-21 16:49:48 -0700 https://trac.webkit.org/r172839 236939 2014-08-21 15:28:45 -0700 2014-08-21 16:04:29 -0700 Patch bug-136133-20140821152837.patch text/plain 6585 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl NDUyMGE5Mzk3MDc2ODQ4NmJmY2Q1ZGZhNzVmYjY3YjA5OWZhYzk5Li44YzhhZjA5MGQyMGFkNjJh Mzg3NGJiMTlmOTNjODI5NmFjNTViY2IzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNC0wOC0yMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxl LmNvbT4KKworICAgICAgICBBZGQgYSBidXR0b24gdG8gZW5hYmxlIHBhaW50IGZsYXNoaW5nIGlu IHRoZSB3ZWIgaW5zcGVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzYxMzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KyAgICAgICAgCisgICAgICAgIEFkZCBhIGJ1dHRvbiB0byB0aGUgcmlnaHQgb2YgdGhlIGxheWVy IGJvcmRlcnMgYnV0dG9uIHRvIHR1cm4gb24gcGFpbnQgZmxhc2hpbmcuCisgICAgICAgIEZ1dHVy ZSBwYXRjaGVzIHdpbGwgYWN0dWFsbHkgZW5hYmxlIHRoaXMgZmVhdHVyZS4KKworICAgICAgICAq IExvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qczogVG9vbHRpcCBzdHJp bmdzLgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvSW1hZ2VzL1BhaW50Rmxhc2hpbmcuc3ZnOiBB ZGRlZC4gIlBhaW50YnJ1c2giIGljb24uCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9E T01UcmVlQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NVHJlZUNvbnRl bnRWaWV3KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlQ29udGVudFZpZXcucHJvdG90 eXBlLmdldCBuYXZpZ2F0aW9uSXRlbXMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVD b250ZW50Vmlldy5wcm90b3R5cGUuX3RvZ2dsZVBhaW50Rmxhc2hpbmcpOgorCiAyMDE0LTA4LTIw ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBIaWdo RmlkZWxpdHlUeXBlUHJvZmlsaW5nIHZhcmlhYmxlcyBmb3IgbW9yZSBjbGFyaXR5CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6 ZWRTdHJpbmdzLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHBy b2ovbG9jYWxpemVkU3RyaW5ncy5qcwppbmRleCBjMWRlNDE4ZjQ1ZmJiZjlkZTA4Y2FiYzJjMTk4 MjdiMmI5ZDFhOTk2Li4wOWNkYjJlYzAyZjRkZTY4YzBhMGZiY2Y1NTE3YmJjODliN2VmODJiIDEw MDY0NApHSVQgYmluYXJ5IHBhdGNoCmRlbHRhIDEzMQp6Y21jYnltaWZiYTxfJGxzQkAtRGs4Uyly UDchKC1ONzsrZEE4SHlQKXojezNCd1FTXnR2Qip3N0N1X0wqeCVEelIKWUpYLWZmJHpzKklGNH1i Uj8rQzhWLUJHP1owOHtyUWw+aCgkCgpkZWx0YSAyMwpmY21leWNwODNYRjxfJGxzSEBEa05rKD1D Wlc0SE5uRzthKzZrLVE1PAoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0ltYWdlcy9QYWludEZsYXNoaW5nLnN2ZyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0ltYWdlcy9QYWludEZsYXNoaW5nLnN2ZwpuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42N2Nm MGM5NWFiYWQ0NjkyOTJkMDU0MGUwNWY2NmM5ZWYyYzQxZDhhCi0tLSAvZGV2L251bGwKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvSW1hZ2VzL1BhaW50Rmxhc2hpbmcu c3ZnCkBAIC0wLDAgKzEsNSBAQAorPD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgi Pz4KKzwhLS0gQ29weXJpZ2h0IMKpIDIwMTMgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LiAtLT4KKzxzdmcgdmVyc2lvbj0iMS4xIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9z dmciIHZpZXdCb3g9IjAgMCAxNiAxNiI+CisgICAgPHBhdGggZD0iTSAxLjM2NzE4OCAxMy43ODkw NjIgQyAxLjM2NzE4OCAxMy43ODkwNjIgMi44MjAzMTIgMTQuMTA1NDY5IDMuMjg5MDYyIDEyLjcy MjY1NiBDIDMuNzU3ODEyIDExLjM0Mzc1IDMuOTYwOTM4IDEwLjg2NzE4OCA1LjIyMjY1NiAxMC45 NzY1NjIgQyA1LjIyMjY1NiAxMC45NzY1NjIgNS43MTQ4NDQgMTEuODg2NzE5IDYuOTMzNTk0IDEy LjMwODU5NCBDIDYuOTMzNTk0IDEyLjMwODU5NCA1Ljc1IDE2LjIwNzAzMSAxLjM2NzE4OCAxMy43 ODkwNjIgWiBNIDE0LjMzOTg0NCAyLjM1MTU2MiBDIDE0LjA1NDY4OCAyLjgzOTg0NCAxMC4yODkw NjIgOC44MDQ2ODggOS41NTQ2ODggOS42NTYyNSBDIDguODIwMzEyIDEwLjUxMTcxOSA2LjkxNzk2 OSAxMS43MTg3NSA2LjkxNzk2OSAxMS43MTg3NSBDIDYuMDAzOTA2IDExLjI0MjE4OCA1LjcxMDkz OCAxMC43MzgyODEgNS43MTA5MzggMTAuNzM4MjgxIEMgNS43MTA5MzggMTAuNzM4MjgxIDYuMzI4 MTI1IDguOTkyMTg4IDcuMjMwNDY5IDcuNjgzNTk0IEMgOC4xMzI4MTIgNi4zNzg5MDYgMTMuMDUw NzgxIDEuOTQ5MjE5IDEzLjQ2MDkzOCAxLjYzNjcxOSBDIDEzLjg3MTA5NCAxLjMyMDMxMiAxNC42 MjUgMS44NjcxODggMTQuMzM5ODQ0IDIuMzUxNTYyIFoiLz4KKzwvc3ZnPgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUNvbnRlbnRW aWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJl ZUNvbnRlbnRWaWV3LmpzCmluZGV4IDg3ZmNhMzAwYmVlMmE3YTg5ZTQ5YmNhY2Q3OGM0MjU0NDVh NmI0YzYuLjYzYmQ3ZDZkZTk1ZTQyNjAyMGVjZGVhN2U3MWI3OTAyMWU4MjdmNTggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVDb250 ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9ET01UcmVlQ29udGVudFZpZXcuanMKQEAgLTI5LDE5ICsyOSwyNSBAQCBXZWJJbnNwZWN0b3Iu RE9NVHJlZUNvbnRlbnRWaWV3ID0gZnVuY3Rpb24ocmVwcmVzZW50ZWRPYmplY3QpCiAKICAgICBX ZWJJbnNwZWN0b3IuQ29udGVudFZpZXcuY2FsbCh0aGlzLCByZXByZXNlbnRlZE9iamVjdCk7CiAK LSAgICB2YXIgbGF5ZXJCb3JkZXJzSW1hZ2UsIHNoYWRvd0RPTUltYWdlOworICAgIHZhciBsYXll ckJvcmRlcnNJbWFnZSwgc2hhZG93RE9NSW1hZ2UsIHBhaW50Rmxhc2hpbmdJbWFnZTsKICAgICBp ZiAoV2ViSW5zcGVjdG9yLlBsYXRmb3JtLmlzTGVnYWN5TWFjT1MpIHsKICAgICAgICAgbGF5ZXJC b3JkZXJzSW1hZ2UgPSB7c3JjOiAiSW1hZ2VzL0xlZ2FjeS9MYXllckJvcmRlcnMuc3ZnIiwgd2lk dGg6IDE2LCBoZWlnaHQ6IDE2fTsKICAgICAgICAgc2hhZG93RE9NSW1hZ2UgPSB7c3JjOiAiSW1h Z2VzL0xlZ2FjeS9TaGFkb3dET00uc3ZnIiwgd2lkdGg6IDE2LCBoZWlnaHQ6IDE2fTsKKyAgICAg ICAgcGFpbnRGbGFzaGluZ0ltYWdlID0ge3NyYzogIkltYWdlcy9QYWludEZsYXNoaW5nLnN2ZyIs IHdpZHRoOiAxNiwgaGVpZ2h0OiAxNn07CiAgICAgfSBlbHNlIHsKICAgICAgICAgbGF5ZXJCb3Jk ZXJzSW1hZ2UgPSB7c3JjOiAiSW1hZ2VzL0xheWVyQm9yZGVycy5zdmciLCB3aWR0aDogMTMsIGhl aWdodDogMTN9OwogICAgICAgICBzaGFkb3dET01JbWFnZSA9IHtzcmM6ICJJbWFnZXMvU2hhZG93 RE9NLnN2ZyIsIHdpZHRoOiAxMywgaGVpZ2h0OiAxM307CisgICAgICAgIHBhaW50Rmxhc2hpbmdJ bWFnZSA9IHtzcmM6ICJJbWFnZXMvUGFpbnRGbGFzaGluZy5zdmciLCB3aWR0aDogMTMsIGhlaWdo dDogMTN9OwogICAgIH0KIAogICAgIHRoaXMuX2NvbXBvc2l0aW5nQm9yZGVyc0J1dHRvbk5hdmln YXRpb25JdGVtID0gbmV3IFdlYkluc3BlY3Rvci5BY3RpdmF0ZUJ1dHRvbk5hdmlnYXRpb25JdGVt KCJsYXllci1ib3JkZXJzIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJTaG93IGNvbXBvc2l0aW5n IGJvcmRlcnMiKSwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJIaWRlIGNvbXBvc2l0aW5nIGJvcmRl cnMiKSwgbGF5ZXJCb3JkZXJzSW1hZ2Uuc3JjLCBsYXllckJvcmRlcnNJbWFnZS53aWR0aCwgbGF5 ZXJCb3JkZXJzSW1hZ2UuaGVpZ2h0KTsKICAgICB0aGlzLl9jb21wb3NpdGluZ0JvcmRlcnNCdXR0 b25OYXZpZ2F0aW9uSXRlbS5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5CdXR0b25OYXZp Z2F0aW9uSXRlbS5FdmVudC5DbGlja2VkLCB0aGlzLl90b2dnbGVDb21wb3NpdGluZ0JvcmRlcnMs IHRoaXMpOwogICAgIHRoaXMuX2NvbXBvc2l0aW5nQm9yZGVyc0J1dHRvbk5hdmlnYXRpb25JdGVt LmVuYWJsZWQgPSAhIVBhZ2VBZ2VudC5nZXRDb21wb3NpdGluZ0JvcmRlcnNWaXNpYmxlOwogCisg ICAgdGhpcy5fcGFpbnRGbGFzaGluZ0J1dHRvbk5hdmlnYXRpb25JdGVtID0gbmV3IFdlYkluc3Bl Y3Rvci5BY3RpdmF0ZUJ1dHRvbk5hdmlnYXRpb25JdGVtKCJwYWludC1mbGFzaGluZyIsIFdlYklu c3BlY3Rvci5VSVN0cmluZygiRW5hYmxlIHBhaW50IGZsYXNoaW5nIiksIFdlYkluc3BlY3Rvci5V SVN0cmluZygiRGlzYWJsZSBwYWludCBmbGFzaGluZyIpLCBwYWludEZsYXNoaW5nSW1hZ2Uuc3Jj LCBwYWludEZsYXNoaW5nSW1hZ2Uud2lkdGgsIHBhaW50Rmxhc2hpbmdJbWFnZS5oZWlnaHQpOwor ICAgIHRoaXMuX3BhaW50Rmxhc2hpbmdCdXR0b25OYXZpZ2F0aW9uSXRlbS5hZGRFdmVudExpc3Rl bmVyKFdlYkluc3BlY3Rvci5CdXR0b25OYXZpZ2F0aW9uSXRlbS5FdmVudC5DbGlja2VkLCB0aGlz Ll90b2dnbGVQYWludEZsYXNoaW5nLCB0aGlzKTsKKyAgICB0aGlzLl9wYWludEZsYXNoaW5nQnV0 dG9uTmF2aWdhdGlvbkl0ZW0uZW5hYmxlZCA9IHRydWU7CisKICAgICBXZWJJbnNwZWN0b3Iuc2hv d1NoYWRvd0RPTVNldHRpbmcuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuU2V0dGluZy5F dmVudC5DaGFuZ2VkLCB0aGlzLl9zaG93U2hhZG93RE9NU2V0dGluZ0NoYW5nZWQsIHRoaXMpOwog ICAgIHRoaXMuX3Nob3dzU2hhZG93RE9NQnV0dG9uTmF2aWdhdGlvbkl0ZW0gPSBuZXcgV2ViSW5z cGVjdG9yLkFjdGl2YXRlQnV0dG9uTmF2aWdhdGlvbkl0ZW0oInNob3dzLXNoYWRvdy1ET00iLCBX ZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlNob3cgc2hhZG93IERPTSBub2RlcyIpLCBXZWJJbnNwZWN0 b3IuVUlTdHJpbmcoIkhpZGUgc2hhZG93IERPTSBub2RlcyIpLCBzaGFkb3dET01JbWFnZS5zcmMs IHNoYWRvd0RPTUltYWdlLndpZHRoLCBzaGFkb3dET01JbWFnZS5oZWlnaHQpOwogICAgIHRoaXMu X3Nob3dzU2hhZG93RE9NQnV0dG9uTmF2aWdhdGlvbkl0ZW0uYWRkRXZlbnRMaXN0ZW5lcihXZWJJ bnNwZWN0b3IuQnV0dG9uTmF2aWdhdGlvbkl0ZW0uRXZlbnQuQ2xpY2tlZCwgdGhpcy5fdG9nZ2xl U2hvd3NTaGFkb3dET01TZXR0aW5nLCB0aGlzKTsKQEAgLTc0LDcgKzgwLDcgQEAgV2ViSW5zcGVj dG9yLkRPTVRyZWVDb250ZW50Vmlldy5wcm90b3R5cGUgPSB7CiAKICAgICBnZXQgbmF2aWdhdGlv bkl0ZW1zKCkKICAgICB7Ci0gICAgICAgIHJldHVybiBbdGhpcy5fc2hvd3NTaGFkb3dET01CdXR0 b25OYXZpZ2F0aW9uSXRlbSwgdGhpcy5fY29tcG9zaXRpbmdCb3JkZXJzQnV0dG9uTmF2aWdhdGlv bkl0ZW1dOworICAgICAgICByZXR1cm4gW3RoaXMuX3Nob3dzU2hhZG93RE9NQnV0dG9uTmF2aWdh dGlvbkl0ZW0sIHRoaXMuX2NvbXBvc2l0aW5nQm9yZGVyc0J1dHRvbk5hdmlnYXRpb25JdGVtLCB0 aGlzLl9wYWludEZsYXNoaW5nQnV0dG9uTmF2aWdhdGlvbkl0ZW1dOwogICAgIH0sCiAKICAgICBn ZXQgZG9tVHJlZU91dGxpbmUoKQpAQCAtNDE0LDYgKzQyMCwxNSBAQCBXZWJJbnNwZWN0b3IuRE9N VHJlZUNvbnRlbnRWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgUGFnZUFnZW50LnNldENvbXBv c2l0aW5nQm9yZGVyc1Zpc2libGUoYWN0aXZhdGVkKTsKICAgICB9LAogCisgICAgX3RvZ2dsZVBh aW50Rmxhc2hpbmc6IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsKKyAgICAgICAgY29uc29sZS5hc3Nl cnQoUGFnZUFnZW50LnNldFNob3dQYWludFJlY3RzKTsKKworICAgICAgICB2YXIgYWN0aXZhdGVk ID0gIXRoaXMuX3BhaW50Rmxhc2hpbmdCdXR0b25OYXZpZ2F0aW9uSXRlbS5hY3RpdmF0ZWQ7Cisg ICAgICAgIHRoaXMuX3BhaW50Rmxhc2hpbmdCdXR0b25OYXZpZ2F0aW9uSXRlbS5hY3RpdmF0ZWQg PSBhY3RpdmF0ZWQ7CisgICAgICAgIFBhZ2VBZ2VudC5zZXRTaG93UGFpbnRSZWN0cyhhY3RpdmF0 ZWQpOworICAgIH0sCisKICAgICBfdXBkYXRlQ29tcG9zaXRpbmdCb3JkZXJzQnV0dG9uVG9NYXRj aFBhZ2VTZXR0aW5nczogZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgaWYgKCFQYWdlQWdlbnQu Z2V0Q29tcG9zaXRpbmdCb3JkZXJzVmlzaWJsZSkK