136130 2014-08-21 12:44:17 -0700 [GTK] Toggle buttons visually broken with GTK+ 3.13.7 2014-08-24 15:07:52 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Major --- 1 mcatanzaro webkit-unassigned cgarcia commit-queue mrobinson oldest_to_newest 1030531 0 mcatanzaro 2014-08-21 12:44:17 -0700 GTK+ 3.13.7 added GTK_STATE_FLAG_CHECKED to solve a theme problem; we have to use it if we want toggle buttons (like checkboxes and radio buttons) to display as active. 1030533 1 mcatanzaro 2014-08-21 12:45:00 -0700 We don't have a see also field? OK, see also: https://bugzilla.gnome.org/show_bug.cgi?id=733967 https://bugzilla.gnome.org/show_bug.cgi?id=735011 1030538 2 236935 mcatanzaro 2014-08-21 13:05:09 -0700 Created attachment 236935 Patch 1030908 3 236935 mrobinson 2014-08-22 23:33:43 -0700 Comment on attachment 236935 Patch Does GTK_STATE_FLAG_CHECKED exist in older versions as well. Can we just add this flag unconditionally? 1030926 4 mcatanzaro 2014-08-23 07:55:46 -0700 No, it's new. If we add it unconditionally then we must bump the GTK+ requirement. 1030928 5 236935 mrobinson 2014-08-23 11:11:25 -0700 Comment on attachment 236935 Patch Thanks! 1030971 6 mcatanzaro 2014-08-24 09:23:32 -0700 I think this also needs review+ for it to be committed, correct? 1030991 7 236935 mrobinson 2014-08-24 14:34:56 -0700 Comment on attachment 236935 Patch Sorry. 1030992 8 236935 commit-queue 2014-08-24 15:07:49 -0700 Comment on attachment 236935 Patch Clearing flags on attachment: 236935 Committed r172896: <http://trac.webkit.org/changeset/172896> 1030993 9 commit-queue 2014-08-24 15:07:52 -0700 All reviewed patches have been landed. Closing bug. 236935 2014-08-21 13:05:09 -0700 2014-08-24 15:07:45 -0700 Patch bug-136130-20140821150500.patch text/plain 1756 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyODE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmEyOGM1Mzg5MGM0M2Yz NDE4OTZjMTlkY2NmZjI1ODU4ZDc1Yzk2NS4uOWZmMWZlZmY2OTRjOWQxYzRjNGI0ZjU4MDIyYWM3 NWNlM2ZmZTk0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA4LTIxICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBU b2dnbGUgYnV0dG9ucyB2aXN1YWxseSBicm9rZW4gd2l0aCBHVEsrIDMuMTMuNworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2MTMwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBIb3Bl ZnVsbHkgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cywgYW5kIG91ciB0ZXN0cyBvbmx5CisgICAg ICAgIHJ1biB3aXRoIEdUSysgMy42IGFueXdheS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9S ZW5kZXJUaGVtZUd0azMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGFpbnRUb2dnbGUpOiB1c2Ug R1RLX1NUQVRFX0ZMQUdfQ0hFQ0tFRCB3aGVuIGNvbXBpbGluZyBmb3IKKyAgICAgICAgR1RLKyAz LjEzLjcgYW5kIGFib3ZlIHRvIGVuc3VyZSB0b2dnbGUgYnV0dG9ucyBkaXNwbGF5IGFzIHRvZ2ds ZWQuCisKIDIwMTQtMDgtMjAgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0 Lm9yZz4KIAogICAgICAgICBJbnRyb2R1Y2luZyBXRUJDT1JFX0VYUE9SVCBtYWNyby4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0azMuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrMy5jcHAKaW5kZXggMzYz MGM0M2RmZmRlNTljNmVhODQzYzM1YTM3ZThlOTQ2MTFlNGFlNS4uNmQ4MTFhMTc0N2FjM2NhN2Zm Mzc2YmI2YTBmY2IwMjI3M2MzMzVkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1JlbmRlclRoZW1lR3RrMy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3RrL1JlbmRlclRoZW1lR3RrMy5jcHAKQEAgLTI1Myw3ICsyNTMsMTEgQEAgc3RhdGljIHZvaWQg cGFpbnRUb2dnbGUoY29uc3QgUmVuZGVyVGhlbWVHdGsqIHRoZW1lLCBHVHlwZSB3aWRnZXRUeXBl LCBjb25zdCBSZW4KICAgICBpZiAodGhlbWUtPmlzSW5kZXRlcm1pbmF0ZShyZW5kZXJPYmplY3Qp KQogICAgICAgICBmbGFncyB8PSBHVEtfU1RBVEVfRkxBR19JTkNPTlNJU1RFTlQ7CiAgICAgZWxz ZSBpZiAodGhlbWUtPmlzQ2hlY2tlZChyZW5kZXJPYmplY3QpKQorI2lmIEdUS19DSEVDS19WRVJT SU9OKDMsIDEzLCA3KQorICAgICAgICBmbGFncyB8PSBHVEtfU1RBVEVfRkxBR19DSEVDS0VEOwor I2Vsc2UKICAgICAgICAgZmxhZ3MgfD0gR1RLX1NUQVRFX0ZMQUdfQUNUSVZFOworI2VuZGlmCiAg ICAgaWYgKHRoZW1lLT5pc1ByZXNzZWQocmVuZGVyT2JqZWN0KSkKICAgICAgICAgZmxhZ3MgfD0g R1RLX1NUQVRFX0ZMQUdfU0VMRUNURUQ7CiAgICAgZ3RrX3N0eWxlX2NvbnRleHRfc2V0X3N0YXRl KGNvbnRleHQsIHN0YXRpY19jYXN0PEd0a1N0YXRlRmxhZ3M+KGZsYWdzKSk7Cg==