136126 2014-08-21 02:07:55 -0700 WebResourceLoadScheduler class has a public constructor although it is a singleton. 2016-09-17 07:09:43 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 a.malewski webkit-unassigned andersca ap dbates m.leszko mpakulavelrutka oldest_to_newest 1030474 0 a.malewski 2014-08-21 02:07:55 -0700 WebResourceLoadScheduler class is a singleton but has public constructor. Access to constructor needs to be changed from public to protected. There is also need to implement a function that is responsible for returning reference to immortal object. 1031051 1 237062 a.malewski 2014-08-25 00:21:14 -0700 Created attachment 237062 Patch 1031058 2 237062 darin 2014-08-25 00:46:08 -0700 Comment on attachment 237062 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237062&action=review > Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.h:66 > +protected: > + WebResourceLoadScheduler(); > + virtual ~WebResourceLoadScheduler(); Why protected instead of private? 1031059 3 237062 darin 2014-08-25 00:46:40 -0700 Comment on attachment 237062 Patch This doesn’t seem like a great change. It’s OK, but not a significant improvement. 1031063 4 a.malewski 2014-08-25 01:05:33 -0700 This patch is a result of discussion from: https://bugs.webkit.org/show_bug.cgi?id=136038 1187199 5 237062 dbates 2016-04-25 20:24:43 -0700 Comment on attachment 237062 Patch This patch is stale and needs to be rebased. The class WebResourceLoadScheduler was renamed to WebLoaderStrategy in <http://trac.webkit.org/changeset/193468> (bug #151854). 1230812 6 237062 mcatanzaro 2016-09-17 07:09:43 -0700 Comment on attachment 237062 Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug. 237062 2014-08-25 00:21:14 -0700 2016-09-17 07:09:43 -0700 Patch bug-136126-20140825092106.patch text/plain 4664 a.malewski U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxOTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjhiYTI2OTlkMWUzNTVk ZDBjNzk1OTEwMGQ4ZjljYjUxNmQ3Y2RmZi4uZjFjN2VmNWVlZmNmZWFiNDNiZGYzNmU3YzZmM2Zi NWJhNjI3YTQ3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA4LTI1ICBBbGJl cnQgTWFsZXdza2kgIDxhLm1hbGV3c2tpQHNhbXN1bmcuY29tPgorCisgICAgICAgIENoYW5nZWQg YmVoYXZpb3Igb2YgV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyIHRvIGFjdCBhcyBuZXZlciBkZWxl dGVkIG9iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM2MTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyIGNsYXNzIGlzIGEgc2luZ2xldG9uIHNvIGNoYW5n ZWQgYWNjZXNzIHRvIGNvbnN0cnVjdG9yIGZyb20gcHVibGljIHRvIHByb3RlY3RlZCBhbmQgY3Jl YXRlZCB3ZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXIoKSBzdGF0aWMgZnVuY3Rpb24gcmV0dXJuaW5n IHJlZmVyZW5jZSB0byBXZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXIgaW5zdGFuY2UuCisKKyAgICAg ICAgKiBXZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyOjpjcmVhdGUpOgorICAgICAg ICAqIFdlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXIuaDoKKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9j ZXNzOjpXZWJQcm9jZXNzKToKKwogMjAxNC0wOC0wMiAgSmVyZW15IEpvbmVzICA8amVyZW15akBh cHBsZS5jb20+CiAKICAgICAgICAgU3VwcG9ydCBib3RoIHdpbmRvdyBhbmQgdmlldyBiYXNlZCB2 aWRlbyBmdWxsc2NyZWVuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9O ZXR3b3JrL1dlYlJlc291cmNlTG9hZFNjaGVkdWxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcAppbmRleCBjYWJjM2Mz ZDUzZDliZDcxNjM4NDE2MDVmZmYwMjYzMDhlYjEwZGI1Li5jN2UzMWZjM2Y2MzZmZDYwZmZjZmJl MDFiNzU5YjE4YTdjMDg5N2RhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcApAQCAtNTks NiArNTksMTIgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJLaXQg ewogCitXZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXImIFdlYlJlc291cmNlTG9hZFNjaGVkdWxlcjo6 d2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyKCkKK3sKKyAgICBzdGF0aWMgV2ViUmVzb3VyY2VMb2Fk U2NoZWR1bGVyIGdsb2JhbFdlYlNjaGVkdWxlcjsKKyAgICByZXR1cm4gZ2xvYmFsV2ViU2NoZWR1 bGVyOworfQorCiBXZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXI6OldlYlJlc291cmNlTG9hZFNjaGVk dWxlcigpCiAgICAgOiBtX2ludGVybmFsbHlGYWlsZWRMb2FkVGltZXIoUnVuTG9vcDo6bWFpbigp LCB0aGlzLCAmV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyOjppbnRlcm5hbGx5RmFpbGVkTG9hZFRp bWVyRmlyZWQpCiAgICAgLCBtX3N1c3BlbmRQZW5kaW5nUmVxdWVzdHNDb3VudCgwKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZFNj aGVkdWxlci5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNl TG9hZFNjaGVkdWxlci5oCmluZGV4IGZiYTRhZjQzYTZmMTFhZTFlOGFiY2U4MmIzNThhYjQ3ZTA1 OGVhNDcuLjA0NDkxN2NkNjY5NGY2ZmRhNDVlMjkxN2ZhMmViN2FiODczZjZmZGMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRTY2hl ZHVsZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3Vy Y2VMb2FkU2NoZWR1bGVyLmgKQEAgLTQyLDE2ICs0MiwxNCBAQCB0eXBlZGVmIHVpbnQ2NF90IFJl c291cmNlTG9hZElkZW50aWZpZXI7CiBjbGFzcyBXZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXIgOiBw dWJsaWMgV2ViQ29yZTo6UmVzb3VyY2VMb2FkU2NoZWR1bGVyIHsKICAgICBXVEZfTUFLRV9OT05D T1BZQUJMRShXZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXIpOyBXVEZfTUFLRV9GQVNUX0FMTE9DQVRF RDsKIHB1YmxpYzoKLSAgICBXZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXIoKTsKLSAgICB2aXJ0dWFs IH5XZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXIoKTsKLSAgICAKKyAgICBzdGF0aWMgV2ViUmVzb3Vy Y2VMb2FkU2NoZWR1bGVyJiB3ZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXIoKTsKICAgICB2aXJ0dWFs IFBhc3NSZWZQdHI8V2ViQ29yZTo6U3VicmVzb3VyY2VMb2FkZXI+IHNjaGVkdWxlU3VicmVzb3Vy Y2VMb2FkKFdlYkNvcmU6OkZyYW1lKiwgV2ViQ29yZTo6Q2FjaGVkUmVzb3VyY2UqLCBjb25zdCBX ZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmLCBXZWJDb3JlOjpSZXNvdXJjZUxvYWRQcmlvcml0eSwg Y29uc3QgV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXJPcHRpb25zJikgb3ZlcnJpZGU7CiAgICAgdmly dHVhbCBQYXNzUmVmUHRyPFdlYkNvcmU6Ok5ldHNjYXBlUGx1Z0luU3RyZWFtTG9hZGVyPiBzY2hl ZHVsZVBsdWdpblN0cmVhbUxvYWQoV2ViQ29yZTo6RnJhbWUqLCBXZWJDb3JlOjpOZXRzY2FwZVBs dWdJblN0cmVhbUxvYWRlckNsaWVudCosIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYp IG92ZXJyaWRlOwotICAgIAorCiAgICAgdmlydHVhbCB2b2lkIHJlbW92ZShXZWJDb3JlOjpSZXNv dXJjZUxvYWRlciopIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCBzZXREZWZlcnNMb2FkaW5n KFdlYkNvcmU6OlJlc291cmNlTG9hZGVyKiwgYm9vbCkgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCB2 b2lkIGNyb3NzT3JpZ2luUmVkaXJlY3RSZWNlaXZlZChXZWJDb3JlOjpSZXNvdXJjZUxvYWRlcios IGNvbnN0IFdlYkNvcmU6OlVSTCYgcmVkaXJlY3RVUkwpIG92ZXJyaWRlOwotICAgIAorCiAgICAg dmlydHVhbCB2b2lkIHNlcnZlUGVuZGluZ1JlcXVlc3RzKFdlYkNvcmU6OlJlc291cmNlTG9hZFBy aW9yaXR5IG1pbmltdW1Qcmlvcml0eSA9IFdlYkNvcmU6OlJlc291cmNlTG9hZFByaW9yaXR5VmVy eUxvdykgb3ZlcnJpZGU7CiAKICAgICB2aXJ0dWFsIHZvaWQgc3VzcGVuZFBlbmRpbmdSZXF1ZXN0 cygpIG92ZXJyaWRlOwpAQCAtNjMsNiArNjEsMTAgQEAgcHVibGljOgogCiAgICAgdm9pZCBuZXR3 b3JrUHJvY2Vzc0NyYXNoZWQoKTsKIAorcHJvdGVjdGVkOgorICAgIFdlYlJlc291cmNlTG9hZFNj aGVkdWxlcigpOworICAgIHZpcnR1YWwgfldlYlJlc291cmNlTG9hZFNjaGVkdWxlcigpOworCiBw cml2YXRlOgogICAgIHZvaWQgc2NoZWR1bGVMb2FkKFdlYkNvcmU6OlJlc291cmNlTG9hZGVyKiwg V2ViQ29yZTo6Q2FjaGVkUmVzb3VyY2UqLCBXZWJDb3JlOjpSZXNvdXJjZUxvYWRQcmlvcml0eSwg Ym9vbCBzaG91bGRDbGVhclJlZmVycmVyT25IVFRQU1RvSFRUUFJlZGlyZWN0KTsKICAgICB2b2lk IHNjaGVkdWxlSW50ZXJuYWxseUZhaWxlZExvYWQoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXIqKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCmluZGV4IDdmM2MxMjAwMDZi OTNjYTcyZDZkZjQ4Mzk3OWQwNDYyY2EzYTA3NTQuLjM2NzdhYzczNjY5MTIyMDM4ODY5Nzk3ZGI5 Y2EwMjc3ZDVhOGE1NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNw cApAQCAtMTY2LDcgKzE2Niw3IEBAIFdlYlByb2Nlc3M6OldlYlByb2Nlc3MoKQogICAgICwgbV9p Y29uRGF0YWJhc2VQcm94eShuZXcgV2ViSWNvbkRhdGFiYXNlUHJveHkodGhpcykpCiAjaWYgRU5B QkxFKE5FVFdPUktfUFJPQ0VTUykKICAgICAsIG1fdXNlc05ldHdvcmtQcm9jZXNzKGZhbHNlKQot ICAgICwgbV93ZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXIobmV3IFdlYlJlc291cmNlTG9hZFNjaGVk dWxlcikKKyAgICAsIG1fd2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyKCZXZWJSZXNvdXJjZUxvYWRT Y2hlZHVsZXI6OndlYlJlc291cmNlTG9hZFNjaGVkdWxlcigpKQogI2VuZGlmCiAjaWYgRU5BQkxF KE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAgICAgLCBtX3BsdWdpblByb2Nlc3NDb25uZWN0aW9uTWFu YWdlcihQbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbk1hbmFnZXI6OmNyZWF0ZSgpKQo=