136125 2014-08-21 01:33:41 -0700 Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests 2014-09-16 07:13:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 136856 126604 131054 1 ossy webkit-unassigned commit-queue ggaren lforschler msaboff ossy rnagy oldest_to_newest 1030470 0 ossy 2014-08-21 01:33:41 -0700 countFailures of RunLLINTCLoopTests and Run32bitJSCTests in master.cfg don't work at all, they don't report the number of failing tests: http://build.webkit.org/builders/Apple%20Mavericks%2032-bit%20JSC%20%28BuildAndTest%29/builds/3703 It's hard to determine which patch caused how many regressions if we can't see the exact number on the waterfall. The buggy countFailures introduced in: https://trac.webkit.org/changeset/166608 https://trac.webkit.org/changeset/161461 Why can't we reuse the RunJavaScriptCoreTests class which works fine and its commandComplete covered by unittests too? 1030471 1 ossy 2014-08-21 01:40:06 -0700 I think only the 32 bit countFailures is buggy, because this bot runs the jsc-stress tests, not the old Mozilla tests, and their output are different. But unifying the output parsing of run-javascriptcore-tests would be great. 1030488 2 ossy 2014-08-21 03:37:30 -0700 Run32bitJSCTests buildstep runs the JSC stress tests, so its regexp should accept "failure" and "failures", not "regressions". RunLLINTCLoopTests buildstep runs Mozilla tests, so its regexp should accept "regression" and "regressions" too. The command of RunJavaScriptCoreTests, RunLLINTCLoopTests and Run32bitJSCTests are a little bit different, so unifying them isn't trivial. So let's fix the regexps quickly and try to unify them later. 1030494 3 236923 rnagy 2014-08-21 04:32:17 -0700 Created attachment 236923 Proposed patch Quick fix in regexps at RunLLINTCLoopTests and Run32bitJSCTests class. 1030496 4 commit-queue 2014-08-21 04:33:39 -0700 Attachment 236923 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:148: [RunLLINTCLoopTestsTest.assertResults] Undefined variable 'RunLLINTCLoopTests' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:157: [RunLLINTCLoopTestsTest.test_failures] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:160: [RunLLINTCLoopTestsTest.test_failure] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:163: [RunLLINTCLoopTestsTest.test_no_failure] Undefined variable 'SUCCESS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:169: [Run32bitJSCTestsTest.assertResults] Undefined variable 'Run32bitJSCTests' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:178: [Run32bitJSCTestsTest.test_failures] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:181: [Run32bitJSCTestsTest.test_failure] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:184: [Run32bitJSCTestsTest.test_no_failure] Undefined variable 'SUCCESS' [pylint/E0602] [5] Total errors found: 8 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1030497 5 236923 ossy 2014-08-21 04:40:36 -0700 Comment on attachment 236923 Proposed patch LGTM, just a nit: Can we use only single or double quotes? 1030498 6 236924 rnagy 2014-08-21 04:50:39 -0700 Created attachment 236924 Proposed patch Change all double quote to singe quote. 1030499 7 commit-queue 2014-08-21 04:52:29 -0700 Attachment 236924 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:148: [RunLLINTCLoopTestsTest.assertResults] Undefined variable 'RunLLINTCLoopTests' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:157: [RunLLINTCLoopTestsTest.test_failures] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:160: [RunLLINTCLoopTestsTest.test_failure] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:163: [RunLLINTCLoopTestsTest.test_no_failure] Undefined variable 'SUCCESS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:169: [Run32bitJSCTestsTest.assertResults] Undefined variable 'Run32bitJSCTests' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:178: [Run32bitJSCTestsTest.test_failures] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:181: [Run32bitJSCTestsTest.test_failure] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:184: [Run32bitJSCTestsTest.test_no_failure] Undefined variable 'SUCCESS' [pylint/E0602] [5] Total errors found: 8 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1030500 8 236924 commit-queue 2014-08-21 05:29:49 -0700 Comment on attachment 236924 Proposed patch Clearing flags on attachment: 236924 Committed r172829: <http://trac.webkit.org/changeset/172829> 1030501 9 commit-queue 2014-08-21 05:29:53 -0700 All reviewed patches have been landed. Closing bug. 236923 2014-08-21 04:32:17 -0700 2014-08-21 04:50:39 -0700 Proposed patch 0001-Fix-countFailures-of-RunLLINTCLoopTests-and-Run32bit.patch text/plain 5383 rnagy RnJvbSA5ZjRjZTEwOWFmZjA3MGQ3MDg1YjE0MmI4YzlkOGZmODE1YjQyM2U3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZW5hdG8gTmFneSA8bmFneS5yZW5hdG9Ac3R1ZC51LXN6ZWdl ZC5odT4KRGF0ZTogVGh1LCAyMSBBdWcgMjAxNCAxMzoyMToyMyArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIEZpeCBjb3VudEZhaWx1cmVzIG9mIFJ1bkxMSU5UQ0xvb3BUZXN0cyBhbmQgUnVuMzJiaXRK U0NUZXN0cwoKLS0tCiAuLi4vYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZyAgICAg ICAgICAgICB8ICA4ICsrLS0tCiAuLi4vYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyY2Zn X3VuaXR0ZXN0LnB5ICB8IDQyICsrKysrKysrKysrKysrKysrKysrKysKIFRvb2xzL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMjIgKysrKysrKysrKysrCiAz IGZpbGVzIGNoYW5nZWQsIDY4IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L21hc3Rlci5jZmcKaW5kZXggNDYyOTQyNS4uYzVjZWNkYiAxMDA2NDQKLS0tIGEvVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZworKysgYi9U b29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2Zn CkBAIC01NTIsOCArNTUyLDggQEAgY2xhc3MgUnVuTExJTlRDTG9vcFRlc3RzKFRlc3RXaXRoRmFp bHVyZUNvdW50KToKIAogICAgIGRlZiBjb3VudEZhaWx1cmVzKHNlbGYsIGNtZCk6CiAgICAgICAg IGxvZ1RleHQgPSBjbWQubG9nc1snc3RkaW8nXS5nZXRUZXh0KCkKLSAgICAgICAgIyBXZSdyZSBs b29raW5nIGZvciB0aGUgbGluZSB0aGF0IGxvb2tzIGxpa2UgdGhpczogMCByZWdyZXNzaW9ucyBm b3VuZC5cbjAgdGVzdHMgZml4ZWQuCi0gICAgICAgIHJlZ2V4ID0gcmUuY29tcGlsZShyJyg/UDxj b3VudD5cZCspIHJlZ3Jlc3Npb25zIGZvdW5kLicpCisgICAgICAgICMgV2UncmUgbG9va2luZyBm b3IgdGhlIGxpbmUgdGhhdCBsb29rcyBsaWtlIHRoaXM6IDAgcmVncmVzc2lvbnMgZm91bmQuCisg ICAgICAgIHJlZ2V4ID0gcmUuY29tcGlsZShyJyg/UDxjb3VudD5cZCspIHJlZ3Jlc3Npb25zPyBm b3VuZC4nKQogICAgICAgICBmb3IgbGluZSBpbiBsb2dUZXh0LnNwbGl0bGluZXMoKToKICAgICAg ICAgICAgIG1hdGNoID0gcmVnZXgubWF0Y2gobGluZSkKICAgICAgICAgICAgIGlmIG5vdCBtYXRj aDoKQEAgLTU3MSw4ICs1NzEsOCBAQCBjbGFzcyBSdW4zMmJpdEpTQ1Rlc3RzKFRlc3RXaXRoRmFp bHVyZUNvdW50KToKIAogICAgIGRlZiBjb3VudEZhaWx1cmVzKHNlbGYsIGNtZCk6CiAgICAgICAg IGxvZ1RleHQgPSBjbWQubG9nc1snc3RkaW8nXS5nZXRUZXh0KCkKLSAgICAgICAgIyBXZSdyZSBs b29raW5nIGZvciB0aGUgbGluZSB0aGF0IGxvb2tzIGxpa2UgdGhpczogMCByZWdyZXNzaW9ucyBm b3VuZC5cbjAgdGVzdHMgZml4ZWQuCi0gICAgICAgIHJlZ2V4ID0gcmUuY29tcGlsZShyJyg/UDxj b3VudD5cZCspIHJlZ3Jlc3Npb25zIGZvdW5kLicpCisgICAgICAgICMgV2UncmUgbG9va2luZyBm b3IgdGhlIGxpbmUgdGhhdCBsb29rcyBsaWtlIHRoaXM6IDAgZmFpbHVyZXMgZm91bmQuCisgICAg ICAgIHJlZ2V4ID0gcmUuY29tcGlsZShyJyg/UDxjb3VudD5cZCspIGZhaWx1cmVzPyBmb3VuZC4n KQogICAgICAgICBmb3IgbGluZSBpbiBsb2dUZXh0LnNwbGl0bGluZXMoKToKICAgICAgICAgICAg IG1hdGNoID0gcmVnZXgubWF0Y2gobGluZSkKICAgICAgICAgICAgIGlmIG5vdCBtYXRjaDoKZGlm ZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L21hc3RlcmNmZ191bml0dGVzdC5weSBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndl YmtpdC5vcmctY29uZmlnL21hc3RlcmNmZ191bml0dGVzdC5weQppbmRleCA3YmFmMjhkLi5hOTg3 YTMwIDEwMDc1NQotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXJjZmdfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyY2ZnX3VuaXR0ZXN0LnB5CkBAIC0xNDIs NiArMTQyLDQ4IEBAIGNsYXNzIFJ1bkphdmFTY3JpcHRDb3JlVGVzdHNUZXN0KHVuaXR0ZXN0LlRl c3RDYXNlKToKICAgICA1IGZhaWx1cmVzIGZvdW5kLiIiIikKIAogCitjbGFzcyBSdW5MTElOVENM b29wVGVzdHNUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKKyAgICBkZWYgYXNzZXJ0UmVzdWx0cyhz ZWxmLCBleHBlY3RlZF9yZXN1bHQsIGV4cGVjdGVkX3RleHQsIHJjLCBzdGRpbyk6CisgICAgICAg IGNtZCA9IFN0dWJSZW1vdGVDb21tYW5kKHJjLCBzdGRpbykKKyAgICAgICAgc3RlcCA9IFJ1bkxM SU5UQ0xvb3BUZXN0cygpCisgICAgICAgIHN0ZXAuY29tbWFuZENvbXBsZXRlKGNtZCkKKyAgICAg ICAgYWN0dWFsX3Jlc3VsdHMgPSBzdGVwLmV2YWx1YXRlQ29tbWFuZChjbWQpCisgICAgICAgIGFj dHVhbF90ZXh0ID0gc3RlcC5nZXRUZXh0MihjbWQsIGFjdHVhbF9yZXN1bHRzKQorCisgICAgICAg IHNlbGYuYXNzZXJ0RXF1YWwoZXhwZWN0ZWRfcmVzdWx0LCBhY3R1YWxfcmVzdWx0cykKKyAgICAg ICAgc2VsZi5hc3NlcnRFcXVhbChhY3R1YWxfdGV4dCwgZXhwZWN0ZWRfdGV4dCkKKworICAgIGRl ZiB0ZXN0X2ZhaWx1cmVzKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydFJlc3VsdHMoRkFJTFVS RSwgWyc1IHJlZ3Jlc3Npb25zIGZvdW5kLiddLCAxLCAgJzUgcmVncmVzc2lvbnMgZm91bmQuJykK KworICAgIGRlZiB0ZXN0X2ZhaWx1cmUoc2VsZik6CisgICAgICAgIHNlbGYuYXNzZXJ0UmVzdWx0 cyhGQUlMVVJFLCBbJzEgcmVncmVzc2lvbnMgZm91bmQuJ10sIDEsICAnMSByZWdyZXNzaW9uIGZv dW5kLicpCisKKyAgICBkZWYgdGVzdF9ub19mYWlsdXJlKHNlbGYpOgorICAgICAgICBzZWxmLmFz c2VydFJlc3VsdHMoU1VDQ0VTUywgWyJ3ZWJraXQtanNjLWNsb29wLXRlc3QiXSwgMCwgICIwIHJl Z3Jlc3Npb25zIGZvdW5kLiIpCisKKworY2xhc3MgUnVuMzJiaXRKU0NUZXN0c1Rlc3QodW5pdHRl c3QuVGVzdENhc2UpOgorICAgIGRlZiBhc3NlcnRSZXN1bHRzKHNlbGYsIGV4cGVjdGVkX3Jlc3Vs dCwgZXhwZWN0ZWRfdGV4dCwgcmMsIHN0ZGlvKToKKyAgICAgICAgY21kID0gU3R1YlJlbW90ZUNv bW1hbmQocmMsIHN0ZGlvKQorICAgICAgICBzdGVwID0gUnVuMzJiaXRKU0NUZXN0cygpCisgICAg ICAgIHN0ZXAuY29tbWFuZENvbXBsZXRlKGNtZCkKKyAgICAgICAgYWN0dWFsX3Jlc3VsdHMgPSBz dGVwLmV2YWx1YXRlQ29tbWFuZChjbWQpCisgICAgICAgIGFjdHVhbF90ZXh0ID0gc3RlcC5nZXRU ZXh0MihjbWQsIGFjdHVhbF9yZXN1bHRzKQorCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoZXhw ZWN0ZWRfcmVzdWx0LCBhY3R1YWxfcmVzdWx0cykKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChh Y3R1YWxfdGV4dCwgZXhwZWN0ZWRfdGV4dCkKKworICAgIGRlZiB0ZXN0X2ZhaWx1cmVzKHNlbGYp OgorICAgICAgICBzZWxmLmFzc2VydFJlc3VsdHMoRkFJTFVSRSwgWyc1IHJlZ3Jlc3Npb25zIGZv dW5kLiddLCAxLCAgJzUgZmFpbHVyZXMgZm91bmQuJykKKworICAgIGRlZiB0ZXN0X2ZhaWx1cmUo c2VsZik6CisgICAgICAgIHNlbGYuYXNzZXJ0UmVzdWx0cyhGQUlMVVJFLCBbJzEgcmVncmVzc2lv bnMgZm91bmQuJ10sIDEsICAnMSBmYWlsdXJlIGZvdW5kLicpCisKKyAgICBkZWYgdGVzdF9ub19m YWlsdXJlKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydFJlc3VsdHMoU1VDQ0VTUywgWyJ3ZWJr aXQtMzJiaXQtanNjLXRlc3QiXSwgMCwgICIwIGZhaWx1cmVzIGZvdW5kLiIpCisKKwogY2xhc3Mg UnVuVW5pdFRlc3RzVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgZGVmIGFzc2VydEZhaWx1 cmVzKHNlbGYsIGV4cGVjdGVkX2ZhaWx1cmVfY291bnQsIHN0ZGlvKToKICAgICAgICAgaWYgZXhw ZWN0ZWRfZmFpbHVyZV9jb3VudDoKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xz L0NoYW5nZUxvZwppbmRleCA4N2NhOTAyLi5mYTlhNDM4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFu Z2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTQtMDgtMjEg IFJlbmF0byBOYWd5ICA8bmFneS5yZW5hdG9Ac3R1ZC51LXN6ZWdlZC5odT4KKworICAgICAgICBG aXggY291bnRGYWlsdXJlcyBvZiBSdW5MTElOVENMb29wVGVzdHMgYW5kIFJ1bjMyYml0SlNDVGVz dHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYx MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmc6CisgICAg ICAgIChSdW5MTElOVENMb29wVGVzdHMuY291bnRGYWlsdXJlcyk6CisgICAgICAgIChSdW4zMmJp dEpTQ1Rlc3RzLmNvdW50RmFpbHVyZXMpOgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3RlcmNmZ191bml0dGVzdC5weToKKyAgICAgICAgKFJ1 bkxMSU5UQ0xvb3BUZXN0c1Rlc3QpOgorICAgICAgICAoUnVuTExJTlRDTG9vcFRlc3RzVGVzdC5h c3NlcnRSZXN1bHRzKToKKyAgICAgICAgKFJ1bkxMSU5UQ0xvb3BUZXN0c1Rlc3QudGVzdF9mYWls dXJlcyk6CisgICAgICAgIChSdW5MTElOVENMb29wVGVzdHNUZXN0LnRlc3RfZmFpbHVyZSk6Cisg ICAgICAgIChSdW5MTElOVENMb29wVGVzdHNUZXN0LnRlc3Rfbm9fZmFpbHVyZSk6CisgICAgICAg IChSdW4zMmJpdEpTQ1Rlc3RzVGVzdCk6CisgICAgICAgIChSdW4zMmJpdEpTQ1Rlc3RzVGVzdC5h c3NlcnRSZXN1bHRzKToKKyAgICAgICAgKFJ1bjMyYml0SlNDVGVzdHNUZXN0LnRlc3RfZmFpbHVy ZXMpOgorICAgICAgICAoUnVuMzJiaXRKU0NUZXN0c1Rlc3QudGVzdF9mYWlsdXJlKToKKyAgICAg ICAgKFJ1bjMyYml0SlNDVGVzdHNUZXN0LnRlc3Rfbm9fZmFpbHVyZSk6CisKIDIwMTQtMDgtMTgg IFJlbmF0byBOYWd5ICA8bmFneS5yZW5hdG9Ac3R1ZC51LXN6ZWdlZC5odT4KIAogICAgICAgICBS ZW1vdmUgb2Jzb2xldGUgcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzIHJlc3VsdCBwYXJzaW5nIGZy b20gbWFzdGVyLmNmZwotLSAKMS45LjEKCg== 236924 2014-08-21 04:50:39 -0700 2014-08-21 05:29:49 -0700 Proposed patch 0001-Fix-countFailures-of-RunLLINTCLoopTests-and-Run32bit.patch text/plain 0 rnagy