136122 2014-08-21 00:15:43 -0700 [EFL][WK2] Minibrowser : Add stop button to abort page load 2014-08-21 17:25:46 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kumar.rohit webkit-unassigned commit-queue gyuyoung.kim lucas.de.marchi ryuan.choi oldest_to_newest 1030456 0 kumar.rohit 2014-08-21 00:15:43 -0700 Add stop button to Minibrowser to abort page load similar to refresh button for page reload. 1030475 1 236917 kumar.rohit 2014-08-21 02:23:29 -0700 Created attachment 236917 Patch 1030503 2 236917 gyuyoung.kim 2014-08-21 05:36:27 -0700 Comment on attachment 236917 Patch LGTM 1030600 3 236917 commit-queue 2014-08-21 17:25:40 -0700 Comment on attachment 236917 Patch Clearing flags on attachment: 236917 Committed r172840: <http://trac.webkit.org/changeset/172840> 1030601 4 commit-queue 2014-08-21 17:25:46 -0700 All reviewed patches have been landed. Closing bug. 236917 2014-08-21 02:23:29 -0700 2014-08-21 17:25:40 -0700 Patch bug-136122-20140821145415.patch text/plain 2922 kumar.rohit U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNzk2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjA2OTQ0NWQ4ZTdkNmU4MDcyYjI5MjU5YWI3NzAxMGQw MzIzYjI2MC4uYTZlZmNmZmFiZTFmY2MxYzIxODVmZGM5NDUyYWRlNDNiNWU1OWVkNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTA4LTIxICBSb2hpdCBLdW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdW1dLMl0gTWluaWJyb3dzZXIgOiBBZGQgc3RvcCBidXR0b24gdG8gYWJv cnQgcGFnZSBsb2FkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzYxMjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWluLmM6CisgICAgICAgIChvbl9rZXlfZG93bik6Cisg ICAgICAgIChvbl9zdG9wX2J1dHRvbl9jbGlja2VkKTogQ2FsbGJhY2sgZm9yIHN0b3AgYnV0dG9u IHByZXNzLgorICAgICAgICAod2luZG93X2NyZWF0ZSk6CisKIDIwMTQtMDgtMTkgIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICB1cGRhdGUtd2Via2l0IHNob3VsZCBu b3QgY2hlY2sgZm9yIHRoZSBwcmVzZW5jZSBvZiBBcHBsZeKAmXMgSW50ZXJuYWwgZGlyZWN0b3J5 CmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJy b3dzZXIvZWZsL21haW4uYwppbmRleCA1NmZjZjQ3MDdiYzJlMDVhNzc5YjI1NzQwMGE4N2U1MjEw M2VjZWFjLi43OTNjNzVhNDI4YTJiN2M4OTU1N2EwNzQwNjc2MzkyMDllNWY0ZjgyIDEwMDY0NAot LS0gYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2Vy L2VmbC9tYWluLmMKQEAgLTQ3Niw4ICs0NzYsOCBAQCBvbl9rZXlfZG93bih2b2lkICp1c2VyX2Rh dGEsIEV2YXMgKmUsIEV2YXNfT2JqZWN0ICpld2tfdmlldywgdm9pZCAqZXZlbnRfaW5mbykKICAg ICB9IGVsc2UgaWYgKCFzdHJjbXAoZXYtPmtleSwgIkY1IikpIHsKICAgICAgICAgaW5mbygiUmVs b2FkIChGNSkgd2FzIHByZXNzZWQsIHJlbG9hZGluZy4iKTsKICAgICAgICAgZXdrX3ZpZXdfcmVs b2FkKGV3a192aWV3KTsKLSAgICB9IGVsc2UgaWYgKCFzdHJjbXAoZXYtPmtleSwgIkY2IikpIHsK LSAgICAgICAgaW5mbygiU3RvcCAoRjYpIHdhcyBwcmVzc2VkLCBzdG9wIGxvYWRpbmcuIik7Cisg ICAgfSBlbHNlIGlmICghc3RyY21wKGV2LT5rZXksICJGNiIpIHx8ICFzdHJjbXAoZXYtPmtleSwg IkVzY2FwZSIpKSB7CisgICAgICAgIGluZm8oIlN0b3AgKEY2IG9yIEVzY2FwZSkgd2FzIHByZXNz ZWQsIHN0b3AgbG9hZGluZy4iKTsKICAgICAgICAgZXdrX3ZpZXdfc3RvcChld2tfdmlldyk7CiAg ICAgfSBlbHNlIGlmICghc3RyY21wKGV2LT5rZXksICJGNyIpKSB7CiAgICAgICAgIEV3a19QYWdp bmF0aW9uX01vZGUgbW9kZSA9ICBld2tfdmlld19wYWdpbmF0aW9uX21vZGVfZ2V0KGV3a192aWV3 KTsKQEAgLTEwNzQsNiArMTA3NCwxNSBAQCBvbl9yZWZyZXNoX2J1dHRvbl9jbGlja2VkKHZvaWQg KnVzZXJfZGF0YSwgRXZhc19PYmplY3QgKnJlZnJlc2hfYnV0dG9uLCB2b2lkICpldgogfQogCiBz dGF0aWMgdm9pZAorb25fc3RvcF9idXR0b25fY2xpY2tlZCh2b2lkICp1c2VyX2RhdGEsIEV2YXNf T2JqZWN0ICpzdG9wX2J1dHRvbiwgdm9pZCAqZXZlbnRfaW5mbykKK3sKKyAgICBCcm93c2VyX1dp bmRvdyAqd2luZG93ID0gKEJyb3dzZXJfV2luZG93ICopdXNlcl9kYXRhOworCisgICAgaW5mbygi U3RvcCB3YXMgUHJlc3NlZC4gQWJvcnRpbmcgbG9hZC4uLiIpOworICAgIGV3a192aWV3X3N0b3Ao d2luZG93LT5ld2tfdmlldyk7Cit9CisKK3N0YXRpYyB2b2lkCiBxdWl0X2V2ZW50X2xvb3Aodm9p ZCAqdXNlcl9kYXRhLCBFdmFzX09iamVjdCAqb2JqLCB2b2lkICpldmVudF9pbmZvKQogewogICAg IGVjb3JlX21haW5fbG9vcF9xdWl0KCk7CkBAIC0xODQxLDYgKzE4NTAsMTQgQEAgc3RhdGljIEJy b3dzZXJfV2luZG93ICp3aW5kb3dfY3JlYXRlKEV2YXNfT2JqZWN0ICpvcGVuZXIsIGludCB3aWR0 aCwgaW50IGhlaWdodCkKICAgICBlbG1fYm94X3BhY2tfZW5kKGhvcml6b250YWxfbGF5b3V0LCBy ZWZyZXNoX2J1dHRvbik7CiAgICAgZXZhc19vYmplY3Rfc2hvdyhyZWZyZXNoX2J1dHRvbik7CiAK KyAgICAvKiBDcmVhdGUgU3RvcCBidXR0b24gKi8KKyAgICBFdmFzX09iamVjdCAqc3RvcF9idXR0 b24gPSBjcmVhdGVfdG9vbGJhcl9idXR0b24od2luZG93LT5lbG1fd2luZG93LCAiY2xvc2UiKTsK KyAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQoc3RvcF9idXR0b24sICJjbGlja2Vk Iiwgb25fc3RvcF9idXR0b25fY2xpY2tlZCwgd2luZG93KTsKKyAgICBldmFzX29iamVjdF9zaXpl X2hpbnRfd2VpZ2h0X3NldChzdG9wX2J1dHRvbiwgMC4wLCBFVkFTX0hJTlRfRVhQQU5EKTsKKyAg ICBldmFzX29iamVjdF9zaXplX2hpbnRfYWxpZ25fc2V0KHN0b3BfYnV0dG9uLCAxLjAsIDAuNSk7 CisgICAgZWxtX2JveF9wYWNrX2VuZChob3Jpem9udGFsX2xheW91dCwgc3RvcF9idXR0b24pOwor ICAgIGV2YXNfb2JqZWN0X3Nob3coc3RvcF9idXR0b24pOworCiAgICAgLyogQ3JlYXRlIEhvbWUg YnV0dG9uICovCiAgICAgRXZhc19PYmplY3QgKmhvbWVfYnV0dG9uID0gY3JlYXRlX3Rvb2xiYXJf YnV0dG9uKHdpbmRvdy0+ZWxtX3dpbmRvdywgImhvbWUiKTsKICAgICBldmFzX29iamVjdF9zbWFy dF9jYWxsYmFja19hZGQoaG9tZV9idXR0b24sICJjbGlja2VkIiwgb25faG9tZV9idXR0b25fY2xp Y2tlZCwgd2luZG93KTsK