136119 2014-08-20 14:04:58 -0700 [Mac] WebKit1 plug-in test failures in production builds after r172595 2014-08-20 14:43:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrowe mrowe commit-queue oldest_to_newest 1030391 0 mrowe 2014-08-20 14:04:58 -0700 WebKit1 Plug-in tests have been failing in production builds since r172595. This is because the script that adds the symlinks from the top level of WebKitLegacy.framework to the Versions/Current directory bails out in production builds. The script also uses the wrong paths by virtue of using CONFIGURATION_BUILD_DIR when it should be using TARGET_BUILD_DIR. 1030393 1 236896 mrowe 2014-08-20 14:09:03 -0700 Created attachment 236896 Patch 1030397 2 236896 commit-queue 2014-08-20 14:43:48 -0700 Comment on attachment 236896 Patch Clearing flags on attachment: 236896 Committed r172812: <http://trac.webkit.org/changeset/172812> 1030398 3 commit-queue 2014-08-20 14:43:50 -0700 All reviewed patches have been landed. Closing bug. 236896 2014-08-20 14:09:03 -0700 2014-08-20 14:43:48 -0700 Patch bug-136119-20140820140854.patch text/plain 4427 mrowe U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU3YTdiZjA3M2M1NjY0NjU2 MTYzN2Y4ZGM1MGFlZDU2Yzc0NDY4M2UuLjY4OWU1ZDhjZDMzOWVhMjUxOTJmNjZjNWFjNGU2ZTYz NWJkOTVlODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMDgtMjAgIE1hcmsgUm93 ZSAgPG1yb3dlQGFwcGxlLmNvbT4KKworICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM2 MTE5PiBXZWJLaXQxIHBsdWctaW4gdGVzdCBmYWlsdXJlcyBpbiBwcm9kdWN0aW9uIGJ1aWxkcyBh ZnRlciByMTcyNTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBXZWJLaXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvajogQWRkIHRoZSBzeW1saW5r cyBhdCB0aGUgdG9wIGxldmVsIG9mIFdlYktpdExlZ2FjeS5mcmFtZXdvcmsKKyAgICAgICAgZXZl biBpbiBQcm9kdWN0aW9uIGJ1aWxkcy4gQWRkIHRoZSBzeW1saW5rcyBpbiB0aGUgcmlnaHQgbG9j YXRpb25zIHRvby4KKwogMjAxNC0wOC0xNSAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+ CiAKICAgICAgICAgW0NvY29hXSBBZGQgbWlncmF0ZS1oZWFkZXJzLnNoIGFuZCBwb3N0cHJvY2Vz cy1oZWFkZXJzLnNoIHRvIFdlYktpdC54Y29kZXByb2oKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvV2ViS2l0Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2ogYi9Tb3VyY2UvV2ViS2l0L1dlYktp dC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IGQ0MjFlOTZiYzdkMmQxYmU5ZGMxMmNk ZDY4NTQ3NGIyZjJkNzU5NTEuLmQ5MDhjMWE4YWE5N2Y1NDM0MWNlM2JmNjZlMDAwNDFkNWU2ZDAz YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViS2l0Lnhjb2RlcHJvai9wcm9qZWN0LnBi eHByb2oKKysrIGIvU291cmNlL1dlYktpdC9XZWJLaXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJv agpAQCAtMjAxMSwxMSArMjAxMSwxMSBAQAogCQkJKTsKIAkJCW5hbWUgPSAiU3ltbGluayBXZWJL aXRQbHVnaW5Ib3N0IjsKIAkJCW91dHB1dFBhdGhzID0gKAotCQkJCSIkKENPTkZJR1VSQVRJT05f QlVJTERfRElSKS9XZWJLaXRMZWdhY3kuZnJhbWV3b3JrL1ZlcnNpb25zL0EvV2ViS2l0UGx1Z2lu SG9zdC5hcHAiLAorCQkJCSIkKFRBUkdFVF9CVUlMRF9ESVIpL1dlYktpdExlZ2FjeS5mcmFtZXdv cmsvVmVyc2lvbnMvQS9XZWJLaXRQbHVnaW5Ib3N0LmFwcCIsCiAJCQkpOwogCQkJcnVuT25seUZv ckRlcGxveW1lbnRQb3N0cHJvY2Vzc2luZyA9IDA7CiAJCQlzaGVsbFBhdGggPSAvYmluL3NoOwot CQkJc2hlbGxTY3JpcHQgPSAiaWYgW1sgJHtQTEFURk9STV9OQU1FfSA9PSBcImlwaG9uZW9zXCIg fHwgJHtQTEFURk9STV9OQU1FfSA9PSBcImlwaG9uZXNpbXVsYXRvclwiIHx8ICR7QUNUSU9OfSAh PSBcImJ1aWxkXCIgXV07IHRoZW5cbiAgICBleGl0IDBcbmZpXG5cbiMgUHJpb3IgdG8gcjE3MjU5 NSwgV2ViS2l0UGx1Z2luSG9zdC5hcHAgbGl2ZWQgYXQgdGhlIHRvcCBsZXZlbCBvZiB0aGUgZnJh bWV3b3JrLiBSZXBsYWNlIGFueSBzdGFsZSBjb3B5IHdpdGggYSBzeW1saW5rIHRvIHRoZSBuZXcg bG9jYXRpb24gYXQgVmVyc2lvbnMvQ3VycmVudC5cbnJtIC1yZiBcIiR7Q09ORklHVVJBVElPTl9C VUlMRF9ESVJ9L1dlYktpdExlZ2FjeS5mcmFtZXdvcmsvV2ViS2l0UGx1Z2luSG9zdC5hcHBcIlxu bG4gLXMgVmVyc2lvbnMvQ3VycmVudC9XZWJLaXRQbHVnaW5Ib3N0LmFwcCBcIiR7Q09ORklHVVJB VElPTl9CVUlMRF9ESVJ9L1dlYktpdExlZ2FjeS5mcmFtZXdvcmsvV2ViS2l0UGx1Z2luSG9zdC5h cHBcIlxuXG5pZiBbWyBcIiR7Q09ORklHVVJBVElPTn1cIiAhPSBcIlByb2R1Y3Rpb25cIiBdXTsg dGhlblxuICAgICMgRklYTUU6IFRoaXMgc2hvdWxkIGJlIHJlbW92ZWQgb25jZSBmYXVsdHkgbGlu a3MgaGF2ZSBiZWVuIHJlbW92ZWQgb24gdGhlIGJvdHMuXG4gICAgaWYgW1sgLUwgXCIke0NPTkZJ R1VSQVRJT05fQlVJTERfRElSfS9XZWJLaXRMZWdhY3kuZnJhbWV3b3JrL1ZlcnNpb25zL0EvV2Vi S2l0UGx1Z2luSG9zdC5hcHBcIiBdXTsgdGhlblxuICAgICAgICBybSBcIiR7Q09ORklHVVJBVElP Tl9CVUlMRF9ESVJ9L1dlYktpdExlZ2FjeS5mcmFtZXdvcmsvVmVyc2lvbnMvQS9XZWJLaXRQbHVn aW5Ib3N0LmFwcFwiXG4gICAgZmlcblxuICAgIGlmIFtbIC1lIFwiL1N5c3RlbS9MaWJyYXJ5L0Zy YW1ld29ya3MvV2ViS2l0LmZyYW1ld29yay9XZWJLaXRQbHVnaW5Ib3N0LmFwcFwiIF1dOyB0aGVu XG4gICAgICAgIGxuIC1zIC9TeXN0ZW0vTGlicmFyeS9GcmFtZXdvcmtzL1dlYktpdC5mcmFtZXdv cmsvV2ViS2l0UGx1Z2luSG9zdC5hcHAgXCIke0NPTkZJR1VSQVRJT05fQlVJTERfRElSfS9XZWJL aXRMZWdhY3kuZnJhbWV3b3JrL1ZlcnNpb25zL0EvV2ViS2l0UGx1Z2luSG9zdC5hcHBcIlxuICAg IGVsc2VcbiAgICAgICAgbG4gLXMgL1N5c3RlbS9MaWJyYXJ5L0ZyYW1ld29ya3MvV2ViS2l0LmZy YW1ld29yay9GcmFtZXdvcmtzL1dlYktpdExlZ2FjeS5mcmFtZXdvcmsvVmVyc2lvbnMvQS9XZWJL aXRQbHVnaW5Ib3N0LmFwcCBcIiR7Q09ORklHVVJBVElPTl9CVUlMRF9ESVJ9L1dlYktpdExlZ2Fj eS5mcmFtZXdvcmsvVmVyc2lvbnMvQS9XZWJLaXRQbHVnaW5Ib3N0LmFwcFwiXG4gICAgZmlcbmZp XG4iOworCQkJc2hlbGxTY3JpcHQgPSAiaWYgW1sgJHtQTEFURk9STV9OQU1FfSA9PSBcImlwaG9u ZW9zXCIgfHwgJHtQTEFURk9STV9OQU1FfSA9PSBcImlwaG9uZXNpbXVsYXRvclwiIF1dOyB0aGVu XG4gICAgZXhpdCAwXG5maVxuXG4jIFByaW9yIHRvIHIxNzI1OTUsIFdlYktpdFBsdWdpbkhvc3Qu YXBwIGFuZCBXZWJLaXRQbHVnaW5BZ2VudCBsaXZlZCBhdCB0aGUgdG9wIGxldmVsIG9mIHRoZSBm cmFtZXdvcmsuIFJlcGxhY2UgYW55IHN0YWxlIGNvcGllcyB3aXRoIHN5bWxpbmtzIHRvIHRoZSBu ZXcgbG9jYXRpb24gYXQgVmVyc2lvbnMvQ3VycmVudC5cbnJtIC1yZiBcIiR7VEFSR0VUX0JVSUxE X0RJUn0vV2ViS2l0TGVnYWN5LmZyYW1ld29yay9XZWJLaXRQbHVnaW5Ib3N0LmFwcFwiIFwiJHtU QVJHRVRfQlVJTERfRElSfS9XZWJLaXRMZWdhY3kuZnJhbWV3b3JrL1dlYktpdFBsdWdpbkFnZW50 XCJcbmxuIC1zIFZlcnNpb25zL0N1cnJlbnQvV2ViS2l0UGx1Z2luSG9zdC5hcHAgXCIke1RBUkdF VF9CVUlMRF9ESVJ9L1dlYktpdExlZ2FjeS5mcmFtZXdvcmsvV2ViS2l0UGx1Z2luSG9zdC5hcHBc IlxubG4gLXMgVmVyc2lvbnMvQ3VycmVudC9XZWJLaXRQbHVnaW5BZ2VudCBcIiR7VEFSR0VUX0JV SUxEX0RJUn0vV2ViS2l0TGVnYWN5LmZyYW1ld29yay9XZWJLaXRQbHVnaW5BZ2VudFwiXG5cbmlm IFtbIFwiJHtDT05GSUdVUkFUSU9OfVwiICE9IFwiUHJvZHVjdGlvblwiICYmICR7QUNUSU9OfSA9 PSBcImJ1aWxkXCIgXV07IHRoZW5cbiAgICAjIEZJWE1FOiBUaGlzIHNob3VsZCBiZSByZW1vdmVk IG9uY2UgZmF1bHR5IGxpbmtzIGhhdmUgYmVlbiByZW1vdmVkIG9uIHRoZSBib3RzLlxuICAgIGlm IFtbIC1MIFwiJHtUQVJHRVRfQlVJTERfRElSfS9XZWJLaXRMZWdhY3kuZnJhbWV3b3JrL1ZlcnNp b25zL0EvV2ViS2l0UGx1Z2luSG9zdC5hcHBcIiBdXTsgdGhlblxuICAgICAgICBybSBcIiR7VEFS R0VUX0JVSUxEX0RJUn0vV2ViS2l0TGVnYWN5LmZyYW1ld29yay9WZXJzaW9ucy9BL1dlYktpdFBs dWdpbkhvc3QuYXBwXCJcbiAgICBmaVxuXG4gICAgaWYgW1sgLWUgXCIvU3lzdGVtL0xpYnJhcnkv RnJhbWV3b3Jrcy9XZWJLaXQuZnJhbWV3b3JrL1dlYktpdFBsdWdpbkhvc3QuYXBwXCIgXV07IHRo ZW5cbiAgICAgICAgbG4gLXMgL1N5c3RlbS9MaWJyYXJ5L0ZyYW1ld29ya3MvV2ViS2l0LmZyYW1l d29yay9XZWJLaXRQbHVnaW5Ib3N0LmFwcCBcIiR7VEFSR0VUX0JVSUxEX0RJUn0vV2ViS2l0TGVn YWN5LmZyYW1ld29yay9WZXJzaW9ucy9BL1dlYktpdFBsdWdpbkhvc3QuYXBwXCJcbiAgICBlbHNl XG4gICAgICAgIGxuIC1zIC9TeXN0ZW0vTGlicmFyeS9GcmFtZXdvcmtzL1dlYktpdC5mcmFtZXdv cmsvRnJhbWV3b3Jrcy9XZWJLaXRMZWdhY3kuZnJhbWV3b3JrL1ZlcnNpb25zL0EvV2ViS2l0UGx1 Z2luSG9zdC5hcHAgXCIke1RBUkdFVF9CVUlMRF9ESVJ9L1dlYktpdExlZ2FjeS5mcmFtZXdvcmsv VmVyc2lvbnMvQS9XZWJLaXRQbHVnaW5Ib3N0LmFwcFwiXG4gICAgZmlcbmZpXG4iOwogCQl9Owog CQkxQzM5NURFMjBDNkJFOEUwMDAwRDFFNTIgLyogR2VuZXJhdGUgRXhwb3J0IEZpbGVzICovID0g ewogCQkJaXNhID0gUEJYU2hlbGxTY3JpcHRCdWlsZFBoYXNlOwo=