136116 2014-08-20 12:55:40 -0700 Cleanup MediaSession 2014-08-20 14:02:43 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson commit-queue glenn jer.noble philipj sergio oldest_to_newest 1030361 0 eric.carlson 2014-08-20 12:55:40 -0700 The MediaSessionManagerClient interface isn't used, remove it. 1030363 1 236892 eric.carlson 2014-08-20 13:01:11 -0700 Created attachment 236892 Proposed patch. 1030374 2 236892 bfulgham 2014-08-20 13:25:50 -0700 Comment on attachment 236892 Proposed patch. r=me. I love removing code! 1030388 3 236892 commit-queue 2014-08-20 14:02:39 -0700 Comment on attachment 236892 Proposed patch. Clearing flags on attachment: 236892 Committed r172809: <http://trac.webkit.org/changeset/172809> 1030389 4 commit-queue 2014-08-20 14:02:43 -0700 All reviewed patches have been landed. Closing bug. 236892 2014-08-20 13:01:11 -0700 2014-08-20 14:02:39 -0700 Proposed patch. patch_2.txt text/plain 6655 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MjgwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA4LTIwICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIENsZWFudXAgTWVkaWFT ZXNzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzYxMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBN ZWRpYVNlc3Npb25NYW5hZ2VyQ2xpZW50IGludGVyZmFjZSBpc24ndCB1c2VkLCByZW1vdmUgaXQu CisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBkb2Vzbid0IGNoYW5nZSBiZWhhdmlvci4KKwor ICAgICAgICAqIFdlYkNvcmUuZXhwLmluOgorICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL01lZGlh U2Vzc2lvbk1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTZXNzaW9uTWFuYWdl cjo6YWRkU2Vzc2lvbik6IAorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTZXNzaW9uTWFuYWdlcjo6 cmVtb3ZlU2Vzc2lvbik6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNlc3Npb25NYW5hZ2VyOjpz ZXNzaW9uV2lsbEJlZ2luUGxheWJhY2spOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTZXNzaW9u TWFuYWdlcjo6YWRkQ2xpZW50KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU2Vz c2lvbk1hbmFnZXI6OnJlbW92ZUNsaWVudCk6IERlbGV0ZWQuCisgICAgICAgICogcGxhdGZvcm0v YXVkaW8vTWVkaWFTZXNzaW9uTWFuYWdlci5oOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTZXNz aW9uTWFuYWdlckNsaWVudDo6fk1lZGlhU2Vzc2lvbk1hbmFnZXJDbGllbnQpOiBEZWxldGVkLgor ICAgICAgICAoV2ViQ29yZTo6TWVkaWFTZXNzaW9uTWFuYWdlckNsaWVudDo6TWVkaWFTZXNzaW9u TWFuYWdlckNsaWVudCk6IERlbGV0ZWQuCisKIDIwMTQtMDgtMjAgIENvbW1pdCBRdWV1ZSAgPGNv bW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0 IHIxNzI3OTguCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgkocmV2aXNpb24gMTcyNjkwKQorKysg U291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHdvcmtpbmcgY29weSkKQEAgLTgyMCw3ICs4 MjAsNiBAQCBfX1pON1dlYkNvcmUxOUxheWVyRmx1c2hTY2hlZHVsZXJEMUV2CiBfX1pON1dlYkNv cmUxOUxheWVyRmx1c2hTY2hlZHVsZXJEMkV2CiBfX1pON1dlYkNvcmUxOUxheWVyUmVwcmVzZW50 YXRpb24xOXJldGFpblBsYXRmb3JtTGF5ZXJFUDdDQUxheWVyCiBfX1pON1dlYkNvcmUxOUxheWVy UmVwcmVzZW50YXRpb24yMHJlbGVhc2VQbGF0Zm9ybUxheWVyRVA3Q0FMYXllcgotX19aTjdXZWJD b3JlMTlNZWRpYVNlc3Npb25NYW5hZ2VyMTJyZW1vdmVDbGllbnRFUE5TXzI1TWVkaWFTZXNzaW9u TWFuYWdlckNsaWVudEUKIF9fWk43V2ViQ29yZTE5TWVkaWFTZXNzaW9uTWFuYWdlcjEycmVzdHJp Y3Rpb25zRU5TXzEyTWVkaWFTZXNzaW9uOU1lZGlhVHlwZUUKIF9fWk43V2ViQ29yZTE5TWVkaWFT ZXNzaW9uTWFuYWdlcjEzc2hhcmVkTWFuYWdlckV2CiBfX1pON1dlYkNvcmUxOU1lZGlhU2Vzc2lv bk1hbmFnZXIxNGFkZFJlc3RyaWN0aW9uRU5TXzEyTWVkaWFTZXNzaW9uOU1lZGlhVHlwZUVqCkBA IC04MjgsNyArODI3LDYgQEAgX19aTjdXZWJDb3JlMTlNZWRpYVNlc3Npb25NYW5hZ2VyMTVlbmRJ bgogX19aTjdXZWJDb3JlMTlNZWRpYVNlc3Npb25NYW5hZ2VyMTdiZWdpbkludGVycnVwdGlvbkVO U18xMk1lZGlhU2Vzc2lvbjE2SW50ZXJydXB0aW9uVHlwZUUKIF9fWk43V2ViQ29yZTE5TWVkaWFT ZXNzaW9uTWFuYWdlcjE3cmVtb3ZlUmVzdHJpY3Rpb25FTlNfMTJNZWRpYVNlc3Npb245TWVkaWFU eXBlRWoKIF9fWk43V2ViQ29yZTE5TWVkaWFTZXNzaW9uTWFuYWdlcjMwZGlkUmVjZWl2ZVJlbW90 ZUNvbnRyb2xDb21tYW5kRU5TXzEyTWVkaWFTZXNzaW9uMjRSZW1vdGVDb250cm9sQ29tbWFuZFR5 cGVFCi1fX1pON1dlYkNvcmUxOU1lZGlhU2Vzc2lvbk1hbmFnZXI5YWRkQ2xpZW50RVBOU18yNU1l ZGlhU2Vzc2lvbk1hbmFnZXJDbGllbnRFCiBfX1pON1dlYkNvcmUxOVByb3RlY3Rpb25TcGFjZUJh c2VDMkVSS04zV1RGNlN0cmluZ0VpTlNfMjVQcm90ZWN0aW9uU3BhY2VTZXJ2ZXJUeXBlRVM0X05T XzM1UHJvdGVjdGlvblNwYWNlQXV0aGVudGljYXRpb25TY2hlbWVFCiBfX1pON1dlYkNvcmUxOVBy b3RlY3Rpb25TcGFjZUJhc2VDMkV2CiBfX1pON1dlYkNvcmUxOVJlc291cmNlUmVxdWVzdEJhc2Ux MXNldEhUVFBCb2R5RU4zV1RGMTBQYXNzUmVmUHRySU5TXzhGb3JtRGF0YUVFRQpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vTWVkaWFTZXNzaW9uTWFuYWdlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vTWVkaWFTZXNzaW9uTWFuYWdl ci5jcHAJKHJldmlzaW9uIDE3MjY5MCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlv L01lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjcsMTIgKzEyNyw2 IEBAIHZvaWQgTWVkaWFTZXNzaW9uTWFuYWdlcjo6YWRkU2Vzc2lvbihNZWQKICAgICAgICAgbV9h dWRpb0hhcmR3YXJlTGlzdGVuZXIgPSBBdWRpb0hhcmR3YXJlTGlzdGVuZXI6OmNyZWF0ZSgqdGhp cyk7CiAKICAgICB1cGRhdGVTZXNzaW9uU3RhdGUoKTsKLQotICAgIGlmIChtX2NsaWVudHMuaXNF bXB0eSgpIHx8ICEoc2Vzc2lvbi5tZWRpYVR5cGUoKSA9PSBNZWRpYVNlc3Npb246OlZpZGVvIHx8 IHNlc3Npb24ubWVkaWFUeXBlKCkgPT0gTWVkaWFTZXNzaW9uOjpBdWRpbykpCi0gICAgICAgIHJl dHVybjsKLQotICAgIGZvciAoYXV0byYgY2xpZW50IDogbV9jbGllbnRzKQotICAgICAgICBjbGll bnQtPnN0YXJ0TGlzdGVuaW5nRm9yUmVtb3RlQ29udHJvbENvbW1hbmRzKCk7CiB9CiAKIHZvaWQg TWVkaWFTZXNzaW9uTWFuYWdlcjo6cmVtb3ZlU2Vzc2lvbihNZWRpYVNlc3Npb24mIHNlc3Npb24p CkBAIC0xNTIsMTIgKzE0Niw2IEBAIHZvaWQgTWVkaWFTZXNzaW9uTWFuYWdlcjo6cmVtb3ZlU2Vz c2lvbigKICAgICB9CiAKICAgICB1cGRhdGVTZXNzaW9uU3RhdGUoKTsKLQotICAgIGlmIChtX2Ns aWVudHMuaXNFbXB0eSgpIHx8ICEoc2Vzc2lvbi5tZWRpYVR5cGUoKSA9PSBNZWRpYVNlc3Npb246 OlZpZGVvIHx8IHNlc3Npb24ubWVkaWFUeXBlKCkgPT0gTWVkaWFTZXNzaW9uOjpBdWRpbykpCi0g ICAgICAgIHJldHVybjsKLQotICAgIGZvciAoYXV0byYgY2xpZW50IDogbV9jbGllbnRzKQotICAg ICAgICBjbGllbnQtPnN0YXJ0TGlzdGVuaW5nRm9yUmVtb3RlQ29udHJvbENvbW1hbmRzKCk7CiB9 CiAKIHZvaWQgTWVkaWFTZXNzaW9uTWFuYWdlcjo6YWRkUmVzdHJpY3Rpb24oTWVkaWFTZXNzaW9u OjpNZWRpYVR5cGUgdHlwZSwgU2Vzc2lvblJlc3RyaWN0aW9ucyByZXN0cmljdGlvbikKQEAgLTE4 NCwxMSArMTcyLDYgQEAgdm9pZCBNZWRpYVNlc3Npb25NYW5hZ2VyOjpzZXNzaW9uV2lsbEJlZwog ICAgIAogICAgIHNldEN1cnJlbnRTZXNzaW9uKHNlc3Npb24pOwogCi0gICAgaWYgKCFtX2NsaWVu dHMuaXNFbXB0eSgpICYmIChzZXNzaW9uLm1lZGlhVHlwZSgpID09IE1lZGlhU2Vzc2lvbjo6Vmlk ZW8gfHwgc2Vzc2lvbi5tZWRpYVR5cGUoKSA9PSBNZWRpYVNlc3Npb246OkF1ZGlvKSkgewotICAg ICAgICBmb3IgKGF1dG8mIGNsaWVudCA6IG1fY2xpZW50cykKLSAgICAgICAgICAgIGNsaWVudC0+ ZGlkQmVnaW5QbGF5YmFjaygpOwotICAgIH0KLQogICAgIE1lZGlhU2Vzc2lvbjo6TWVkaWFUeXBl IHNlc3Npb25UeXBlID0gc2Vzc2lvbi5tZWRpYVR5cGUoKTsKICAgICBTZXNzaW9uUmVzdHJpY3Rp b25zIHJlc3RyaWN0aW9ucyA9IG1fcmVzdHJpY3Rpb25zW3Nlc3Npb25UeXBlXTsKICAgICBpZiAo IXJlc3RyaWN0aW9ucyAmIENvbmN1cnJlbnRQbGF5YmFja05vdFBlcm1pdHRlZCkKQEAgLTMxNiwx OCArMjk5LDYgQEAgdm9pZCBNZWRpYVNlc3Npb25NYW5hZ2VyOjpkaWRSZWNlaXZlUmVtbwogICAg IGFjdGl2ZVNlc3Npb24tPmRpZFJlY2VpdmVSZW1vdGVDb250cm9sQ29tbWFuZChjb21tYW5kKTsK IH0KIAotdm9pZCBNZWRpYVNlc3Npb25NYW5hZ2VyOjphZGRDbGllbnQoTWVkaWFTZXNzaW9uTWFu YWdlckNsaWVudCogY2xpZW50KQotewotICAgIEFTU0VSVCghbV9jbGllbnRzLmNvbnRhaW5zKGNs aWVudCkpOwotICAgIG1fY2xpZW50cy5hcHBlbmQoY2xpZW50KTsKLX0KLQotdm9pZCBNZWRpYVNl c3Npb25NYW5hZ2VyOjpyZW1vdmVDbGllbnQoTWVkaWFTZXNzaW9uTWFuYWdlckNsaWVudCogY2xp ZW50KQotewotICAgIEFTU0VSVChtX2NsaWVudHMuY29udGFpbnMoY2xpZW50KSk7Ci0gICAgbV9j bGllbnRzLnJlbW92ZShtX2NsaWVudHMuZmluZChjbGllbnQpKTsKLX0KLQogdm9pZCBNZWRpYVNl c3Npb25NYW5hZ2VyOjpzeXN0ZW1XaWxsU2xlZXAoKQogewogICAgIGlmIChtX2ludGVycnVwdGVk KQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vTWVkaWFTZXNzaW9uTWFuYWdl ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL01lZGlhU2Vz c2lvbk1hbmFnZXIuaAkocmV2aXNpb24gMTcyNjkwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vYXVkaW8vTWVkaWFTZXNzaW9uTWFuYWdlci5oCSh3b3JraW5nIGNvcHkpCkBAIC00MCwxOSAr NDAsNiBAQCBjbGFzcyBIVE1MTWVkaWFFbGVtZW50OwogY2xhc3MgTWVkaWFTZXNzaW9uOwogY2xh c3MgUmVtb3RlQ29tbWFuZExpc3RlbmVyOwogCi1jbGFzcyBNZWRpYVNlc3Npb25NYW5hZ2VyQ2xp ZW50IHsKLXB1YmxpYzoKLSAgICB2aXJ0dWFsIH5NZWRpYVNlc3Npb25NYW5hZ2VyQ2xpZW50KCkg eyB9Ci0KLSAgICB2aXJ0dWFsIGJvb2wgaXNMaXN0ZW5pbmdGb3JSZW1vdGVDb250cm9sQ29tbWFu ZHMoKSA9IDA7Ci0gICAgdmlydHVhbCB2b2lkIHN0YXJ0TGlzdGVuaW5nRm9yUmVtb3RlQ29udHJv bENvbW1hbmRzKCkgPSAwOwotICAgIHZpcnR1YWwgdm9pZCBzdG9wTGlzdGVuaW5nRm9yUmVtb3Rl Q29udHJvbENvbW1hbmRzKCkgPSAwOwotICAgIHZpcnR1YWwgdm9pZCBkaWRCZWdpblBsYXliYWNr KCkgPSAwOwotCi1wcm90ZWN0ZWQ6Ci0gICAgTWVkaWFTZXNzaW9uTWFuYWdlckNsaWVudCgpIHsg fQotfTsKLQogY2xhc3MgTWVkaWFTZXNzaW9uTWFuYWdlciA6IHByaXZhdGUgUmVtb3RlQ29tbWFu ZExpc3RlbmVyQ2xpZW50LCBwcml2YXRlIFN5c3RlbVNsZWVwTGlzdGVuZXI6OkNsaWVudCwgcHJp dmF0ZSBBdWRpb0hhcmR3YXJlTGlzdGVuZXI6OkNsaWVudCB7CiBwdWJsaWM6CiAgICAgc3RhdGlj IE1lZGlhU2Vzc2lvbk1hbmFnZXImIHNoYXJlZE1hbmFnZXIoKTsKQEAgLTk1LDkgKzgyLDYgQEAg cHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzdG9wTW9uaXRvcmluZ0FpclBsYXlSb3V0ZXMoKSB7 IH0KICNlbmRpZgogCi0gICAgdm9pZCBhZGRDbGllbnQoTWVkaWFTZXNzaW9uTWFuYWdlckNsaWVu dCopOwotICAgIHZvaWQgcmVtb3ZlQ2xpZW50KE1lZGlhU2Vzc2lvbk1hbmFnZXJDbGllbnQqKTsK LQogcHJvdGVjdGVkOgogICAgIGZyaWVuZCBjbGFzcyBNZWRpYVNlc3Npb247CiAgICAgZXhwbGlj aXQgTWVkaWFTZXNzaW9uTWFuYWdlcigpOwpAQCAtMTEzLDcgKzk3LDYgQEAgcHJpdmF0ZToKIAog ICAgIHZvaWQgdXBkYXRlU2Vzc2lvblN0YXRlKCk7CiAKLQogICAgIC8vIFJlbW90ZUNvbW1hbmRM aXN0ZW5lckNsaWVudAogICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlUmVtb3RlQ29udHJvbENv bW1hbmQoTWVkaWFTZXNzaW9uOjpSZW1vdGVDb250cm9sQ29tbWFuZFR5cGUpIG92ZXJyaWRlOwog CkBAIC0xMjksNyArMTEyLDYgQEAgcHJpdmF0ZToKICAgICBTZXNzaW9uUmVzdHJpY3Rpb25zIG1f cmVzdHJpY3Rpb25zW01lZGlhU2Vzc2lvbjo6V2ViQXVkaW8gKyAxXTsKIAogICAgIFZlY3RvcjxN ZWRpYVNlc3Npb24qPiBtX3Nlc3Npb25zOwotICAgIFZlY3RvcjxNZWRpYVNlc3Npb25NYW5hZ2Vy Q2xpZW50Kj4gbV9jbGllbnRzOwogICAgIHN0ZDo6dW5pcXVlX3B0cjxSZW1vdGVDb21tYW5kTGlz dGVuZXI+IG1fcmVtb3RlQ29tbWFuZExpc3RlbmVyOwogICAgIHN0ZDo6dW5pcXVlX3B0cjxTeXN0 ZW1TbGVlcExpc3RlbmVyPiBtX3N5c3RlbVNsZWVwTGlzdGVuZXI7CiAgICAgUmVmUHRyPEF1ZGlv SGFyZHdhcmVMaXN0ZW5lcj4gbV9hdWRpb0hhcmR3YXJlTGlzdGVuZXI7Cg==