136114 2014-08-20 11:50:45 -0700 [MSE] add additional SourceBuffer and MediaSource logging 2014-08-21 00:41:10 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson calvaris commit-queue glenn jer.noble ltilve philipj sergio oldest_to_newest 1030342 0 eric.carlson 2014-08-20 11:50:45 -0700 Add a bit of extra logging. 1030347 1 236888 eric.carlson 2014-08-20 11:59:17 -0700 Created attachment 236888 Proposed patch. 1030353 2 236888 bfulgham 2014-08-20 12:31:24 -0700 Comment on attachment 236888 Proposed patch. r=me. 1030370 3 236888 commit-queue 2014-08-20 13:20:04 -0700 Comment on attachment 236888 Proposed patch. Clearing flags on attachment: 236888 Committed r172806: <http://trac.webkit.org/changeset/172806> 1030371 4 commit-queue 2014-08-20 13:20:07 -0700 All reviewed patches have been landed. Closing bug. 236888 2014-08-20 11:59:17 -0700 2014-08-20 13:20:04 -0700 Proposed patch. patch_1.txt text/plain 5604 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MjgwMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA4LTIwICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNU0VdIGFkZCBhZGRp dGlvbmFsIFNvdXJjZUJ1ZmZlciBhbmQgTWVkaWFTb3VyY2UgbG9nZ2luZworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2MTE0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGlzIGFk ZHMgZGVidWctb25seSBsb2dnaW5nLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXNvdXJjZS9N ZWRpYVNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNvdXJjZTo6c2V0UmVhZHlT dGF0ZSk6IEZpeCBhIHR5cG8uCisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNvdXJjZTo6c3RyZWFt RW5kZWRXaXRoRXJyb3IpOiBMb2cgdGhlIGVycm9yLgorCisgICAgICAgICogTW9kdWxlcy9tZWRp YXNvdXJjZS9Tb3VyY2VCdWZmZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U291cmNlQnVmZmVy Ojpzb3VyY2VCdWZmZXJQcml2YXRlQXBwZW5kQ29tcGxldGUpOiBMb2cgd2hlbiBwYXJzaW5nIGZh aWxzLgorICAgICAgICAoV2ViQ29yZTo6U291cmNlQnVmZmVyOjpzb3VyY2VCdWZmZXJQcml2YXRl RGlkUmVjZWl2ZVJlbmRlcmluZ0Vycm9yKTogTG9nIGVycm9yLgorICAgICAgICAoV2ViQ29yZTo6 U291cmNlQnVmZmVyOjpzb3VyY2VCdWZmZXJQcml2YXRlRGlkRW5kU3RyZWFtKTogRGl0dG8uCisg ICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXI6OnNvdXJjZUJ1ZmZlclByaXZhdGVEaWRSZWNl aXZlSW5pdGlhbGl6YXRpb25TZWdtZW50KTogTG9nLgorICAgICAgICAoV2ViQ29yZTo6U291cmNl QnVmZmVyOjpzb3VyY2VCdWZmZXJQcml2YXRlRGlkUmVjZWl2ZVNhbXBsZSk6IExvZyBlcnJvci4K KwogMjAxNC0wOC0yMCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE3Mjc5OC4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2UuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2UuY3BwCShyZXZp c2lvbiAxNzI2OTApCisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNlL01lZGlh U291cmNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzg1LDcgKzM4NSw3IEBAIHZvaWQgTWVkaWFT b3VyY2U6OnNldFJlYWR5U3RhdGUoY29uc3QgQXQKICAgICBBU1NFUlQoc3RhdGUgPT0gb3Blbktl eXdvcmQoKSB8fCBzdGF0ZSA9PSBjbG9zZWRLZXl3b3JkKCkgfHwgc3RhdGUgPT0gZW5kZWRLZXl3 b3JkKCkpOwogCiAgICAgQXRvbWljU3RyaW5nIG9sZFN0YXRlID0gcmVhZHlTdGF0ZSgpOwotICAg IExPRyhNZWRpYVNvdXJjZSwgIk1lZGlhU291cmNlOjpzZXRSZWFkeVN0YXRlKCkgJXAgOiAlcyAt PiAlcyIsIHRoaXMsIG9sZFN0YXRlLnN0cmluZygpLmFzY2lpKCkuZGF0YSgpLCBzdGF0ZS5zdHJp bmcoKS5hc2NpaSgpLmRhdGEoKSk7CisgICAgTE9HKE1lZGlhU291cmNlLCAiTWVkaWFTb3VyY2U6 OnNldFJlYWR5U3RhdGUoJXApIDogJXMgLT4gJXMiLCB0aGlzLCBvbGRTdGF0ZS5zdHJpbmcoKS5h c2NpaSgpLmRhdGEoKSwgc3RhdGUuc3RyaW5nKCkuYXNjaWkoKS5kYXRhKCkpOwogCiAgICAgaWYg KHN0YXRlID09IGNsb3NlZEtleXdvcmQoKSkgewogICAgICAgICBtX3ByaXZhdGUuY2xlYXIoKTsK QEAgLTQzNyw2ICs0MzcsOCBAQCB2b2lkIE1lZGlhU291cmNlOjpzdHJlYW1FbmRlZFdpdGhFcnJv cihjCiAgICAgREVQUkVDQVRFRF9ERUZJTkVfU1RBVElDX0xPQ0FMKGNvbnN0IEF0b21pY1N0cmlu ZywgbmV0d29yaywgKCJuZXR3b3JrIiwgQXRvbWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJh bCkpOwogICAgIERFUFJFQ0FURURfREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBBdG9taWNTdHJp bmcsIGRlY29kZSwgKCJkZWNvZGUiLCBBdG9taWNTdHJpbmc6OkNvbnN0cnVjdEZyb21MaXRlcmFs KSk7CiAKKyAgICBMT0coTWVkaWFTb3VyY2UsICJNZWRpYVNvdXJjZTo6c3RyZWFtRW5kZWRXaXRo RXJyb3IoJXApIDogJXMiLCB0aGlzLCBlcnJvci5zdHJpbmcoKS5hc2NpaSgpLmRhdGEoKSk7CisK ICAgICAvLyAyLjQuNyBodHRwczovL2R2Y3MudzMub3JnL2hnL2h0bWwtbWVkaWEvcmF3LWZpbGUv dGlwL21lZGlhLXNvdXJjZS9tZWRpYS1zb3VyY2UuaHRtbCNlbmQtb2Ytc3RyZWFtLWFsZ29yaXRo bQogCiAgICAgLy8gMy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2Uv U291cmNlQnVmZmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhc291cmNlL1NvdXJjZUJ1ZmZlci5jcHAJKHJldmlzaW9uIDE3MjY5MCkKKysrIFNvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDg2LDYgKzQ4Niw3IEBAIHZvaWQgU291cmNlQnVmZmVyOjpzb3VyY2VCdWZmZXJQcml2 YXRlQXAKICAgICAvLyAyLiBJZiB0aGUgaW5wdXQgYnVmZmVyIGNvbnRhaW5zIGJ5dGVzIHRoYXQg dmlvbGF0ZSB0aGUgU291cmNlQnVmZmVyIGJ5dGUgc3RyZWFtIGZvcm1hdCBzcGVjaWZpY2F0aW9u LAogICAgIC8vIHRoZW4gcnVuIHRoZSBlbmQgb2Ygc3RyZWFtIGFsZ29yaXRobSB3aXRoIHRoZSBl cnJvciBwYXJhbWV0ZXIgc2V0IHRvICJkZWNvZGUiIGFuZCBhYm9ydCB0aGlzIGFsZ29yaXRobS4K ICAgICBpZiAocmVzdWx0ID09IFBhcnNpbmdGYWlsZWQpIHsKKyAgICAgICAgTE9HKE1lZGlhU291 cmNlLCAiU291cmNlQnVmZmVyOjpzb3VyY2VCdWZmZXJQcml2YXRlQXBwZW5kQ29tcGxldGUoJXAp IC0gcmVzdWx0ID0gUGFyc2luZ0ZhaWxlZCIsIHRoaXMpOwogICAgICAgICBtX3NvdXJjZS0+c3Ry ZWFtRW5kZWRXaXRoRXJyb3IoZGVjb2RlRXJyb3IoKSwgSWdub3JhYmxlRXhjZXB0aW9uQ29kZSgp KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KQEAgLTUzMSw4ICs1MzIsMTQgQEAgdm9pZCBTb3Vy Y2VCdWZmZXI6OnNvdXJjZUJ1ZmZlclByaXZhdGVBcAogICAgIExPRyhNZWRpYSwgIlNvdXJjZUJ1 ZmZlcjo6c291cmNlQnVmZmVyUHJpdmF0ZUFwcGVuZENvbXBsZXRlKCVwKSAtIGJ1ZmZlcmVkID0g JXMiLCB0aGlzLCB0b1N0cmluZyhtX2J1ZmZlcmVkLT5yYW5nZXMoKSkudXRmOCgpLmRhdGEoKSk7 CiB9CiAKLXZvaWQgU291cmNlQnVmZmVyOjpzb3VyY2VCdWZmZXJQcml2YXRlRGlkUmVjZWl2ZVJl bmRlcmluZ0Vycm9yKFNvdXJjZUJ1ZmZlclByaXZhdGUqLCBpbnQpCit2b2lkIFNvdXJjZUJ1ZmZl cjo6c291cmNlQnVmZmVyUHJpdmF0ZURpZFJlY2VpdmVSZW5kZXJpbmdFcnJvcihTb3VyY2VCdWZm ZXJQcml2YXRlKiwgaW50IGVycm9yKQogeworI2lmIExPR19ESVNBQkxFRAorICAgIFVOVVNFRF9Q QVJBTShlcnJvcikKKyNlbmRpZgorCisgICAgTE9HKE1lZGlhU291cmNlLCAiU291cmNlQnVmZmVy Ojpzb3VyY2VCdWZmZXJQcml2YXRlRGlkUmVjZWl2ZVJlbmRlcmluZ0Vycm9yKCVwKSAtIHJlc3Vs dCA9ICVpIiwgdGhpcywgZXJyb3IpOworCiAgICAgaWYgKCFpc1JlbW92ZWQoKSkKICAgICAgICAg bV9zb3VyY2UtPnN0cmVhbUVuZGVkV2l0aEVycm9yKGRlY29kZUVycm9yKCksIElnbm9yYWJsZUV4 Y2VwdGlvbkNvZGUoKSk7CiB9CkBAIC04NDUsNiArODUyLDggQEAgdm9pZCBTb3VyY2VCdWZmZXI6 OnNldEFjdGl2ZShib29sIGFjdGl2ZQogCiB2b2lkIFNvdXJjZUJ1ZmZlcjo6c291cmNlQnVmZmVy UHJpdmF0ZURpZEVuZFN0cmVhbShTb3VyY2VCdWZmZXJQcml2YXRlKiwgY29uc3QgV1RGOjpBdG9t aWNTdHJpbmcmIGVycm9yKQogeworICAgIExPRyhNZWRpYVNvdXJjZSwgIlNvdXJjZUJ1ZmZlcjo6 c291cmNlQnVmZmVyUHJpdmF0ZURpZEVuZFN0cmVhbSglcCkgLSByZXN1bHQgPSAlcyIsIHRoaXMs IFN0cmluZyhlcnJvcikudXRmOCgpLmRhdGEoKSk7CisKICAgICBpZiAoIWlzUmVtb3ZlZCgpKQog ICAgICAgICBtX3NvdXJjZS0+c3RyZWFtRW5kZWRXaXRoRXJyb3IoZXJyb3IsIElnbm9yYWJsZUV4 Y2VwdGlvbkNvZGUoKSk7CiB9CkBAIC04NTQsNiArODYzLDggQEAgdm9pZCBTb3VyY2VCdWZmZXI6 OnNvdXJjZUJ1ZmZlclByaXZhdGVEaQogICAgIGlmIChpc1JlbW92ZWQoKSkKICAgICAgICAgcmV0 dXJuOwogCisgICAgTE9HKE1lZGlhU291cmNlLCAiU291cmNlQnVmZmVyOjpzb3VyY2VCdWZmZXJQ cml2YXRlRGlkUmVjZWl2ZUluaXRpYWxpemF0aW9uU2VnbWVudCglcCkiLCB0aGlzKTsKKwogICAg IC8vIDMuNS43IEluaXRpYWxpemF0aW9uIFNlZ21lbnQgUmVjZWl2ZWQKICAgICAvLyBodHRwczov L2R2Y3MudzMub3JnL2hnL2h0bWwtbWVkaWEvcmF3LWZpbGUvZGVmYXVsdC9tZWRpYS1zb3VyY2Uv bWVkaWEtc291cmNlLmh0bWwjc291cmNlYnVmZmVyLWluaXQtc2VnbWVudC1yZWNlaXZlZAogICAg IC8vIDEuIFVwZGF0ZSB0aGUgZHVyYXRpb24gYXR0cmlidXRlIGlmIGl0IGN1cnJlbnRseSBlcXVh bHMgTmFOOgpAQCAtMTE4Nyw2ICsxMTk4LDkgQEAgdm9pZCBTb3VyY2VCdWZmZXI6OnNvdXJjZUJ1 ZmZlclByaXZhdGVEaQogICAgICAgICAgICAgLy8gYWJvcnQgdGhlc2Ugc3RlcHMuCiAgICAgICAg ICAgICBNZWRpYVRpbWUgcHJlc2VudGF0aW9uU3RhcnRUaW1lID0gTWVkaWFUaW1lOjp6ZXJvVGlt ZSgpOwogICAgICAgICAgICAgaWYgKHByZXNlbnRhdGlvblRpbWVzdGFtcCA8IHByZXNlbnRhdGlv blN0YXJ0VGltZSB8fCBkZWNvZGVUaW1lc3RhbXAgPCBwcmVzZW50YXRpb25TdGFydFRpbWUpIHsK KyNpZiAhTE9HX0RJU0FCTEVECisgICAgICAgICAgICAgICAgTE9HKE1lZGlhU291cmNlLCAiU291 cmNlQnVmZmVyOjpzb3VyY2VCdWZmZXJQcml2YXRlRGlkUmVjZWl2ZVNhbXBsZSglcCkgLSBmYWls aW5nIGJlY2F1c2UgJXMiLCB0aGlzLCBwcmVzZW50YXRpb25UaW1lc3RhbXAgPCBwcmVzZW50YXRp b25TdGFydFRpbWUgPyAicHJlc2VudGF0aW9uVGltZXN0YW1wIDwgcHJlc2VudGF0aW9uU3RhcnRU aW1lIiA6ICJkZWNvZGVUaW1lc3RhbXAgPCBwcmVzZW50YXRpb25TdGFydFRpbWUiKTsKKyNlbmRp ZgogICAgICAgICAgICAgICAgIG1fc291cmNlLT5zdHJlYW1FbmRlZFdpdGhFcnJvcihkZWNvZGVF cnJvcigpLCBJZ25vcmFibGVFeGNlcHRpb25Db2RlKCkpOwogICAgICAgICAgICAgICAgIHJldHVy bjsKICAgICAgICAgICAgIH0K