<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>136110</bug_id>
          
          <creation_ts>2014-08-20 11:03:57 -0700</creation_ts>
          <short_desc>[EFL] Build break occurs when ENABLE_GAMEPAD_DEPRECATED option are turned on.</short_desc>
          <delta_ts>2014-08-22 23:29:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>134076</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="KwangHyuk">hyuki.kim</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bunhere</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>rakuco</cc>
    
    <cc>sergio</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1030322</commentid>
    <comment_count>0</comment_count>
    <who name="KwangHyuk">hyuki.kim</who>
    <bug_when>2014-08-20 11:03:57 -0700</bug_when>
    <thetext>In file included from /home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:25:0:
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h:34:101: error: ‘Gamepad’ was not declared in this scope
     static JSGamepad* create(JSC::Structure* structure, JSDOMGlobalObject* globalObject, PassRefPtr&lt;Gamepad&gt; impl)
                                                                                                     ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h:34:108: error: template argument 1 is invalid
     static JSGamepad* create(JSC::Structure* structure, JSDOMGlobalObject* globalObject, PassRefPtr&lt;Gamepad&gt; impl)
                                                                                                            ^
In file included from /home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:25:0:
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h:53:5: error: ‘Gamepad’ does not name a type
     Gamepad&amp; impl() const { return *m_impl; }
     ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h:65:5: error: ‘Gamepad’ does not name a type
     Gamepad* m_impl;
     ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h:67:63: error: ‘Gamepad’ was not declared in this scope
     JSGamepad(JSC::Structure*, JSDOMGlobalObject*, PassRefPtr&lt;Gamepad&gt;);
                                                               ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h:67:70: error: template argument 1 is invalid
     JSGamepad(JSC::Structure*, JSDOMGlobalObject*, PassRefPtr&lt;Gamepad&gt;);
                                                                      ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h: In member function ‘void WebCore::JSGamepad::releaseImpl()’:
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h:54:26: error: ‘m_impl’ was not declared in this scope
     void releaseImpl() { m_impl-&gt;deref(); m_impl = 0; }
                          ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h: In member function ‘void WebCore::JSGamepad::releaseImplIfNotNull()’:
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h:58:13: error: ‘m_impl’ was not declared in this scope
         if (m_impl) {
             ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h: At global scope:
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h:83:61: error: ‘Gamepad’ has not been declared
 inline JSC::WeakHandleOwner* wrapperOwner(DOMWrapperWorld&amp;, Gamepad*)
                                                             ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h:89:53: error: ‘Gamepad’ has not been declared
 inline void* wrapperContext(DOMWrapperWorld&amp; world, Gamepad*)
                                                     ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h:94:56: error: ‘Gamepad’ has not been declared
 JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, Gamepad*);
                                                        ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h:95:1: error: ‘Gamepad’ does not name a type
 Gamepad* toGamepad(JSC::JSValue);
 ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:93:88: error: ‘Gamepad’ was not declared in this scope
 JSGamepad::JSGamepad(Structure* structure, JSDOMGlobalObject* globalObject, PassRefPtr&lt;Gamepad&gt; impl)
                                                                                        ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:93:95: error: template argument 1 is invalid
 JSGamepad::JSGamepad(Structure* structure, JSDOMGlobalObject* globalObject, PassRefPtr&lt;Gamepad&gt; impl)
                                                                                               ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp: In constructor ‘WebCore::JSGamepad::JSGamepad(JSC::Structure*, WebCore::JSDOMGlobalObject*, int)’:
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:95:7: error: class ‘WebCore::JSGamepad’ does not have any field named ‘m_impl’
     , m_impl(impl.leakRef())
       ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:95:19: error: request for member ‘leakRef’ in ‘impl’, which is of non-class type ‘int’
     , m_impl(impl.leakRef())
                   ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp: In function ‘JSC::EncodedJSValue WebCore::jsGamepadId(JSC::ExecState*, JSC::JSObject*, JSC::EncodedJSValue, JSC::PropertyName)’:
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:131:5: error: ‘Gamepad’ was not declared in this scope
     Gamepad&amp; impl = castedThis-&gt;impl();
     ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:131:14: error: ‘impl’ was not declared in this scope
     Gamepad&amp; impl = castedThis-&gt;impl();
              ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:131:33: error: ‘class WebCore::JSGamepad’ has no member named ‘impl’
     Gamepad&amp; impl = castedThis-&gt;impl();
                                 ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp: In function ‘JSC::EncodedJSValue WebCore::jsGamepadIndex(JSC::ExecState*, JSC::JSObject*, JSC::EncodedJSValue, JSC::PropertyName)’:
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:148:5: error: ‘Gamepad’ was not declared in this scope
     Gamepad&amp; impl = castedThis-&gt;impl();
     ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:148:14: error: ‘impl’ was not declared in this scope
     Gamepad&amp; impl = castedThis-&gt;impl();
              ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:148:33: error: ‘class WebCore::JSGamepad’ has no member named ‘impl’
     Gamepad&amp; impl = castedThis-&gt;impl();
                                 ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp: In function ‘JSC::EncodedJSValue WebCore::jsGamepadTimestamp(JSC::ExecState*, JSC::JSObject*, JSC::EncodedJSValue, JSC::PropertyName)’:
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:165:5: error: ‘Gamepad’ was not declared in this scope
     Gamepad&amp; impl = castedThis-&gt;impl();
     ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:165:14: error: ‘impl’ was not declared in this scope
     Gamepad&amp; impl = castedThis-&gt;impl();
              ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:165:33: error: ‘class WebCore::JSGamepad’ has no member named ‘impl’
     Gamepad&amp; impl = castedThis-&gt;impl();
                                 ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp: In function ‘JSC::EncodedJSValue WebCore::jsGamepadAxes(JSC::ExecState*, JSC::JSObject*, JSC::EncodedJSValue, JSC::PropertyName)’:
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:182:5: error: ‘Gamepad’ was not declared in this scope
     Gamepad&amp; impl = castedThis-&gt;impl();
     ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:182:14: error: ‘impl’ was not declared in this scope
     Gamepad&amp; impl = castedThis-&gt;impl();
              ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:182:33: error: ‘class WebCore::JSGamepad’ has no member named ‘impl’
     Gamepad&amp; impl = castedThis-&gt;impl();
                                 ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp: In function ‘JSC::EncodedJSValue WebCore::jsGamepadButtons(JSC::ExecState*, JSC::JSObject*, JSC::EncodedJSValue, JSC::PropertyName)’:
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:199:5: error: ‘Gamepad’ was not declared in this scope
     Gamepad&amp; impl = castedThis-&gt;impl();
     ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:199:14: error: ‘impl’ was not declared in this scope
     Gamepad&amp; impl = castedThis-&gt;impl();
              ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:199:33: error: ‘class WebCore::JSGamepad’ has no member named ‘impl’
     Gamepad&amp; impl = castedThis-&gt;impl();
                                 ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp: In member function ‘virtual void WebCore::JSGamepadOwner::finalize(JSC::Handle&lt;JSC::Unknown&gt;, void*)’:
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:216:39: error: ‘class WebCore::JSGamepad’ has no member named ‘impl’
     uncacheWrapper(world, &amp;jsGamepad-&gt;impl(), jsGamepad);
                                       ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp: At global scope:
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:220:69: error: ‘Gamepad’ has not been declared
 JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject* globalObject, Gamepad* impl)
                                                                     ^
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:236:1: error: ‘Gamepad’ does not name a type
 Gamepad* toGamepad(JSC::JSValue value)
 ^
In file included from /home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:28:0:
/home/hyuki/git/webkit/Source/WebCore/bindings/js/JSDOMBinding.h: In instantiation of ‘WebCore::JSDOMWrapper* WebCore::createWrapper(WebCore::JSDOMGlobalObject*, DOMClass*) [with WrapperClass = WebCore::JSGamepad; DOMClass = int]’:
/home/hyuki/git/webkit/Source/WebCore/bindings/js/JSDOMBinding.h:253:63:   required from ‘JSC::JSValue WebCore::createNewWrapper(WebCore::JSDOMGlobalObject*, DOMClass*) [with WrapperClass = WebCore::JSGamepad; DOMClass = int]’
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:233:58:   required from here
/home/hyuki/git/webkit/Source/WebCore/bindings/js/JSDOMBinding.h:229:133: error: invalid conversion from ‘int*’ to ‘int’ [-fpermissive]
     WrapperClass* wrapper = WrapperClass::create(getDOMStructure&lt;WrapperClass&gt;(globalObject-&gt;vm(), globalObject), globalObject, node);
                                                                                                                                     ^
In file included from /home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp:25:0:
/home/hyuki/git/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.h:34:23: error:   initializing argument 3 of ‘static WebCore::JSGamepad* WebCore::JSGamepad::create(JSC::Structure*, WebCore::JSDOMGlobalObject*, int)’ [-fpermissive]
     static JSGamepad* create(JSC::Structure* structure, JSDOMGlobalObject* globalObject, PassRefPtr&lt;Gamepad&gt; impl)
                       ^
[ 71%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/JSGeoposition.cpp.o
make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/JSGamepad.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2
make: *** [all] Error 2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030346</commentid>
    <comment_count>1</comment_count>
      <attachid>236887</attachid>
    <who name="KwangHyuk">hyuki.kim</who>
    <bug_when>2014-08-20 11:54:19 -0700</bug_when>
    <thetext>Created attachment 236887
Patch to fix build break when ENABLE_GAMEPAD_DEPRECATED is on.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030525</commentid>
    <comment_count>2</comment_count>
      <attachid>236931</attachid>
    <who name="KwangHyuk">hyuki.kim</who>
    <bug_when>2014-08-21 11:37:15 -0700</bug_when>
    <thetext>Created attachment 236931
Patch.

To fix gtk build break.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030633</commentid>
    <comment_count>3</comment_count>
      <attachid>236956</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2014-08-21 19:05:54 -0700</bug_when>
    <thetext>Created attachment 236956
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030635</commentid>
    <comment_count>4</comment_count>
      <attachid>236931</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2014-08-21 19:08:31 -0700</bug_when>
    <thetext>Comment on attachment 236931
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=236931&amp;action=review

&gt; Source/WebCore/CMakeLists.txt:-7
&gt; -    &quot;${WEBCORE_DIR}/Modules/gamepad/deprecated&quot;

AFAIK, GAMEPAD_DEPRECATED is only needed for EFL port as legacy. right ? If so, I think other ports should follow upcoming GAMEPAD implementation. And EFL port only supports GAMEPAD_DEPRECATED until we need to use it. So, how about using my proposal ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030636</commentid>
    <comment_count>5</comment_count>
    <who name="KwangHyuk">hyuki.kim</who>
    <bug_when>2014-08-21 19:12:22 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 236931 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=236931&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/CMakeLists.txt:-7
&gt; &gt; -    &quot;${WEBCORE_DIR}/Modules/gamepad/deprecated&quot;
&gt; 
&gt; AFAIK, GAMEPAD_DEPRECATED is only needed for EFL port as legacy. right ? If so, I think other ports should follow upcoming GAMEPAD implementation. And EFL port only supports GAMEPAD_DEPRECATED until we need to use it. So, how about using my proposal ?

Looks nice. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030637</commentid>
    <comment_count>6</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2014-08-21 19:13:43 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #4)
&gt; &gt; (From update of attachment 236931 [details] [details])
&gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=236931&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Source/WebCore/CMakeLists.txt:-7
&gt; &gt; &gt; -    &quot;${WEBCORE_DIR}/Modules/gamepad/deprecated&quot;
&gt; &gt; 
&gt; &gt; AFAIK, GAMEPAD_DEPRECATED is only needed for EFL port as legacy. right ? If so, I think other ports should follow upcoming GAMEPAD implementation. And EFL port only supports GAMEPAD_DEPRECATED until we need to use it. So, how about using my proposal ?
&gt; 
&gt; Looks nice. :)

Please upload my proposal with updated ChangeLog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030693</commentid>
    <comment_count>7</comment_count>
      <attachid>236973</attachid>
    <who name="KwangHyuk">hyuki.kim</who>
    <bug_when>2014-08-22 00:54:58 -0700</bug_when>
    <thetext>Created attachment 236973
patch to apply reviewer&apos;s suggestion.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030903</commentid>
    <comment_count>8</comment_count>
      <attachid>236973</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-08-22 23:29:50 -0700</bug_when>
    <thetext>Comment on attachment 236973
patch to apply reviewer&apos;s suggestion.

Clearing flags on attachment: 236973

Committed r172882: &lt;http://trac.webkit.org/changeset/172882&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030904</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-08-22 23:29:54 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>236887</attachid>
            <date>2014-08-20 11:54:19 -0700</date>
            <delta_ts>2014-08-21 11:37:15 -0700</delta_ts>
            <desc>Patch to fix build break when ENABLE_GAMEPAD_DEPRECATED is on.</desc>
            <filename>gamepad_001.patch</filename>
            <type>text/plain</type>
            <size>3004</size>
            <attacher name="KwangHyuk">hyuki.kim</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBmMTRlNjAxLi44YjRjYWI1
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK
KzIwMTQtMDgtMjAgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ftc3VuZy5jb20+CisKKyAg
ICAgICAgW0VGTF0gVHVybiBvbiBFTkFCTEVfR0FNRVBBRF9ERVBSRUNBVEVEIG9wdGlvbi4KKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjExMAorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR1cm4gb24gRU5B
QkxFX0dBTUVQQURfREVQUkVDQVRFRCBvcHRpb24gZm9yIHRoZSBXSzIgRWZsLgorCisgICAgICAg
ICogU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2U6CisKIDIwMTQtMDgtMTkgIFphbGFuIEJ1
anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgRU5BQkxFKFNVQlBJWEVM
X0xBWU9VVCkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1Nv
dXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IGNlMTU4MWQuLjExY2I5YmYgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3Jl
L0NNYWtlTGlzdHMudHh0CkBAIC0zLDggKzMsNiBAQCBzZXQoV2ViQ29yZV9JTkNMVURFX0RJUkVD
VE9SSUVTCiAgICAgIiR7V0VCQ09SRV9ESVJ9L01vZHVsZXMvYWlycGxheSIKICAgICAiJHtXRUJD
T1JFX0RJUn0vTW9kdWxlcy9iYXR0ZXJ5IgogICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL2Vu
Y3J5cHRlZG1lZGlhIgotICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL2dhbWVwYWQiCi0gICAg
IiR7V0VCQ09SRV9ESVJ9L01vZHVsZXMvZ2FtZXBhZC9kZXByZWNhdGVkIgogICAgICIke1dFQkNP
UkVfRElSfS9Nb2R1bGVzL2dlb2xvY2F0aW9uIgogICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVz
L2luZGV4ZWRkYiIKICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9pbmRleGVkZGIvbGV2ZWxk
YiIKQEAgLTI4MzYsNiArMjgzNCwxNiBAQCBpZiAoRU5BQkxFX1NNT09USF9TQ1JPTExJTkcpCiAg
ICAgKQogZW5kaWYgKCkKIAoraWYgKEVOQUJMRV9HQU1FUEFEKQorICAgIGxpc3QoQVBQRU5EIFdl
YkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUworICAgICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxl
cy9nYW1lcGFkIgorICAgICkKK2Vsc2VpZiAoRU5BQkxFX0dBTUVQQURfREVQUkVDQVRFRCkKKyAg
ICBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKKyAgICAgICAgIiR7V0VC
Q09SRV9ESVJ9L01vZHVsZXMvZ2FtZXBhZC9kZXByZWNhdGVkIgorICAgICkKK2VuZGlmICgpCisK
IGlmIChFTkFCTEVfV0VCR0wpCiAgICAgc2V0KFdURl9VU0VfM0RfR1JBUEhJQ1MgMSkKICAgICBh
ZGRfZGVmaW5pdGlvbnMoLURXVEZfVVNFXzNEX0dSQVBISUNTPTEpCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkw
Y2UyNC4uMzIzMGE4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi
L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA4LTIwICBL
d2FuZ0h5dWsgS2ltICA8aHl1a2kua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIEZp
eCBidWlsZCBicmVhayBjYXVzZWQgYnkgRU5BQkxFX0dBTUVQQURfREVQUkVDQVRFRC4KKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjExMAorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlcGFyYXRlIGVhY2gg
aW5jbHVkZSBwYXRoIGNvcnJlc3BvbmRzIHdpdGggRU5BQkxFX0dBTUVQQUQgYW5kIEVOQUJMRV9H
QU1FUEFEX0RFUFJFQ0FURUQgaW4gb3JkZXIgdG8gZml4IGJ1aWxkIGJyZWFrIHdoZW4gRU5BQkxF
X0dBTUVQQURfREVQUkVDQVRFRCBpcyBvbi4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVz
ZSBubyBmdW5jdGlvbmFsIGNoYW5nZXMKKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAy
MDE0LTA4LTIwICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgRGFz
aGVkL2RvdHRlZCBib3JkZXJzIGRvIG5vdCBwYWludC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFr
ZS9PcHRpb25zRWZsLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKaW5kZXgg
MjQ1ZDNhNS4uNDcyYjExYSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21h
a2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKQEAgLTcyLDcgKzcyLDcgQEAg
V0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0VOQ1JZUFRFRF9NRURJQV9W
MiBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9GSUxURVJTIE9O
KQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0ZVTExTQ1JFRU5fQVBJ
IE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0dBTUVQQUQgT0ZG
KQotV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0dBTUVQQURfREVQUkVD
QVRFRCBPRkYpCitXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfR0FNRVBB
RF9ERVBSRUNBVEVEIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxF
X0dFT0xPQ0FUSU9OIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxF
X0lOREVYRURfREFUQUJBU0UgT0ZGKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUo
RU5BQkxFX0lOREVYRURfREFUQUJBU0VfSU5fV09SS0VSUyBPRkYpCg==
</data>
<flag name="review"
          id="261582"
          type_id="1"
          status="+"
          setter="gyuyoung.kim"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>236931</attachid>
            <date>2014-08-21 11:37:15 -0700</date>
            <delta_ts>2014-08-22 00:54:58 -0700</delta_ts>
            <desc>Patch.</desc>
            <filename>gamepad_002.patch</filename>
            <type>text/plain</type>
            <size>3214</size>
            <attacher name="KwangHyuk">hyuki.kim</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBmMTRlNjAxLi40ZDVjNjA5
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK
KzIwMTQtMDgtMjEgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ftc3VuZy5jb20+CisKKyAg
ICAgICAgW0VGTF0gVHVybiBvbiBFTkFCTEVfR0FNRVBBRF9ERVBSRUNBVEVEIG9wdGlvbi4KKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjExMAorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR1cm4gb24gRU5B
QkxFX0dBTUVQQURfREVQUkVDQVRFRCBvcHRpb24gZm9yIHRoZSBXSzIgRWZsLgorCisgICAgICAg
ICogU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2U6CisKIDIwMTQtMDgtMTkgIFphbGFuIEJ1
anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgRU5BQkxFKFNVQlBJWEVM
X0xBWU9VVCkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1Nv
dXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IGNlMTU4MWQuLjRhNzQ2OWYgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3Jl
L0NNYWtlTGlzdHMudHh0CkBAIC0zLDggKzMsNiBAQCBzZXQoV2ViQ29yZV9JTkNMVURFX0RJUkVD
VE9SSUVTCiAgICAgIiR7V0VCQ09SRV9ESVJ9L01vZHVsZXMvYWlycGxheSIKICAgICAiJHtXRUJD
T1JFX0RJUn0vTW9kdWxlcy9iYXR0ZXJ5IgogICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL2Vu
Y3J5cHRlZG1lZGlhIgotICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL2dhbWVwYWQiCi0gICAg
IiR7V0VCQ09SRV9ESVJ9L01vZHVsZXMvZ2FtZXBhZC9kZXByZWNhdGVkIgogICAgICIke1dFQkNP
UkVfRElSfS9Nb2R1bGVzL2dlb2xvY2F0aW9uIgogICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVz
L2luZGV4ZWRkYiIKICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9pbmRleGVkZGIvbGV2ZWxk
YiIKQEAgLTI4MzYsNiArMjgzNCwyMSBAQCBpZiAoRU5BQkxFX1NNT09USF9TQ1JPTExJTkcpCiAg
ICAgKQogZW5kaWYgKCkKIAoraWYgKEVOQUJMRV9HQU1FUEFEKQorICAgIGxpc3QoQVBQRU5EIFdl
YkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUworICAgICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxl
cy9nYW1lcGFkIgorICAgICkKK2Vsc2VpZiAoRU5BQkxFX0dBTUVQQURfREVQUkVDQVRFRCkKKyAg
ICBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKKyAgICAgICAgIiR7V0VC
Q09SRV9ESVJ9L01vZHVsZXMvZ2FtZXBhZC9kZXByZWNhdGVkIgorICAgICkKK2Vsc2UgKCkKKyAg
ICBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKKyAgICAgICAgIiR7V0VC
Q09SRV9ESVJ9L01vZHVsZXMvZ2FtZXBhZCIKKyAgICAgICAgIiR7V0VCQ09SRV9ESVJ9L01vZHVs
ZXMvZ2FtZXBhZC9kZXByZWNhdGVkIgorICAgICkKK2VuZGlmICgpCisKIGlmIChFTkFCTEVfV0VC
R0wpCiAgICAgc2V0KFdURl9VU0VfM0RfR1JBUEhJQ1MgMSkKICAgICBhZGRfZGVmaW5pdGlvbnMo
LURXVEZfVVNFXzNEX0dSQVBISUNTPTEpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu
Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDRmY2NkZi4uMzNmMTZjNyAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3Jl
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA4LTIxICBLd2FuZ0h5dWsgS2ltICA8
aHl1a2kua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIEZpeCBidWlsZCBicmVhayBj
YXVzZWQgYnkgRU5BQkxFX0dBTUVQQURfREVQUkVDQVRFRC4KKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjExMAorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlcGFyYXRlIGVhY2ggaW5jbHVkZSBwYXRoIGNv
cnJlc3BvbmRzIHdpdGggRU5BQkxFX0dBTUVQQUQgYW5kIEVOQUJMRV9HQU1FUEFEX0RFUFJFQ0FU
RUQgaW4gb3JkZXIgdG8gZml4IGJ1aWxkIGJyZWFrIHdoZW4gRU5BQkxFX0dBTUVQQURfREVQUkVD
QVRFRCBpcyBvbi4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSBubyBmdW5jdGlvbmFs
IGNoYW5nZXMuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxNC0wOC0yMSAgVsOt
Y3RvciBNYW51ZWwgSsOhcXVleiBMZWFsICA8dmphcXVlekBpZ2FsaWEuY29tPgogCiAgICAgICAg
IFtHVEtdIFdlYmtpdFdlYlByb2Nlc3MgY3Jhc2hpbmcgbmF2aWdhdGluZyBhd2F5IGZyb20gb2dn
IHZpZGVvIGVsZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtl
IGIvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKaW5kZXggMjQ1ZDNhNS4uNDcyYjExYSAx
MDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKKysrIGIvU291cmNlL2Nt
YWtlL09wdGlvbnNFZmwuY21ha2UKQEAgLTcyLDcgKzcyLDcgQEAgV0VCS0lUX09QVElPTl9ERUZB
VUxUX1BPUlRfVkFMVUUoRU5BQkxFX0VOQ1JZUFRFRF9NRURJQV9WMiBPTikKIFdFQktJVF9PUFRJ
T05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9GSUxURVJTIE9OKQogV0VCS0lUX09QVElPTl9E
RUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0ZVTExTQ1JFRU5fQVBJIE9OKQogV0VCS0lUX09QVElP
Tl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0dBTUVQQUQgT0ZGKQotV0VCS0lUX09QVElPTl9E
RUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0dBTUVQQURfREVQUkVDQVRFRCBPRkYpCitXRUJLSVRf
T1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfR0FNRVBBRF9ERVBSRUNBVEVEIE9OKQog
V0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0dFT0xPQ0FUSU9OIE9OKQog
V0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0lOREVYRURfREFUQUJBU0Ug
T0ZGKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0lOREVYRURfREFU
QUJBU0VfSU5fV09SS0VSUyBPRkYpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>236956</attachid>
            <date>2014-08-21 19:05:54 -0700</date>
            <delta_ts>2014-08-21 19:06:19 -0700</delta_ts>
            <desc>Proposed patch</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>3357</size>
            <attacher name="Gyuyoung Kim">gyuyoung.kim</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAxNjcxMWUwLi43MGQyOWJk
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK
KzIwMTQtMDgtMjEgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ftc3VuZy5jb20+CisKKyAg
ICAgICAgW0VGTF0gVHVybiBvbiBFTkFCTEVfR0FNRVBBRF9ERVBSRUNBVEVEIG9wdGlvbi4KKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjExMAorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR1cm4gb24gRU5B
QkxFX0dBTUVQQURfREVQUkVDQVRFRCBvcHRpb24gZm9yIHRoZSBXSzIgRWZsLgorCisgICAgICAg
ICogU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2U6CisKIDIwMTQtMDgtMjEgIFphbGFuIEJ1
anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgU0FUVVJBVEVEX0xBWU9V
VF9BUklUSE1FVElDLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQg
Yi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCBjZTE1ODFkLi5mMmI2MGVkIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2Vi
Q29yZS9DTWFrZUxpc3RzLnR4dApAQCAtNCw3ICs0LDYgQEAgc2V0KFdlYkNvcmVfSU5DTFVERV9E
SVJFQ1RPUklFUwogICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL2JhdHRlcnkiCiAgICAgIiR7
V0VCQ09SRV9ESVJ9L01vZHVsZXMvZW5jcnlwdGVkbWVkaWEiCiAgICAgIiR7V0VCQ09SRV9ESVJ9
L01vZHVsZXMvZ2FtZXBhZCIKLSAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9nYW1lcGFkL2Rl
cHJlY2F0ZWQiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L01vZHVsZXMvZ2VvbG9jYXRpb24iCiAgICAg
IiR7V0VCQ09SRV9ESVJ9L01vZHVsZXMvaW5kZXhlZGRiIgogICAgICIke1dFQkNPUkVfRElSfS9N
b2R1bGVzL2luZGV4ZWRkYi9sZXZlbGRiIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hh
bmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDEwNjBkMDMuLjg3OTFkODEg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNC0wOC0yMSAgS3dhbmdIeXVrIEtpbSAg
PGh5dWtpLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBGaXggYnVpbGQgYnJlYWsg
Y2F1c2VkIGJ5IEVOQUJMRV9HQU1FUEFEX0RFUFJFQ0FURUQuCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYxMTAKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXBhcmF0ZSBlYWNoIGluY2x1ZGUgcGF0aCBj
b3JyZXNwb25kcyB3aXRoIEVOQUJMRV9HQU1FUEFEIGFuZCBFTkFCTEVfR0FNRVBBRF9ERVBSRUNB
VEVEIGluIG9yZGVyIHRvIGZpeCBidWlsZCBicmVhayB3aGVuIEVOQUJMRV9HQU1FUEFEX0RFUFJF
Q0FURUQgaXMgb24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2Ugbm8gZnVuY3Rpb25h
bCBjaGFuZ2VzLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMTQtMDgtMjEgIFJ5
dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQg
YnVpbGQgZml4IHdoZW4gUlVCQkVSX0JBTkRJTkcgaXMgbm90IGVuYWJsZWQuCmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRm
b3JtRWZsLmNtYWtlCmluZGV4IDM5NzczYzMuLmQ0ODI5OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZs
LmNtYWtlCkBAIC0yNDMsNiArMjQzLDE3IEBAIGlmIChFTkFCTEVfQkFUVEVSWV9TVEFUVVMgT1Ig
KEVGTF9SRVFVSVJFRF9WRVJTSU9OIFZFUlNJT05fTEVTUyAxLjgpKQogICAgIGxpc3QoQVBQRU5E
IFdlYkNvcmVfTElCUkFSSUVTICR7RV9EQlVTX0VVS0lUX0xJQlJBUklFU30pCiBlbmRpZiAoKQog
CitpZiAoRU5BQkxFX0dBTUVQQURfREVQUkVDQVRFRCkKKyAgICAjIEZJWE1FOiBHQU1FUEFEX0RF
UFJFQ0FURUQgaXMgbGVnYWN5IGltcGxlbWVudGF0aW9uLiBOZWVkIHRvIGJlIHJlbW92ZWQuCisg
ICAgbGlzdChSRU1PVkVfSVRFTSBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKKyAgICAgICAg
IiR7V0VCQ09SRV9ESVJ9L01vZHVsZXMvZ2FtZXBhZCIKKyAgICApCisKKyAgICBsaXN0KEFQUEVO
RCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKKyAgICAgICAgIiR7V0VCQ09SRV9ESVJ9L01v
ZHVsZXMvZ2FtZXBhZC9kZXByZWNhdGVkIgorICAgICkKK2VuZGlmICgpCisKIGxpc3QoQVBQRU5E
IFdlYkNvcmVfVVNFUl9BR0VOVF9TVFlMRV9TSEVFVFMKICAgICAke1dFQkNPUkVfRElSfS9Nb2R1
bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmNzcwogKQpkaWZmIC0tZ2l0IGEv
U291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5j
bWFrZQppbmRleCAyNDVkM2E1Li40NzJiMTFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0
aW9uc0VmbC5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQpAQCAtNzIs
NyArNzIsNyBAQCBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfRU5DUllQ
VEVEX01FRElBX1YyIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxF
X0ZJTFRFUlMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfRlVM
TFNDUkVFTl9BUEkgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf
R0FNRVBBRCBPRkYpCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfR0FN
RVBBRF9ERVBSRUNBVEVEIE9GRikKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO
QUJMRV9HQU1FUEFEX0RFUFJFQ0FURUQgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W
QUxVRShFTkFCTEVfR0VPTE9DQVRJT04gT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W
QUxVRShFTkFCTEVfSU5ERVhFRF9EQVRBQkFTRSBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRf
UE9SVF9WQUxVRShFTkFCTEVfSU5ERVhFRF9EQVRBQkFTRV9JTl9XT1JLRVJTIE9GRikK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>236973</attachid>
            <date>2014-08-22 00:54:58 -0700</date>
            <delta_ts>2014-08-22 23:29:49 -0700</delta_ts>
            <desc>patch to apply reviewer&apos;s suggestion.</desc>
            <filename>gamepad_003.patch</filename>
            <type>text/plain</type>
            <size>2702</size>
            <attacher name="KwangHyuk">hyuki.kim</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAxNjcxMWUwLi43MGQyOWJk
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK
KzIwMTQtMDgtMjEgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ftc3VuZy5jb20+CisKKyAg
ICAgICAgW0VGTF0gVHVybiBvbiBFTkFCTEVfR0FNRVBBRF9ERVBSRUNBVEVEIG9wdGlvbi4KKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjExMAorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR1cm4gb24gRU5B
QkxFX0dBTUVQQURfREVQUkVDQVRFRCBvcHRpb24gZm9yIHRoZSBXSzIgRWZsLgorCisgICAgICAg
ICogU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2U6CisKIDIwMTQtMDgtMjEgIFphbGFuIEJ1
anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgU0FUVVJBVEVEX0xBWU9V
VF9BUklUSE1FVElDLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDEwNjBkMDMuLmJiODYzYjEgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK
QEAgLTEsMyArMSwxNiBAQAorMjAxNC0wOC0yMSAgS3dhbmdIeXVrIEtpbSAgPGh5dWtpLmtpbUBz
YW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBGaXggYnVpbGQgYnJlYWsgY2F1c2VkIGJ5IEVO
QUJMRV9HQU1FUEFEX0RFUFJFQ0FURUQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xMzYxMTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JZIGZvciBnYW1lcGFkIHdh
cyByZW1vdmVkIGZyb20gV0syIEVmbCBpbiBvcmRlciB0byBmaXggYnVpbGQgYnJlYWsgd2hlbiBF
TkFCTEVfR0FNRVBBRF9ERVBSRUNBVEVEIGlzIG9uLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBi
ZWNhdXNlIG5vIGZ1bmN0aW9uYWwgY2hhbmdlcy4KKworICAgICAgICAqIFBsYXRmb3JtRWZsLmNt
YWtlOgorCiAyMDE0LTA4LTIxICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4K
IAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCB3aGVuIFJVQkJFUl9CQU5ESU5HIGlzIG5v
dCBlbmFibGVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2Ug
Yi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZQppbmRleCAzOTc3M2MzLi5hNGVjMzE1
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZQorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAtMjQzLDYgKzI0MywxMyBAQCBpZiAoRU5B
QkxFX0JBVFRFUllfU1RBVFVTIE9SIChFRkxfUkVRVUlSRURfVkVSU0lPTiBWRVJTSU9OX0xFU1Mg
MS44KSkKICAgICBsaXN0KEFQUEVORCBXZWJDb3JlX0xJQlJBUklFUyAke0VfREJVU19FVUtJVF9M
SUJSQVJJRVN9KQogZW5kaWYgKCkKIAoraWYgKEVOQUJMRV9HQU1FUEFEX0RFUFJFQ0FURUQpCisg
ICAgIyBGSVhNRTogR0FNRVBBRF9ERVBSRUNBVEVEIGlzIGxlZ2FjeSBpbXBsZW1lbnRhdGlvbi4g
TmVlZCB0byBiZSByZW1vdmVkLgorICAgIGxpc3QoUkVNT1ZFX0lURU0gV2ViQ29yZV9JTkNMVURF
X0RJUkVDVE9SSUVTCisgICAgICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL2dhbWVwYWQiCisg
ICAgKQorZW5kaWYgKCkKKwogbGlzdChBUFBFTkQgV2ViQ29yZV9VU0VSX0FHRU5UX1NUWUxFX1NI
RUVUUwogICAgICR7V0VCQ09SRV9ESVJ9L01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRy
b2xzQXBwbGUuY3NzCiApCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFr
ZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDI0NWQzYTUuLjQ3MmIxMWEg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9j
bWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC03Miw3ICs3Miw3IEBAIFdFQktJVF9PUFRJT05fREVG
QVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9FTkNSWVBURURfTUVESUFfVjIgT04pCiBXRUJLSVRfT1BU
SU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfRklMVEVSUyBPTikKIFdFQktJVF9PUFRJT05f
REVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9GVUxMU0NSRUVOX0FQSSBPTikKIFdFQktJVF9PUFRJ
T05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9HQU1FUEFEIE9GRikKLVdFQktJVF9PUFRJT05f
REVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9HQU1FUEFEX0RFUFJFQ0FURUQgT0ZGKQorV0VCS0lU
X09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0dBTUVQQURfREVQUkVDQVRFRCBPTikK
IFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9HRU9MT0NBVElPTiBPTikK
IFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9JTkRFWEVEX0RBVEFCQVNF
IE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9JTkRFWEVEX0RB
VEFCQVNFX0lOX1dPUktFUlMgT0ZGKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>