<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>136105</bug_id>
          
          <creation_ts>2014-08-20 09:26:32 -0700</creation_ts>
          <short_desc>[Win] JavaScriptCore.dll is missing version information</short_desc>
          <delta_ts>2014-08-20 12:47:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Blocker</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1030284</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-08-20 09:26:32 -0700</bug_when>
    <thetext>The JavaScriptCore.dll is missing the version information specified in the sources. This patch corrects the missing step needed to seed the version resource for the build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030285</commentid>
    <comment_count>1</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-08-20 09:26:52 -0700</bug_when>
    <thetext>&lt;rdar://problem/18075852&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030286</commentid>
    <comment_count>2</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-08-20 09:31:21 -0700</bug_when>
    <thetext>It looks like the JavaScriptCorePreBuild.cmd is missing a call to auto-version.pl to seed the JSC-specific build directory with the version information.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030314</commentid>
    <comment_count>3</comment_count>
      <attachid>236881</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-08-20 10:56:02 -0700</bug_when>
    <thetext>Created attachment 236881
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030357</commentid>
    <comment_count>4</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-08-20 12:47:03 -0700</bug_when>
    <thetext>Committed r172805: &lt;http://trac.webkit.org/changeset/172805&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>236881</attachid>
            <date>2014-08-20 10:56:02 -0700</date>
            <delta_ts>2014-08-20 11:01:52 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-136105-20140820105635.patch</filename>
            <type>text/plain</type>
            <size>1412</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyNzk3KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA
CisyMDE0LTA4LTIwICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAg
ICAgIFtXaW5dIEphdmFTY3JpcHRDb3JlLmRsbCBpcyBtaXNzaW5nIHZlcnNpb24gaW5mb3JtYXRp
b24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYx
MDUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE4MDc1ODUyPgorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUudmN4cHJvai9K
YXZhU2NyaXB0Q29yZVByZUJ1aWxkLmNtZDogQWRkIG1pc3Npbmcgc3RlcCB0byBnZW5lcmF0ZQor
ICAgICAgICB2ZXJzaW9uIGluZm9ybWF0aW9uIGZvciBpbnRlcm1lZGlhcnkgYnVpbGQgcGF0aC4K
KwogMjAxNC0wOC0xOSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAg
IFJFR1JFU1NJT04ocjE3MjQwMSk6IGZvci1pbiBvcHRpbWl6YXRpb24gbm8gbG9uZ2VyIHdvcmtz
IGF0IGFsbApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjeHBy
b2ovSmF2YVNjcmlwdENvcmVQcmVCdWlsZC5jbWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT
Y3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjeHByb2ovSmF2YVNjcmlwdENvcmVQcmVCdWlsZC5j
bWQJKHJldmlzaW9uIDE3Mjc5NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0
Q29yZS52Y3hwcm9qL0phdmFTY3JpcHRDb3JlUHJlQnVpbGQuY21kCSh3b3JraW5nIGNvcHkpCkBA
IC00LDMgKzQsNSBAQCBjbWQgL2MKIGlmIGV4aXN0ICIlQ09ORklHVVJBVElPTkJVSUxERElSJVxi
dWlsZGZhaWxlZCIgcGVybCAtd25sZSAiaWYgKC9YWCVQUk9KRUNUTkFNRSVYWC8pIHsgcHJpbnQg
fSBlbHNlIHsgZXhpdCAxIH0iICIlQ09ORklHVVJBVElPTkJVSUxERElSJVxidWlsZGZhaWxlZCIK
IGlmIGVycm9ybGV2ZWwgMSBleGl0IDEKIGVjaG8gWFglUFJPSkVDVE5BTUUlWFggPiAiJUNPTkZJ
R1VSQVRJT05CVUlMRERJUiVcYnVpbGRmYWlsZWQiCisKK3BlcmwgIiVXRUJLSVRfTElCUkFSSUVT
JVx0b29sc1xzY3JpcHRzXGF1dG8tdmVyc2lvbi5wbCIgIiVJTlRESVIlIgo=
</data>
<flag name="review"
          id="261575"
          type_id="1"
          status="+"
          setter="dino"
    />
          </attachment>
      

    </bug>

</bugzilla>