136103 2014-08-20 08:39:59 -0700 [Win] Assertion fails when running JSC stress tests. 2014-08-20 11:11:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue darin fpizlo mark.lam oldest_to_newest 1030272 0 peavo 2014-08-20 08:39:59 -0700 When I run the JSC stress tests on Windows, I get a few asserts in the function specializationKindFor in the InlineCallFrame struct (CodeOrigin.h). This happens because the kind parameter has the value -2. static CodeSpecializationKind specializationKindFor(Kind kind) { switch (kind) { case Call: case GetterCall: case SetterCall: return CodeForCall; case Construct: return CodeForConstruct; } RELEASE_ASSERT_NOT_REACHED(); return CodeForCall; } Since enums are signed on Windows, and only 2 bits are allocated for the Kind member in the InlineCallFrame struct, the values we can represent are -2, -1, 0, 1. We should use an extra bit in the bitfield, so we also can represent the values 2, and 3. See http://rogerkarlsson.com/blogs/programming/enum-bit-field-visual-studio/ for a similar case. 1030287 1 236873 peavo 2014-08-20 09:38:02 -0700 Created attachment 236873 Patch 1030292 2 236873 darin 2014-08-20 09:55:59 -0700 Comment on attachment 236873 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236873&action=review > Source/JavaScriptCore/bytecode/CodeOrigin.h:143 > + static CodeSpecializationKind specializationKindFor(unsigned kind) This change should not be necessary. What happens when you don’t change this? Some kind of failure to compile? > Source/JavaScriptCore/bytecode/CodeOrigin.h:163 > + unsigned kind : 2; I believe our WebKit coding style pattern in cases like this is to put a comment off to the right with the name of the enum type. See examples like the ones in DFGNode.h, RenderObject.h, StyleRareInheritedData.h, and StyleRareNonInheritedData.h. 1030293 3 236874 peavo 2014-08-20 10:03:12 -0700 Created attachment 236874 Patch 1030295 4 236874 darin 2014-08-20 10:04:15 -0700 Comment on attachment 236874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236874&action=review > Source/JavaScriptCore/bytecode/CodeOrigin.h:143 > - static CodeSpecializationKind specializationKindFor(Kind kind) > + static CodeSpecializationKind specializationKindFor(unsigned kind) This change should not be necessary. What happens when you don’t change this? Some kind of failure to compile? 1030296 5 236874 darin 2014-08-20 10:04:45 -0700 Comment on attachment 236874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236874&action=review >> Source/JavaScriptCore/bytecode/CodeOrigin.h:143 >> + static CodeSpecializationKind specializationKindFor(unsigned kind) > > This change should not be necessary. What happens when you don’t change this? Some kind of failure to compile? There is likely a better way to fix this than to remove the type here. 1030299 6 peavo 2014-08-20 10:07:44 -0700 (In reply to comment #5) > (From update of attachment 236874 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236874&action=review > > >> Source/JavaScriptCore/bytecode/CodeOrigin.h:143 > >> + static CodeSpecializationKind specializationKindFor(unsigned kind) > > > > This change should not be necessary. What happens when you don’t change this? Some kind of failure to compile? > > There is likely a better way to fix this than to remove the type here. MSVC was not able to convert from unsigned to the Kind enum type. Maybe replace with a static_cast when calling the function instead? 1030302 7 236874 mark.lam 2014-08-20 10:13:20 -0700 Comment on attachment 236874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236874&action=review >>>> Source/JavaScriptCore/bytecode/CodeOrigin.h:143 >>>> + static CodeSpecializationKind specializationKindFor(unsigned kind) >>> >>> This change should not be necessary. What happens when you don’t change this? Some kind of failure to compile? >> >> There is likely a better way to fix this than to remove the type here. > > MSVC was not able to convert from unsigned to the Kind enum type. > Maybe replace with a static_cast when calling the function instead? I see that we’re now using enum classes everywhere. How about using “enum class Kind : unsigned”? 1030303 8 236874 darin 2014-08-20 10:16:39 -0700 Comment on attachment 236874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236874&action=review >>>>> Source/JavaScriptCore/bytecode/CodeOrigin.h:143 >>>>> + static CodeSpecializationKind specializationKindFor(unsigned kind) >>>> >>>> This change should not be necessary. What happens when you don’t change this? Some kind of failure to compile? >>> >>> There is likely a better way to fix this than to remove the type here. >> >> MSVC was not able to convert from unsigned to the Kind enum type. >> Maybe replace with a static_cast when calling the function instead? > > I see that we’re now using enum classes everywhere. How about using “enum class Kind : unsigned”? Yes, we should put the static_cast into the specializationKind() function; note that the two other callers in DFGByteCodeParser.cpp would not require a static_cast. Also seems fine to try Mark’s suggestion of moving to an enum class, but I think that will lead to even more changes and I am not sure it’s worth it. 1030304 9 236876 peavo 2014-08-20 10:27:45 -0700 Created attachment 236876 Patch 1030305 10 peavo 2014-08-20 10:28:18 -0700 (In reply to comment #8) > (From update of attachment 236874 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236874&action=review > > >>>>> Source/JavaScriptCore/bytecode/CodeOrigin.h:143 > >>>>> + static CodeSpecializationKind specializationKindFor(unsigned kind) > >>>> > >>>> This change should not be necessary. What happens when you don’t change this? Some kind of failure to compile? > >>> > >>> There is likely a better way to fix this than to remove the type here. > >> > >> MSVC was not able to convert from unsigned to the Kind enum type. > >> Maybe replace with a static_cast when calling the function instead? > > > > I see that we’re now using enum classes everywhere. How about using “enum class Kind : unsigned”? > > Yes, we should put the static_cast into the specializationKind() function; note that the two other callers in DFGByteCodeParser.cpp would not require a static_cast. Also seems fine to try Mark’s suggestion of moving to an enum class, but I think that will lead to even more changes and I am not sure it’s worth it. Ok, thanks, updated patch :) 1030319 11 bfulgham 2014-08-20 11:00:50 -0700 (In reply to comment #7) > (From update of attachment 236874 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236874&action=review > > >>>> Source/JavaScriptCore/bytecode/CodeOrigin.h:143 > >>>> + static CodeSpecializationKind specializationKindFor(unsigned kind) > >>> > >>> This change should not be necessary. What happens when you don’t change this? Some kind of failure to compile? > >> > >> There is likely a better way to fix this than to remove the type here. > > > > MSVC was not able to convert from unsigned to the Kind enum type. > > Maybe replace with a static_cast when calling the function instead? > > I see that we’re now using enum classes everywhere. How about using “enum class Kind : unsigned”? Yes. See <https://bugs.webkit.org/show_bug.cgi?id=134252> as well. We've hit this numerous times. 1030325 12 236876 commit-queue 2014-08-20 11:11:29 -0700 Comment on attachment 236876 Patch Clearing flags on attachment: 236876 Committed r172801: <http://trac.webkit.org/changeset/172801> 1030326 13 commit-queue 2014-08-20 11:11:35 -0700 All reviewed patches have been landed. Closing bug. 236873 2014-08-20 09:38:02 -0700 2014-08-20 10:03:00 -0700 Patch bug-136103-20140820183742.patch text/plain 1873 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyNzk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTA4LTIwICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisg ICAgICAgIFtXaW5dIEFzc2VydGlvbiBmYWlscyB3aGVuIHJ1bm5pbmcgSlNDIHN0cmVzcyB0ZXN0 cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjEw MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB1 bnNpZ25lZCBiaXRmaWVsZCBtZW1iZXIgaW5zdGVhZCBvZiBlbnVtIGJpdGZpZWxkIG1lbWJlciB0 byBhdm9pZCBuZWdhdGl2ZSB2YWx1ZXMuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlT3JpZ2lu Lmg6CisgICAgICAgIChKU0M6OklubGluZUNhbGxGcmFtZTo6c3BlY2lhbGl6YXRpb25LaW5kRm9y KToKKwogMjAxNC0wOC0xOSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAg ICAgIFJFR1JFU1NJT04ocjE3MjQwMSk6IGZvci1pbiBvcHRpbWl6YXRpb24gbm8gbG9uZ2VyIHdv cmtzIGF0IGFsbApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVPcmln aW4uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZU9y aWdpbi5oCShyZXZpc2lvbiAxNzI3OTcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUvQ29kZU9yaWdpbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDAsNyArMTQwLDcgQEAgc3RydWN0 IElubGluZUNhbGxGcmFtZSB7CiAgICAgICAgIHJldHVybiBDYWxsOwogICAgIH0KICAgICAKLSAg ICBzdGF0aWMgQ29kZVNwZWNpYWxpemF0aW9uS2luZCBzcGVjaWFsaXphdGlvbktpbmRGb3IoS2lu ZCBraW5kKQorICAgIHN0YXRpYyBDb2RlU3BlY2lhbGl6YXRpb25LaW5kIHNwZWNpYWxpemF0aW9u S2luZEZvcih1bnNpZ25lZCBraW5kKQogICAgIHsKICAgICAgICAgc3dpdGNoIChraW5kKSB7CiAg ICAgICAgIGNhc2UgQ2FsbDoKQEAgLTE2MCw3ICsxNjAsNyBAQCBzdHJ1Y3QgSW5saW5lQ2FsbEZy YW1lIHsKICAgICBDb2RlT3JpZ2luIGNhbGxlcjsKICAgICBCaXRWZWN0b3IgY2FwdHVyZWRWYXJz OyAvLyBJbmRleGVkIGJ5IHRoZSBtYWNoaW5lIGNhbGwgZnJhbWUncyB2YXJpYWJsZSBudW1iZXJp bmcuCiAgICAgc2lnbmVkIHN0YWNrT2Zmc2V0IDogMzA7Ci0gICAgS2luZCBraW5kIDogMjsKKyAg ICB1bnNpZ25lZCBraW5kIDogMjsKICAgICBib29sIGlzQ2xvc3VyZUNhbGwgOiAxOyAvLyBJZiBm YWxzZSB0aGVuIHdlIGtub3cgdGhhdCBjYWxsZWUvc2NvcGUgYXJlIGNvbnN0YW50cyBhbmQgdGhl IERGRyB3b24ndCB0cmVhdCB0aGVtIGFzIHZhcmlhYmxlcywgaS5lLiB0aGV5IGhhdmUgdG8gYmUg cmVjb3ZlcmVkIG1hbnVhbGx5LgogICAgIFZpcnR1YWxSZWdpc3RlciBhcmd1bWVudHNSZWdpc3Rl cjsgLy8gVGhpcyBpcyBvbmx5IHNldCBpZiB0aGUgY29kZSB1c2VzIGFyZ3VtZW50cy4gVGhlIHVu bW9kaWZpZWQgYXJndW1lbnRzIHJlZ2lzdGVyIGZvbGxvd3MgdGhlIHVubW9kaWZpZWRBcmd1bWVu dHNSZWdpc3RlcigpIGNvbnZlbnRpb24gKHNlZSBDb2RlQmxvY2suaCkuCiAgICAgCg== 236874 2014-08-20 10:03:12 -0700 2014-08-20 10:27:35 -0700 Patch bug-136103-20140820190251.patch text/plain 1937 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyNzk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTA4LTIwICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisg ICAgICAgIFtXaW5dIEFzc2VydGlvbiBmYWlscyB3aGVuIHJ1bm5pbmcgSlNDIHN0cmVzcyB0ZXN0 cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjEw MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB1 bnNpZ25lZCBiaXRmaWVsZCBtZW1iZXIgaW5zdGVhZCBvZiBlbnVtIGJpdGZpZWxkIG1lbWJlciB0 byBhdm9pZCBuZWdhdGl2ZSB2YWx1ZXMuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlT3JpZ2lu Lmg6IFVzZSB1bnNpZ25lZCBiaXRmaWVsZCBtZW1iZXIuCisgICAgICAgIChKU0M6OklubGluZUNh bGxGcmFtZTo6c3BlY2lhbGl6YXRpb25LaW5kRm9yKTogQ29tcGlsZSBmaXguCisKIDIwMTQtMDgt MTkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O KHIxNzI0MDEpOiBmb3ItaW4gb3B0aW1pemF0aW9uIG5vIGxvbmdlciB3b3JrcyBhdCBhbGwKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlT3JpZ2luLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVPcmlnaW4uaAkocmV2aXNp b24gMTcyNzk3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVPcmlnaW4u aAkod29ya2luZyBjb3B5KQpAQCAtMTQwLDcgKzE0MCw3IEBAIHN0cnVjdCBJbmxpbmVDYWxsRnJh bWUgewogICAgICAgICByZXR1cm4gQ2FsbDsKICAgICB9CiAgICAgCi0gICAgc3RhdGljIENvZGVT cGVjaWFsaXphdGlvbktpbmQgc3BlY2lhbGl6YXRpb25LaW5kRm9yKEtpbmQga2luZCkKKyAgICBz dGF0aWMgQ29kZVNwZWNpYWxpemF0aW9uS2luZCBzcGVjaWFsaXphdGlvbktpbmRGb3IodW5zaWdu ZWQga2luZCkKICAgICB7CiAgICAgICAgIHN3aXRjaCAoa2luZCkgewogICAgICAgICBjYXNlIENh bGw6CkBAIC0xNjAsNyArMTYwLDcgQEAgc3RydWN0IElubGluZUNhbGxGcmFtZSB7CiAgICAgQ29k ZU9yaWdpbiBjYWxsZXI7CiAgICAgQml0VmVjdG9yIGNhcHR1cmVkVmFyczsgLy8gSW5kZXhlZCBi eSB0aGUgbWFjaGluZSBjYWxsIGZyYW1lJ3MgdmFyaWFibGUgbnVtYmVyaW5nLgogICAgIHNpZ25l ZCBzdGFja09mZnNldCA6IDMwOwotICAgIEtpbmQga2luZCA6IDI7CisgICAgdW5zaWduZWQga2lu ZCA6IDI7IC8vIHJlYWwgdHlwZSBpcyBLaW5kCiAgICAgYm9vbCBpc0Nsb3N1cmVDYWxsIDogMTsg Ly8gSWYgZmFsc2UgdGhlbiB3ZSBrbm93IHRoYXQgY2FsbGVlL3Njb3BlIGFyZSBjb25zdGFudHMg YW5kIHRoZSBERkcgd29uJ3QgdHJlYXQgdGhlbSBhcyB2YXJpYWJsZXMsIGkuZS4gdGhleSBoYXZl IHRvIGJlIHJlY292ZXJlZCBtYW51YWxseS4KICAgICBWaXJ0dWFsUmVnaXN0ZXIgYXJndW1lbnRz UmVnaXN0ZXI7IC8vIFRoaXMgaXMgb25seSBzZXQgaWYgdGhlIGNvZGUgdXNlcyBhcmd1bWVudHMu IFRoZSB1bm1vZGlmaWVkIGFyZ3VtZW50cyByZWdpc3RlciBmb2xsb3dzIHRoZSB1bm1vZGlmaWVk QXJndW1lbnRzUmVnaXN0ZXIoKSBjb252ZW50aW9uIChzZWUgQ29kZUJsb2NrLmgpLgogICAgIAo= 236876 2014-08-20 10:27:45 -0700 2014-08-20 11:11:29 -0700 Patch bug-136103-20140820192726.patch text/plain 1985 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyNzk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTA4LTIwICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisg ICAgICAgIFtXaW5dIEFzc2VydGlvbiBmYWlscyB3aGVuIHJ1bm5pbmcgSlNDIHN0cmVzcyB0ZXN0 cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjEw MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB1 bnNpZ25lZCBiaXRmaWVsZCBtZW1iZXIgaW5zdGVhZCBvZiBlbnVtIGJpdGZpZWxkIG1lbWJlciB0 byBhdm9pZCBuZWdhdGl2ZSB2YWx1ZXMuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlT3JpZ2lu Lmg6IFVzZSB1bnNpZ25lZCBiaXRmaWVsZCBtZW1iZXIuCisgICAgICAgIChKU0M6OklubGluZUNh bGxGcmFtZTo6c3BlY2lhbGl6YXRpb25LaW5kKTogQ29tcGlsZSBmaXguCisKIDIwMTQtMDgtMTkg IEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIx NzI0MDEpOiBmb3ItaW4gb3B0aW1pemF0aW9uIG5vIGxvbmdlciB3b3JrcyBhdCBhbGwKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlT3JpZ2luLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVPcmlnaW4uaAkocmV2aXNpb24g MTcyNzk3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVPcmlnaW4uaAko d29ya2luZyBjb3B5KQpAQCAtMTYwLDcgKzE2MCw3IEBAIHN0cnVjdCBJbmxpbmVDYWxsRnJhbWUg ewogICAgIENvZGVPcmlnaW4gY2FsbGVyOwogICAgIEJpdFZlY3RvciBjYXB0dXJlZFZhcnM7IC8v IEluZGV4ZWQgYnkgdGhlIG1hY2hpbmUgY2FsbCBmcmFtZSdzIHZhcmlhYmxlIG51bWJlcmluZy4K ICAgICBzaWduZWQgc3RhY2tPZmZzZXQgOiAzMDsKLSAgICBLaW5kIGtpbmQgOiAyOworICAgIHVu c2lnbmVkIGtpbmQgOiAyOyAvLyByZWFsIHR5cGUgaXMgS2luZAogICAgIGJvb2wgaXNDbG9zdXJl Q2FsbCA6IDE7IC8vIElmIGZhbHNlIHRoZW4gd2Uga25vdyB0aGF0IGNhbGxlZS9zY29wZSBhcmUg Y29uc3RhbnRzIGFuZCB0aGUgREZHIHdvbid0IHRyZWF0IHRoZW0gYXMgdmFyaWFibGVzLCBpLmUu IHRoZXkgaGF2ZSB0byBiZSByZWNvdmVyZWQgbWFudWFsbHkuCiAgICAgVmlydHVhbFJlZ2lzdGVy IGFyZ3VtZW50c1JlZ2lzdGVyOyAvLyBUaGlzIGlzIG9ubHkgc2V0IGlmIHRoZSBjb2RlIHVzZXMg YXJndW1lbnRzLiBUaGUgdW5tb2RpZmllZCBhcmd1bWVudHMgcmVnaXN0ZXIgZm9sbG93cyB0aGUg dW5tb2RpZmllZEFyZ3VtZW50c1JlZ2lzdGVyKCkgY29udmVudGlvbiAoc2VlIENvZGVCbG9jay5o KS4KICAgICAKQEAgLTE3NCw3ICsxNzQsNyBAQCBzdHJ1Y3QgSW5saW5lQ2FsbEZyYW1lIHsKICAg ICB7CiAgICAgfQogICAgIAotICAgIENvZGVTcGVjaWFsaXphdGlvbktpbmQgc3BlY2lhbGl6YXRp b25LaW5kKCkgY29uc3QgeyByZXR1cm4gc3BlY2lhbGl6YXRpb25LaW5kRm9yKGtpbmQpOyB9Cisg ICAgQ29kZVNwZWNpYWxpemF0aW9uS2luZCBzcGVjaWFsaXphdGlvbktpbmQoKSBjb25zdCB7IHJl dHVybiBzcGVjaWFsaXphdGlvbktpbmRGb3Ioc3RhdGljX2Nhc3Q8S2luZD4oa2luZCkpOyB9CiAK ICAgICBKU0Z1bmN0aW9uKiBjYWxsZWVDb25zdGFudCgpIGNvbnN0CiAgICAgewo=