136096 2014-08-19 23:00:52 -0700 [EFL][WK2] Layout Test storage/websql/sql-error-codes.html is passed 2014-08-20 04:40:51 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 shiva.jm webkit-unassigned bunhere cdumez commit-queue gyuyoung.kim lucas.de.marchi sergio oldest_to_newest 1030218 0 shiva.jm 2014-08-19 23:00:52 -0700 Layout Test storage/websql/sql-error-codes.html is no longer generating failure, it is passed in latest builds. 1030219 1 236855 shiva.jm 2014-08-19 23:07:53 -0700 Created attachment 236855 Patch Layout Test storage/websql/sql-error-codes.html is no longer generating failure, it is passed in latest builds. 1030226 2 236855 g.czajkowski 2014-08-20 00:03:52 -0700 Comment on attachment 236855 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236855&action=review > LayoutTests/ChangeLog:8 > + Layout Test storage/websql/sql-error-codes.html is no longer generating failure, it is passed in latest builds. Nit: personally, I am in favor of adding the revision affecting layout test success/failure. That brings us information what change makes it better or worse. > LayoutTests/platform/efl/TestExpectations:745 > +webkit.org/b/108355 storage/websql/sql-error-codes.html [ Pass ] If it passes just remove its failure expectation. Did you check debug build as well? 1030242 3 236855 mpakulavelrutka 2014-08-20 00:56:06 -0700 Comment on attachment 236855 Patch This test still fails on EFL bot: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Fwebsql%2Fsql-error-codes.html 1030250 4 236864 shiva.jm 2014-08-20 02:44:15 -0700 Created attachment 236864 Patch-Updated Update the patch with comments, these test passed in my local build always. 1030255 5 236864 mpakulavelrutka 2014-08-20 04:31:04 -0700 Comment on attachment 236864 Patch-Updated View in context: https://bugs.webkit.org/attachment.cgi?id=236864&action=review I checked on my local machine and the test fails the same as on bot. Anyway we cannot take results from our local machines as a reference point, instead we should rely only on build bot results. > LayoutTests/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Gardening does not require review, next time please replace this line with something like: Unreviewed gardening and set only cq? leaving r flag not set. > LayoutTests/platform/efl/TestExpectations:745 > +webkit.org/b/108355 storage/websql/sql-error-codes.html Still if test starts to pass you should remove whole entry, not remove the modifier. Now leaving a test name without modifier means the same as [ Skip ]. 1030257 6 shiva.jm 2014-08-20 04:38:55 -0700 (In reply to comment #5) > (From update of attachment 236864 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236864&action=review > > I checked on my local machine and the test fails the same as on bot. Anyway we cannot take results from our local machines as a reference point, instead we should rely only on build bot results. > > > LayoutTests/ChangeLog:6 > > + Reviewed by NOBODY (OOPS!). > > Gardening does not require review, next time please replace this line with something like: Unreviewed gardening and set only cq? leaving r flag not set. > > > LayoutTests/platform/efl/TestExpectations:745 > > +webkit.org/b/108355 storage/websql/sql-error-codes.html > > Still if test starts to pass you should remove whole entry, not remove the modifier. Now leaving a test name without modifier means the same as [ Skip ]. Dear Michal, Thanks for the inputs, will take care these things for next submissions. I will close these issue as not fix. Thanks 236855 2014-08-19 23:07:53 -0700 2014-08-20 02:44:15 -0700 Patch bug-136096.patch text/plain 1457 shiva.jm SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE3Mjc5NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA4LTE5ICBTaGl2YWt1bWFyIEpNICA8 c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBMYXlvdXQgVGVzdCBz dG9yYWdlL3dlYnNxbC9zcWwtZXJyb3ItY29kZXMuaHRtbCBpcyBwYXNzZWQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYwOTYuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGF5b3V0IFRlc3Qgc3RvcmFn ZS93ZWJzcWwvc3FsLWVycm9yLWNvZGVzLmh0bWwgaXMgbm8gbG9uZ2VyIGdlbmVyYXRpbmcgZmFp bHVyZSwgaXQgaXMgcGFzc2VkIGluIGxhdGVzdCBidWlsZHMuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9lZmwvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNC0wOC0xOSAgSmlud29vIFNvbmcgIDxqaW53 b283LnNvbmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgSWdub3JlIHVzZW1hcCBhdHRyaWJ1dGVz IHdpdGhvdXQgJyMnIGluIGltZyBlbGVtZW50CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9l ZmwvVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9l ZmwvVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24gMTcyNzk2KQorKysgTGF5b3V0VGVzdHMvcGxh dGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkKQEAgLTc0Miw3ICs3NDIs NyBAQCB3ZWJraXQub3JnL2IvMTA4MjU3IGNvbXBvc2l0aW5nL292ZXJmbG93CiB3ZWJraXQub3Jn L2IvMTA4MjU3IGNvbXBvc2l0aW5nL292ZXJmbG93L2NvbXBvc2l0ZWQtc2Nyb2xsaW5nLWNyZWF0 ZXMtYS1zdGFja2luZy1jb250YWluZXIuaHRtbCBbIE1pc3NpbmcgRmFpbHVyZSBdCiAKICMgQXNz ZXJ0cyB3aGVuIGRlc3Ryb3lpbmcgV2ViQ29yZTo6RGF0YWJhc2UgKHBvc3NpYmx5IGJlY2F1c2Ug cjE0MTIwNykKLXdlYmtpdC5vcmcvYi8xMDgzNTUgc3RvcmFnZS93ZWJzcWwvc3FsLWVycm9yLWNv ZGVzLmh0bWwgWyBGYWlsdXJlIF0KK3dlYmtpdC5vcmcvYi8xMDgzNTUgc3RvcmFnZS93ZWJzcWwv c3FsLWVycm9yLWNvZGVzLmh0bWwgWyBQYXNzIF0KIAogIyBMaWJzb3VwIDIuNDIuMCByZWdyZXNz aW9ucwogd2Via2l0Lm9yZy9iLzExNDkxOCBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2NhY2hl LW92ZXJyaWRlLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQo= 236864 2014-08-20 02:44:15 -0700 2014-08-20 04:31:03 -0700 Patch-Updated bug-136096-updated.patch text/plain 1469 shiva.jm SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE3Mjc5NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA4LTE5ICBTaGl2YWt1bWFyIEpNICA8 c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBMYXlvdXQgVGVzdCBz dG9yYWdlL3dlYnNxbC9zcWwtZXJyb3ItY29kZXMuaHRtbCBpcyBwYXNzZWQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYwOTYuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGF5b3V0IFRlc3Qgc3RvcmFn ZS93ZWJzcWwvc3FsLWVycm9yLWNvZGVzLmh0bWwgaXMgbm8gbG9uZ2VyIGdlbmVyYXRpbmcgZmFp bHVyZSwgaXQgaXMgcGFzc2VkIGluIGxhdGVzdCBidWlsZHMgd2l0aCByZXZpc2lvbiAxNzI3OTYu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNC0wOC0x OSAgSmlud29vIFNvbmcgIDxqaW53b283LnNvbmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgSWdu b3JlIHVzZW1hcCBhdHRyaWJ1dGVzIHdpdGhvdXQgJyMnIGluIGltZyBlbGVtZW50CkluZGV4OiBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24gMTcyNzk2 KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcg Y29weSkKQEAgLTc0Miw3ICs3NDIsNyBAQCB3ZWJraXQub3JnL2IvMTA4MjU3IGNvbXBvc2l0aW5n L292ZXJmbG93CiB3ZWJraXQub3JnL2IvMTA4MjU3IGNvbXBvc2l0aW5nL292ZXJmbG93L2NvbXBv c2l0ZWQtc2Nyb2xsaW5nLWNyZWF0ZXMtYS1zdGFja2luZy1jb250YWluZXIuaHRtbCBbIE1pc3Np bmcgRmFpbHVyZSBdCiAKICMgQXNzZXJ0cyB3aGVuIGRlc3Ryb3lpbmcgV2ViQ29yZTo6RGF0YWJh c2UgKHBvc3NpYmx5IGJlY2F1c2UgcjE0MTIwNykKLXdlYmtpdC5vcmcvYi8xMDgzNTUgc3RvcmFn ZS93ZWJzcWwvc3FsLWVycm9yLWNvZGVzLmh0bWwgWyBGYWlsdXJlIF0KK3dlYmtpdC5vcmcvYi8x MDgzNTUgc3RvcmFnZS93ZWJzcWwvc3FsLWVycm9yLWNvZGVzLmh0bWwKIAogIyBMaWJzb3VwIDIu NDIuMCByZWdyZXNzaW9ucwogd2Via2l0Lm9yZy9iLzExNDkxOCBodHRwL3Rlc3RzL3htbGh0dHBy ZXF1ZXN0L2NhY2hlLW92ZXJyaWRlLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQo=