136093 2014-08-19 19:40:06 -0700 GCC fails on #pragma clang diagnostic after r172756 2014-08-19 19:51:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 akiss webkit-unassigned fpizlo gyuyoung.kim mmirman ossy oldest_to_newest 1030194 0 akiss 2014-08-19 19:40:06 -0700 GCC emits the following error messages when building jsc: /home/akiss/devel/WebKit/Source/JavaScriptCore/runtime/JSDataViewPrototype.cpp:211:0: error: ignoring #pragma clang diagnostic [-Werror=unknown-pragmas] /home/akiss/devel/WebKit/Source/JavaScriptCore/runtime/JSDataViewPrototype.cpp:212:0: error: ignoring #pragma clang diagnostic [-Werror=unknown-pragmas] /home/akiss/devel/WebKit/Source/JavaScriptCore/runtime/JSDataViewPrototype.cpp:293:0: error: ignoring #pragma clang diagnostic [-Werror=unknown-pragmas] cc1plus: all warnings being treated as errors make[3]: *** [Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/JSDataViewPrototype.cpp.o] Error 1 1030195 1 236849 akiss 2014-08-19 19:44:28 -0700 Created attachment 236849 Proposed patch. 1030199 2 236849 akiss 2014-08-19 19:50:04 -0700 Comment on attachment 236849 Proposed patch. r172793 fixed it already 236849 2014-08-19 19:44:28 -0700 2014-08-19 19:50:04 -0700 Proposed patch. 0001-Build-fix-for-non-clang-builds-after-r172756.patch text/plain 1846 akiss RnJvbSBlYWU3ZTZhNzMzYzQwMDYyNjRiODA0MGU4MGE1NTUzY2UzMjg1ZjE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBa29zIEtpc3MgPGFraXNzQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogV2VkLCAyMCBBdWcgMjAxNCAwNDo0MjozNiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEJ1aWxk IGZpeCBmb3Igbm9uLWNsYW5nIGJ1aWxkcyBhZnRlciByMTcyNzU2CgotLS0KIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgIHwgMTEgKysrKysrKysr KysKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTRGF0YVZpZXdQcm90b3R5cGUuY3Bw IHwgIDQgKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKaW5kZXggZDg4NTIxZi4uZDk5ZGZkYSAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDgtMTkgIEFrb3MgS2lzcyAgPGFraXNzQGluZi51 LXN6ZWdlZC5odT4KKworICAgICAgICBCdWlsZCBmaXggZm9yIG5vbi1jbGFuZyBidWlsZHMgYWZ0 ZXIgcjE3Mjc1NgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM2MDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgR3VhcmQgY2xhbmctc3BlY2lmaWMgZGlhZ25vc3RpYyBwcmFnbWFzIHdpdGggI2lmZGVmIF9f Y2xhbmdfXy4KKworICAgICAgICAqIHJ1bnRpbWUvSlNEYXRhVmlld1Byb3RvdHlwZS5jcHA6CisK IDIwMTQtMDgtMTkgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAg ICAgQ3Jhc2ggaW4ganNjLWxheW91dC10ZXN0cy55YW1sL2pzL3NjcmlwdC10ZXN0cy9yZWVudHJh bnQtY2FjaGluZy5qcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNEYXRhVmlld1Byb3RvdHlwZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0RhdGFWaWV3UHJvdG90eXBlLmNwcAppbmRleCA5NDcyZDJkLi44NTg0M2ViIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0RhdGFWaWV3UHJvdG90eXBlLmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0RhdGFWaWV3UHJvdG90eXBlLmNw cApAQCAtMjA4LDggKzIwOCwxMCBAQCBFbmNvZGVkSlNWYWx1ZSBzZXREYXRhKEV4ZWNTdGF0ZSog ZXhlYykKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOwogfQogCisj aWZkZWYgX19jbGFuZ19fCiAjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcHVzaAogI3ByYWdtYSBj bGFuZyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XbWlzc2luZy1wcm90b3R5cGVzIgorI2VuZGlmCiAK IEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZGF0YVZpZXdQcm90b0Z1bmNHZXRJbnQ4KEV4 ZWNTdGF0ZSogZXhlYykKIHsKQEAgLTI5MCw2ICsyOTIsOCBAQCBFbmNvZGVkSlNWYWx1ZSBKU0Nf SE9TVF9DQUxMIGRhdGFWaWV3UHJvdG9GdW5jU2V0RmxvYXQ2NChFeGVjU3RhdGUqIGV4ZWMpCiB7 CiAgICAgcmV0dXJuIHNldERhdGE8RmxvYXQ2NEFkYXB0b3I+KGV4ZWMpOwogfQorI2lmZGVmIF9f Y2xhbmdfXwogI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIHBvcAorI2VuZGlmCiAKIH0gLy8gbmFt ZXNwYWNlIEpTQwotLSAKMS45LjEKCg==