136088 2014-08-19 17:58:11 -0700 Fix how CodeBlock dumps the opcode op_profile_type 2014-08-20 19:30:02 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam commit-queue oldest_to_newest 1030169 0 saam 2014-08-19 17:58:11 -0700 Currently, the implementation doesn't increment the iterator enough times to go through all arguments. This never got done when the other patch that incremented the number of arguments the opcode receives was landed. 1030432 1 236906 saam 2014-08-20 18:47:33 -0700 Created attachment 236906 patch Fixes the bug. 1030433 2 236907 saam 2014-08-20 18:49:15 -0700 Created attachment 236907 patch Fix problem w/ above patch's ChangeLog incorrect spacing for bug description. 1030435 3 236907 commit-queue 2014-08-20 19:30:00 -0700 Comment on attachment 236907 patch Clearing flags on attachment: 236907 Committed r172822: <http://trac.webkit.org/changeset/172822> 1030436 4 commit-queue 2014-08-20 19:30:02 -0700 All reviewed patches have been landed. Closing bug. 236906 2014-08-20 18:47:33 -0700 2014-08-20 18:49:15 -0700 patch patch.diff text/plain 1528 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyODIxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTA4LTIwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEZpeCBob3cgQ29kZUJsb2NrIGR1bXBzIHRoZSBvcGNvZGUgb3BfcHJvZmlsZV90eXBlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYwODgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworb3BfcHJvZmlsZV90eXBlIHdhcyBt b2RpZmllZCB0byByZWNlaXZlIHR3byBleHRyYSBhcmd1bWVudHMsCitidXQgaXRzIGR1bXAgaW4g Q29kZUJsb2NrOjpkdW1wQnl0ZWNvZGUgd2Fzbid0IGNoYW5nZWQgdG8gCithY2NvdW50IGZvciB0 aGlzLCBzbyBpdCBicm9rZSBDb2RlQmxvY2s6OmR1bXBCeXRlY29kZSB3aGVuCitvcF9wcm9maWxl X3R5cGUgd2FzIGluIHRoZSBzdHJlYW0gb2YgYnl0ZWNvZGUgaW5zdHJ1Y3Rpb25zLgorQ29kZUJs b2NrOjpkdW1wQnl0ZWNvZGUgbm93IGFjY291bnRzIGZvciB0aGUgY2hhbmdlIGluIAorb3BfcHJv ZmlsZV90eXBlJ3MgYXJpdHkuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgor ICAgICAgICAoSlNDOjpDb2RlQmxvY2s6OmR1bXBCeXRlY29kZSk6CisKIDIwMTQtMDgtMjAgIFNh YW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIEhpZ2hGaWRl bGl0eVR5cGVQcm9maWxpbmcgdmFyaWFibGVzIGZvciBtb3JlIGNsYXJpdHkKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCShyZXZpc2lvbiAxNzI4 MjEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAkod29y a2luZyBjb3B5KQpAQCAtODQzLDYgKzg0Myw4IEBAIHZvaWQgQ29kZUJsb2NrOjpkdW1wQnl0ZWNv ZGUoCiAgICAgICAgICAgICBpbnQgcjAgPSAoKytpdCktPnUub3BlcmFuZDsKICAgICAgICAgICAg ICsraXQ7CiAgICAgICAgICAgICArK2l0OworICAgICAgICAgICAgKytpdDsKKyAgICAgICAgICAg ICsraXQ7CiAgICAgICAgICAgICBwcmludExvY2F0aW9uQW5kT3Aob3V0LCBleGVjLCBsb2NhdGlv biwgaXQsICJvcF9wcm9maWxlX3R5cGUiKTsKICAgICAgICAgICAgIG91dC5wcmludGYoIiVzIiwg cmVnaXN0ZXJOYW1lKHIwKS5kYXRhKCkpOwogICAgICAgICAgICAgYnJlYWs7Cg== 236907 2014-08-20 18:49:15 -0700 2014-08-20 19:30:00 -0700 patch patch.diff text/plain 1576 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyODIxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTA4LTIwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEZpeCBob3cgQ29kZUJsb2NrIGR1bXBzIHRoZSBvcGNvZGUgb3BfcHJvZmlsZV90eXBlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYwODgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBvcF9wcm9maWxlX3R5 cGUgd2FzIG1vZGlmaWVkIHRvIHJlY2VpdmUgdHdvIGV4dHJhIGFyZ3VtZW50cywKKyAgICAgICAg YnV0IGl0cyBkdW1wIGluIENvZGVCbG9jazo6ZHVtcEJ5dGVjb2RlIHdhc24ndCBjaGFuZ2VkIHRv IAorICAgICAgICBhY2NvdW50IGZvciB0aGlzLCBzbyBpdCBicm9rZSBDb2RlQmxvY2s6OmR1bXBC eXRlY29kZSB3aGVuCisgICAgICAgIG9wX3Byb2ZpbGVfdHlwZSB3YXMgaW4gdGhlIHN0cmVhbSBv ZiBieXRlY29kZSBpbnN0cnVjdGlvbnMuCisgICAgICAgIENvZGVCbG9jazo6ZHVtcEJ5dGVjb2Rl IG5vdyBhY2NvdW50cyBmb3IgdGhlIGNoYW5nZSBpbiAKKyAgICAgICAgb3BfcHJvZmlsZV90eXBl J3MgYXJpdHkuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAgICAgICAo SlNDOjpDb2RlQmxvY2s6OmR1bXBCeXRlY29kZSk6CisKIDIwMTQtMDgtMjAgIFNhYW0gQmFyYXRp ICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIEhpZ2hGaWRlbGl0eVR5cGVQ cm9maWxpbmcgdmFyaWFibGVzIGZvciBtb3JlIGNsYXJpdHkKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCShyZXZpc2lvbiAxNzI4MjEpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtODQzLDYgKzg0Myw4IEBAIHZvaWQgQ29kZUJsb2NrOjpkdW1wQnl0ZWNvZGUoCiAgICAg ICAgICAgICBpbnQgcjAgPSAoKytpdCktPnUub3BlcmFuZDsKICAgICAgICAgICAgICsraXQ7CiAg ICAgICAgICAgICArK2l0OworICAgICAgICAgICAgKytpdDsKKyAgICAgICAgICAgICsraXQ7CiAg ICAgICAgICAgICBwcmludExvY2F0aW9uQW5kT3Aob3V0LCBleGVjLCBsb2NhdGlvbiwgaXQsICJv cF9wcm9maWxlX3R5cGUiKTsKICAgICAgICAgICAgIG91dC5wcmludGYoIiVzIiwgcmVnaXN0ZXJO YW1lKHIwKS5kYXRhKCkpOwogICAgICAgICAgICAgYnJlYWs7Cg==