136068 2014-08-19 04:31:29 -0700 JSC_timeout is hard-coded in run-javascriptcore-test 2014-08-20 20:49:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 akiss webkit-unassigned commit-queue darin fpizlo ossy oldest_to_newest 1029998 0 akiss 2014-08-19 04:31:29 -0700 Currently, the value of the JSC_timeout environment variable is unconditionally set to 60 (seconds). On some platforms, that's overly restrictive since the running time of some jsc tests can exceed 60 seconds (not because of hanging, just running slowly). The caller of run-javascriptcore-tests should be able to increase/set this timeout value to get valid results. 1030000 1 236808 akiss 2014-08-19 04:38:55 -0700 Created attachment 236808 Proposed patch. This patch allows changing the timeout for jsc tests by defining JSC_timeout in advance, e.g., as follows: JSC_timeout=120 Tools/Scripts/run-javascriptcore-tests 1030009 2 236808 ossy 2014-08-19 04:53:41 -0700 Comment on attachment 236808 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=236808&action=review > Tools/Scripts/run-javascriptcore-tests:151 > +$ENV{JSC_timeout} = 60 if (!defined($ENV{JSC_timeout})); # Set a 60 second timeout on all jsc tests (if environment variable not defined already). I think we can do it in a simpler way: $ENV{JSC_timeout} = 60 unless $ENV{JSC_timeout}; 1030012 3 236810 akiss 2014-08-19 05:30:01 -0700 Created attachment 236810 Proposed patch, v2 Made the change more perlish, according to the review. 1030013 4 236810 ossy 2014-08-19 05:30:57 -0700 Comment on attachment 236810 Proposed patch, v2 LGTM 1030015 5 236810 commit-queue 2014-08-19 06:09:40 -0700 Comment on attachment 236810 Proposed patch, v2 Clearing flags on attachment: 236810 Committed r172751: <http://trac.webkit.org/changeset/172751> 1030016 6 commit-queue 2014-08-19 06:09:43 -0700 All reviewed patches have been landed. Closing bug. 236808 2014-08-19 04:38:55 -0700 2014-08-19 05:30:01 -0700 Proposed patch. 0001-Let-the-caller-define-JSC_timeout-for-run-javascript.patch text/plain 1699 akiss RnJvbSAwNDZkYTU5ZjYyZmVmNDRmNGMyYjUwYWFkM2Q1NDYwZTEwMGE3YWExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBa29zIEtpc3MgPGFraXNzQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogVHVlLCAxOSBBdWcgMjAxNCAxMzozMjoyMiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIExldCB0 aGUgY2FsbGVyIGRlZmluZSBKU0NfdGltZW91dCBmb3IKIHJ1bi1qYXZhc2NyaXB0Y29yZS10ZXN0 cwoKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICB8IDEyICsrKysr KysrKysrKwogVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMgfCAgMiArLQog MiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGY2ZmM0OTUuLjkz ZmY2YWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNSBAQAorMjAxNC0wOC0xOSAgQWtvcyBLaXNzICA8YWtpc3NAaW5mLnUtc3pl Z2VkLmh1PgorCisgICAgICAgIExldCB0aGUgY2FsbGVyIGRlZmluZSBKU0NfdGltZW91dCBmb3Ig cnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzYwNjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBLZWVwIHRoZSA2MCBzZWNvbmQgdGltZW91dCBmb3IganNjIHRlc3Rz IGFzIHRoZSBkZWZhdWx0IHNldHRpbmcgYnV0CisgICAgICAgIGRvbid0IG92ZXJyaWRlIHRoZSB2 YWx1ZSBvZiBKU0NfdGltZW91dCBpZiBhbHJlYWR5IHNldC4KKworICAgICAgICAqIFNjcmlwdHMv cnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzOgorCiAyMDE0LTA4LTE4ICBTaW1vbiBGcmFzZXIgIDxz aW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEVuYWJsZSBXZWIgSW5zcGVjdG9yIGlu IE1pbmlCcm93c2VyIFdLMiB3aW5kb3dzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1q YXZhc2NyaXB0Y29yZS10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRl c3RzCmluZGV4IDlmMzg3OTIuLmYyMzU4NTYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVu LWphdmFzY3JpcHRjb3JlLXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRj b3JlLXRlc3RzCkBAIC0xNDgsNyArMTQ4LDcgQEAgaWYgKCFkZWZpbmVkKCRyb290KSAmJiAkYnVp bGRKU0MpIHsKIAogbXkgJHByb2R1Y3REaXIgPSBqc2NQcm9kdWN0RGlyKCk7CiAkRU5We0RZTERf RlJBTUVXT1JLX1BBVEh9ID0gJHByb2R1Y3REaXI7Ci0kRU5We0pTQ190aW1lb3V0fSA9IDYwOyAj IFNldCBhIDYwIHNlY29uZCB0aW1lb3V0IG9uIGFsbCBqc2MgdGVzdHMuCiskRU5We0pTQ190aW1l b3V0fSA9IDYwIGlmICghZGVmaW5lZCgkRU5We0pTQ190aW1lb3V0fSkpOyAjIFNldCBhIDYwIHNl Y29uZCB0aW1lb3V0IG9uIGFsbCBqc2MgdGVzdHMgKGlmIGVudmlyb25tZW50IHZhcmlhYmxlIG5v dCBkZWZpbmVkIGFscmVhZHkpLgogc2V0UGF0aEZvclJ1bm5pbmdXZWJLaXRBcHAoXCVFTlYpIGlm IGlzQ3lnd2luKCk7CiAKIHN1YiB0ZXN0YXBpUGF0aCgkKQotLSAKMS45LjEKCg== 236810 2014-08-19 05:30:01 -0700 2014-08-19 06:09:40 -0700 Proposed patch, v2 fix-run-jsc-tests-timeout-v2.patch text/plain 1288 akiss ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmNmZj NDk1Li45M2ZmNmFkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDgtMTkgIEFrb3MgS2lzcyAgPGFraXNzQGlu Zi51LXN6ZWdlZC5odT4KKworICAgICAgICBMZXQgdGhlIGNhbGxlciBkZWZpbmUgSlNDX3RpbWVv dXQgZm9yIHJ1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2MDY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgS2VlcCB0aGUgNjAgc2Vjb25kIHRpbWVvdXQgZm9yIGpz YyB0ZXN0cyBhcyB0aGUgZGVmYXVsdCBzZXR0aW5nIGJ1dAorICAgICAgICBkb24ndCBvdmVycmlk ZSB0aGUgdmFsdWUgb2YgSlNDX3RpbWVvdXQgaWYgYWxyZWFkeSBzZXQuCisKKyAgICAgICAgKiBT Y3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0czoKKwogMjAxNC0wOC0xOCAgU2ltb24gRnJh c2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgV2ViIEluc3Bl Y3RvciBpbiBNaW5pQnJvd3NlciBXSzIgd2luZG93cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0 Y29yZS10ZXN0cwppbmRleCA5ZjM4NzkyLi5lMDU4NTlkIDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qYXZh c2NyaXB0Y29yZS10ZXN0cwpAQCAtMTQ4LDcgKzE0OCw3IEBAIGlmICghZGVmaW5lZCgkcm9vdCkg JiYgJGJ1aWxkSlNDKSB7CiAKIG15ICRwcm9kdWN0RGlyID0ganNjUHJvZHVjdERpcigpOwogJEVO VntEWUxEX0ZSQU1FV09SS19QQVRIfSA9ICRwcm9kdWN0RGlyOwotJEVOVntKU0NfdGltZW91dH0g PSA2MDsgIyBTZXQgYSA2MCBzZWNvbmQgdGltZW91dCBvbiBhbGwganNjIHRlc3RzLgorJEVOVntK U0NfdGltZW91dH0gPSA2MCB1bmxlc3MgJEVOVntKU0NfdGltZW91dH07ICMgU2V0IGEgNjAgc2Vj b25kIHRpbWVvdXQgb24gYWxsIGpzYyB0ZXN0cyAoaWYgZW52aXJvbm1lbnQgdmFyaWFibGUgbm90 IGRlZmluZWQgYWxyZWFkeSkuCiBzZXRQYXRoRm9yUnVubmluZ1dlYktpdEFwcChcJUVOVikgaWYg aXNDeWd3aW4oKTsKIAogc3ViIHRlc3RhcGlQYXRoKCQpCg==