136061 2014-08-18 22:13:03 -0700 Extend injected bundle node snapshotting to support forced white and black text 2014-08-19 11:32:47 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 136076 1 prandolph webkit-unassigned bdakin commit-queue oldest_to_newest 1029952 0 prandolph 2014-08-18 22:13:03 -0700 It would be convenient to allow black and white text snapshotting options on injected bundle nodes. 1029954 1 236800 prandolph 2014-08-18 22:14:50 -0700 Created attachment 236800 Patch 1030076 2 236800 commit-queue 2014-08-19 11:32:44 -0700 Comment on attachment 236800 Patch Clearing flags on attachment: 236800 Committed r172755: <http://trac.webkit.org/changeset/172755> 1030077 3 commit-queue 2014-08-19 11:32:47 -0700 All reviewed patches have been landed. Closing bug. 236800 2014-08-18 22:14:50 -0700 2014-08-19 11:32:44 -0700 Patch bug-136061-20140818221441.patch text/plain 4656 prandolph U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjAwZGFjOGU3NWFhMzUz YWRlNDM0Y2QyNDI4MDMzMWJlYjY4M2E2ZC4uOTJkNzVjNGI2ZWRlMGE3MDkwZjFhOWYyMDg3MjA4 ZTk4NDA2ZGVlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE0LTA4LTE4ICBQZXl0 b24gUmFuZG9scGggIDxwcmFuZG9scGhAYXBwbGUuY29tPgogCisgICAgICAgIEV4dGVuZCBpbmpl Y3RlZCBidW5kbGUgbm9kZSBzbmFwc2hvdHRpbmcgdG8gc3VwcG9ydCBmb3JjZWQgd2hpdGUgYW5k IGJsYWNrIHRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNjA2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2hhcmVkL0FQSS9jL1dLSW1hZ2UuaDoKKyAgICAgICAgQWRkIC1Gb3JjZUJsYWNrVGV4 dCBhbmQgLUZvcmNlV2hpdGVUZXh0IHNuYXBzaG90dGluZyBvcHRpb25zLgorICAgICAgICAqIFNo YXJlZC9BUEkvYy9XS1NoYXJlZEFQSUNhc3QuaDoKKyAgICAgICAgKFdlYktpdDo6dG9TbmFwc2hv dE9wdGlvbnMpOgorICAgICAgICBTdXBwb3J0IGFmb3JlbWVudGlvbmVkIHRleHQgc25hcHNob3R0 aW5nIG9wdGlvbnMuCisgICAgICAgICogU2hhcmVkL0ltYWdlT3B0aW9ucy5oOgorICAgICAgICAq IFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvRE9NL0luamVjdGVkQnVuZGxlTm9kZUhhbmRsZS5j cHA6CisgICAgICAgIChXZWJLaXQ6OmltYWdlRm9yUmVjdCk6CisgICAgICAgIFJlc3BlY3QgdGV4 dCBjb2xvciBzbmFwc2hvdHRpbmcgb3B0aW9ucyBieSBzZXR0aW5nIGFwcHJvcHJpYXRlIHBhaW50 IGJlaGF2aW9ycy4KKworMjAxNC0wOC0xOCAgUGV5dG9uIFJhbmRvbHBoICA8cHJhbmRvbHBoQGFw cGxlLmNvbT4KKwogICAgICAgICBFeHBvc2UgbG9uZyBtb3VzZSBwcmVzcyBXZWJLaXQgQVBJLiBQ YXJ0IG9mIDEzNTI1NyAtIEFkZCBsb25nIG1vdXNlIHByZXNzIGdlc3R1cmUKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjA0OAogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tJbWFnZS5oIGIvU291cmNlL1dlYktpdDIv U2hhcmVkL0FQSS9jL1dLSW1hZ2UuaAppbmRleCBjZTZlZmU1NjYxN2IwMDJkZWZhODAwZmMzN2M2 NzA2ZTQ4MWRkZGZiLi44ZGQ1NmNjNzlkZTIwZjNjNjE3MmRjM2MxM2EyOTJkMDE2YWYwNjdmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tJbWFnZS5oCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9XS0ltYWdlLmgKQEAgLTQyLDcgKzQyLDkgQEAgZW51 bSB7CiAgICAga1dLU25hcHNob3RPcHRpb25zU2hhcmVhYmxlID0gMSA8PCAwLAogICAgIGtXS1Nu YXBzaG90T3B0aW9uc0V4Y2x1ZGVTZWxlY3Rpb25IaWdobGlnaHRpbmcgPSAxIDw8IDEsCiAgICAg a1dLU25hcHNob3RPcHRpb25zSW5WaWV3Q29vcmRpbmF0ZXMgPSAxIDw8IDIsCi0gICAga1dLU25h cHNob3RPcHRpb25zUGFpbnRTZWxlY3Rpb25SZWN0YW5nbGUgPSAxIDw8IDMKKyAgICBrV0tTbmFw c2hvdE9wdGlvbnNQYWludFNlbGVjdGlvblJlY3RhbmdsZSA9IDEgPDwgMywKKyAgICBrV0tTbmFw c2hvdE9wdGlvbnNGb3JjZUJsYWNrVGV4dCA9IDEgPDwgNCwKKyAgICBrV0tTbmFwc2hvdE9wdGlv bnNGb3JjZVdoaXRlVGV4dCA9IDEgPDwgNSwKIH07CiB0eXBlZGVmIHVpbnQzMl90IFdLU25hcHNo b3RPcHRpb25zOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tT aGFyZWRBUElDYXN0LmggYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tTaGFyZWRBUElD YXN0LmgKaW5kZXggY2ZlNzc5MjUxYWM1NjU0ZDEwZDNjNmNjNzZjZDNhMWI1NmIyMjI1Ni4uMDI2 YmExYTQxOWUxYzIxZDA5MzY3YWU2ZmE4NDQxYWEwODdkZjlmZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2FzdC5oCisrKyBiL1NvdXJjZS9XZWJL aXQyL1NoYXJlZC9BUEkvYy9XS1NoYXJlZEFQSUNhc3QuaApAQCAtODkxLDYgKzg5MSwxMCBAQCBp bmxpbmUgU25hcHNob3RPcHRpb25zIHRvU25hcHNob3RPcHRpb25zKFdLU25hcHNob3RPcHRpb25z IHdrU25hcHNob3RPcHRpb25zKQogICAgICAgICBzbmFwc2hvdE9wdGlvbnMgfD0gU25hcHNob3RP cHRpb25zSW5WaWV3Q29vcmRpbmF0ZXM7CiAgICAgaWYgKHdrU25hcHNob3RPcHRpb25zICYga1dL U25hcHNob3RPcHRpb25zUGFpbnRTZWxlY3Rpb25SZWN0YW5nbGUpCiAgICAgICAgIHNuYXBzaG90 T3B0aW9ucyB8PSBTbmFwc2hvdE9wdGlvbnNQYWludFNlbGVjdGlvblJlY3RhbmdsZTsKKyAgICBp ZiAod2tTbmFwc2hvdE9wdGlvbnMgJiBrV0tTbmFwc2hvdE9wdGlvbnNGb3JjZUJsYWNrVGV4dCkK KyAgICAgICAgc25hcHNob3RPcHRpb25zIHw9IFNuYXBzaG90T3B0aW9uc0ZvcmNlQmxhY2tUZXh0 OworICAgIGlmICh3a1NuYXBzaG90T3B0aW9ucyAmIGtXS1NuYXBzaG90T3B0aW9uc0ZvcmNlV2hp dGVUZXh0KQorICAgICAgICBzbmFwc2hvdE9wdGlvbnMgfD0gU25hcHNob3RPcHRpb25zRm9yY2VX aGl0ZVRleHQ7CiAKICAgICByZXR1cm4gc25hcHNob3RPcHRpb25zOwogfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvU2hhcmVkL0ltYWdlT3B0aW9ucy5oIGIvU291cmNlL1dlYktpdDIvU2hh cmVkL0ltYWdlT3B0aW9ucy5oCmluZGV4IDhiNjZjMTk0YmRjMmM3YmZhM2FhNjlmMjQ4YWQ1ZDhk MTZjYTliNmUuLjk5YmE3OWY4ZGU4NWZjN2E0NmVlM2U3NTYyNWVmMjEzNWZlNTU1NjggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9JbWFnZU9wdGlvbnMuaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvSW1hZ2VPcHRpb25zLmgKQEAgLTM4LDYgKzM4LDggQEAgZW51bSB7CiAg ICAgU25hcHNob3RPcHRpb25zSW5WaWV3Q29vcmRpbmF0ZXMgPSAxIDw8IDIsCiAgICAgU25hcHNo b3RPcHRpb25zUGFpbnRTZWxlY3Rpb25SZWN0YW5nbGUgPSAxIDw8IDMsCiAgICAgU25hcHNob3RP cHRpb25zRXhjbHVkZURldmljZVNjYWxlRmFjdG9yID0gMSA8PCA1LAorICAgIFNuYXBzaG90T3B0 aW9uc0ZvcmNlQmxhY2tUZXh0ID0gMSA8PCA2LAorICAgIFNuYXBzaG90T3B0aW9uc0ZvcmNlV2hp dGVUZXh0ID0gMSA8PCA3LAogfTsKIHR5cGVkZWYgdWludDMyX3QgU25hcHNob3RPcHRpb25zOwog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0RP TS9JbmplY3RlZEJ1bmRsZU5vZGVIYW5kbGUuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9JbmplY3RlZEJ1bmRsZS9ET00vSW5qZWN0ZWRCdW5kbGVOb2RlSGFuZGxlLmNwcAppbmRleCBh YTZmNTU0ZmM1OTdjMDY5ZGJlYjA1MGE0OGNlNjlkNTAxYTk2NjUxLi5hOThjOTIzYzZmZWFkMzJl NGM1YThhMjE3Zjc3ZGI0MTdiNjFiNTYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL0luamVjdGVkQnVuZGxlL0RPTS9JbmplY3RlZEJ1bmRsZU5vZGVIYW5kbGUuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvRE9NL0luamVjdGVk QnVuZGxlTm9kZUhhbmRsZS5jcHAKQEAgLTE0NCw3ICsxNDQsMTYgQEAgc3RhdGljIFBhc3NSZWZQ dHI8V2ViSW1hZ2U+IGltYWdlRm9yUmVjdChGcmFtZVZpZXcqIGZyYW1lVmlldywgY29uc3QgSW50 UmVjdCYgcmUKICAgICBpZiAob3B0aW9ucyAmIFNuYXBzaG90T3B0aW9uc0V4Y2x1ZGVTZWxlY3Rp b25IaWdobGlnaHRpbmcpCiAgICAgICAgIHNob3VsZFBhaW50U2VsZWN0aW9uID0gRnJhbWVWaWV3 OjpFeGNsdWRlU2VsZWN0aW9uOwogCisgICAgUGFpbnRCZWhhdmlvciBwYWludEJlaGF2aW9yID0g ZnJhbWVWaWV3LT5wYWludEJlaGF2aW9yKCkgfCBQYWludEJlaGF2aW9yRmxhdHRlbkNvbXBvc2l0 aW5nTGF5ZXJzOworICAgIGlmIChvcHRpb25zICYgU25hcHNob3RPcHRpb25zRm9yY2VCbGFja1Rl eHQpCisgICAgICAgIHBhaW50QmVoYXZpb3IgfD0gUGFpbnRCZWhhdmlvckZvcmNlQmxhY2tUZXh0 OworICAgIGlmIChvcHRpb25zICYgU25hcHNob3RPcHRpb25zRm9yY2VXaGl0ZVRleHQpCisgICAg ICAgIHBhaW50QmVoYXZpb3IgfD0gUGFpbnRCZWhhdmlvckZvcmNlV2hpdGVUZXh0OworCisgICAg UGFpbnRCZWhhdmlvciBvbGRQYWludEJlaGF2aW9yID0gZnJhbWVWaWV3LT5wYWludEJlaGF2aW9y KCk7CisgICAgZnJhbWVWaWV3LT5zZXRQYWludEJlaGF2aW9yKHBhaW50QmVoYXZpb3IpOwogICAg IGZyYW1lVmlldy0+cGFpbnRDb250ZW50c0ZvclNuYXBzaG90KGdyYXBoaWNzQ29udGV4dC5nZXQo KSwgcmVjdCwgc2hvdWxkUGFpbnRTZWxlY3Rpb24sIEZyYW1lVmlldzo6RG9jdW1lbnRDb29yZGlu YXRlcyk7CisgICAgZnJhbWVWaWV3LT5zZXRQYWludEJlaGF2aW9yKG9sZFBhaW50QmVoYXZpb3Ip OwogCiAgICAgcmV0dXJuIHNuYXBzaG90LnJlbGVhc2UoKTsKIH0K