136050 2014-08-18 14:35:44 -0700 [JSC] Build error on ARM64 with gcc: signed/unsigned comparison error in JSC::GPRInfo::debugName 2014-08-21 01:59:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 akiss webkit-unassigned commit-queue dbates fpizlo msaboff ossy oldest_to_newest 1029880 0 akiss 2014-08-18 14:35:44 -0700 When compilig debug version of JSC for arm64 with gcc, the following error is raised: /home/akiss/devel/WebKit/Source/JavaScriptCore/jit/GPRInfo.h: In static member function ‘static const char* JSC::GPRInfo::debugName(JSC::GPRReg)’: /home/akiss/devel/WebKit/Source/JavaScriptCore/jit/GPRInfo.h:35:41: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] #define InvalidGPRReg ((::JSC::GPRReg)-1) ^ /home/akiss/devel/WebKit/Source/WTF/wtf/Assertions.h:237:8: note: in definition of macro ‘ASSERT’ (!(assertion) ? \ ^ /home/akiss/devel/WebKit/Source/JavaScriptCore/jit/GPRInfo.h:615:46: note: in expansion of macro ‘InvalidGPRReg’ ASSERT(static_cast<unsigned>(reg) != InvalidGPRReg); ^ 1029892 1 236788 akiss 2014-08-18 14:44:32 -0700 Created attachment 236788 Proposed patch. This change makes the ASSERT in the ARM64 version of GPRInfo::debugName the same as in the other implementations. 1029909 2 236788 commit-queue 2014-08-18 16:20:17 -0700 Comment on attachment 236788 Proposed patch. Clearing flags on attachment: 236788 Committed r172734: <http://trac.webkit.org/changeset/172734> 1029910 3 commit-queue 2014-08-18 16:20:19 -0700 All reviewed patches have been landed. Closing bug. 236788 2014-08-18 14:44:32 -0700 2014-08-18 16:20:16 -0700 Proposed patch. 0001-Fix-signed-unsigned-comparison-error-in-JSC-GPRInfo-.patch text/plain 1650 akiss RnJvbSBmYWYyODZjOTE4YzcwZjFhOTMyZWNjZDk4OGNlNWZkNmVlZTViYWViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBa29zIEtpc3MgPGFraXNzQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogTW9uLCAxOCBBdWcgMjAxNCAyMTozNzoyMiArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBz aWduZWQvdW5zaWduZWQgY29tcGFyaXNvbiBlcnJvciBpbgogSlNDOjpHUFJJbmZvOjpkZWJ1Z05h bWUKCi0tLQogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAgICAgfCAxMyArKysrKysr KysrKysrCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0dQUkluZm8uaCB8ICAyICstCiAyIGZp bGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwppbmRleCAxMTQxOTMyLi44YjQ0Y2JkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNC0wOC0xOCAgQWtvcyBLaXNzICA8YWtpc3NAaW5mLnUt c3plZ2VkLmh1PgorCisgICAgICAgIEZpeCBBU1NFUlQgaW4gQVJNNjQncyBKU0M6OkdQUkluZm86 OmRlYnVnTmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM2MDUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlIGNhc3Qgb2YgR1BSUmVnIHRvIHVuc2lnbmVkIHRvIHByZXZlbnQgc2lnbmVkL3Vu c2lnbmVkIGNvbXBhcmlzb24KKyAgICAgICAgZXJyb3IuCisKKyAgICAgICAgKiBqaXQvR1BSSW5m by5oOgorICAgICAgICAoSlNDOjpHUFJJbmZvOjpkZWJ1Z05hbWUpOgorCiAyMDE0LTA4LTE4ICBT YWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIFRoZSBwYXJzZXIgc2hv dWxkIGdlbmVyYXRlIEFTVCBub2RlcyB0aGUgdmFyIGRlY2xhcmF0aW9ucyB3aXRoIG5vIGluaXRp YWxpemVycwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9HUFJJbmZvLmgg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0dQUkluZm8uaAppbmRleCBiMzcxMWNkLi45MmEx OGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0dQUkluZm8uaAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0dQUkluZm8uaApAQCAtNjEyLDcgKzYxMiw3IEBA IHB1YmxpYzoKIAogICAgIHN0YXRpYyBjb25zdCBjaGFyKiBkZWJ1Z05hbWUoR1BSUmVnIHJlZykK ICAgICB7Ci0gICAgICAgIEFTU0VSVChzdGF0aWNfY2FzdDx1bnNpZ25lZD4ocmVnKSAhPSBJbnZh bGlkR1BSUmVnKTsKKyAgICAgICAgQVNTRVJUKHJlZyAhPSBJbnZhbGlkR1BSUmVnKTsKICAgICAg ICAgQVNTRVJUKHN0YXRpY19jYXN0PHVuc2lnbmVkPihyZWcpIDwgMzIpOwogICAgICAgICBzdGF0 aWMgY29uc3QgY2hhciogbmFtZUZvclJlZ2lzdGVyWzMyXSA9IHsKICAgICAgICAgICAgICJyMCIs ICJyMSIsICJyMiIsICJyMyIsICJyNCIsICJyNSIsICJyNiIsICJyNyIsCi0tIAoxLjkuMQoK