136042 2014-08-18 10:04:13 -0700 [GTK] when running with WEBKIT_OUTPUTDIR the configuration is ignored 2014-08-19 02:15:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 vjaquez vjaquez cgarcia commit-queue dbates mitz mrobinson mrowe pnormand oldest_to_newest 1029790 0 vjaquez 2014-08-18 10:04:13 -0700 When executing run-launcher or run-webkit-tests with WEBKIT_OUTPUTDIR set, the configuration flag (--debug/--release) is ignored. 1029793 1 236766 vjaquez 2014-08-18 10:13:06 -0700 Created attachment 236766 Patch 1029794 2 236766 mrobinson 2014-08-18 10:16:25 -0700 Comment on attachment 236766 Patch It seems pretty likely this is going to break a lot of scripts which just look for built products in WEBKIT_OUTPUTDIR. 1029796 3 vjaquez 2014-08-18 10:44:23 -0700 oops! It breaks the bot compilation. 1029798 4 vjaquez 2014-08-18 10:55:20 -0700 Is there a way to see CMakeOutput.log nad CMakeError.log? 1029811 5 vjaquez 2014-08-18 11:36:37 -0700 I've found why # [Gtk] We don't have Release/Debug configurations in straight # autotool builds (non build-webkit). In this case and if # WEBKIT_OUTPUTDIR exist, use that as our configuration dir. This will # allows us to run run-webkit-tests without using build-webkit Perhaps we should change that with cmake. But I'm not sure. Resolving as invalid. 1029987 6 236766 pnormand 2014-08-19 02:15:11 -0700 Comment on attachment 236766 Patch Removing from review queue 236766 2014-08-18 10:13:06 -0700 2014-08-19 02:15:10 -0700 Patch bug-136042-20140818191256.patch text/plain 1448 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNzAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2VmNjEyYTZkOTBmNzg4ZjVhNDYwY2FhZTY3NTcwOTZj YjZhM2JkOC4uYmQ0N2Q0MjA4YjY4MjlkOTFhOWM2NTg2YjcyYjgzNzU0OWI3NDliZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE0LTA4LTE4ICBWw61jdG9yIE1hbnVlbCBKw6FxdWV6IExlYWwgIDx2amFxdWV6QGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gd2hlbiBydW5uaW5nIHdpdGggV0VCS0lUX09VVFBV VERJUiB0aGUgY29uZmlndXJhdGlvbiBpcyBpZ25vcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYwNDIKKworICAgICAgICBXaGVuIGV4ZWN1dGlu ZyBydW4tbGF1bmNoZXIgb3IgcnVuLXdlYmtpdC10ZXN0cyB3aXRoIFdFQktJVF9PVVRQVVRESVIK KyAgICAgICAgc2V0LCB0aGUgY29uZmlndXJhdGlvbiBmbGFnICgtLWRlYnVnLy0tcmVsZWFzZSkg aXMgaWdub3JlZC4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgdG8gdGhlIGJhc2UgZGlyZWN0 b3J5IHRoZSBwYXNzZWQgY29uZmlndXJhdGlvbi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAg KGRldGVybWluZUJhc2VQcm9kdWN0RGlyKTogQXBwZW5kcyBjb25maWd1cmF0aW9uIHRvIGJhc2UK KyAgICAgICAgZGlyZWN0b3J5LgorCiAyMDE0LTA4LTE4ICBSZW5hdG8gTmFneSAgPG5hZ3kucmVu YXRvQHN0dWQudS1zemVnZWQuaHU+CiAKICAgICAgICAgbWFzdGVyLmNmZyBzaG91bGQgaGFuZGxl IHNwZWNpYWwgcmV0dXJuIGNvZGVzIG9mIHJ1bi1wZXJmLXRlc3RzCmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5k ZXggOTgxM2Q5YTBkN2JmNzk4ODg1MzliY2JhZmMxMmEyZjllNmNkMTE3Ny4uZDgwM2IwMTY1N2Fm OWMwMWY0YjE1MmU2ZDBjOTg5YmI2NDY2ODkwMyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMjYwLDYg KzI2MCwxMCBAQCBzdWIgZGV0ZXJtaW5lQmFzZVByb2R1Y3REaXIKICAgICAgICAgY2hvbXAgJHVu aXhCdWlsZFBhdGg7CiAgICAgICAgICRiYXNlUHJvZHVjdERpciA9ICR1bml4QnVpbGRQYXRoOwog ICAgIH0KKworICAgIGlmIChpc0d0aygpKSB7CisgICAgICAgICRiYXNlUHJvZHVjdERpciA9ICIk YmFzZVByb2R1Y3REaXIvIiAuIHBhc3NlZENvbmZpZ3VyYXRpb24oKTsKKyAgICB9CiB9CiAKIHN1 YiBzZXRCYXNlUHJvZHVjdERpcigkKQo=