136038 2014-08-18 04:39:35 -0700 Resource leak in object - memory allocated in constructor but not freed in destructor. 2016-09-17 07:10:37 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 a.malewski webkit-unassigned ap beidson commit-queue gyuyoung.kim japhet kling m.leszko mpakulavelrutka oldest_to_newest 1029748 0 a.malewski 2014-08-18 04:39:35 -0700 Constructor of ResourceLoadScheduler allocates field m_nonHTTPProtocolHost. This field needs to be freed in destructor. 1029755 1 236759 a.malewski 2014-08-18 05:18:17 -0700 Created attachment 236759 Patch 1029776 2 236759 kling 2014-08-18 09:18:58 -0700 Comment on attachment 236759 Patch m_nonHTTPProtocolHost should be a std::unique_ptr<HostInformation> instead. That way we don't have to manually delete it. 1029960 3 ap 2014-08-18 22:58:51 -0700 Does the leak occur in practice? It looks like ResourceLoadScheduler object is a singleton, and is never expected to be deleted. Unless I'm misreading the code, what needs to be fixed is: 1. We should have ASSERT_NOT_REACHED in the destructor. 2. WebResourceLoadScheduler (a subclass of ResourceLoadScheduler) should not have a public constructor. 1029990 4 a.malewski 2014-08-19 03:11:53 -0700 (In reply to comment #3) In my opinion, WebResourceLoadScheduler should have a public constructor because it is used in WebProcess class. Of course, we can mark WebProcess class as a friend of WebResourceLoadScheduler, but I think it does not make any sense, because in result it does not change anything.. 1030019 5 236811 a.malewski 2014-08-19 07:38:47 -0700 Created attachment 236811 Patch 1030030 6 236811 darin 2014-08-19 09:00:48 -0700 Comment on attachment 236811 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236811&action=review It’s kind of weak to use unique_ptr for m_nonHTTPProtocolHost but not do the same thing for the hosts in m_hosts. > Source/WebCore/ChangeLog:3 > + Fixed resource leak in object This is not a good name for a bug. It’s much too vague. Almost like “fixed bug in project”. And also, it’s inaccurate. This patch doesn’t fix a leak. It makes some inconsequential changes in a class, which I suppose could be helpful if someone didn’t realize the object was an immortal singleton. > Source/WebCore/ChangeLog:8 > + Changed m_nonHTTPProtocolHost from HostInformation* to std::unique_ptr<HostInformation> and added ASSERT_NOT_REACHED() in the destructor. It’s a little strange to do both of these things. It’s correct to assert that the destructor is never called. That’s what makes it clear we don’t really need a unique_ptr. But I suppose it’s OK to use unique_ptr just to be a little clearer about object ownership. > Source/WebCore/loader/ResourceLoadScheduler.cpp:107 > + m_nonHTTPProtocolHost = std::make_unique<ResourceLoadScheduler::HostInformation>(String(), maxRequestsInFlightForNonHTTPProtocols); Why change from construction syntax to assignment syntax? For unique_ptr that’s less efficient for no good reason. Just seems like gratuitous “make coding style a little worse” change. 1030051 7 ap 2014-08-19 10:20:34 -0700 > In my opinion, WebResourceLoadScheduler should have a public constructor because it is used in WebProcess class. Yes, this is how it is used today. What I was getting at is that this design appears wrong, because it requires exposing a public constructor for a singleton. 1031050 8 237061 a.malewski 2014-08-25 00:16:06 -0700 Created attachment 237061 Patch 1031064 9 a.malewski 2014-08-25 01:08:47 -0700 Created a patch with changed access to constructor of WebResourceLoadScheduler: https://bugs.webkit.org/show_bug.cgi?id=136126 1031070 10 a.malewski 2014-08-25 01:38:41 -0700 Created a patch with changed access to constructor of WebResourceLoadScheduler: https://bugs.webkit.org/show_bug.cgi?id=136126 1230813 11 237061 mcatanzaro 2016-09-17 07:10:37 -0700 Comment on attachment 237061 Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug. 236759 2014-08-18 05:18:17 -0700 2014-08-19 07:38:37 -0700 Patch bug-136038-20140818141807.patch text/plain 1505 a.malewski U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxOTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzE5YjA2ODZjNjc2NGFl ZDNlZWRhNjdmMTliYTY3Mzk5NjVkOTEyNC4uZGYzYmVjNTdiZmI4YTM5ZmI4N2I5MmJiMjg3NzA3 ODY5NjViZGIwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA4LTA0ICBBbGJl cnQgTWFsZXdza2kgIDxhLm1hbGV3c2tpQHNhbXN1bmcuY29tPgorCisgICAgICAgIEZpeGVkIHJl c291cmNlIGxlYWsgaW4gb2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzYwMzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRlZCBkZWxldGlvbiBvZiBtX25vbkhUVFBQcm90b2NvbEhvc3QgaW4g ZGVzdHJ1Y3Rvci4KKworICAgICAgICBObyBuZXcgdGVzdHMgcmVxdWlyZWQsIG5vIG5ldyBmdW5j dGlvbmFsaXR5LgorCisgICAgICAgICogbG9hZGVyL1Jlc291cmNlTG9hZFNjaGVkdWxlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUxvYWRTY2hlZHVsZXI6On5SZXNvdXJjZUxvYWRT Y2hlZHVsZXIpOgorCiAyMDE0LTA4LTA0ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxv b2suY29tPgogCiAgICAgICAgIFtXaW5DYWlyb10gQ29tcGlsZSBlcnJvciBpbiBPcGVuVHlwZU1h dGhEYXRhLmNwcC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxv YWRTY2hlZHVsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZFNjaGVk dWxlci5jcHAKaW5kZXggYTcwZDI0MzVlNTk2NTkxZDNjZTYwMGM5YjJkM2E5OTcxOWFhYTcwNi4u MjY5ZWY2YzVlNTVlZjY1YWEzYmIwMDczMWM4NTgwYTU3YjBiZjA2ZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZFNjaGVkdWxlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZFNjaGVkdWxlci5jcHAKQEAgLTExMCw2ICsxMTAs NyBAQCBSZXNvdXJjZUxvYWRTY2hlZHVsZXI6OlJlc291cmNlTG9hZFNjaGVkdWxlcigpCiAKIFJl c291cmNlTG9hZFNjaGVkdWxlcjo6flJlc291cmNlTG9hZFNjaGVkdWxlcigpCiB7CisgICAgZGVs ZXRlIG1fbm9uSFRUUFByb3RvY29sSG9zdDsKIH0KIAogUGFzc1JlZlB0cjxTdWJyZXNvdXJjZUxv YWRlcj4gUmVzb3VyY2VMb2FkU2NoZWR1bGVyOjpzY2hlZHVsZVN1YnJlc291cmNlTG9hZChGcmFt ZSogZnJhbWUsIENhY2hlZFJlc291cmNlKiByZXNvdXJjZSwgY29uc3QgUmVzb3VyY2VSZXF1ZXN0 JiByZXF1ZXN0LCBSZXNvdXJjZUxvYWRQcmlvcml0eSBwcmlvcml0eSwgY29uc3QgUmVzb3VyY2VM b2FkZXJPcHRpb25zJiBvcHRpb25zKQo= 236811 2014-08-19 07:38:47 -0700 2014-08-25 00:15:54 -0700 Patch bug-136038-20140819163838.patch text/plain 3781 a.malewski U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxOTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzE5YjA2ODZjNjc2NGFl ZDNlZWRhNjdmMTliYTY3Mzk5NjVkOTEyNC4uNzYwZWI2MGI3ZmYzNDQ0NzM2YWQ1ZjYxOTk5YmFk NjZhOTQxZWVkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA4LTE5ICBBbGJl cnQgTWFsZXdza2kgIDxhLm1hbGV3c2tpQHNhbXN1bmcuY29tPgorCisgICAgICAgIEZpeGVkIHJl c291cmNlIGxlYWsgaW4gb2JqZWN0IAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM2MDM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisgICAgICAgIAorICAgICAgICBDaGFuZ2VkIG1fbm9uSFRUUFByb3RvY29sSG9zdCBmcm9t IEhvc3RJbmZvcm1hdGlvbiogdG8gc3RkOjp1bmlxdWVfcHRyPEhvc3RJbmZvcm1hdGlvbj4gYW5k IGFkZGVkIEFTU0VSVF9OT1RfUkVBQ0hFRCgpIGluIHRoZSBkZXN0cnVjdG9yLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cyByZXF1aXJlZCwgbm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAg KiBsb2FkZXIvUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl c291cmNlTG9hZFNjaGVkdWxlcjo6aG9zdEZvclVSTCk6CisgICAgICAgIChXZWJDb3JlOjpSZXNv dXJjZUxvYWRTY2hlZHVsZXI6OlJlc291cmNlTG9hZFNjaGVkdWxlcik6CisgICAgICAgIChXZWJD b3JlOjpSZXNvdXJjZUxvYWRTY2hlZHVsZXI6On5SZXNvdXJjZUxvYWRTY2hlZHVsZXIpOgorICAg ICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkU2NoZWR1bGVyOjpzZXJ2ZVBlbmRpbmdSZXF1ZXN0 cyk6CisgICAgICAgICogbG9hZGVyL1Jlc291cmNlTG9hZFNjaGVkdWxlci5oOgorCiAyMDE0LTA4 LTA0ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgogCiAgICAgICAgIFtX aW5DYWlyb10gQ29tcGlsZSBlcnJvciBpbiBPcGVuVHlwZU1hdGhEYXRhLmNwcC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRTY2hlZHVsZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZFNjaGVkdWxlci5jcHAKaW5kZXggYTcwZDI0 MzVlNTk2NTkxZDNjZTYwMGM5YjJkM2E5OTcxOWFhYTcwNi4uMDhjOGRlMTJkOWFjZWEzMDM1MzE3 YTY4OWE5YWNmMDEwMzRmZDhmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jl c291cmNlTG9hZFNjaGVkdWxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291 cmNlTG9hZFNjaGVkdWxlci5jcHAKQEAgLTY0LDcgKzY0LDcgQEAgc3RhdGljIGNvbnN0IHVuc2ln bmVkIG1heFJlcXVlc3RzSW5GbGlnaHRGb3JOb25IVFRQUHJvdG9jb2xzID0gMTAwMDA7CiBSZXNv dXJjZUxvYWRTY2hlZHVsZXI6Okhvc3RJbmZvcm1hdGlvbiogUmVzb3VyY2VMb2FkU2NoZWR1bGVy Ojpob3N0Rm9yVVJMKGNvbnN0IFVSTCYgdXJsLCBDcmVhdGVIb3N0UG9saWN5IGNyZWF0ZUhvc3RQ b2xpY3kpCiB7CiAgICAgaWYgKCF1cmwucHJvdG9jb2xJc0luSFRUUEZhbWlseSgpKQotICAgICAg ICByZXR1cm4gbV9ub25IVFRQUHJvdG9jb2xIb3N0OworICAgICAgICByZXR1cm4gbV9ub25IVFRQ UHJvdG9jb2xIb3N0LmdldCgpOwogCiAgICAgbV9ob3N0cy5jaGVja0NvbnNpc3RlbmN5KCk7CiAg ICAgU3RyaW5nIGhvc3ROYW1lID0gdXJsLmhvc3QoKTsKQEAgLTEwMCwxNiArMTAwLDE3IEBAIFJl c291cmNlTG9hZFNjaGVkdWxlciogcmVzb3VyY2VMb2FkU2NoZWR1bGVyKCkKIH0KIAogUmVzb3Vy Y2VMb2FkU2NoZWR1bGVyOjpSZXNvdXJjZUxvYWRTY2hlZHVsZXIoKQotICAgIDogbV9ub25IVFRQ UHJvdG9jb2xIb3N0KG5ldyBIb3N0SW5mb3JtYXRpb24oU3RyaW5nKCksIG1heFJlcXVlc3RzSW5G bGlnaHRGb3JOb25IVFRQUHJvdG9jb2xzKSkKLSAgICAsIG1fcmVxdWVzdFRpbWVyKHRoaXMsICZS ZXNvdXJjZUxvYWRTY2hlZHVsZXI6OnJlcXVlc3RUaW1lckZpcmVkKQorICAgIDogbV9yZXF1ZXN0 VGltZXIodGhpcywgJlJlc291cmNlTG9hZFNjaGVkdWxlcjo6cmVxdWVzdFRpbWVyRmlyZWQpCiAg ICAgLCBtX3N1c3BlbmRQZW5kaW5nUmVxdWVzdHNDb3VudCgwKQogICAgICwgbV9pc1NlcmlhbExv YWRpbmdFbmFibGVkKGZhbHNlKQogeworICAgIG1fbm9uSFRUUFByb3RvY29sSG9zdCA9IHN0ZDo6 bWFrZV91bmlxdWU8UmVzb3VyY2VMb2FkU2NoZWR1bGVyOjpIb3N0SW5mb3JtYXRpb24+KFN0cmlu ZygpLCBtYXhSZXF1ZXN0c0luRmxpZ2h0Rm9yTm9uSFRUUFByb3RvY29scyk7CiAgICAgbWF4UmVx dWVzdHNJbkZsaWdodFBlckhvc3QgPSBpbml0aWFsaXplTWF4aW11bUhUVFBDb25uZWN0aW9uQ291 bnRQZXJIb3N0KCk7CiB9CiAKIFJlc291cmNlTG9hZFNjaGVkdWxlcjo6flJlc291cmNlTG9hZFNj aGVkdWxlcigpCiB7CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiB9CiAKIFBhc3NSZWZQdHI8 U3VicmVzb3VyY2VMb2FkZXI+IFJlc291cmNlTG9hZFNjaGVkdWxlcjo6c2NoZWR1bGVTdWJyZXNv dXJjZUxvYWQoRnJhbWUqIGZyYW1lLCBDYWNoZWRSZXNvdXJjZSogcmVzb3VyY2UsIGNvbnN0IFJl c291cmNlUmVxdWVzdCYgcmVxdWVzdCwgUmVzb3VyY2VMb2FkUHJpb3JpdHkgcHJpb3JpdHksIGNv bnN0IFJlc291cmNlTG9hZGVyT3B0aW9ucyYgb3B0aW9ucykKQEAgLTI1OSw3ICsyNjAsNyBAQCB2 b2lkIFJlc291cmNlTG9hZFNjaGVkdWxlcjo6c2VydmVQZW5kaW5nUmVxdWVzdHMoUmVzb3VyY2VM b2FkUHJpb3JpdHkgbWluaW11bVByaQogCiAgICAgbV9yZXF1ZXN0VGltZXIuc3RvcCgpOwogICAg IAotICAgIHNlcnZlUGVuZGluZ1JlcXVlc3RzKG1fbm9uSFRUUFByb3RvY29sSG9zdCwgbWluaW11 bVByaW9yaXR5KTsKKyAgICBzZXJ2ZVBlbmRpbmdSZXF1ZXN0cyhtX25vbkhUVFBQcm90b2NvbEhv c3QuZ2V0KCksIG1pbmltdW1Qcmlvcml0eSk7CiAKICAgICBWZWN0b3I8SG9zdEluZm9ybWF0aW9u Kj4gaG9zdHNUb1NlcnZlOwogICAgIG1faG9zdHMuY2hlY2tDb25zaXN0ZW5jeSgpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZFNjaGVkdWxlci5oIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZFNjaGVkdWxlci5oCmluZGV4IDliNGYzZWZm Y2NlMjlhZWNkNzhhMWFjNWNhODEwMDZjZmI5Y2ZiZjguLjkyNjlkY2U3OGQyYWMzNTg0NDkyYTYw MzE1Nzc4YzdlN2I1M2FlY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNv dXJjZUxvYWRTY2hlZHVsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VM b2FkU2NoZWR1bGVyLmgKQEAgLTEyMiw3ICsxMjIsNyBAQCBwcml2YXRlOgogCiAgICAgdHlwZWRl ZiBIYXNoTWFwPFN0cmluZywgSG9zdEluZm9ybWF0aW9uKiwgU3RyaW5nSGFzaD4gSG9zdE1hcDsK ICAgICBIb3N0TWFwIG1faG9zdHM7Ci0gICAgSG9zdEluZm9ybWF0aW9uKiBtX25vbkhUVFBQcm90 b2NvbEhvc3Q7CisgICAgc3RkOjp1bmlxdWVfcHRyPEhvc3RJbmZvcm1hdGlvbj4gbV9ub25IVFRQ UHJvdG9jb2xIb3N0OwogICAgICAgICAKICAgICBUaW1lcjxSZXNvdXJjZUxvYWRTY2hlZHVsZXI+ IG1fcmVxdWVzdFRpbWVyOwogCg== 237061 2014-08-25 00:16:06 -0700 2016-09-17 07:10:37 -0700 Patch bug-136038-20140825091558.patch text/plain 1544 a.malewski U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxOTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzE5YjA2ODZjNjc2NGFl ZDNlZWRhNjdmMTliYTY3Mzk5NjVkOTEyNC4uMzA4ZGUzYWIzMTgxY2JlNmEwNzY1NDlmYWMzOGYy MzUyZmE3Zjc0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA4LTI1ICBBbGJl cnQgTWFsZXdza2kgIDxhLm1hbGV3c2tpQHNhbXN1bmcuY29tPgorCisgICAgICAgIEFkZGVkIEFT U0VSVF9OT1RfUkVBQ0hFRCB0byBSZXNvdXJjZUxvYWRTY2hlZHVsZXIncyBkZXN0cnVjdG9yCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYwMzgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayB3aGV0 aGVyIGRlc3RydWN0b3Igb2YgYSBSZXNvdXJjZUxvYWRTY2hlZHVsZXIgaXMgbmV2ZXIgY2FsbGVk LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyByZXF1aXJlZCwgbm8gbmV3IGZ1bmN0aW9uYWxpdHku CisKKyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlc291cmNlTG9hZFNjaGVkdWxlcjo6flJlc291cmNlTG9hZFNjaGVkdWxlcik6 CisKIDIwMTQtMDgtMDQgIHBlYXZvQG91dGxvb2suY29tICA8cGVhdm9Ab3V0bG9vay5jb20+CiAK ICAgICAgICAgW1dpbkNhaXJvXSBDb21waWxlIGVycm9yIGluIE9wZW5UeXBlTWF0aERhdGEuY3Bw LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZFNjaGVkdWxl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcApp bmRleCBhNzBkMjQzNWU1OTY1OTFkM2NlNjAwYzliMmQzYTk5NzE5YWFhNzA2Li4xZjg3YjkxM2E5 YzdjMDNlMDAzMDYwOGU4NGJmOWVhMzk3Y2FhNTg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcApAQCAtMTEwLDYgKzExMCw3IEBAIFJlc291 cmNlTG9hZFNjaGVkdWxlcjo6UmVzb3VyY2VMb2FkU2NoZWR1bGVyKCkKIAogUmVzb3VyY2VMb2Fk U2NoZWR1bGVyOjp+UmVzb3VyY2VMb2FkU2NoZWR1bGVyKCkKIHsKKyAgICBBU1NFUlRfTk9UX1JF QUNIRUQoKTsKIH0KIAogUGFzc1JlZlB0cjxTdWJyZXNvdXJjZUxvYWRlcj4gUmVzb3VyY2VMb2Fk U2NoZWR1bGVyOjpzY2hlZHVsZVN1YnJlc291cmNlTG9hZChGcmFtZSogZnJhbWUsIENhY2hlZFJl c291cmNlKiByZXNvdXJjZSwgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBSZXNvdXJj ZUxvYWRQcmlvcml0eSBwcmlvcml0eSwgY29uc3QgUmVzb3VyY2VMb2FkZXJPcHRpb25zJiBvcHRp b25zKQo=