136028 2014-08-17 12:49:44 -0700 REGRESSION(r163179): It broke the build on ARM Thumb2 with GCC 2015-02-05 06:28:40 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Blocker --- 108645 131578 1 ossy msaboff clopez fpizlo ggaren mark.lam mhahnenberg mmirman msaboff oliver ossy zan oldest_to_newest 1029677 0 ossy 2014-08-17 12:49:44 -0700 See https://bugs.webkit.org/show_bug.cgi?id=131578 for details. Feel free to pick it up, I won't have time for it in the near future. 1029775 1 msaboff 2014-08-18 09:16:30 -0700 Working on patch. Will post later today. 1029958 2 236802 msaboff 2014-08-18 22:48:16 -0700 Created attachment 236802 Patch 1029968 3 ossy 2014-08-18 23:55:18 -0700 Thanks for fixing this bug. I tried the patch, and there is one more remaining build failure with it: LowLevelInterpreter.s: Assembler messages: LowLevelInterpreter.s:1514: Error: r13 not allowed here -- `subs sp,r7,#48' .LhandleUncaughtException: ldr r4, [r7, #16] movw r12, #0 movt r12, #65535 ands r4, r12 ldr r4, [r4, #1076] movw r12, #26908 add r12, r4 ldr r7, [r12, #0] ldr r7, [r7, #0] subs sp, r7, #48 <---------- line 1514 subs r4, r7, #48 mov sp, r4 ldr r4, [sp, #0] ldr r9, [sp, #4] movw r12, #22952 add r12, r4 str r9, [r12, #0] ldr r9, [sp, #8] movw r12, #22948 add r12, r4 str r9, [r12, #0] subs r4, r7, #28 mov sp, r4 pop {r4-r6, r8-r11} pop { r7 } pop { lr } bx lr 1029969 4 236802 ossy 2014-08-18 23:58:22 -0700 Comment on attachment 236802 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236802&action=review > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:405 > vmEntryRecord(cfr, sp) I think this line should be removed. 1029972 5 ossy 2014-08-19 00:15:27 -0700 Committed r172746: <http://trac.webkit.org/changeset/172746> 1029973 6 ossy 2014-08-19 00:16:51 -0700 (In reply to comment #5) > Committed r172746: <http://trac.webkit.org/changeset/172746> I landed the patch with the typo fix mentioned in Comment #4. (build and tests works fine) 1030083 7 236802 msaboff 2014-08-19 12:11:44 -0700 Comment on attachment 236802 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236802&action=review >> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:405 >> vmEntryRecord(cfr, sp) > > I think this line should be removed. Yep. Thanks. 236802 2014-08-18 22:48:16 -0700 2014-08-19 12:11:43 -0700 Patch 136028.patch text/plain 4104 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyNzQ0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTA4LTE4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjE2MzE3OSk6IEl0IGJyb2tlIHRoZSBidWlsZCBvbiBBUk0gVGh1bWIy IHdpdGggR0NDCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzYwMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGRlZCBiYWNrIEFSTXY3IGNvbmRpdGlvbmFscyBhcm91bmQgdGhyZWUgb3AgYWRkcCBhbmQg c3VicCBzaW5jZSBBUk0gVGh1bWIyIHNwZWMgc2F5cyB0aGF0CisgICAgICAgIHRoZSBiZWhhdmlv ciBmb3IgdGhvc2Ugb3BzIGFyZSB1bmRlZmluZWQuICBUaGlzIHdhcyBvcmlnaW5hbGx5IGRvbmUg aW4gY2hhbmdlc2V0IDE2MzE3OS4KKworICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0 ZXIzMl82NC5hc206CisKIDIwMTQtMDgtMTggIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNzI3NDEuCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0 LmFzbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJ bnRlcnByZXRlcjMyXzY0LmFzbQkocmV2aXNpb24gMTcyNjg3KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20JKHdvcmtpbmcgY29weSkK QEAgLTIwMyw3ICsyMDMsMTIgQEAgbWFjcm8gZG9WTUVudHJ5KG1ha2VDYWxsKQogICAgICAgICBs b2FkcCA4W2Nmcl0sIGVudHJ5CiAgICAgZW5kCiAKLSAgICB2bUVudHJ5UmVjb3JkKGNmciwgc3Ap CisgICAgaWYgQVJNdjcKKyAgICAgICAgdm1FbnRyeVJlY29yZChjZnIsIHRlbXAxKQorICAgICAg ICBtb3ZlIHRlbXAxLCBzcAorICAgIGVsc2UKKyAgICAgICAgdm1FbnRyeVJlY29yZChjZnIsIHNw KQorICAgIGVuZAogCiAgICAgc3RvcmVwIHZtLCBWTUVudHJ5UmVjb3JkOjptX3ZtW3NwXQogICAg IGxvYWRwIFZNOjp0b3BDYWxsRnJhbWVbdm1dLCB0ZW1wMgpAQCAtMjE5LDcgKzIyNCwxMiBAQCBt YWNybyBkb1ZNRW50cnkobWFrZUNhbGwpCiAgICAgZWxzaWYgQVJNIG9yIEFSTXY3IG9yIEFSTXY3 X1RSQURJVElPTkFMCiAgICAgICAgIGFkZHAgQ2FsbEZyYW1lQWxpZ25TbG90cyAqIFNsb3RTaXpl LCBzcCwgdGVtcDEKICAgICAgICAgY2xyYnAgdGVtcDEsIFN0YWNrQWxpZ25tZW50TWFzaywgdGVt cDEKLSAgICAgICAgc3VicCB0ZW1wMSwgQ2FsbEZyYW1lQWxpZ25TbG90cyAqIFNsb3RTaXplLCBz cAorICAgICAgICBpZiBBUk12NworICAgICAgICAgICAgc3VicCB0ZW1wMSwgQ2FsbEZyYW1lQWxp Z25TbG90cyAqIFNsb3RTaXplLCB0ZW1wMQorICAgICAgICAgICAgbW92ZSB0ZW1wMSwgc3AKKyAg ICAgICAgZWxzZQorICAgICAgICAgICAgc3VicCB0ZW1wMSwgQ2FsbEZyYW1lQWxpZ25TbG90cyAq IFNsb3RTaXplLCBzcAorICAgICAgICBlbmQKICAgICBlbmQKIAogICAgIGlmIFg4NiBvciBYODZf V0lOCkBAIC0yNTIsNyArMjYyLDEyIEBAIG1hY3JvIGRvVk1FbnRyeShtYWtlQ2FsbCkKIAogICAg IGNDYWxsMihfbGxpbnRfdGhyb3dfc3RhY2tfb3ZlcmZsb3dfZXJyb3IsIHZtLCBwcm90b0NhbGxG cmFtZSkKIAotICAgIHZtRW50cnlSZWNvcmQoY2ZyLCBzcCkKKyAgICBpZiBBUk12NworICAgICAg ICB2bUVudHJ5UmVjb3JkKGNmciwgdGVtcDEpCisgICAgICAgIG1vdmUgdGVtcDEsIHNwCisgICAg ZWxzZQorICAgICAgICB2bUVudHJ5UmVjb3JkKGNmciwgc3ApCisgICAgZW5kCiAKICAgICBsb2Fk cCBWTUVudHJ5UmVjb3JkOjptX3ZtW3NwXSwgdGVtcDMKICAgICBsb2FkcCBWTUVudHJ5UmVjb3Jk OjptX3ByZXZUb3BDYWxsRnJhbWVbc3BdLCB0ZW1wNApAQCAtMjYwLDcgKzI3NSwxMiBAQCBtYWNy byBkb1ZNRW50cnkobWFrZUNhbGwpCiAgICAgbG9hZHAgVk1FbnRyeVJlY29yZDo6bV9wcmV2VG9w Vk1FbnRyeUZyYW1lW3NwXSwgdGVtcDQKICAgICBzdG9yZXAgdGVtcDQsIFZNOjp0b3BWTUVudHJ5 RnJhbWVbdGVtcDNdCiAKLSAgICBzdWJwIGNmciwgQ2FsbGVlUmVnaXN0ZXJTYXZlU2l6ZSwgc3AK KyAgICBpZiBBUk12NworICAgICAgICBzdWJwIGNmciwgQ2FsbGVlUmVnaXN0ZXJTYXZlU2l6ZSwg dGVtcDMKKyAgICAgICAgbW92ZSB0ZW1wMywgc3AKKyAgICBlbHNlCisgICAgICAgIHN1YnAgY2Zy LCBDYWxsZWVSZWdpc3RlclNhdmVTaXplLCBzcAorICAgIGVuZAogCiAgICAgcG9wQ2FsbGVlU2F2 ZXMoKQogICAgIGZ1bmN0aW9uRXBpbG9ndWUoKQpAQCAtMzA4LDcgKzMyOCwxMiBAQCBtYWNybyBk b1ZNRW50cnkobWFrZUNhbGwpCiAKICAgICBtYWtlQ2FsbChlbnRyeSwgdGVtcDEsIHRlbXAyKQog Ci0gICAgdm1FbnRyeVJlY29yZChjZnIsIHNwKQorICAgIGlmIEFSTXY3CisgICAgICAgIHZtRW50 cnlSZWNvcmQoY2ZyLCB0ZW1wMSkKKyAgICAgICAgbW92ZSB0ZW1wMSwgc3AKKyAgICBlbHNlCisg ICAgICAgIHZtRW50cnlSZWNvcmQoY2ZyLCBzcCkKKyAgICBlbmQKIAogICAgIGxvYWRwIFZNRW50 cnlSZWNvcmQ6Om1fdm1bc3BdLCB0ZW1wMwogICAgIGxvYWRwIFZNRW50cnlSZWNvcmQ6Om1fcHJl dlRvcENhbGxGcmFtZVtzcF0sIHRlbXA0CkBAIC0zMTYsNyArMzQxLDEyIEBAIG1hY3JvIGRvVk1F bnRyeShtYWtlQ2FsbCkKICAgICBsb2FkcCBWTUVudHJ5UmVjb3JkOjptX3ByZXZUb3BWTUVudHJ5 RnJhbWVbc3BdLCB0ZW1wNAogICAgIHN0b3JlcCB0ZW1wNCwgVk06OnRvcFZNRW50cnlGcmFtZVt0 ZW1wM10KIAotICAgIHN1YnAgY2ZyLCBDYWxsZWVSZWdpc3RlclNhdmVTaXplLCBzcAorICAgIGlm IEFSTXY3CisgICAgICAgIHN1YnAgY2ZyLCBDYWxsZWVSZWdpc3RlclNhdmVTaXplLCB0ZW1wMwor ICAgICAgICBtb3ZlIHRlbXAzLCBzcAorICAgIGVsc2UKKyAgICAgICAgc3VicCBjZnIsIENhbGxl ZVJlZ2lzdGVyU2F2ZVNpemUsIHNwCisgICAgZW5kCiAKICAgICBwb3BDYWxsZWVTYXZlcygpCiAg ICAgZnVuY3Rpb25FcGlsb2d1ZSgpCkBAIC0zNzMsNiArNDAzLDEyIEBAIF9oYW5kbGVVbmNhdWdo dEV4Y2VwdGlvbjoKICAgICBsb2FkcCBDYWxsZXJGcmFtZSArIFBheWxvYWRPZmZzZXRbY2ZyXSwg Y2ZyCiAKICAgICB2bUVudHJ5UmVjb3JkKGNmciwgc3ApCisgICAgaWYgQVJNdjcKKyAgICAgICAg dm1FbnRyeVJlY29yZChjZnIsIHQzKQorICAgICAgICBtb3ZlIHQzLCBzcAorICAgIGVsc2UKKyAg ICAgICAgdm1FbnRyeVJlY29yZChjZnIsIHNwKQorICAgIGVuZAogCiAgICAgbG9hZHAgVk1FbnRy eVJlY29yZDo6bV92bVtzcF0sIHQzCiAgICAgbG9hZHAgVk1FbnRyeVJlY29yZDo6bV9wcmV2VG9w Q2FsbEZyYW1lW3NwXSwgdDUKQEAgLTM4MCw3ICs0MTYsMTIgQEAgX2hhbmRsZVVuY2F1Z2h0RXhj ZXB0aW9uOgogICAgIGxvYWRwIFZNRW50cnlSZWNvcmQ6Om1fcHJldlRvcFZNRW50cnlGcmFtZVtz cF0sIHQ1CiAgICAgc3RvcmVwIHQ1LCBWTTo6dG9wVk1FbnRyeUZyYW1lW3QzXQogCi0gICAgc3Vi cCBjZnIsIENhbGxlZVJlZ2lzdGVyU2F2ZVNpemUsIHNwCisgICAgaWYgQVJNdjcKKyAgICAgICAg c3VicCBjZnIsIENhbGxlZVJlZ2lzdGVyU2F2ZVNpemUsIHQzCisgICAgICAgIG1vdmUgdDMsIHNw CisgICAgZWxzZQorICAgICAgICBzdWJwIGNmciwgQ2FsbGVlUmVnaXN0ZXJTYXZlU2l6ZSwgc3AK KyAgICBlbmQKIAogICAgIHBvcENhbGxlZVNhdmVzKCkKICAgICBmdW5jdGlvbkVwaWxvZ3VlKCkK