136017 2014-08-16 03:01:28 -0700 [GTK] build fails with error: cannot allocate an object of abstract type ‘WebKit::PageClientImpl’ 2014-08-16 07:26:34 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sun.shin webkit-unassigned berto cgarcia commit-queue gustavo gyuyoung.kim mrobinson oldest_to_newest 1029601 0 sun.shin 2014-08-16 03:01:28 -0700 ./Tools/Scripts/build-webkit --gtk fails with this error: ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h: In static member function ‘static std::unique_ptr<WebKit::PageClientImpl> WebKit::PageClientImpl::create(GtkWidget*)’: ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:54:77: error: cannot allocate an object of abstract type ‘WebKit::PageClientImpl’ return std::unique_ptr<PageClientImpl>(new PageClientImpl(viewWidget)); ^ ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:46:7: note: because the following virtual functions are pure within ‘WebKit::PageClientImpl’: class PageClientImpl : public PageClient ^ In file included from ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:33:0, from ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:29: ../../Source/WebKit2/UIProcess/PageClient.h:306:18: note: virtual void WebKit::PageClient::didFirstVisuallyNonEmptyLayoutForMainFrame() virtual void didFirstVisuallyNonEmptyLayoutForMainFrame() = 0; ^ ../../Source/WebKit2/UIProcess/PageClient.h:307:18: note: virtual void WebKit::PageClient::didFinishLoadForMainFrame() virtual void didFinishLoadForMainFrame() = 0; ^ 1029602 1 236709 sun.shin 2014-08-16 03:06:33 -0700 Created attachment 236709 Patch 1029603 2 236710 sun.shin 2014-08-16 03:07:59 -0700 Created attachment 236710 Patch 1029604 3 commit-queue 2014-08-16 03:08:17 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1029611 4 236710 gyuyoung.kim 2014-08-16 06:53:12 -0700 Comment on attachment 236710 Patch rs=me to fix build break on gtk port. 1029612 5 gyuyoung.kim 2014-08-16 07:02:29 -0700 For the record, r172635 caused this break. http://trac.webkit.org/changeset/172635. 1029615 6 236710 commit-queue 2014-08-16 07:26:30 -0700 Comment on attachment 236710 Patch Clearing flags on attachment: 236710 Committed r172690: <http://trac.webkit.org/changeset/172690> 1029616 7 commit-queue 2014-08-16 07:26:34 -0700 All reviewed patches have been landed. Closing bug. 236709 2014-08-16 03:06:33 -0700 2014-08-16 03:07:52 -0700 Patch bug-136017-20140816190626.patch text/plain 2263 sun.shin U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNjg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDM1MTZjYWRmZWQ2NDg5 YTA4NzNiMmM0ZjcxMWIzNjBiNDUxYWU4OS4uZjg4ZjQ2MmU2MzI3Y2RiMmQxY2E4YjhlMTY0NjFj MTNhNDM0YTMwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA4LTE2ICBCeXVu Z3Nlb24gU2hpbiAgPHN1bi5zaGluQGxnZS5jb20+CisKKyAgICAgICAgW0dUS10gYnVpbGQgZmFp bHMgd2l0aCBlcnJvcjogY2Fubm90IGFsbG9jYXRlIGFuIG9iamVjdCBvZiBhYnN0cmFjdCB0eXBl IOKAmFdlYktpdDo6UGFnZUNsaWVudEltcGzigJkgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYwMTcgCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1w bC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBhZ2VDbGllbnRJbXBsOjpkaWRGaXJzdFZpc3VhbGx5 Tm9uRW1wdHlMYXlvdXRGb3JNYWluRnJhbWUpOgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50 SW1wbDo6ZGlkRmluaXNoTG9hZEZvck1haW5GcmFtZSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9ndGsvUGFnZUNsaWVudEltcGwuaDoKKwogMjAxNC0wOC0xNSAgUnl1YW4gQ2hvaSAgPHJ5dWFu LmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gQWRkIGV3a19pbnRyby5oIHRvIGRl c2NyaWJlIG1haW4gcGFnZSBvZiBkb3h5Z2VuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAKaW5kZXggZWZhMmRhNGEyYzBjM2RlZmJj OGI3YzZhYmZmNTRhNDI1ZDAwMGNkZS4uMGZiOTgyNGE3MmIxNmFiY2QwZTA4YWY0YjUyNTA2ZjFm ZWQ3OTM4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFn ZUNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1Bh Z2VDbGllbnRJbXBsLmNwcApAQCAtMzk4LDQgKzM5OCwxMiBAQCB2b2lkIFBhZ2VDbGllbnRJbXBs Ojp3aWxsUmVjb3JkTmF2aWdhdGlvblNuYXBzaG90KFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0mKQog ewogfQogCit2b2lkIFBhZ2VDbGllbnRJbXBsOjpkaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlv dXRGb3JNYWluRnJhbWUoKQoreworfQorCit2b2lkIFBhZ2VDbGllbnRJbXBsOjpkaWRGaW5pc2hM b2FkRm9yTWFpbkZyYW1lKCkKK3sKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuaAppbmRleCAy YjBkY2I1YzU4MDhkZjM2NzM1MTQxMzgwNWRhYzY0MWQ0ODA1NDY2Li5jMDM5ZDZkY2I2OTFlZGVj NzFiYWMwYmViYmY1OTM4YjM0ZjExMmI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmgKQEAgLTEyNyw2ICsxMjcsOSBAQCBwcml2YXRl OgogICAgIHZpcnR1YWwgdm9pZCBuYXZpZ2F0aW9uR2VzdHVyZURpZEVuZChib29sLCBXZWJCYWNr Rm9yd2FyZExpc3RJdGVtJikgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCB2b2lkIHdpbGxSZWNvcmRO YXZpZ2F0aW9uU25hcHNob3QoV2ViQmFja0ZvcndhcmRMaXN0SXRlbSYpIG92ZXJyaWRlOwogCisg ICAgdmlydHVhbCB2b2lkIGRpZEZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dEZvck1haW5GcmFt ZSgpIG92ZXJyaWRlOworICAgIHZpcnR1YWwgdm9pZCBkaWRGaW5pc2hMb2FkRm9yTWFpbkZyYW1l KCkgb3ZlcnJpZGU7CisKICAgICB2aXJ0dWFsIHZvaWQgZG9uZVdpdGhUb3VjaEV2ZW50KGNvbnN0 IE5hdGl2ZVdlYlRvdWNoRXZlbnQmLCBib29sIHdhc0V2ZW50SGFuZGxlZCkgb3ZlcnJpZGU7CiAK ICAgICAvLyBNZW1iZXJzIG9mIFBhZ2VDbGllbnRJbXBsIGNsYXNzCg== 236710 2014-08-16 03:07:59 -0700 2014-08-16 07:26:30 -0700 Patch bug-136017-20140816190751.patch text/plain 2258 sun.shin U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNjg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDM1MTZjYWRmZWQ2NDg5 YTA4NzNiMmM0ZjcxMWIzNjBiNDUxYWU4OS4uMTNjMTZhYWZhZGVjNGJhMTcwNzZhN2Y1NjhjODNm ZmNkOTY3NjhlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA4LTE2ICBCeXVu Z3Nlb24gU2hpbiAgPHN1bi5zaGluQGxnZS5jb20+CisKKyAgICAgICAgW0dUS10gYnVpbGQgZmFp bHMgd2l0aCBlcnJvcjogY2Fubm90IGFsbG9jYXRlIGFuIG9iamVjdCBvZiBhYnN0cmFjdCB0eXBl ICdXZWJLaXQ6OlBhZ2VDbGllbnRJbXBsJworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM2MDE3IAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3Bw OgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6ZGlkRmlyc3RWaXN1YWxseU5vbkVt cHR5TGF5b3V0Rm9yTWFpbkZyYW1lKToKKyAgICAgICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6 OmRpZEZpbmlzaExvYWRGb3JNYWluRnJhbWUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3Rr L1BhZ2VDbGllbnRJbXBsLmg6CisKIDIwMTQtMDgtMTUgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9p QHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEFkZCBld2tfaW50cm8uaCB0byBkZXNjcmli ZSBtYWluIHBhZ2Ugb2YgZG94eWdlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwCmluZGV4IGVmYTJkYTRhMmMwYzNkZWZiYzhiN2M2 YWJmZjU0YTQyNWQwMDBjZGUuLjBmYjk4MjRhNzJiMTZhYmNkMGUwOGFmNGI1MjUwNmYxZmVkNzkz OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGll bnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xp ZW50SW1wbC5jcHAKQEAgLTM5OCw0ICszOTgsMTIgQEAgdm9pZCBQYWdlQ2xpZW50SW1wbDo6d2ls bFJlY29yZE5hdmlnYXRpb25TbmFwc2hvdChXZWJCYWNrRm9yd2FyZExpc3RJdGVtJikKIHsKIH0K IAordm9pZCBQYWdlQ2xpZW50SW1wbDo6ZGlkRmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0Rm9y TWFpbkZyYW1lKCkKK3sKK30KKwordm9pZCBQYWdlQ2xpZW50SW1wbDo6ZGlkRmluaXNoTG9hZEZv ck1haW5GcmFtZSgpCit7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuaCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmgKaW5kZXggMmIwZGNi NWM1ODA4ZGYzNjczNTE0MTM4MDVkYWM2NDFkNDgwNTQ2Ni4uYzAzOWQ2ZGNiNjkxZWRlYzcxYmFj MGJlYmJmNTkzOGIzNGYxMTJiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvUGFnZUNsaWVudEltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oCkBAIC0xMjcsNiArMTI3LDkgQEAgcHJpdmF0ZToKICAg ICB2aXJ0dWFsIHZvaWQgbmF2aWdhdGlvbkdlc3R1cmVEaWRFbmQoYm9vbCwgV2ViQmFja0Zvcndh cmRMaXN0SXRlbSYpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCB3aWxsUmVjb3JkTmF2aWdh dGlvblNuYXBzaG90KFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0mKSBvdmVycmlkZTsKIAorICAgIHZp cnR1YWwgdm9pZCBkaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXRGb3JNYWluRnJhbWUoKSBv dmVycmlkZTsKKyAgICB2aXJ0dWFsIHZvaWQgZGlkRmluaXNoTG9hZEZvck1haW5GcmFtZSgpIG92 ZXJyaWRlOworCiAgICAgdmlydHVhbCB2b2lkIGRvbmVXaXRoVG91Y2hFdmVudChjb25zdCBOYXRp dmVXZWJUb3VjaEV2ZW50JiwgYm9vbCB3YXNFdmVudEhhbmRsZWQpIG92ZXJyaWRlOwogCiAgICAg Ly8gTWVtYmVycyBvZiBQYWdlQ2xpZW50SW1wbCBjbGFzcwo=