136011 2014-08-15 18:56:36 -0700 REGRESSION (r164173): Safari AutoFill button in popover, default buttons on iCloud control panel and Safari Safe Browsing pages don't have default appearance 2014-08-16 14:21:43 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino sam oldest_to_newest 1029549 0 dino 2014-08-15 18:56:36 -0700 In order to render some controls correctly, the NSWindow subclass we use in ThemeMac.mm should identify itself as the key window (when the WebKit view is key). <rdar://problem/17577321> 1029550 1 236698 dino 2014-08-15 18:59:43 -0700 Created attachment 236698 Patch 1029568 2 sam 2014-08-15 21:08:27 -0700 Can this be tested? 1029644 3 dino 2014-08-16 13:28:32 -0700 (In reply to comment #2) > Can this be tested? Not that easily. I'll open a bug to expose the chrome mode. https://bugs.webkit.org/show_bug.cgi?id=136023 1029646 4 sam 2014-08-16 13:32:51 -0700 (In reply to comment #3) > (In reply to comment #2) > > Can this be tested? > > Not that easily. I'll open a bug to expose the chrome mode. > > https://bugs.webkit.org/show_bug.cgi?id=136023 What makes it hard? 1029650 5 dino 2014-08-16 14:21:43 -0700 Committed r172693: <http://trac.webkit.org/changeset/172693> 236698 2014-08-15 18:59:43 -0700 2014-08-15 21:08:10 -0700 Patch bug-136011-20140816115933.patch text/plain 1588 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODUwMTYwZTVjY2U4NmFi YjQwZTgwMGEzYTNhYzRmMGNjYTBhNDZhZi4uYzFmOTYxMzMxN2E3MmNmMGUzY2Q1ZTU2ZmM1NmFj MzMzNDcyZWVmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA4LTE1ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBOU1dpbmRvdyBzdWJjbGFzcyBz aG91bGQgYmVjb21lIGtleSB3aW5kb3cgd2hlbiBmb2N1c2VkIChyZW5kZXJpbmcpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYwMTEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHdlIHJlbmRlciBz b21lIGNvbnRyb2xzLCB3ZSBuZWVkIHRvIG1ha2Ugc3VyZSB0aGUgTlNXaW5kb3cgc3ViY2xhc3Mg d2UKKyAgICAgICAgdXNlIGFzIHRoZSBob3N0IG9mIHRoZSBBcHBLaXQgdmlld3MgaWRlbnRpZmll cyBpdHNlbGYgYXMgdGhlIGtleSB3aW5kb3cgKGlmCisgICAgICAgIHRoZSBjb250cm9sIHN0YXRl IGlzIGNvcnJlY3QpLiBXZSBhbHJlYWR5IGhhdmUgYSBmbGFnIHRyYWNraW5nIHRoaXMgZm9yCisg ICAgICAgIGtleSBhcHBlYXJhbmNlIC0ganVzdCBtYWtlIHN1cmUgd2UgZG8gdGhlIHNhbWUgZm9y IGlzS2V5V2luZG93LgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1RoZW1lTWFjLm1tOgorICAg ICAgICAoLVtXZWJDb3JlVGhlbWVXaW5kb3cgaXNLZXlXaW5kb3ddKTogTmV3IG92ZXJyaWRlIHRv IG1pcnJvciB0aGUgc3RhdGljCisgICAgICAgIHZhcmlhYmxlIGZvciBrZXkgYXBwZWFyYW5jZS4K KwogMjAxNC0wOC0xNSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAog ICAgICAgICBGaXggZ2xpZGluZyBpbiBBeGlzU2Nyb2xsU25hcEFuaW1hdG9yIGZvciBNYWMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9UaGVtZU1hYy5tbSBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9UaGVtZU1hYy5tbQppbmRleCBlOGY4MzJjNGU4ZWQwNmFm MTQyMzAxOTg4ZmE0NzZjNGQwOTM5MTE5Li5kNGNhMzg0YmI5YmI3MDk5MTBjMjgzM2E4OGIwOTAz NDYwM2FhNTFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvVGhlbWVN YWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1RoZW1lTWFjLm1tCkBAIC01 OCw2ICs1OCwxMSBAQCBzdGF0aWMgQk9PTCB0aGVtZVdpbmRvd0hhc0tleUFwcGVhcmFuY2U7CiAg ICAgcmV0dXJuIHRoZW1lV2luZG93SGFzS2V5QXBwZWFyYW5jZTsKIH0KIAorLSAoQk9PTClpc0tl eVdpbmRvdworeworICAgIHJldHVybiB0aGVtZVdpbmRvd0hhc0tleUFwcGVhcmFuY2U7Cit9CisK IEBlbmQKIAogQGludGVyZmFjZSBXZWJDb3JlVGhlbWVWaWV3IDogTlNDb250cm9sCg==