136009 2014-08-15 18:23:01 -0700 Web Inspector: Remove forced layouts during recording caused by striped background element resizing 2014-08-15 21:06:08 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1029541 0 joepeck 2014-08-15 18:23:01 -0700 * SUMMARY Remove forced layouts during recording caused by striped background element resizing. This is a performance issue. But, we should be able to avoid resizing this element manually and draw the background with CSS! 1029542 1 webkit-bug-importer 2014-08-15 18:23:09 -0700 <rdar://problem/18038767> 1029543 2 236697 joepeck 2014-08-15 18:34:10 -0700 Created attachment 236697 [PATCH] Proposed Fix 1029559 3 236697 timothy 2014-08-15 20:30:57 -0700 Comment on attachment 236697 [PATCH] Proposed Fix Why didn't I think of that!? 1029565 4 236697 commit-queue 2014-08-15 21:06:05 -0700 Comment on attachment 236697 [PATCH] Proposed Fix Clearing flags on attachment: 236697 Committed r172682: <http://trac.webkit.org/changeset/172682> 1029566 5 commit-queue 2014-08-15 21:06:08 -0700 All reviewed patches have been landed. Closing bug. 236697 2014-08-15 18:34:10 -0700 2014-08-15 21:06:05 -0700 [PATCH] Proposed Fix remove-striped-background.patch text/plain 7524 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc1MjExZjEuLjk2M2IzOTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM1IEBACiAyMDE0LTA4LTE1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Zl IGZvcmNlZCBsYXlvdXRzIGR1cmluZyByZWNvcmRpbmcgY2F1c2VkIGJ5IHN0cmlwZWQgYmFja2dy b3VuZCBlbGVtZW50IHJlc2l6aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzYwMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZSB1c2VkIHRvIG1hbnVhbGx5IHJlc2l6ZSBhbmQgYSBjdXN0b20gc3Ry aXBlZCBiYWNrZ3JvdW5kIGJlaGluZAorICAgICAgICB0aGUgdGltZWxpbmUgdHJlZSBvdXRsaW5l IGNvbnRlbnQgYXJlYS4gVGhpcyBjYW4gaGFwcGVuIGZyZXF1ZW50bHkKKyAgICAgICAgZHVyaW5n IHRpbWVsaW5lIHJlY29yZGluZ3MgY2F1c2luZyBmb3JjZWQgbGF5b3V0cy4gV2UgY2FuIGVsaW1p bmF0ZQorICAgICAgICB0aGUgaGFjayBhbmQgaW5zdGVhZCBwdXQgdGhlIHN0cmlwZSBiYWNrZ3Jv dW5kIG9uIHRoZSB0cmVlIG91dGxpbmUuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdz L1RpbWVsaW5lU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5l U2lkZWJhclBhbmVsLnByb3RvdHlwZS51cGRhdGVDdXN0b21Db250ZW50T3ZlcmZsb3cpOiBEZWxl dGVkLgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwu Y3NzOgorICAgICAgICAoYm9keS5tYWMtcGxhdGZvcm0ubGVnYWN5IC5zaWRlYmFyID4gLnBhbmVs Lm5hdmlnYXRpb24udGltZWxpbmUgPiAuY29udGVudCAuaXRlbSA+IC5zdGF0dXMgPiAuc3RhdHVz LWJ1dHRvbik6CisgICAgICAgICguc2lkZWJhciA+IC5wYW5lbC5uYXZpZ2F0aW9uLnRpbWVsaW5l ID4gLmNvbnRlbnQgPiAuc3RyaXBlLWJhY2tncm91bmQpOiBEZWxldGVkLgorICAgICAgICAoLnNp ZGViYXIgPiAucGFuZWwubmF2aWdhdGlvbi50aW1lbGluZS50aW1lbGluZS1jb250ZW50LXZpZXct c2hvd2luZyA+IC5jb250ZW50ID4gLnN0cmlwZS1iYWNrZ3JvdW5kKTogRGVsZXRlZC4KKyAgICAg ICAgRWxpbWluYXRlIHRoZSBzdHJpcGVkIGJhY2tncm91bmQgZWxlbWVudC4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVWaWV3LmNzczoKKyAgICAgICAgKC5wYW5lbC5u YXZpZ2F0aW9uLnRpbWVsaW5lID4gLmNvbnRlbnQgPiAubmF2aWdhdGlvbi1zaWRlYmFyLXBhbmVs LWNvbnRlbnQtdHJlZS1vdXRsaW5lKToKKyAgICAgICAgKC5wYW5lbC5uYXZpZ2F0aW9uLnRpbWVs aW5lLnRpbWVsaW5lLWNvbnRlbnQtdmlldy1zaG93aW5nID4gLmNvbnRlbnQgPiAubmF2aWdhdGlv bi1zaWRlYmFyLXBhbmVsLWNvbnRlbnQtdHJlZS1vdXRsaW5lKToKKyAgICAgICAgR2l2ZSB0aGUg dGltZWxpbmUgY29udGVudCB0cmVlIG91dGxpbmVzIHRoZSBzdHJpcGVkIGJhY2tncm91bmQuCisK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25TaWRlYmFyUGFuZWwuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmF2aWdhdGlvblNpZGViYXJQYW5lbC5wcm90b3R5cGUu X3VwZGF0ZUNvbnRlbnRPdmVyZmxvd1NoYWRvd1Zpc2liaWxpdHkpOgorICAgICAgICAoV2ViSW5z cGVjdG9yLk5hdmlnYXRpb25TaWRlYmFyUGFuZWwucHJvdG90eXBlLnVwZGF0ZUN1c3RvbUNvbnRl bnRPdmVyZmxvdyk6IERlbGV0ZWQuCisgICAgICAgIFJlbW92ZSB0aGUgbm93IHVudXNlZCB1cGRh dGVDdXN0b21Db250ZW50T3ZlcmZsb3cgbWV0aG9kLgorCisyMDE0LTA4LTE1ICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogVXBk YXRlIFNjcmlwdHMvdXBkYXRlLUxlZ2FjeUluc3BlY3RvckJhY2tlbmRDb21tYW5kcy5yYiBmb3Ig dGhlIG5ldyBnZW5lcmF0b3IKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzNjAwNgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcwpp bmRleCA4NjdkYWE2Li4xOGFiOTk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25TaWRlYmFyUGFu ZWwuanMKQEAgLTI5NywxMSArMjk3LDYgQEAgV2ViSW5zcGVjdG9yLk5hdmlnYXRpb25TaWRlYmFy UGFuZWwucHJvdG90eXBlID0gewogICAgICAgICB9CiAgICAgfSwKIAotICAgIHVwZGF0ZUN1c3Rv bUNvbnRlbnRPdmVyZmxvdzogZnVuY3Rpb24oKQotICAgIHsKLSAgICAgICAgLy8gSW1wbGVtZW50 ZWQgYnkgc3ViY2xhc3NlcyBpZiBuZWVkZWQuCi0gICAgfSwKLQogICAgIHVwZGF0ZUZpbHRlcjog ZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgdGhpcy5fdXBkYXRlRmlsdGVyKCk7CkBAIC00NDEs OCArNDM2LDYgQEAgV2ViSW5zcGVjdG9yLk5hdmlnYXRpb25TaWRlYmFyUGFuZWwucHJvdG90eXBl ID0gewogICAgIHsKICAgICAgICAgZGVsZXRlIHRoaXMuX3VwZGF0ZUNvbnRlbnRPdmVyZmxvd1No YWRvd1Zpc2liaWxpdHlJZGVudGlmaWVyOwogCi0gICAgICAgIHRoaXMudXBkYXRlQ3VzdG9tQ29u dGVudE92ZXJmbG93KCk7Ci0KICAgICAgICAgdmFyIHNjcm9sbEhlaWdodCA9IHRoaXMuX2NvbnRl bnRFbGVtZW50LnNjcm9sbEhlaWdodDsKICAgICAgICAgdmFyIG9mZnNldEhlaWdodCA9IHRoaXMu X2NvbnRlbnRFbGVtZW50Lm9mZnNldEhlaWdodDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuY3NzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFy UGFuZWwuY3NzCmluZGV4IDkwYTBiMTcuLmZmMzhmMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lU2lkZWJhclBhbmVsLmNzcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVNp ZGViYXJQYW5lbC5jc3MKQEAgLTI1MSwyMSArMjUxLDMgQEAgYm9keS5tYWMtcGxhdGZvcm0ubGVn YWN5IC5zaWRlYmFyID4gLnBhbmVsLm5hdmlnYXRpb24udGltZWxpbmUgPiAuY29udGVudCAuaXRl bQogICAgIGhlaWdodDogMTJweDsKICAgICBtYXJnaW4tdG9wOiAycHg7CiB9Ci0KLS5zaWRlYmFy ID4gLnBhbmVsLm5hdmlnYXRpb24udGltZWxpbmUgPiAuY29udGVudCA+IC5zdHJpcGUtYmFja2dy b3VuZCB7Ci0gICAgcG9zaXRpb246IGFic29sdXRlOwotICAgIHRvcDogMDsKLSAgICBsZWZ0OiAw OwotICAgIHJpZ2h0OiAwOwotICAgIG1pbi1oZWlnaHQ6IDEwMCU7Ci0KLSAgICBiYWNrZ3JvdW5k LWltYWdlOiBsaW5lYXItZ3JhZGllbnQodG8gYm90dG9tLCB0cmFuc3BhcmVudCwgdHJhbnNwYXJl bnQgNTAlLCByZ2JhKDAsIDAsIDAsIDAuMDMpIDUwJSwgcmdiYSgwLCAwLCAwLCAwLjAzKSk7Ci0g ICAgYmFja2dyb3VuZC1zaXplOiAxMDAlIDQwcHg7Ci0KLSAgICBwb2ludGVyLWV2ZW50czogbm9u ZTsKLSAgICBkaXNwbGF5OiBub25lOwotfQotCi0uc2lkZWJhciA+IC5wYW5lbC5uYXZpZ2F0aW9u LnRpbWVsaW5lLnRpbWVsaW5lLWNvbnRlbnQtdmlldy1zaG93aW5nID4gLmNvbnRlbnQgPiAuc3Ry aXBlLWJhY2tncm91bmQgewotICAgIGRpc3BsYXk6IGJsb2NrOwotfQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFu ZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGlu ZVNpZGViYXJQYW5lbC5qcwppbmRleCA5ZTMzMjUxLi5jNTdhZGQ2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVNpZGViYXJQYW5l bC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1l bGluZVNpZGViYXJQYW5lbC5qcwpAQCAtMTM2LDEwICsxMzYsNiBAQCBXZWJJbnNwZWN0b3IuVGlt ZWxpbmVTaWRlYmFyUGFuZWwgPSBmdW5jdGlvbigpCiAgICAgV2ViSW5zcGVjdG9yLnRpbWVsaW5l TWFuYWdlci5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5UaW1lbGluZU1hbmFnZXIuRXZl bnQuUmVjb3JkaW5nQ3JlYXRlZCwgdGhpcy5fcmVjb3JkaW5nQ3JlYXRlZCwgdGhpcyk7CiAgICAg V2ViSW5zcGVjdG9yLnRpbWVsaW5lTWFuYWdlci5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rv ci5UaW1lbGluZU1hbmFnZXIuRXZlbnQuUmVjb3JkaW5nTG9hZGVkLCB0aGlzLl9yZWNvcmRpbmdM b2FkZWQsIHRoaXMpOwogCi0gICAgdGhpcy5fc3RyaXBlQmFja2dyb3VuZEVsZW1lbnQgPSBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKLSAgICB0aGlzLl9zdHJpcGVCYWNrZ3JvdW5kRWxl bWVudC5jbGFzc05hbWUgPSBXZWJJbnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFuZWwuU3RyaXBl QmFja2dyb3VuZFN0eWxlQ2xhc3M7Ci0gICAgdGhpcy5jb250ZW50RWxlbWVudC5pbnNlcnRCZWZv cmUodGhpcy5fc3RyaXBlQmFja2dyb3VuZEVsZW1lbnQsIHRoaXMuY29udGVudEVsZW1lbnQuZmly c3RDaGlsZCk7Ci0KICAgICBXZWJJbnNwZWN0b3IuY29udGVudEJyb3dzZXIuYWRkRXZlbnRMaXN0 ZW5lcihXZWJJbnNwZWN0b3IuQ29udGVudEJyb3dzZXIuRXZlbnQuQ3VycmVudENvbnRlbnRWaWV3 RGlkQ2hhbmdlLCB0aGlzLl9jb250ZW50QnJvd3NlckN1cnJlbnRDb250ZW50Vmlld0RpZENoYW5n ZSwgdGhpcyk7CiAgICAgV2ViSW5zcGVjdG9yLnRpbWVsaW5lTWFuYWdlci5hZGRFdmVudExpc3Rl bmVyKFdlYkluc3BlY3Rvci5UaW1lbGluZU1hbmFnZXIuRXZlbnQuQ2FwdHVyaW5nU3RhcnRlZCwg dGhpcy5fY2FwdHVyaW5nU3RhcnRlZCwgdGhpcyk7CiAgICAgV2ViSW5zcGVjdG9yLnRpbWVsaW5l TWFuYWdlci5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5UaW1lbGluZU1hbmFnZXIuRXZl bnQuQ2FwdHVyaW5nU3RvcHBlZCwgdGhpcy5fY2FwdHVyaW5nU3RvcHBlZCwgdGhpcyk7CkBAIC0x NTUsNyArMTUxLDYgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lU2lkZWJhclBhbmVsLlRpdGxlQmFy U3R5bGVDbGFzcyA9ICJ0aXRsZS1iYXIiOwogV2ViSW5zcGVjdG9yLlRpbWVsaW5lU2lkZWJhclBh bmVsLlRpbWVsaW5lc1RpdGxlQmFyU3R5bGVDbGFzcyA9ICJ0aW1lbGluZXMiOwogV2ViSW5zcGVj dG9yLlRpbWVsaW5lU2lkZWJhclBhbmVsLlRpbWVsaW5lRXZlbnRzVGl0bGVCYXJTdHlsZUNsYXNz ID0gInRpbWVsaW5lLWV2ZW50cyI7CiBXZWJJbnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFuZWwu VGltZWxpbmVzQ29udGVudENvbnRhaW5lclN0eWxlQ2xhc3MgPSAidGltZWxpbmVzLWNvbnRlbnQi OwotV2ViSW5zcGVjdG9yLlRpbWVsaW5lU2lkZWJhclBhbmVsLlN0cmlwZUJhY2tncm91bmRTdHls ZUNsYXNzID0gInN0cmlwZS1iYWNrZ3JvdW5kIjsKIFdlYkluc3BlY3Rvci5UaW1lbGluZVNpZGVi YXJQYW5lbC5DbG9zZUJ1dHRvblN0eWxlQ2xhc3MgPSAiY2xvc2UtYnV0dG9uIjsKIFdlYkluc3Bl Y3Rvci5UaW1lbGluZVNpZGViYXJQYW5lbC5MYXJnZUljb25TdHlsZUNsYXNzID0gImxhcmdlIjsK IFdlYkluc3BlY3Rvci5UaW1lbGluZVNpZGViYXJQYW5lbC5TdG9wd2F0Y2hJY29uU3R5bGVDbGFz cyA9ICJzdG9wd2F0Y2gtaWNvbiI7CkBAIC0yODgsMTcgKzI4Myw2IEBAIFdlYkluc3BlY3Rvci5U aW1lbGluZVNpZGViYXJQYW5lbC5wcm90b3R5cGUgPSB7CiAKICAgICAvLyBQcm90ZWN0ZWQKIAot ICAgIHVwZGF0ZUN1c3RvbUNvbnRlbnRPdmVyZmxvdzogZnVuY3Rpb24oKQotICAgIHsKLSAgICAg ICAgaWYgKCF0aGlzLl9zdHJpcGVCYWNrZ3JvdW5kRWxlbWVudCkKLSAgICAgICAgICAgIHJldHVy bjsKLQotICAgICAgICB2YXIgY29udGVudEhlaWdodCA9IHRoaXMuY29udGVudFRyZWVPdXRsaW5l LmVsZW1lbnQub2Zmc2V0SGVpZ2h0OwotICAgICAgICB2YXIgY3VycmVudEhlaWdodCA9IHBhcnNl SW50KHRoaXMuX3N0cmlwZUJhY2tncm91bmRFbGVtZW50LnN0eWxlLmhlaWdodCk7Ci0gICAgICAg IGlmIChjdXJyZW50SGVpZ2h0ICE9PSBjb250ZW50SGVpZ2h0KQotICAgICAgICAgICAgdGhpcy5f c3RyaXBlQmFja2dyb3VuZEVsZW1lbnQuc3R5bGUuaGVpZ2h0ID0gY29udGVudEhlaWdodCArICJw eCI7Ci0gICAgfSwKLQogICAgIGhhc0N1c3RvbUZpbHRlcnM6IGZ1bmN0aW9uKCkKICAgICB7CiAg ICAgICAgIHJldHVybiB0cnVlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVWaWV3LmNzcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVmlldy5jc3MKaW5kZXggOTIzZWQ3ZS4uOTQ0 YWI4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVGltZWxpbmVWaWV3LmNzcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UaW1lbGluZVZpZXcuY3NzCkBAIC0zMCwzICszMCwxMyBAQAogICAgIHJpZ2h0 OiAwOwogICAgIGJvdHRvbTogMDsKIH0KKworLnBhbmVsLm5hdmlnYXRpb24udGltZWxpbmUgPiAu Y29udGVudCA+IC5uYXZpZ2F0aW9uLXNpZGViYXItcGFuZWwtY29udGVudC10cmVlLW91dGxpbmUg eworICAgIG1pbi1oZWlnaHQ6IDEwMCU7CisgICAgYmFja2dyb3VuZC1pbWFnZTogbm9uZTsKK30K KworLnBhbmVsLm5hdmlnYXRpb24udGltZWxpbmUudGltZWxpbmUtY29udGVudC12aWV3LXNob3dp bmcgPiAuY29udGVudCA+IC5uYXZpZ2F0aW9uLXNpZGViYXItcGFuZWwtY29udGVudC10cmVlLW91 dGxpbmUgeworICAgIGJhY2tncm91bmQtaW1hZ2U6IGxpbmVhci1ncmFkaWVudCh0byBib3R0b20s IHRyYW5zcGFyZW50LCB0cmFuc3BhcmVudCA1MCUsIHJnYmEoMCwgMCwgMCwgMC4wMykgNTAlLCBy Z2JhKDAsIDAsIDAsIDAuMDMpKTsKKyAgICBiYWNrZ3JvdW5kLXNpemU6IDEwMCUgNDBweDsKK30K