<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>136007</bug_id>
          
          <creation_ts>2014-08-15 16:55:58 -0700</creation_ts>
          <short_desc>[Win] Link to static VS2013 runtime library</short_desc>
          <delta_ts>2014-08-18 08:48:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Blocker</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>ossy</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1029523</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-08-15 16:55:58 -0700</bug_when>
    <thetext>This bug switches our build from using the VS2013 DLL to linking to the static library.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029524</commentid>
    <comment_count>1</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-08-15 16:56:18 -0700</bug_when>
    <thetext>&lt;rdar://problem/18037766&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029526</commentid>
    <comment_count>2</comment_count>
      <attachid>236693</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-08-15 16:58:21 -0700</bug_when>
    <thetext>Created attachment 236693
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029535</commentid>
    <comment_count>3</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-08-15 17:42:50 -0700</bug_when>
    <thetext>Committed r172661: &lt;http://trac.webkit.org/changeset/172661&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029628</commentid>
    <comment_count>4</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-08-16 11:01:22 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; Committed r172661: &lt;http://trac.webkit.org/changeset/172661&gt;

FYI: It broke the build on the Apple Windows buildbots and EWS</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029766</commentid>
    <comment_count>5</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-08-18 08:48:31 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (In reply to comment #3)
&gt; &gt; Committed r172661: &lt;http://trac.webkit.org/changeset/172661&gt;
&gt; 
&gt; FYI: It broke the build on the Apple Windows buildbots and EWS

This is fixed. We needed to update the WebKitSystemInterface.lib to a version that statically linked to VS2013 runtime.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>236693</attachid>
            <date>2014-08-15 16:58:21 -0700</date>
            <delta_ts>2014-08-15 17:10:52 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-136007-20140815165915.patch</filename>
            <type>text/plain</type>
            <size>2392</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0TGli
cmFyaWVzL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyNjU5KQorKysgV2ViS2l0TGlicmFyaWVzL0No
YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA4LTE1ICBCcmVu
dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIExpbmsgdG8g
c3RhdGljIFZTMjAxMyBydW50aW1lIGxpYnJhcnkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYwMDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE4
MDM3NzY2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
ICogd2luL3Rvb2xzL3ZzcHJvcHMvY29tbW9uLnByb3BzOiBVcGRhdGUgbGluayBjb21tYW5kLgor
ICAgICAgICAqIHdpbi90b29scy92c3Byb3BzL2RlYnVnc3VmZml4LnByb3BzOiBEaXR0by4KKwog
MjAxNC0wOC0xNCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAg
ICBbV2luXSBFeHRlbmQgYXV0by12ZXJzaW9uIGFuZCB2ZXJzaW9uLXN0YW1wIGZvciBSQ19Qcm9q
ZWN0QnVpbGRWZXJzaW9uCkluZGV4OiBXZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMv
Y29tbW9uLnByb3BzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNw
cm9wcy9jb21tb24ucHJvcHMJKHJldmlzaW9uIDE3MjYyNykKKysrIFdlYktpdExpYnJhcmllcy93
aW4vdG9vbHMvdnNwcm9wcy9jb21tb24ucHJvcHMJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDcgKzQ3
LDcgQEAgbm1ha2UgL25vbG9nbyAtZiAkKFByb2plY3ROYW1lKS5tYWtlIGNsZQogICAgICAgPFRy
ZWF0V2FybmluZ0FzRXJyb3I+ZmFsc2U8L1RyZWF0V2FybmluZ0FzRXJyb3I+CiAgICAgICA8RGVi
dWdJbmZvcm1hdGlvbkZvcm1hdD5Qcm9ncmFtRGF0YWJhc2U8L0RlYnVnSW5mb3JtYXRpb25Gb3Jt
YXQ+CiAgICAgICA8RGlzYWJsZVNwZWNpZmljV2FybmluZ3M+NDAxODs0MDY4OzQwOTk7NDEwMDs0
MTI3OzQxMzg7NDE0Njs0MTgwOzQxODk7NDIwMTs0MjQ0OzQyNTE7NDI2Nzs0Mjc1OzQyODg7NDI5
MTs0MzA1OzQzMDk7NDM0NDs0MzU1OzQzODk7NDM5Njs0NDgxOzQ1MDM7NDUwNTs0NTEwOzQ1MTI7
NDUzMDs0NjEwOzQ3MDI7NDcwNjs0ODAwOzQ4MTk7NDk1MTs0OTUyOzQ5OTY7NjAxMTs2MDMxOzYy
MTE7NjI0Njs2MjU1OzYzODc7JShEaXNhYmxlU3BlY2lmaWNXYXJuaW5ncyk8L0Rpc2FibGVTcGVj
aWZpY1dhcm5pbmdzPgotICAgICAgPFJ1bnRpbWVMaWJyYXJ5Pk11bHRpVGhyZWFkZWRETEw8L1J1
bnRpbWVMaWJyYXJ5PgorICAgICAgPFJ1bnRpbWVMaWJyYXJ5Pk11bHRpVGhyZWFkZWQ8L1J1bnRp
bWVMaWJyYXJ5PgogICAgICAgPEZ1bmN0aW9uTGV2ZWxMaW5raW5nPmZhbHNlPC9GdW5jdGlvbkxl
dmVsTGlua2luZz4KICAgICAgIDxGbG9hdGluZ1BvaW50RXhjZXB0aW9ucz5mYWxzZTwvRmxvYXRp
bmdQb2ludEV4Y2VwdGlvbnM+CiAgICAgICA8T3Blbk1QU3VwcG9ydD5mYWxzZTwvT3Blbk1QU3Vw
cG9ydD4KSW5kZXg6IFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9kZWJ1Z3N1ZmZp
eC5wcm9wcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMv
ZGVidWdzdWZmaXgucHJvcHMJKHJldmlzaW9uIDE3MjYyNykKKysrIFdlYktpdExpYnJhcmllcy93
aW4vdG9vbHMvdnNwcm9wcy9kZWJ1Z3N1ZmZpeC5wcm9wcwkod29ya2luZyBjb3B5KQpAQCAtMTEs
NyArMTEsNyBAQAogICA8SXRlbURlZmluaXRpb25Hcm91cD4KICAgICA8Q2xDb21waWxlPgogICAg
ICAgPFByZXByb2Nlc3NvckRlZmluaXRpb25zPl9DT05TT0xFO0RFQlVHX0lOVEVSTkFMO0RFQlVH
X0FMTDslKFByZXByb2Nlc3NvckRlZmluaXRpb25zKTwvUHJlcHJvY2Vzc29yRGVmaW5pdGlvbnM+
Ci0gICAgICA8UnVudGltZUxpYnJhcnk+TXVsdGlUaHJlYWRlZERlYnVnRExMPC9SdW50aW1lTGli
cmFyeT4KKyAgICAgIDxSdW50aW1lTGlicmFyeT5NdWx0aVRocmVhZGVkRGVidWc8L1J1bnRpbWVM
aWJyYXJ5PgogICAgIDwvQ2xDb21waWxlPgogICAgIDxMaWI+CiAgICAgICA8T3V0cHV0RmlsZT4k
KE91dERpcilcJChQcm9qZWN0TmFtZSkkKERlYnVnU3VmZml4KS5saWI8L091dHB1dEZpbGU+Cg==
</data>
<flag name="review"
          id="261369"
          type_id="1"
          status="+"
          setter="dino"
    />
          </attachment>
      

    </bug>

</bugzilla>