135995 2014-08-15 15:21:18 -0700 Web Inspector: Inspect Element doesn't always highlight the correct element when inspector is closed before inspecting 2014-08-15 17:57:00 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jonowells jonowells commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1029477 0 jonowells 2014-08-15 15:21:18 -0700 In pages with heavy use of frames, a frame might trigger restore of a selected element after the inspected element has been highlighted. <rdar://problem/17971908> 1029484 1 236682 jonowells 2014-08-15 15:37:52 -0700 Created attachment 236682 [PATCH] Attempted fix. 1029527 2 236682 joepeck 2014-08-15 17:07:53 -0700 Comment on attachment 236682 [PATCH] Attempted fix. View in context: https://bugs.webkit.org/attachment.cgi?id=236682&action=review > Source/WebInspectorUI/ChangeLog:11 > + Change so if an element is inspected, restoreSelectedNodeIsAllowed is set to false > + and kept in that state until the main resource changes or is refreshed. This way an > + attempt by a frame on a page to restore a node will not change the highlighted > + element unexpectedly. There is a lot of ambiguity in this ChangeLog comment! How about something like: (emphasis mine and can be removed) Change so if an element is inspected *via the Inspect Element context menu*, selected node restoration is disallowed until the main resource *in the main frame* changes. This way an attempt by a *sub-frame* will not change the highlighted element in the Main Frame's DOM tree unexpectedly. > Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:272 > + _mainResourceDidChange: function(event) { > + if (event.target.isMainFrame()) > + this._restoreSelectedNodeIsAllowed = true; > + }, Style: Opening brace should be on its own line Style: This function should be down at the bottom of this file in the Private section. 1029528 3 joepeck 2014-08-15 17:08:35 -0700 > until the main resource *in the main frame* changes Can just be until a page navigation / reload. 1029532 4 236695 jonowells 2014-08-15 17:17:00 -0700 Created attachment 236695 [PATCH] Attempted fix, review feedback. 1029536 5 236695 commit-queue 2014-08-15 17:56:57 -0700 Comment on attachment 236695 [PATCH] Attempted fix, review feedback. Clearing flags on attachment: 236695 Committed r172662: <http://trac.webkit.org/changeset/172662> 1029537 6 commit-queue 2014-08-15 17:57:00 -0700 All reviewed patches have been landed. Closing bug. 236682 2014-08-15 15:37:52 -0700 2014-08-15 17:17:00 -0700 [PATCH] Attempted fix. inspect.diff text/plain 2568 jonowells ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDMwZjEyNWUuLmZkNTMzOTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA4LTE1ICBKb25vIFdlbGxzICA8 am9ub3dlbGxzQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0IEVs ZW1lbnQgZG9lc24ndCBhbHdheXMgaGlnaGxpZ2h0IHRoZSBjb3JyZWN0IGVsZW1lbnQgd2hlbiBp bnNwZWN0b3IgaXMgY2xvc2VkIGJlZm9yZSBpbnNwZWN0aW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU5OTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2Ugc28gaWYgYW4gZWxlbWVudCBpcyBp bnNwZWN0ZWQsIHJlc3RvcmVTZWxlY3RlZE5vZGVJc0FsbG93ZWQgaXMgc2V0IHRvIGZhbHNlCisg ICAgICAgIGFuZCBrZXB0IGluIHRoYXQgc3RhdGUgdW50aWwgdGhlIG1haW4gcmVzb3VyY2UgY2hh bmdlcyBvciBpcyByZWZyZXNoZWQuIFRoaXMgd2F5IGFuCisgICAgICAgIGF0dGVtcHQgYnkgYSBm cmFtZSBvbiBhIHBhZ2UgdG8gcmVzdG9yZSBhIG5vZGUgd2lsbCBub3QgY2hhbmdlIHRoZSBoaWdo bGlnaHRlZAorICAgICAgICBlbGVtZW50IHVuZXhwZWN0ZWRseS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NVHJlZU1hbmFnZXIuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuRE9NVHJlZU1hbmFnZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVNYW5h Z2VyLnByb3RvdHlwZS5fbWFpblJlc291cmNlRGlkQ2hhbmdlKToKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5ET01UcmVlTWFuYWdlci5wcm90b3R5cGUuaW5zcGVjdEVsZW1lbnQpOgorCiAyMDE0LTA4 LTE1ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBQcm9iZSBkZXRhaWxzIHNpZGViYXIgZGF0YSBncmlkcyBkbyBub3Qgc2hvdyBk YXRhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250 cm9sbGVycy9ET01UcmVlTWFuYWdlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTVRyZWVNYW5hZ2VyLmpzCmluZGV4IGI1NTc4MDYuLjZhYmE1 MDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRy b2xsZXJzL0RPTVRyZWVNYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTVRyZWVNYW5hZ2VyLmpzCkBAIC0zNyw2ICszNyw4IEBA IFdlYkluc3BlY3Rvci5ET01UcmVlTWFuYWdlciA9IGZ1bmN0aW9uKCkgewogICAgIHRoaXMuX2Zs b3dzID0gbmV3IE1hcDsKICAgICB0aGlzLl9jb250ZW50Tm9kZXNUb0Zsb3dzTWFwID0gbmV3IE1h cDsKICAgICB0aGlzLl9yZXN0b3JlU2VsZWN0ZWROb2RlSXNBbGxvd2VkID0gdHJ1ZTsKKworICAg IFdlYkluc3BlY3Rvci5GcmFtZS5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5GcmFtZS5F dmVudC5NYWluUmVzb3VyY2VEaWRDaGFuZ2UsIHRoaXMuX21haW5SZXNvdXJjZURpZENoYW5nZSwg dGhpcyk7CiB9OwogCiBXZWJJbnNwZWN0b3IuT2JqZWN0LmFkZENvbnN0cnVjdG9yRnVuY3Rpb25z KFdlYkluc3BlY3Rvci5ET01UcmVlTWFuYWdlcik7CkBAIC0yNjQsNiArMjY2LDExIEBAIFdlYklu c3BlY3Rvci5ET01UcmVlTWFuYWdlci5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB0aGlzLl91 bmJpbmQobm9kZS5jaGlsZHJlbltpXSk7CiAgICAgfSwKIAorICAgIF9tYWluUmVzb3VyY2VEaWRD aGFuZ2U6IGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgICAgIGlmIChldmVudC50YXJnZXQuaXNNYWlu RnJhbWUoKSkKKyAgICAgICAgICAgIHRoaXMuX3Jlc3RvcmVTZWxlY3RlZE5vZGVJc0FsbG93ZWQg PSB0cnVlOworICAgIH0sCisKICAgICBnZXQgcmVzdG9yZVNlbGVjdGVkTm9kZUlzQWxsb3dlZCgp CiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fcmVzdG9yZVNlbGVjdGVkTm9kZUlzQWxsb3dl ZDsKQEAgLTI3MSw4ICsyNzgsNiBAQCBXZWJJbnNwZWN0b3IuRE9NVHJlZU1hbmFnZXIucHJvdG90 eXBlID0gewogCiAgICAgaW5zcGVjdEVsZW1lbnQ6IGZ1bmN0aW9uKG5vZGVJZCkKICAgICB7Ci0g ICAgICAgIHRoaXMuX3Jlc3RvcmVTZWxlY3RlZE5vZGVJc0FsbG93ZWQgPSB0cnVlOwotCiAgICAg ICAgIHZhciBub2RlID0gdGhpcy5faWRUb0RPTU5vZGVbbm9kZUlkXTsKICAgICAgICAgaWYgKG5v ZGUpCiAgICAgICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0 b3IuRE9NVHJlZU1hbmFnZXIuRXZlbnQuRE9NTm9kZVdhc0luc3BlY3RlZCwge25vZGU6IG5vZGV9 KTsK 236695 2014-08-15 17:17:00 -0700 2014-08-15 17:56:57 -0700 [PATCH] Attempted fix, review feedback. inspect.diff text/plain 2508 jonowells ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDMwZjEyNWUuLjhhNTQ2YzkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA4LTE1ICBKb25vIFdlbGxzICA8 am9ub3dlbGxzQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0IEVs ZW1lbnQgZG9lc24ndCBhbHdheXMgaGlnaGxpZ2h0IHRoZSBjb3JyZWN0IGVsZW1lbnQgd2hlbiBp bnNwZWN0b3IgaXMgY2xvc2VkIGJlZm9yZSBpbnNwZWN0aW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU5OTUKKworICAgICAgICBSZXZpZXdlZCBi eSBKb3NlcGggUGVjb3Jhcm8uCisKKyAgICAgICAgQ2hhbmdlIHNvIGlmIGFuIGVsZW1lbnQgaXMg aW5zcGVjdGVkIHZpYSB0aGUgSW5zcGVjdCBFbGVtZW50IGNvbnRleHQgbWVudSwgc2VsZWN0ZWQK KyAgICAgICAgbm9kZSByZXN0b3JhdGlvbiBpcyBkaXNhbGxvd2VkIHVudGlsIHRoZSBtYWluIHJl c291cmNlIGluIHRoZSBtYWluIGZyYW1lIGNoYW5nZXMuCisgICAgICAgIFRoaXMgd2F5IGFuIGF0 dGVtcHQgYnkgYSBzdWItZnJhbWUgd2lsbCBub3QgY2hhbmdlIHRoZSBoaWdobGlnaHRlZCBlbGVt ZW50IGluIHRoZQorICAgICAgICBNYWluIEZyYW1lJ3MgRE9NIHRyZWUgdW5leHBlY3RlZGx5Lgor CisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9ET01UcmVlTWFuYWdlci5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlTWFuYWdlcik6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuRE9NVHJlZU1hbmFnZXIucHJvdG90eXBlLl9tYWluUmVzb3VyY2VEaWRDaGFuZ2UpOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVNYW5hZ2VyLnByb3RvdHlwZS5pbnNwZWN0RWxl bWVudCk6CisKIDIwMTQtMDgtMTUgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29t PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFByb2JlIGRldGFpbHMgc2lkZWJhciBkYXRhIGdy aWRzIGRvIG5vdCBzaG93IGRhdGEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTVRyZWVNYW5hZ2VyLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NVHJlZU1hbmFnZXIuanMKaW5k ZXggYjU1NzgwNi4uNTNhYTJjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NVHJlZU1hbmFnZXIuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NVHJlZU1hbmFnZXIuanMK QEAgLTM3LDYgKzM3LDggQEAgV2ViSW5zcGVjdG9yLkRPTVRyZWVNYW5hZ2VyID0gZnVuY3Rpb24o KSB7CiAgICAgdGhpcy5fZmxvd3MgPSBuZXcgTWFwOwogICAgIHRoaXMuX2NvbnRlbnROb2Rlc1Rv Rmxvd3NNYXAgPSBuZXcgTWFwOwogICAgIHRoaXMuX3Jlc3RvcmVTZWxlY3RlZE5vZGVJc0FsbG93 ZWQgPSB0cnVlOworCisgICAgV2ViSW5zcGVjdG9yLkZyYW1lLmFkZEV2ZW50TGlzdGVuZXIoV2Vi SW5zcGVjdG9yLkZyYW1lLkV2ZW50Lk1haW5SZXNvdXJjZURpZENoYW5nZSwgdGhpcy5fbWFpblJl c291cmNlRGlkQ2hhbmdlLCB0aGlzKTsKIH07CiAKIFdlYkluc3BlY3Rvci5PYmplY3QuYWRkQ29u c3RydWN0b3JGdW5jdGlvbnMoV2ViSW5zcGVjdG9yLkRPTVRyZWVNYW5hZ2VyKTsKQEAgLTI3MSw4 ICsyNzMsNiBAQCBXZWJJbnNwZWN0b3IuRE9NVHJlZU1hbmFnZXIucHJvdG90eXBlID0gewogCiAg ICAgaW5zcGVjdEVsZW1lbnQ6IGZ1bmN0aW9uKG5vZGVJZCkKICAgICB7Ci0gICAgICAgIHRoaXMu X3Jlc3RvcmVTZWxlY3RlZE5vZGVJc0FsbG93ZWQgPSB0cnVlOwotCiAgICAgICAgIHZhciBub2Rl ID0gdGhpcy5faWRUb0RPTU5vZGVbbm9kZUlkXTsKICAgICAgICAgaWYgKG5vZGUpCiAgICAgICAg ICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuRE9NVHJlZU1h bmFnZXIuRXZlbnQuRE9NTm9kZVdhc0luc3BlY3RlZCwge25vZGU6IG5vZGV9KTsKQEAgLTcxMSw2 ICs3MTEsMTQgQEAgV2ViSW5zcGVjdG9yLkRPTVRyZWVNYW5hZ2VyLnByb3RvdHlwZSA9IHsKIAog ICAgICAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICAgICAgfQorICAgIH0sCisKKyAgICAvLyBQ cml2YXRlCisKKyAgICBfbWFpblJlc291cmNlRGlkQ2hhbmdlOiBmdW5jdGlvbihldmVudCkKKyAg ICB7CisgICAgICAgIGlmIChldmVudC50YXJnZXQuaXNNYWluRnJhbWUoKSkKKyAgICAgICAgICAg IHRoaXMuX3Jlc3RvcmVTZWxlY3RlZE5vZGVJc0FsbG93ZWQgPSB0cnVlOwogICAgIH0KIH07CiAK