135991 2014-08-15 12:49:56 -0700 Fix plugin visibility check. 2014-08-15 14:22:33 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 1029436 0 barraclough 2014-08-15 12:49:56 -0700 We should only take a UserActivity if the plugin is in a visible window, and also is itself visible. 1029437 1 236671 barraclough 2014-08-15 12:53:38 -0700 Created attachment 236671 Fix 1029446 2 236671 kling 2014-08-15 13:21:31 -0700 Comment on attachment 236671 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=236671&action=review r=me > Source/WebKit2/ChangeLog:20 > + - added m_isVisibile, m_isWindowVisibile, updateVisiblityActivity. m_isVisibile -> m_isVisible m_isWindowVisibile -> m_isWindowVisible updateVisiblityActivity -> updateVisibilityActivity 1029453 3 barraclough 2014-08-15 13:32:36 -0700 Transmitting file data ... Committed revision 172645. 1029455 4 barraclough 2014-08-15 13:37:48 -0700 Type fix Transmitting file data ... Committed revision 172646. 1029470 5 barraclough 2014-08-15 14:22:33 -0700 Transmitting file data ... Committed revision 172653. 236671 2014-08-15 12:53:38 -0700 2014-08-15 13:21:31 -0700 Fix 135991.1.patch text/plain 3788 barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MjY0MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA4LTE1ICBHYXZpbiBC YXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggcGx1Z2lu IHZpc2liaWxpdHkgY2hlY2suCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzU5OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXZSBzaG91bGQgb25seSB0YWtlIGEgVXNlckFjdGl2aXR5IGlmIHRoZSBwbHVn aW4gaXMgaW4gYSB2aXNpYmxlIHdpbmRvdywKKyAgICAgICAgYW5kIGFsc28gaXMgaXRzZWxmIHZp c2libGUuCisKKyAgICAgICAgKiBQbHVnaW5Qcm9jZXNzL1BsdWdpbkNvbnRyb2xsZXJQcm94eS5j cHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpbkNvbnRyb2xsZXJQcm94eTo6UGx1Z2luQ29udHJv bGxlclByb3h5KToKKyAgICAgICAgICAgIC0gaW5pdGlhbGl6ZSBtZW1iZXIgc3RhdGUuCisgICAg ICAgIChXZWJLaXQ6OlBsdWdpbkNvbnRyb2xsZXJQcm94eTo6dmlzaWJpbGl0eURpZENoYW5nZSk6 CisgICAgICAgIChXZWJLaXQ6OlBsdWdpbkNvbnRyb2xsZXJQcm94eTo6d2luZG93VmlzaWJpbGl0 eUNoYW5nZWQpOgorICAgICAgICAgICAgLSB1cGRhdGUgbWVtYmVyIHN0YXRlICYgY2FsbCB1cGRh dGVWaXNpYmxpdHlBY3Rpdml0eS4KKyAgICAgICAgKFdlYktpdDo6UGx1Z2luQ29udHJvbGxlclBy b3h5Ojp1cGRhdGVWaXNpYmxpdHlBY3Rpdml0eSk6CisgICAgICAgICAgICAtIGVuYWJsZSB0aGUg VXNlckFjdGl2aXR5IG9ubHkgaWYgYm90aCB2aXNpYmlsaXRpZXMgYXJlIHRydWUuCisgICAgICAg ICogUGx1Z2luUHJvY2Vzcy9QbHVnaW5Db250cm9sbGVyUHJveHkuaDoKKyAgICAgICAgICAgIC0g YWRkZWQgbV9pc1Zpc2liaWxlLCBtX2lzV2luZG93VmlzaWJpbGUsIHVwZGF0ZVZpc2libGl0eUFj dGl2aXR5LgorCiAyMDE0LTA4LTE1ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUu Y29tPgogCiAgICAgICAgIFNlcnZpY2Ugb3ZlcmxheXMgc3RheSBmaXhlZCB3aGVuIDxpZnJhbWU+ IHNjcm9sbHMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvUGx1Z2luQ29udHJv bGxlclByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNz L1BsdWdpbkNvbnRyb2xsZXJQcm94eS5jcHAJKHJldmlzaW9uIDE3MjYzNykKKysrIFNvdXJjZS9X ZWJLaXQyL1BsdWdpblByb2Nlc3MvUGx1Z2luQ29udHJvbGxlclByb3h5LmNwcAkod29ya2luZyBj b3B5KQpAQCAtNjEsNiArNjEsOCBAQCBQbHVnaW5Db250cm9sbGVyUHJveHk6OlBsdWdpbkNvbnRy b2xsZXJQCiAgICAgLCBtX2lzUHJpdmF0ZUJyb3dzaW5nRW5hYmxlZChjcmVhdGlvblBhcmFtZXRl cnMuaXNQcml2YXRlQnJvd3NpbmdFbmFibGVkKQogICAgICwgbV9pc0FjY2VsZXJhdGVkQ29tcG9z aXRpbmdFbmFibGVkKGNyZWF0aW9uUGFyYW1ldGVycy5pc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdF bmFibGVkKQogICAgICwgbV9pc0luaXRpYWxpemluZyhmYWxzZSkKKyAgICAsIG1faXNWaXNpYmls ZShmYWxzZSkKKyAgICAsIG1faXNXaW5kb3dWaXNpYmlsZShmYWxzZSkKICAgICAsIG1fcGFpbnRU aW1lcihSdW5Mb29wOjptYWluKCksIHRoaXMsICZQbHVnaW5Db250cm9sbGVyUHJveHk6OnBhaW50 KQogICAgICwgbV9wbHVnaW5EZXN0cnVjdGlvblByb3RlY3RDb3VudCgwKQogICAgICwgbV9wbHVn aW5EZXN0cm95VGltZXIoUnVuTG9vcDo6bWFpbigpLCB0aGlzLCAmUGx1Z2luQ29udHJvbGxlclBy b3h5OjpkZXN0cm95KQpAQCAtNDMwLDggKzQzMiwxMiBAQCB2b2lkIFBsdWdpbkNvbnRyb2xsZXJQ cm94eTo6Z2VvbWV0cnlEaWRDCiAKIHZvaWQgUGx1Z2luQ29udHJvbGxlclByb3h5Ojp2aXNpYmls aXR5RGlkQ2hhbmdlKGJvb2wgaXNWaXNpYmxlKQogeworICAgIG1faXNWaXNpYmlsZSA9IGlzVmlz aWJsZTsKKyAgICAKICAgICBBU1NFUlQobV9wbHVnaW4pOwogICAgIG1fcGx1Z2luLT52aXNpYmls aXR5RGlkQ2hhbmdlKGlzVmlzaWJsZSk7CisKKyAgICB1cGRhdGVWaXNpYmxpdHlBY3Rpdml0eSgp OwogfQogCiB2b2lkIFBsdWdpbkNvbnRyb2xsZXJQcm94eTo6d2luZG93Rm9jdXNDaGFuZ2VkKGJv b2wgaGFzRm9jdXMpCkBAIC00NDIsMTAgKzQ0OCwxNyBAQCB2b2lkIFBsdWdpbkNvbnRyb2xsZXJQ cm94eTo6d2luZG93Rm9jdXNDCiAKIHZvaWQgUGx1Z2luQ29udHJvbGxlclByb3h5Ojp3aW5kb3dW aXNpYmlsaXR5Q2hhbmdlZChib29sIGlzVmlzaWJsZSkKIHsKKyAgICBtX2lzV2luZG93VmlzaWJp bGUgPSBpc1Zpc2libGU7CisKICAgICBBU1NFUlQobV9wbHVnaW4pOwogICAgIG1fcGx1Z2luLT53 aW5kb3dWaXNpYmlsaXR5Q2hhbmdlZChpc1Zpc2libGUpOwogCi0gICAgaWYgKGlzVmlzaWJsZSkK KyAgICB1cGRhdGVWaXNpYmxpdHlBY3Rpdml0eSgpOworfQorCit2b2lkIFBsdWdpbkNvbnRyb2xs ZXJQcm94eTo6dXBkYXRlVmlzaWJsaXR5QWN0aXZpdHkoKQoreworICAgIGlmIChtX2lzVmlzaWJp bGUgJiYgbV9pc1dpbmRvd1Zpc2liaWxlKQogICAgICAgICBtX3Zpc2libGl0eUFjdGl2aXR5LnN0 YXJ0KCk7CiAgICAgZWxzZQogICAgICAgICBtX3Zpc2libGl0eUFjdGl2aXR5LnN0b3AoKTsKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvUGx1Z2luQ29udHJvbGxlclByb3h5LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9QbHVnaW5Db250cm9s bGVyUHJveHkuaAkocmV2aXNpb24gMTcyNjM3KQorKysgU291cmNlL1dlYktpdDIvUGx1Z2luUHJv Y2Vzcy9QbHVnaW5Db250cm9sbGVyUHJveHkuaAkod29ya2luZyBjb3B5KQpAQCAtMTUxLDYgKzE1 MSw3IEBAIHByaXZhdGU6CiAKICAgICB2b2lkIHdpbmRvd0ZvY3VzQ2hhbmdlZChib29sKTsKICAg ICB2b2lkIHdpbmRvd1Zpc2liaWxpdHlDaGFuZ2VkKGJvb2wpOworICAgIHZvaWQgdXBkYXRlVmlz aWJsaXR5QWN0aXZpdHkoKTsKIAogI2lmIFBMQVRGT1JNKENPQ09BKQogICAgIHZvaWQgd2luZG93 QW5kVmlld0ZyYW1lc0NoYW5nZWQoY29uc3QgV2ViQ29yZTo6SW50UmVjdCYgd2luZG93RnJhbWVJ blNjcmVlbkNvb3JkaW5hdGVzLCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiB2aWV3RnJhbWVJbldp bmRvd0Nvb3JkaW5hdGVzKTsKQEAgLTE3Niw2ICsxNzcsOCBAQCBwcml2YXRlOgogICAgIGJvb2wg bV9pc1ByaXZhdGVCcm93c2luZ0VuYWJsZWQ7CiAgICAgYm9vbCBtX2lzQWNjZWxlcmF0ZWRDb21w b3NpdGluZ0VuYWJsZWQ7CiAgICAgYm9vbCBtX2lzSW5pdGlhbGl6aW5nOworICAgIGJvb2wgbV9p c1Zpc2liaWxlOworICAgIGJvb2wgbV9pc1dpbmRvd1Zpc2liaWxlOwogCiAgICAgUmVmUHRyPE1l c3NhZ2VzOjpXZWJQcm9jZXNzQ29ubmVjdGlvbjo6Q3JlYXRlUGx1Z2luOjpEZWxheWVkUmVwbHk+ IG1faW5pdGlhbGl6YXRpb25SZXBseTsKIAo=