135989 2014-08-15 11:59:17 -0700 [Services with UI] Selections are incorrect when selecting three lines. 2014-08-15 12:53:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica thorton oldest_to_newest 1029415 0 enrica 2014-08-15 11:59:17 -0700 1. Go to http://www.apple.com/contact 2. Select three lines of text 4. Try to hover it. Expected: Services overlay should show up, in the right place, triggered by hovering the text. Actual: Services overlay shows up when hovering the first and last line only.  <rdar://problem/18032571> 1029419 1 236665 enrica 2014-08-15 12:06:54 -0700 Created attachment 236665 Patch 1029429 2 236665 thorton 2014-08-15 12:16:03 -0700 Comment on attachment 236665 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236665&action=review > Source/WebKit2/ChangeLog:10 > + over theree lines, if the middle line is composed of only one rectangle. s/theree/three/, and no comma. 1029438 3 enrica 2014-08-15 12:53:45 -0700 Committed revision 172643. 236665 2014-08-15 12:06:54 -0700 2014-08-15 12:16:03 -0700 Patch stitch3.txt text/plain 3163 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MjYzNykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA4LTE1ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW1NlcnZpY2VzIHdpdGggVUld IFNlbGVjdGlvbnMgYXJlIGluY29ycmVjdCB3aGVuIHNlbGVjdGluZyB0aHJlZSBsaW5lcy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTk4OQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMTgwMzI1NzE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHN0aXRjaGluZyBhbGdvcml0aG0gZGlkIG5vdCBo YW5kbGUgY29ycmVjdGx5IHRoZSBjYXNlIG9mIHNlbGVjdGlvbnMKKyAgICAgICAgb3ZlciB0aGVy ZWUgbGluZXMsIGlmIHRoZSBtaWRkbGUgbGluZSBpcyBjb21wb3NlZCBvZiBvbmx5IG9uZSByZWN0 YW5nbGUuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3Zlcmxh eUNvbnRyb2xsZXIubW06CisgICAgICAgIChXZWJLaXQ6OnN0aXRjaFJlY3RzKToKKwogMjAxNC0w OC0xNSAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAg ICAgZGUtUExBVEZPUk0oQ09DT0EpIGEgY291cGxlIG9mIG1ldGhvZHMgaW4gcGx1Z2luIGNvZGUK SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVy bGF5Q29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIubW0JKHJldmlzaW9uIDE3MjYz NykKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVy bGF5Q29udHJvbGxlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMjc5LDcgKzI3OSw3IEBAIHN0YXRp YyBpbmxpbmUgdm9pZCBzdGl0Y2hSZWN0cyhWZWN0b3I8TGEKICAgICAvLyBGaXJzdCBzdGl0Y2gg dG9nZXRoZXIgYWxsIHRoZSByZWN0cyBvbiB0aGUgZmlyc3QgbGluZSBvZiB0aGUgc2VsZWN0aW9u LgogICAgIHNpemVfdCBpbmRleEZyb21TdGFydCA9IDA7CiAgICAgTGF5b3V0VW5pdCBmaXJzdFRv cCA9IHJlY3RzW2luZGV4RnJvbVN0YXJ0XS55KCk7Ci0gICAgTGF5b3V0UmVjdCYgY3VycmVudFJl Y3QgPSByZWN0c1tpbmRleEZyb21TdGFydCsrXTsKKyAgICBMYXlvdXRSZWN0JiBjdXJyZW50UmVj dCA9IHJlY3RzW2luZGV4RnJvbVN0YXJ0XTsKICAgICB3aGlsZSAoaW5kZXhGcm9tU3RhcnQgPCBy ZWN0cy5zaXplKCkgJiYgcmVjdHNbaW5kZXhGcm9tU3RhcnRdLnkoKSA9PSBmaXJzdFRvcCkKICAg ICAgICAgY3VycmVudFJlY3QudW5pdGUocmVjdHNbaW5kZXhGcm9tU3RhcnQrK10pOwogICAgIApA QCAtMjk0LDE4ICsyOTQsMjIgQEAgc3RhdGljIGlubGluZSB2b2lkIHN0aXRjaFJlY3RzKFZlY3Rv cjxMYQogICAgIHNpemVfdCBpbmRleEZyb21FbmQgPSByZWN0cy5zaXplKCkgLSAxOwogICAgIExh eW91dFVuaXQgbGFzdFRvcCA9IHJlY3RzW2luZGV4RnJvbUVuZF0ueSgpOwogICAgIExheW91dFJl Y3QgbGFzdFJlY3QgPSByZWN0c1tpbmRleEZyb21FbmRdOwotICAgIHdoaWxlIChpbmRleEZyb21F bmQgIT0gaW5kZXhGcm9tU3RhcnQgJiYgcmVjdHNbLS1pbmRleEZyb21FbmRdLnkoKSA9PSBsYXN0 VG9wKQotICAgICAgICBsYXN0UmVjdC51bml0ZShyZWN0c1tpbmRleEZyb21FbmRdKTsKKyAgICB3 aGlsZSAoaW5kZXhGcm9tRW5kID49IGluZGV4RnJvbVN0YXJ0ICYmIHJlY3RzW2luZGV4RnJvbUVu ZF0ueSgpID09IGxhc3RUb3ApCisgICAgICAgIGxhc3RSZWN0LnVuaXRlKHJlY3RzW2luZGV4RnJv bUVuZC0tXSk7CiAgICAgCi0gICAgaWYgKGluZGV4RnJvbUVuZCA9PSBpbmRleEZyb21TdGFydCkg ewotICAgICAgICAvLyBBbGwgdGhlIHJlY3RzIGFyZSBvbiB0d28gbGluZXMgb25seS4gVGhlcmUg aXMgbm90aGluZyBlbHNlIHRvIGRvLgorICAgIC8vIGluZGV4RnJvbVN0YXJ0IGlzIHRoZSBpbmRl eCBvZiB0aGUgZmlyc3QgcmVjdGFuZ2xlIG9uIHRoZSBzZWNvbmQgbGluZS4KKyAgICAvLyBpbmRl eEZyb21FbmQgaXMgdGhlIGluZGV4IG9mIHRoZSBsYXN0IHJlY3RhbmdsZSBvbiB0aGUgc2Vjb25k IHRvIHRoZSBsYXN0IGxpbmUuCisgICAgLy8gaWYgdGhleSBhcmUgZXF1YWwsIHRoZXJlIGlzIG9u ZSBhZGRpdGlvbmFsIHJlY3RhbmdsZSBmb3IgdGhlIGxpbmUgaW4gdGhlIG1pZGRsZS4KKyAgICBp ZiAoaW5kZXhGcm9tRW5kID09IGluZGV4RnJvbVN0YXJ0KQorICAgICAgICBuZXdSZWN0cy5hcHBl bmQocmVjdHNbaW5kZXhGcm9tU3RhcnRdKTsKKyAgICAKKyAgICBpZiAoaW5kZXhGcm9tRW5kIDw9 IGluZGV4RnJvbVN0YXJ0KSB7CisgICAgICAgIC8vIFRoZXJlIGFyZSBubyBtb3JlIHJlY3RzIHRv IHN0aXRjaC4gSnVzdCBhcHBlbmQgdGhlIGxhc3QgbGluZS4KICAgICAgICAgbmV3UmVjdHMuYXBw ZW5kKGxhc3RSZWN0KTsKICAgICAgICAgcmVjdHMuc3dhcChuZXdSZWN0cyk7CiAgICAgICAgIHJl dHVybjsKICAgICB9CiAgICAgCi0gICAgLy8gaW5kZXhGcm9tU3RhcnQgaXMgdGhlIGluZGV4IG9m IHRoZSBmaXJzdCByZWN0YW5nbGUgb24gdGhlIHNlY29uZCBsaW5lLgotICAgIC8vIGluZGV4RnJv bUVuZCBpcyB0aGUgaW5kZXggb2YgdGhlIGxhc3QgcmVjdGFuZ2xlIG9uIHRoZSBzZWNvbmQgdG8g dGhlIGxhc3QgbGluZS4KICAgICAvLyBTdGl0Y2ggdG9nZXRoZXIgYWxsIHRoZSByZWN0cyBhZnRl ciB0aGUgZmlyc3QgbGluZSB1bnRpbCB0aGUgc2Vjb25kIHRvIHRoZSBsYXN0IGluY2x1ZGVkLgog ICAgIGN1cnJlbnRSZWN0ID0gcmVjdHNbaW5kZXhGcm9tU3RhcnRdOwogICAgIHdoaWxlIChpbmRl eEZyb21TdGFydCAhPSBpbmRleEZyb21FbmQpCg==