135988 2014-08-15 11:44:36 -0700 Native library inlining crashes when module isn't found 2014-08-15 14:04:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mmirman mmirman commit-queue fpizlo ggaren mmirman oldest_to_newest 1029405 0 mmirman 2014-08-15 11:44:36 -0700 Patch forthcoming. 1029413 1 236663 mmirman 2014-08-15 11:56:39 -0700 Created attachment 236663 fixed native library inlining in the ftl segfaulting Also abstracts out an "Options::verboseCompilation" 1029451 2 236663 ggaren 2014-08-15 13:30:50 -0700 Comment on attachment 236663 fixed native library inlining in the ftl segfaulting View in context: https://bugs.webkit.org/attachment.cgi?id=236663&action=review > Source/JavaScriptCore/ChangeLog:15 > + (JSC::FTL::LowerDFGToLLVM::compilePutById): > + abstracted out Options::verboseCompilation as was the case in the rest of the file. > + (JSC::FTL::LowerDFGToLLVM::compileNativeCallOrConstruct): > + (JSC::FTL::LowerDFGToLLVM::getModuleByPathForSymbol): > + added output error messages for llvm module loading. Best to capitalize these sentences. 1029461 3 236663 commit-queue 2014-08-15 14:04:48 -0700 Comment on attachment 236663 fixed native library inlining in the ftl segfaulting Clearing flags on attachment: 236663 Committed r172648: <http://trac.webkit.org/changeset/172648> 1029462 4 commit-queue 2014-08-15 14:04:51 -0700 All reviewed patches have been landed. Closing bug. 236663 2014-08-15 11:56:39 -0700 2014-08-15 14:04:48 -0700 fixed native library inlining in the ftl segfaulting 0001-Made-native-inlining-errors-not-segfault.patch text/plain 4755 mmirman ZGlmZiAtLWdpdCBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggMGU1NmIwNS4uOWMzMjQwNiAxMDA2NDQKLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxNC0wOC0xNSAgTWF0dGhldyBNaXJtYW4gIDxtbWly bWFuQGFwcGxlLmNvbT4KKworICAgICAgICBNYWRlIG5hdGl2ZSBpbmxpbmluZyBlcnJvcnMgbm90 IHNlZ2ZhdWx0LiAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNTk4OAorICAgICAgICAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBmdGwvRlRMQWJicmV2aWF0aW9ucy5oOgorICAgICAgICAoSlNDOjpGVEw6 OmRpc3Bvc2VNZXNzYWdlKTogQWRkZWQuCisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9MTFZN LmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6Y29tcGlsZVB1dEJ5SWQp OiAKKyAgICAgICAgYWJzdHJhY3RlZCBvdXQgT3B0aW9uczo6dmVyYm9zZUNvbXBpbGF0aW9uIGFz IHdhcyB0aGUgY2FzZSBpbiB0aGUgcmVzdCBvZiB0aGUgZmlsZS4KKyAgICAgICAgKEpTQzo6RlRM OjpMb3dlckRGR1RvTExWTTo6Y29tcGlsZU5hdGl2ZUNhbGxPckNvbnN0cnVjdCk6CisgICAgICAg IChKU0M6OkZUTDo6TG93ZXJERkdUb0xMVk06OmdldE1vZHVsZUJ5UGF0aEZvclN5bWJvbCk6IAor ICAgICAgICBhZGRlZCBvdXRwdXQgZXJyb3IgbWVzc2FnZXMgZm9yIGxsdm0gbW9kdWxlIGxvYWRp bmcuCisKIDIwMTQtMDgtMTIgIFBleXRvbiBSYW5kb2xwaCAgPHByYW5kb2xwaEBhcHBsZS5jb20+ CiAKICAgICAgICAgUnVudGltZSBzd2l0Y2ggZm9yIGxvbmcgbW91c2UgcHJlc3MgZ2VzdHVyZS4g UGFydCBvZiAxMzUyNTcgLSBBZGQgbG9uZyBtb3VzZSBwcmVzcyBnZXN0dXJlLgpkaWZmIC0tZ2l0 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQWJicmV2aWF0aW9ucy5oIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9mdGwvRlRMQWJicmV2aWF0aW9ucy5oCmluZGV4IGEzNjBkZWYyLi5mYzdjYjFi IDEwMDY0NAotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYmJyZXZpYXRpb25zLmgK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQWJicmV2aWF0aW9ucy5oCkBAIC0xODcs NiArMTg3LDggQEAgc3RhdGljIGlubGluZSB2b2lkIGRpc3Bvc2VNZW1vcnlCdWZmZXIoTExWTU1l bW9yeUJ1ZmZlclJlZiBtZW1CdWYpeyBsbHZtLT5EaXNwb3MKIHN0YXRpYyBpbmxpbmUgTE1vZHVs ZSBtb2R1bGVDcmVhdGVXaXRoTmFtZUluQ29udGV4dChjb25zdCBjaGFyKiBtb2R1bGVJRCwgTENv bnRleHQgY29udGV4dCl7IHJldHVybiBsbHZtLT5Nb2R1bGVDcmVhdGVXaXRoTmFtZUluQ29udGV4 dChtb2R1bGVJRCwgY29udGV4dCk7IH0KIHN0YXRpYyBpbmxpbmUgdm9pZCBkaXNwb3NlTW9kdWxl KExNb2R1bGUgbSl7IGxsdm0tPkRpc3Bvc2VNb2R1bGUobSk7IH0KIAorc3RhdGljIGlubGluZSB2 b2lkIGRpc3Bvc2VNZXNzYWdlKGNoYXIqIG91dE1zZykgeyBsbHZtLT5EaXNwb3NlTWVzc2FnZShv dXRNc2cpOyB9CisKIHN0YXRpYyBpbmxpbmUgTFZhbHVlIGdldFBhcmFtKExWYWx1ZSBmdW5jdGlv biwgdW5zaWduZWQgaW5kZXgpIHsgcmV0dXJuIGxsdm0tPkdldFBhcmFtKGZ1bmN0aW9uLCBpbmRl eCk7IH0KIAogc3RhdGljIGlubGluZSB2b2lkIGdldFBhcmFtVHlwZXMoTFR5cGUgZnVuY3Rpb24s IExUeXBlKiBkZXN0KSB7IHJldHVybiBsbHZtLT5HZXRQYXJhbVR5cGVzKGZ1bmN0aW9uLCBkZXN0 KTsgfQpkaWZmIC0tZ2l0IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xM Vk0uY3BwIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCmlu ZGV4IGIyYWUxNmUuLmVjMWZiOGIgMTAwNjQ0Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRs L0ZUTExvd2VyREZHVG9MTFZNLmNwcAorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExM b3dlckRGR1RvTExWTS5jcHAKQEAgLTE4OTksNyArMTg5OSw3IEBAIHByaXZhdGU6CiAgICAgICAg IC8vIEFyZ3VtZW50czogaWQsIGJ5dGVzLCB0YXJnZXQsIG51bUFyZ3MsIGFyZ3MuLi4KICAgICAg ICAgdW5zaWduZWQgc3RhY2ttYXBJRCA9IG1fc3RhY2ttYXBJRHMrKzsKIAotICAgICAgICBpZiAo T3B0aW9uczo6dmVyYm9zZUNvbXBpbGF0aW9uKCkpCisgICAgICAgIGlmICh2ZXJib3NlQ29tcGls YXRpb25FbmFibGVkKCkpCiAgICAgICAgICAgICBkYXRhTG9nKCIgICAgRW1pdHRpbmcgUHV0QnlJ ZCBwYXRjaHBvaW50IHdpdGggc3RhY2ttYXAgIyIsIHN0YWNrbWFwSUQsICJcbiIpOwogICAgICAg ICAKICAgICAgICAgTFZhbHVlIGNhbGwgPSBtX291dC5jYWxsKApAQCAtMzcxNSw3ICszNzE1LDcg QEAgcHJpdmF0ZToKICAgICAgICAgICAgIDogbV9vdXQuYml0Q2FzdChjYWxsZWVDYWxsRnJhbWUs IHR5cGVDYWxsZWVBcmcpOwogICAgICAgICBMVmFsdWUgY2FsbCA9IHZtQ2FsbChjYWxsZWUsIGFy Z3VtZW50KTsKIAotICAgICAgICBpZiAoT3B0aW9uczo6dmVyYm9zZUNvbXBpbGF0aW9uKCkpCisg ICAgICAgIGlmICh2ZXJib3NlQ29tcGlsYXRpb25FbmFibGVkKCkpCiAgICAgICAgICAgICBkYXRh TG9nKCJOYXRpdmUgY2FsbGluZzogIiwgaW5mby5kbGlfc25hbWUsICJcbiIpOwogCiAgICAgICAg IHNldEpTVmFsdWUoY2FsbCk7CkBAIC00MzgyLDE2ICs0MzgyLDIyIEBAIHByaXZhdGU6CiAgICAg ICAgICAgICBpc1g4NigpID8gIi9SZXNvdXJjZXMvUnVudGltZS94ODZfNjQvIiA6ICIvUmVzb3Vy Y2VzL1J1bnRpbWUvYXJtNjQvIiwKICAgICAgICAgICAgIHBhdGguZGF0YSgpKTsKIAotICAgICAg ICBpZiAoY3JlYXRlTWVtb3J5QnVmZmVyV2l0aENvbnRlbnRzT2ZGaWxlKGFjdHVhbFBhdGguZGF0 YSgpLCAmbWVtQnVmLCBudWxscHRyKSkgewotICAgICAgICAgICAgaWYgKE9wdGlvbnM6OnZlcmJv c2VDb21waWxhdGlvbigpKSAKLSAgICAgICAgICAgICAgICBkYXRhTG9nKCJGYWlsZWQgdG8gbG9h ZCBtb2R1bGUgYXQgIiwgYWN0dWFsUGF0aC5kYXRhKCksICJcbiBmb3Igc3ltYm9sICIsIHN5bWJv bC5kYXRhKCkpOworICAgICAgICBjaGFyKiBvdXRNc2c7CisgICAgICAgIAorICAgICAgICBpZiAo Y3JlYXRlTWVtb3J5QnVmZmVyV2l0aENvbnRlbnRzT2ZGaWxlKGFjdHVhbFBhdGguZGF0YSgpLCAm bWVtQnVmLCAmb3V0TXNnKSkgeworICAgICAgICAgICAgaWYgKE9wdGlvbnM6OnZlcmJvc2VGVExG YWlsdXJlKCkpCisgICAgICAgICAgICAgICAgZGF0YUxvZygiRmFpbGVkIHRvIGxvYWQgbW9kdWxl IGF0ICIsIGFjdHVhbFBhdGgsICJcbiBmb3Igc3ltYm9sICIsIHN5bWJvbCwgIlxuRVJST1I6ICIs IG91dE1zZywgIlxuIik7CisgICAgICAgICAgICBkaXNwb3NlTWVzc2FnZShvdXRNc2cpOwogICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICB9CiAKICAgICAgICAgTE1vZHVsZSBtb2R1 bGU7CiAKLSAgICAgICAgaWYgKHBhcnNlQml0Y29kZUluQ29udGV4dChtX2Z0bFN0YXRlLmNvbnRl eHQsIG1lbUJ1ZiwgJm1vZHVsZSwgbnVsbHB0cikpIHsKKyAgICAgICAgaWYgKHBhcnNlQml0Y29k ZUluQ29udGV4dChtX2Z0bFN0YXRlLmNvbnRleHQsIG1lbUJ1ZiwgJm1vZHVsZSwgJm91dE1zZykp IHsKKyAgICAgICAgICAgIGlmIChPcHRpb25zOjp2ZXJib3NlRlRMRmFpbHVyZSgpKQorICAgICAg ICAgICAgICAgIGRhdGFMb2coIkZhaWxlZCB0byBwYXJzZSBtb2R1bGUgYXQgIiwgYWN0dWFsUGF0 aCwgIlxuIGZvciBzeW1ib2wgIiwgc3ltYm9sLCAiXG5FUlJPUjogIiwgb3V0TXNnLCAiXG4iKTsK ICAgICAgICAgICAgIGRpc3Bvc2VNZW1vcnlCdWZmZXIobWVtQnVmKTsKKyAgICAgICAgICAgIGRp c3Bvc2VNZXNzYWdlKG91dE1zZyk7CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAg IH0KIApAQCAtNDQyNCw4ICs0NDMwLDEyIEBAIHByaXZhdGU6CiAgICAgICAgICAgICBuYW1lZEds b2JhbHMuYXBwZW5kKGdsb2JhbE5hbWUpOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKGxpbmtN b2R1bGVzKG1fZnRsU3RhdGUubW9kdWxlLCBtb2R1bGUsIExMVk1MaW5rZXJEZXN0cm95U291cmNl LCBudWxscHRyKSkKKyAgICAgICAgaWYgKGxpbmtNb2R1bGVzKG1fZnRsU3RhdGUubW9kdWxlLCBt b2R1bGUsIExMVk1MaW5rZXJEZXN0cm95U291cmNlLCAmb3V0TXNnKSkgeworICAgICAgICAgICAg aWYgKE9wdGlvbnM6OnZlcmJvc2VGVExGYWlsdXJlKCkpCisgICAgICAgICAgICAgICAgZGF0YUxv ZygiRmFpbGVkIHRvIGxpbmsgbW9kdWxlIGF0ICIsIGFjdHVhbFBhdGgsICJcbiBmb3Igc3ltYm9s ICIsIHN5bWJvbCwgIlxuRVJST1I6ICIsIG91dE1zZywgIlxuIik7CisgICAgICAgICAgICBkaXNw b3NlTWVzc2FnZShvdXRNc2cpOwogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICB9 CiAgICAgICAgIAogICAgICAgICBmb3IgKENTdHJpbmcqIHN5bWJvbCA9IG5hbWVkRnVuY3Rpb25z LmJlZ2luKCk7IHN5bWJvbCAhPSBuYW1lZEZ1bmN0aW9ucy5lbmQoKTsgKytzeW1ib2wpIHsKICAg ICAgICAgICAgIExWYWx1ZSBmdW5jdGlvbiA9IGdldE5hbWVkRnVuY3Rpb24obV9mdGxTdGF0ZS5t b2R1bGUsIHN5bWJvbC0+ZGF0YSgpKTsK