135968 2014-08-15 00:12:05 -0700 CSS JIT: compile :-webkit-full-page-media 2014-08-15 18:37:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin ap oldest_to_newest 1029306 0 benjamin 2014-08-15 00:12:05 -0700 CSS JIT: compile :-webkit-full-page-media 1029307 1 236644 benjamin 2014-08-15 00:14:34 -0700 Created attachment 236644 Patch 1029361 2 236644 ap 2014-08-15 10:07:55 -0700 Comment on attachment 236644 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236644&action=review > Source/WebCore/ChangeLog:10 > + It would be possible to inline it, but this selector is so unommon I don't think Typo: should be "uncommon". > Source/WebCore/css/SelectorCheckerTestFunctions.h:76 > +ALWAYS_INLINE bool isMediaDocument(const Element* element) Does this have to take a const? Node/Element constness is a highly questionable concept, which I thought we agreed to not use, see <https://lists.webkit.org/pipermail/webkit-dev/2011-May/016875.html>. 1029540 3 benjamin 2014-08-15 18:19:17 -0700 Thanks for the review! > > Source/WebCore/css/SelectorCheckerTestFunctions.h:76 > > +ALWAYS_INLINE bool isMediaDocument(const Element* element) > > Does this have to take a const? Node/Element constness is a highly questionable concept, which I thought we agreed to not use, see <https://lists.webkit.org/pipermail/webkit-dev/2011-May/016875.html>. The const has no value here, I'll remove it. 1029544 4 benjamin 2014-08-15 18:37:51 -0700 Committed r172663: <http://trac.webkit.org/changeset/172663> 236644 2014-08-15 00:14:34 -0700 2014-08-15 10:07:55 -0700 Patch bug-135968-20140815001424.patch text/plain 3873 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGI4Mzk0OTE1ODE3ZjMw OWU2NWIxYmY0OTAxNzllMjM0YmNhMTE2Ni4uYWM5ZDA3NzZjYjA2NjU1NDQzMzI0ZWFhZWQxYTcz M2RkYjNhYjA5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA4LTE1ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBDU1MgSklUOiBj b21waWxlIDotd2Via2l0LWZ1bGwtcGFnZS1tZWRpYQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1OTY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRoZSBwc2V1ZG8gY2xhc3MgOi13ZWJraXQtZnVs bC1wYWdlLW1lZGlhIHdpdGggYW4gdW5vcHRpbWl6ZWQgZnVuY3Rpb24gY2FsbC4KKworICAgICAg ICBJdCB3b3VsZCBiZSBwb3NzaWJsZSB0byBpbmxpbmUgaXQsIGJ1dCB0aGlzIHNlbGVjdG9yIGlz IHNvIHVub21tb24gSSBkb24ndCB0aGluaworICAgICAgICBpdCBpcyB3b3J0aCBoYXZpbmcgYW55 IGFkZGl0aW9uYWwgY29tcGxleGl0eSBmb3IgaXQuCisKKyAgICAgICAgKiBjc3MvU2VsZWN0b3JD aGVja2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdG9yQ2hlY2tlcjo6Y2hlY2tPbmUp OgorICAgICAgICAqIGNzcy9TZWxlY3RvckNoZWNrZXJUZXN0RnVuY3Rpb25zLmg6CisgICAgICAg IChXZWJDb3JlOjppc01lZGlhRG9jdW1lbnQpOgorICAgICAgICAqIGNzc2ppdC9TZWxlY3RvckNv bXBpbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdG9yQ29tcGlsZXI6OmFkZFBzZXVk b0NsYXNzVHlwZSk6CisKIDIwMTQtMDgtMTQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUu Y29tPgogCiAgICAgICAgIFJlbW92ZSB0d28gdW51c2VkIFJhbmdlIGZ1bmN0aW9ucy4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAKaW5kZXggZDY1ODViZDlmODlkZDRhNzY1ZTE1 NTI4ODdjMmQxNDdhOGUxMTQ3OC4uZWFkNDA2MzJkOTRiNDY5M2Y2NjhhNGM0ZGM4MzljOGUwYzQ0 YWNiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAKQEAgLTcyMyw3ICs3 MjMsNyBAQCBib29sIFNlbGVjdG9yQ2hlY2tlcjo6Y2hlY2tPbmUoY29uc3QgU2VsZWN0b3JDaGVj a2luZ0NvbnRleHQmIGNvbnRleHQpIGNvbnN0CiAgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBz ZXVkb0NsYXNzRW5hYmxlZDoKICAgICAgICAgICAgIHJldHVybiBpc0VuYWJsZWQoZWxlbWVudCk7 CiAgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVkb0NsYXNzRnVsbFBhZ2VNZWRpYToKLSAg ICAgICAgICAgIHJldHVybiBlbGVtZW50LT5kb2N1bWVudCgpLmlzTWVkaWFEb2N1bWVudCgpOwor ICAgICAgICAgICAgcmV0dXJuIGlzTWVkaWFEb2N1bWVudChlbGVtZW50KTsKICAgICAgICAgY2Fz ZSBDU1NTZWxlY3Rvcjo6UHNldWRvQ2xhc3NEZWZhdWx0OgogICAgICAgICAgICAgcmV0dXJuIGlz RGVmYXVsdEJ1dHRvbkZvckZvcm0oZWxlbWVudCk7CiAgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6 OlBzZXVkb0NsYXNzRGlzYWJsZWQ6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU2Vs ZWN0b3JDaGVja2VyVGVzdEZ1bmN0aW9ucy5oIGIvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9y Q2hlY2tlclRlc3RGdW5jdGlvbnMuaAppbmRleCA5NzM3YTYyODI3YTQ5N2I2OTI1YTNjZTI0NGMw MjY2ZDY4Y2I2NDg0Li5mOTY1ZDJkZWJhOTBlOGIxYzAyNzA1OTJlYzEyMTdhYzc2ODA2YTNmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVja2VyVGVzdEZ1bmN0aW9u cy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXJUZXN0RnVuY3Rpb25z LmgKQEAgLTczLDYgKzczLDExIEBAIEFMV0FZU19JTkxJTkUgYm9vbCBpc0VuYWJsZWQoY29uc3Qg RWxlbWVudCogZWxlbWVudCkKICAgICByZXR1cm4gaXNFbmFibGVkOwogfQogCitBTFdBWVNfSU5M SU5FIGJvb2wgaXNNZWRpYURvY3VtZW50KGNvbnN0IEVsZW1lbnQqIGVsZW1lbnQpCit7CisgICAg cmV0dXJuIGVsZW1lbnQtPmRvY3VtZW50KCkuaXNNZWRpYURvY3VtZW50KCk7Cit9CisKIEFMV0FZ U19JTkxJTkUgYm9vbCBpc0NoZWNrZWQoRWxlbWVudCogZWxlbWVudCkKIHsKICAgICAvLyBFdmVu IHRob3VnaCBXaW5JRSBhbGxvd3MgY2hlY2tlZCBhbmQgaW5kZXRlcm1pbmF0ZSB0byBjby1leGlz dCwgdGhlIENTUyBzZWxlY3RvciBzcGVjIHNheXMgdGhhdApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3Nzaml0L1NlbGVjdG9yQ29tcGlsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3Nzaml0 L1NlbGVjdG9yQ29tcGlsZXIuY3BwCmluZGV4IDM3NmQyZTI2NmJlNzIwMGY2ZmFhM2I0MDlmNmY0 ZmZiYmIxNGUwMDIuLjAyMjkzNTMyNGY3OWRmNTgzYjcyY2YyYzdmMjJjODkwMTg0ZjVjMjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzc2ppdC9TZWxlY3RvckNvbXBpbGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3NqaXQvU2VsZWN0b3JDb21waWxlci5jcHAKQEAgLTQzMCw2ICs0 MzAsOSBAQCBzdGF0aWMgaW5saW5lIEZ1bmN0aW9uVHlwZSBhZGRQc2V1ZG9DbGFzc1R5cGUoY29u c3QgQ1NTU2VsZWN0b3ImIHNlbGVjdG9yLCBTZWxlYwogICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBz ZXVkb0NsYXNzRm9jdXM6CiAgICAgICAgIGZyYWdtZW50LnVub3B0aW1pemVkUHNldWRvQ2xhc3Nl cy5hcHBlbmQoSlNDOjpGdW5jdGlvblB0cihTZWxlY3RvckNoZWNrZXI6Om1hdGNoZXNGb2N1c1Bz ZXVkb0NsYXNzKSk7CiAgICAgICAgIHJldHVybiBGdW5jdGlvblR5cGU6OlNpbXBsZVNlbGVjdG9y Q2hlY2tlcjsKKyAgICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9DbGFzc0Z1bGxQYWdlTWVkaWE6 CisgICAgICAgIGZyYWdtZW50LnVub3B0aW1pemVkUHNldWRvQ2xhc3Nlcy5hcHBlbmQoSlNDOjpG dW5jdGlvblB0cihpc01lZGlhRG9jdW1lbnQpKTsKKyAgICAgICAgcmV0dXJuIEZ1bmN0aW9uVHlw ZTo6U2ltcGxlU2VsZWN0b3JDaGVja2VyOwogICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVkb0Ns YXNzSW5SYW5nZToKICAgICAgICAgZnJhZ21lbnQudW5vcHRpbWl6ZWRQc2V1ZG9DbGFzc2VzLmFw cGVuZChKU0M6OkZ1bmN0aW9uUHRyKGlzSW5SYW5nZSkpOwogICAgICAgICByZXR1cm4gRnVuY3Rp b25UeXBlOjpTaW1wbGVTZWxlY3RvckNoZWNrZXI7CkBAIC01MDYsNyArNTA5LDYgQEAgc3RhdGlj IGlubGluZSBGdW5jdGlvblR5cGUgYWRkUHNldWRvQ2xhc3NUeXBlKGNvbnN0IENTU1NlbGVjdG9y JiBzZWxlY3RvciwgU2VsZWMKICAgICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9DbGFzc050aExh c3RPZlR5cGU6CiAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRvQ2xhc3NWaXNpdGVkOgogICAg IGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVkb0NsYXNzRHJhZzoKLSAgICBjYXNlIENTU1NlbGVjdG9y OjpQc2V1ZG9DbGFzc0Z1bGxQYWdlTWVkaWE6CiAgICAgICAgIHJldHVybiBGdW5jdGlvblR5cGU6 OkNhbm5vdENvbXBpbGU7CiAKICAgICAvLyBPcHRpbWl6ZWQgcHNldWRvIHNlbGVjdG9ycy4K