135950 2014-08-14 13:57:22 -0700 Web Inspector: Dragging Undocked inspector by window title has broken behavior 2014-08-14 17:30:57 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1029196 0 joepeck 2014-08-14 13:57:22 -0700 * SUMMARY Dragging Undocked inspector by window title has broken behavior. Releasing the mouse does not stop the drag and can be completely broken. Also there is flickering. * STEPS TO REPRODUCE 1. Inspect apple.com 2. Undock inspector if needed 3. Drag window vertically all the way to the top of the screen, release mouse 4. Try to mouse over the inspector window again => window goes bonkers 1029197 1 webkit-bug-importer 2014-08-14 13:57:30 -0700 <rdar://problem/18023242> 1029202 2 timothy 2014-08-14 14:05:09 -0700 Just the title or the whole title bar (22px) top? Do we need to draw our own title too? Sigh. 1029222 3 joepeck 2014-08-14 14:41:45 -0700 (In reply to comment #2) > Just the title or the whole title bar (22px) top? Do we need to draw our own title too? Sigh. Just the top 22pt. 1029224 4 timothy 2014-08-14 14:43:14 -0700 I wonder if both us and AppKit are trying to handle the drag. 1029240 5 236628 joepeck 2014-08-14 15:34:34 -0700 Created attachment 236628 [PATCH] Frontend Fix Could probably use some more testing. I made sure that you could drag on exactly event.pageY 21, 22, 23, etc. 1029275 6 236628 commit-queue 2014-08-14 17:30:55 -0700 Comment on attachment 236628 [PATCH] Frontend Fix Clearing flags on attachment: 236628 Committed r172617: <http://trac.webkit.org/changeset/172617> 1029276 7 commit-queue 2014-08-14 17:30:57 -0700 All reviewed patches have been landed. Closing bug. 236628 2014-08-14 15:34:34 -0700 2014-08-14 17:30:55 -0700 [PATCH] Frontend Fix fix-window-dragging.patch text/plain 3252 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDBkOThmODUuLmM4ZmUzMDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE0LTA4LTE0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRHJhZ2dp bmcgVW5kb2NrZWQgaW5zcGVjdG9yIGJ5IHdpbmRvdyB0aXRsZSBoYXMgYnJva2VuIGJlaGF2aW9y CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU5NTAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICBPbiBNYWMgcG9ydHMgd2hlcmUgd2UgdGhl IGluc3BlY3RvciBjb250ZW50IGdvZXMgZXZlcnl3aGVyZSwgd2luZG93IGRyYWdnaW5nIGJlaGF2 aW9yCisgICAgICAgIHN0aWxsIGV4aXN0cyBmb3IgdGhlIHRvcCAyMnB4IG9mIHRoZSB3aW5kb3cu IFNvIGRvbid0IGRvIG91ciBKYXZhU2NyaXB0IGJhc2VkIHdpbmRvdworICAgICAgICBkcmFnZ2lu ZyBmb3IgdGhpcyBzcGVjaWFsIHJlZ2lvbi4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9k ZWxzL0tleWJvYXJkU2hvcnRjdXQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRT aG9ydGN1dC5Nb2RpZmllci5nZXQgQ29tbWFuZE9yQ29udHJvbCk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5wcm90b3R5cGUuZ2V0IGRpc3BsYXlOYW1lKToKKyAgICAg ICAgSW5zdGVhZCBvZiBjYWxsaW5nIGEgaG9zdCBmdW5jdGlvbiwgdXNlIHRoZSB2YWx1ZSBhbHJl YWR5IGluIHRoZSBmcm9udGVuZC4KKworMjAxNC0wOC0xNCAgSm9zZXBoIFBlY29yYXJvICA8cGVj b3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNwbGl0IGNvbnNvbGUg dG9nZ2xlIGJ1dHRvbiB3cm9uZyAtIEltYWdlcy9JbWFnZXMvU3BsaXRUb2dnbGVVcC5zdmcgZG9l cyBub3QgZXhpc3QKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNTk1NwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL01haW4uanMKaW5kZXggMDRkMzlhOS4uYjM0OWE4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtMTMxNiw2ICsxMzE2LDEz IEBAIFdlYkluc3BlY3Rvci5fbW92ZVdpbmRvd01vdXNlRG93biA9IGZ1bmN0aW9uKGV2ZW50KQog ICAgICAgICAhZXZlbnQudGFyZ2V0LmNsYXNzTGlzdC5jb250YWlucygiaXRlbS1zZWN0aW9uIikp CiAgICAgICAgIHJldHVybjsKIAorICAgIC8vIElnbm9yZSBkcmFnZ2luZyBvbiB0aGUgdG9wIG9m IHRoZSB0b29sYmFyIG9uIE1hYyB3aGVyZSB0aGUgaW5zcGVjdG9yIGNvbnRlbnQgZmlsbHMgdGhl IGVudGlyZSB3aW5kb3cuCisgICAgaWYgKFdlYkluc3BlY3Rvci5QbGF0Zm9ybS5uYW1lID09PSAi bWFjIiAmJiBXZWJJbnNwZWN0b3IuUGxhdGZvcm0udmVyc2lvbi5yZWxlYXNlID49IDEwKSB7Cisg ICAgICAgIGNvbnN0IHdpbmRvd0RyYWdIYW5kbGVkVGl0bGVCYXJIZWlnaHQgPSAyMjsKKyAgICAg ICAgaWYgKGV2ZW50LnBhZ2VZIDwgd2luZG93RHJhZ0hhbmRsZWRUaXRsZUJhckhlaWdodCkKKyAg ICAgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICB2YXIgbGFzdFNjcmVlblggPSBldmVudC5z Y3JlZW5YOwogICAgIHZhciBsYXN0U2NyZWVuWSA9IGV2ZW50LnNjcmVlblk7CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9LZXlib2FyZFNo b3J0Y3V0LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0tl eWJvYXJkU2hvcnRjdXQuanMKaW5kZXggODk2YWQ0Ni4uMzZjMThmYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0tleWJvYXJkU2hvcnRjdXQu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0tleWJv YXJkU2hvcnRjdXQuanMKQEAgLTkzLDcgKzkzLDcgQEAgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hv cnRjdXQuTW9kaWZpZXIgPSB7CiAKICAgICBnZXQgQ29tbWFuZE9yQ29udHJvbCgpCiAgICAgewot ICAgICAgICByZXR1cm4gSW5zcGVjdG9yRnJvbnRlbmRIb3N0LnBsYXRmb3JtKCkgPT09ICJtYWMi ID8gdGhpcy5Db21tYW5kIDogdGhpcy5Db250cm9sOworICAgICAgICByZXR1cm4gV2ViSW5zcGVj dG9yLlBsYXRmb3JtLm5hbWUgPT09ICJtYWMiID8gdGhpcy5Db21tYW5kIDogdGhpcy5Db250cm9s OwogICAgIH0KIH07CiAKQEAgLTE4MSw3ICsxODEsNyBAQCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRT aG9ydGN1dC5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmICh0aGlzLl9tb2RpZmllcnMgJiBXZWJJ bnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db250cm9sKQogICAgICAgICAgICAg cmVzdWx0ICs9ICJcdTIzMDMiOwogICAgICAgICBpZiAodGhpcy5fbW9kaWZpZXJzICYgV2ViSW5z cGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuT3B0aW9uKQotICAgICAgICAgICAgcmVz dWx0ICs9IEluc3BlY3RvckZyb250ZW5kSG9zdC5wbGF0Zm9ybSgpID09PSAibWFjIiA/ICJcdTIz MjUiIDogIlx1MjM4NyI7CisgICAgICAgICAgICByZXN1bHQgKz0gV2ViSW5zcGVjdG9yLlBsYXRm b3JtLm5hbWUgPT09ICJtYWMiID8gIlx1MjMyNSIgOiAiXHUyMzg3IjsKICAgICAgICAgaWYgKHRo aXMuX21vZGlmaWVycyAmIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLlNo aWZ0KQogICAgICAgICAgICAgcmVzdWx0ICs9ICJcdTIxZTciOwogICAgICAgICBpZiAodGhpcy5f bW9kaWZpZXJzICYgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29tbWFu ZCkK