135949 2014-08-14 12:59:23 -0700 Web Inspector: Avoid re-binding the same function over and over 2014-08-14 14:34:53 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1029179 0 joepeck 2014-08-14 12:59:23 -0700 * SUMMARY During an auto capturing of pages, especially when doing the dead timeout check, we may be re-binding the same function hundreds of times. We should bind it once, it never changes. Possible performance issue. 1029180 1 webkit-bug-importer 2014-08-14 12:59:32 -0700 <rdar://problem/18022467> 1029181 2 236612 joepeck 2014-08-14 13:00:51 -0700 Created attachment 236612 [PATCH] Proposed Fix 1029182 3 joepeck 2014-08-14 13:01:47 -0700 For example reloading icloud.com this would happen over a thousand times. 1029215 4 236612 commit-queue 2014-08-14 14:34:51 -0700 Comment on attachment 236612 [PATCH] Proposed Fix Clearing flags on attachment: 236612 Committed r172606: <http://trac.webkit.org/changeset/172606> 1029216 5 commit-queue 2014-08-14 14:34:53 -0700 All reviewed patches have been landed. Closing bug. 236612 2014-08-14 13:00:51 -0700 2014-08-14 14:34:51 -0700 [PATCH] Proposed Fix stash-bound.patch text/plain 3029 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDUyMTZkYTIuLjRmMGZiMGIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE0LTA4LTE0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQXZvaWQg cmUtYmluZGluZyB0aGUgc2FtZSBmdW5jdGlvbiBvdmVyIGFuZCBvdmVyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU5NDkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJv bGxlcnMvVGltZWxpbmVNYW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5l TWFuYWdlci5wcm90b3R5cGUuX3N0YXJ0QXV0b0NhcHR1cmluZyk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuVGltZWxpbmVNYW5hZ2VyLnByb3RvdHlwZS5fc3RvcEF1dG9SZWNvcmRpbmdTb29uKToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZU1hbmFnZXIucHJvdG90eXBlLl9yZXNldEF1 dG9SZWNvcmRpbmdEZWFkVGltZVRpbWVvdXQpOgorICAgICAgICBTdGFzaCBhIGJvdW5kIGNvcHkg b2YgdGhlIGZ1bmN0aW9uIG9uY2UsIGFuZCByZXVzZSBpdC4KKworMjAxNC0wOC0xNCAgSm9zZXBo IFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IFRpbWVsaW5lcyBjYW4gZ2V0IGNhdWdodCBpbiByZXF1ZXN0QW5pbWF0aW9uRnJhbWUgbG9vcCB3 aGVuIG5vdCByZWNvcmRpbmcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzNTk0NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanMKaW5k ZXggZTJjZGQ2My4uOTAyMTJlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVGltZWxpbmVNYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5q cwpAQCAtMzcsNiArMzcsOCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVNYW5hZ2VyID0gZnVuY3Rp b24oKQogCiAgICAgdGhpcy5fbmV4dFJlY29yZGluZ0lkZW50aWZpZXIgPSAxOwogCisgICAgdGhp cy5fYm91bmRTdG9wQ2FwdHVyaW5nID0gdGhpcy5zdG9wQ2FwdHVyaW5nLmJpbmQodGhpcyk7CisK ICAgICBmdW5jdGlvbiBkZWxheWVkV29yaygpCiAgICAgewogICAgICAgICB0aGlzLl9sb2FkTmV3 UmVjb3JkaW5nKCk7CkBAIC00ODEsNyArNDgzLDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lTWFu YWdlci5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgaWYgKHRoaXMuX3N0b3BDYXB0dXJpbmdUaW1l b3V0KQogICAgICAgICAgICAgY2xlYXJUaW1lb3V0KHRoaXMuX3N0b3BDYXB0dXJpbmdUaW1lb3V0 KTsKLSAgICAgICAgdGhpcy5fc3RvcENhcHR1cmluZ1RpbWVvdXQgPSBzZXRUaW1lb3V0KHRoaXMu c3RvcENhcHR1cmluZy5iaW5kKHRoaXMpLCBXZWJJbnNwZWN0b3IuVGltZWxpbmVNYW5hZ2VyLk1h eGltdW1BdXRvUmVjb3JkRHVyYXRpb24pOworICAgICAgICB0aGlzLl9zdG9wQ2FwdHVyaW5nVGlt ZW91dCA9IHNldFRpbWVvdXQodGhpcy5fYm91bmRTdG9wQ2FwdHVyaW5nLCBXZWJJbnNwZWN0b3Iu VGltZWxpbmVNYW5hZ2VyLk1heGltdW1BdXRvUmVjb3JkRHVyYXRpb24pOwogCiAgICAgICAgIHJl dHVybiB0cnVlOwogICAgIH0sCkBAIC00OTQsNyArNDk2LDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVs aW5lTWFuYWdlci5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgaWYgKHRoaXMuX3N0b3BDYXB0dXJp bmdUaW1lb3V0KQogICAgICAgICAgICAgY2xlYXJUaW1lb3V0KHRoaXMuX3N0b3BDYXB0dXJpbmdU aW1lb3V0KTsKLSAgICAgICAgdGhpcy5fc3RvcENhcHR1cmluZ1RpbWVvdXQgPSBzZXRUaW1lb3V0 KHRoaXMuc3RvcENhcHR1cmluZy5iaW5kKHRoaXMpLCBXZWJJbnNwZWN0b3IuVGltZWxpbmVNYW5h Z2VyLk1heGltdW1BdXRvUmVjb3JkRHVyYXRpb25BZnRlckxvYWRFdmVudCk7CisgICAgICAgIHRo aXMuX3N0b3BDYXB0dXJpbmdUaW1lb3V0ID0gc2V0VGltZW91dCh0aGlzLl9ib3VuZFN0b3BDYXB0 dXJpbmcsIFdlYkluc3BlY3Rvci5UaW1lbGluZU1hbmFnZXIuTWF4aW11bUF1dG9SZWNvcmREdXJh dGlvbkFmdGVyTG9hZEV2ZW50KTsKICAgICB9LAogCiAgICAgX3Jlc2V0QXV0b1JlY29yZGluZ0Rl YWRUaW1lVGltZW91dDogZnVuY3Rpb24oKQpAQCAtNTA1LDcgKzUwNyw3IEBAIFdlYkluc3BlY3Rv ci5UaW1lbGluZU1hbmFnZXIucHJvdG90eXBlID0gewogCiAgICAgICAgIGlmICh0aGlzLl9kZWFk VGltZVRpbWVvdXQpCiAgICAgICAgICAgICBjbGVhclRpbWVvdXQodGhpcy5fZGVhZFRpbWVUaW1l b3V0KTsKLSAgICAgICAgdGhpcy5fZGVhZFRpbWVUaW1lb3V0ID0gc2V0VGltZW91dCh0aGlzLnN0 b3BDYXB0dXJpbmcuYmluZCh0aGlzKSwgV2ViSW5zcGVjdG9yLlRpbWVsaW5lTWFuYWdlci5EZWFk VGltZVJlcXVpcmVkVG9TdG9wQXV0b1JlY29yZGluZ0Vhcmx5KTsKKyAgICAgICAgdGhpcy5fZGVh ZFRpbWVUaW1lb3V0ID0gc2V0VGltZW91dCh0aGlzLl9ib3VuZFN0b3BDYXB0dXJpbmcsIFdlYklu c3BlY3Rvci5UaW1lbGluZU1hbmFnZXIuRGVhZFRpbWVSZXF1aXJlZFRvU3RvcEF1dG9SZWNvcmRp bmdFYXJseSk7CiAgICAgfSwKIAogICAgIF9tYWluUmVzb3VyY2VEaWRDaGFuZ2U6IGZ1bmN0aW9u KGV2ZW50KQo=