135946 2014-08-14 11:37:50 -0700 Web Inspector: Timelines can get caught in requestAnimationFrame loop when not recording 2014-08-14 13:40:37 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck burg commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1029151 0 joepeck 2014-08-14 11:37:50 -0700 * SUMMARY Profiling the inspector the Timelines can get caught in requestAnimationFrame loop when not recording. TimelineContentView.js: _update: function(timestamp) { if (this._waitingToResetCurrentTime) { requestAnimationFrame(this._updateCallback); return; } ... } * STEPS TO REPRODUCE 1. Inspect <http://bogojoker.com/shell/> 2. Reload the page and wait for the Timeline recording to auto stop 3. Reload the page and wait for the Timeline recording to auto stop => looping requestAnimationFrame 1029153 1 webkit-bug-importer 2014-08-14 11:37:58 -0700 <rdar://problem/18021462> 1029176 2 236610 joepeck 2014-08-14 12:49:32 -0700 Created attachment 236610 [PATCH] Proposed Fix 1029186 3 236610 timothy 2014-08-14 13:07:36 -0700 Comment on attachment 236610 [PATCH] Proposed Fix Nice! 1029193 4 236610 commit-queue 2014-08-14 13:40:34 -0700 Comment on attachment 236610 [PATCH] Proposed Fix Clearing flags on attachment: 236610 Committed r172601: <http://trac.webkit.org/changeset/172601> 1029194 5 commit-queue 2014-08-14 13:40:37 -0700 All reviewed patches have been landed. Closing bug. 236610 2014-08-14 12:49:32 -0700 2014-08-14 13:40:34 -0700 [PATCH] Proposed Fix unloading-recording.patch text/plain 6469 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRlNTQ4NGIuLjUyMTZkYTIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDE0LTA4LTE0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxp bmVzIGNhbiBnZXQgY2F1Z2h0IGluIHJlcXVlc3RBbmltYXRpb25GcmFtZSBsb29wIHdoZW4gbm90 IHJlY29yZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM1OTQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRWFjaCBUaW1lbGluZUNvbnRlbnRWaWV3IHdhcyBsaXN0ZW5pbmcgZm9yIHRoZSBUaW1lbGlu ZU1hbmFnZXIncyBzdGFydC9zdG9wCisgICAgICAgIGNhcHR1cmluZyBldmVudHMuIEhvd2V2ZXIs IG9ubHkgdGhlIGFjdGl2ZSByZWNvcmRpbmcgY291bGQgcG9zc2libHkgdXBkYXRlLgorICAgICAg ICBMaWtld2lzZSwgaWYgYSBwcmUtZXhpc3RpbmcgcmVjb3JkaW5nIHN0YXJ0ZWQgYW5kIHN0b3Bw ZWQgd2UgZGlkIG5vdCBwcm9wZXJseQorICAgICAgICBzdG9wIGluIHRoZSBjYXNlIHdoZXJlIHdl IHdlcmUgd2FpdGluZyBmb3IgYW4gZXZlbnQgdG8gdXBkYXRlIHRoZSBjdXJyZW50IHRpbWUsCisg ICAgICAgIHdoaWNoIHdvdWxkIHJlc3VsdCBpbiBhbiBpbmZpbml0ZSByQUYgbG9vcCBvZiBubyB1 cGRhdGVzLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvVGltZWxpbmVSZWNvcmRp bmcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmcucHJvdG90eXBl LnVubG9hZGVkKToKKyAgICAgICAgV2hlbiBhIHRpbWVsaW5lIHJlY29yZGluZyBpcyB1bmxvYWRl ZCB0cmlnZ2VyIGFuIGV2ZW50LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1l bGluZUNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lQ29udGVu dFZpZXcucHJvdG90eXBlLl9zdGFydFVwZGF0aW5nQ3VycmVudFRpbWUpOgorICAgICAgICBBc3Nl cnQgd2Ugd2VyZSBub3QgYWxyZWFkeSB3YWl0aW5nLgorCisgICAgICAgIChXZWJJbnNwZWN0b3Iu VGltZWxpbmVDb250ZW50Vmlldy5wcm90b3R5cGUuX3N0b3BVcGRhdGluZ0N1cnJlbnRUaW1lKToK KyAgICAgICAgUHJvcGVybHkgaGFuZGxlIHRoZSBjYXNlIG9mIHN0YXJ0aW5nL3N0b3BpbmcgYW4g YWxyZWFkeSBleGlzdGluZyByZWNvcmRpbmcKKyAgICAgICAgd2l0aG91dCBhIG5ldyBldmVudCBj b21pbmcgaW4uCisKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZUNvbnRlbnRWaWV3LnBy b3RvdHlwZS5fcmVjb3JkaW5nVGltZXNVcGRhdGVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5U aW1lbGluZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5fcmVjb3JkaW5nUmVzZXQpOgorICAgICAgICBD b252ZXJ0IHRvIGEgYm9vbGVhbiBpbnN0ZWFkIG9mIGRlbGV0aW5nIHN0YXRlLgorCisgICAgICAg IChXZWJJbnNwZWN0b3IuVGltZWxpbmVDb250ZW50Vmlldy5wcm90b3R5cGUuX3JlY29yZGluZ1Vu bG9hZGVkKToKKyAgICAgICAgU3RvcCBsaXN0ZW5pbmcgdG8gdGltZWxpbmUgbWFuYWdlciBldmVu dHMgdGhhdCBubyBsb25nZXIgYWZmZWN0IHVubG9hZGVkIHJlY29yZGluZ3MuCisKIDIwMTQtMDgt MTMgIEpvbm8gV2VsbHMgIDxqb25vd2VsbHNAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IGVzbGludCBjb25maWd1cmF0aW9uIHNob3VsZCBiZSBzdG9yZWQgYXMgLmVzbGludHJj CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMv VGltZWxpbmVSZWNvcmRpbmcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Nb2RlbHMvVGltZWxpbmVSZWNvcmRpbmcuanMKaW5kZXggY2VlODFlOC4uMjg1YTQ1ZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1RpbWVs aW5lUmVjb3JkaW5nLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L01vZGVscy9UaW1lbGluZVJlY29yZGluZy5qcwpAQCAtNDQsNiArNDQsNyBAQCBXZWJJbnNwZWN0 b3IuVGltZWxpbmVSZWNvcmRpbmcgPSBmdW5jdGlvbihpZGVudGlmaWVyLCBkaXNwbGF5TmFtZSkK IAogV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nLkV2ZW50ID0gewogICAgIFJlc2V0OiAi dGltZWxpbmUtcmVjb3JkaW5nLXJlc2V0IiwKKyAgICBVbmxvYWRlZDogInRpbWVsaW5lLXJlY29y ZGluZy11bmxvYWRlZCIsCiAgICAgU291cmNlQ29kZVRpbWVsaW5lQWRkZWQ6ICJ0aW1lbGluZS1y ZWNvcmRpbmctc291cmNlLWNvZGUtdGltZWxpbmUtYWRkZWQiLAogICAgIFRpbWVzVXBkYXRlZDog InRpbWVsaW5lLXJlY29yZGluZy10aW1lcy11cGRhdGVkIgogfTsKQEAgLTEwNSw2ICsxMDYsOCBA QCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmcucHJvdG90eXBlID0gewogICAgICAgICBj b25zb2xlLmFzc2VydCghdGhpcy5pc0VtcHR5KCksICJTaG91bGRuJ3QgdW5sb2FkIGFuIGVtcHR5 IHJlY29yZGluZzsgaXQgc2hvdWxkIGJlIHJldXNlZCBpbnN0ZWFkLiIpOwogCiAgICAgICAgIHRo aXMuX2lzV3JpdGFibGUgPSBmYWxzZTsKKworICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xp c3RlbmVycyhXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmcuRXZlbnQuVW5sb2FkZWQpOwog ICAgIH0sCiAKICAgICByZXNldDogZnVuY3Rpb24oc3VwcHJlc3NFdmVudHMpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZUNvbnRl bnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGlt ZWxpbmVDb250ZW50Vmlldy5qcwppbmRleCA0YjE3YmZjLi5iZTRhNGU3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZUNvbnRlbnRW aWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Rp bWVsaW5lQ29udGVudFZpZXcuanMKQEAgLTkzLDYgKzkzLDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVs aW5lQ29udGVudFZpZXcgPSBmdW5jdGlvbihyZWNvcmRpbmcpCiAgICAgdGhpcy5fc3RhcnRUaW1l TmVlZHNSZXNldCA9IHRydWU7CiAKICAgICByZWNvcmRpbmcuYWRkRXZlbnRMaXN0ZW5lcihXZWJJ bnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmcuRXZlbnQuUmVzZXQsIHRoaXMuX3JlY29yZGluZ1Jl c2V0LCB0aGlzKTsKKyAgICByZWNvcmRpbmcuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3Iu VGltZWxpbmVSZWNvcmRpbmcuRXZlbnQuVW5sb2FkZWQsIHRoaXMuX3JlY29yZGluZ1VubG9hZGVk LCB0aGlzKTsKIAogICAgIFdlYkluc3BlY3Rvci50aW1lbGluZU1hbmFnZXIuYWRkRXZlbnRMaXN0 ZW5lcihXZWJJbnNwZWN0b3IuVGltZWxpbmVNYW5hZ2VyLkV2ZW50LkNhcHR1cmluZ1N0YXJ0ZWQs IHRoaXMuX2NhcHR1cmluZ1N0YXJ0ZWQsIHRoaXMpOwogICAgIFdlYkluc3BlY3Rvci50aW1lbGlu ZU1hbmFnZXIuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuVGltZWxpbmVNYW5hZ2VyLkV2 ZW50LkNhcHR1cmluZ1N0b3BwZWQsIHRoaXMuX2NhcHR1cmluZ1N0b3BwZWQsIHRoaXMpOwpAQCAt MzcxLDYgKzM3Miw3IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZUNvbnRlbnRWaWV3LnByb3RvdHlw ZSA9IHsKICAgICAgICAgaWYgKCFpc05hTih0aGlzLl9jdXJyZW50VGltZSkpIHsKICAgICAgICAg ICAgIC8vIFdlIGhhdmUgYSBjdXJyZW50IHRpbWUgYWxyZWFkeSwgc28gd2UgbGlrZWx5IG5lZWQg dG8ganVtcCBpbnRvIHRoZSBmdXR1cmUgdG8gYSBiZXR0ZXIgY3VycmVudCB0aW1lLgogICAgICAg ICAgICAgLy8gVGhpcyBoYXBwZW5zIHdoZW4geW91IHN0b3AgYW5kIGxhdGVyIHJlc3RhcnQgcmVj b3JkaW5nLgorICAgICAgICAgICAgY29uc29sZS5hc3NlcnQoIXRoaXMuX3dhaXRpbmdUb1Jlc2V0 Q3VycmVudFRpbWUpOwogICAgICAgICAgICAgdGhpcy5fd2FpdGluZ1RvUmVzZXRDdXJyZW50VGlt ZSA9IHRydWU7CiAgICAgICAgICAgICB0aGlzLl9yZWNvcmRpbmcuYWRkRXZlbnRMaXN0ZW5lcihX ZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmcuRXZlbnQuVGltZXNVcGRhdGVkLCB0aGlzLl9y ZWNvcmRpbmdUaW1lc1VwZGF0ZWQsIHRoaXMpOwogICAgICAgICB9CkBAIC0zODcsNiArMzg5LDEy IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZUNvbnRlbnRWaWV3LnByb3RvdHlwZSA9IHsKICAgICB7 CiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMuX3VwZGF0aW5nKTsKICAgICAgICAgdGhpcy5f dXBkYXRpbmcgPSBmYWxzZTsKKworICAgICAgICBpZiAodGhpcy5fd2FpdGluZ1RvUmVzZXRDdXJy ZW50VGltZSkgeworICAgICAgICAgICAgLy8gRGlkIG5vdCBnZXQgYW55IGV2ZW50IHdoaWxlIHdh aXRpbmcgZm9yIHRoZSBjdXJyZW50IHRpbWUsIGJ1dCB3ZSBzaG91bGQgc3RvcCB3YWl0aW5nLgor ICAgICAgICAgICAgdGhpcy5fcmVjb3JkaW5nLnJlbW92ZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVj dG9yLlRpbWVsaW5lUmVjb3JkaW5nLkV2ZW50LlRpbWVzVXBkYXRlZCwgdGhpcy5fcmVjb3JkaW5n VGltZXNVcGRhdGVkLCB0aGlzKTsKKyAgICAgICAgICAgIHRoaXMuX3dhaXRpbmdUb1Jlc2V0Q3Vy cmVudFRpbWUgPSBmYWxzZTsgICAgICAgICAgICAKKyAgICAgICAgfQogICAgIH0sCiAKICAgICBf Y2FwdHVyaW5nU3RhcnRlZDogZnVuY3Rpb24oZXZlbnQpCkBAIC00MTcsNyArNDI1LDcgQEAgV2Vi SW5zcGVjdG9yLlRpbWVsaW5lQ29udGVudFZpZXcucHJvdG90eXBlID0gewogICAgICAgICB9CiAK ICAgICAgICAgdGhpcy5fcmVjb3JkaW5nLnJlbW92ZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9y LlRpbWVsaW5lUmVjb3JkaW5nLkV2ZW50LlRpbWVzVXBkYXRlZCwgdGhpcy5fcmVjb3JkaW5nVGlt ZXNVcGRhdGVkLCB0aGlzKTsKLSAgICAgICAgZGVsZXRlIHRoaXMuX3dhaXRpbmdUb1Jlc2V0Q3Vy cmVudFRpbWU7CisgICAgICAgIHRoaXMuX3dhaXRpbmdUb1Jlc2V0Q3VycmVudFRpbWUgPSBmYWxz ZTsKICAgICB9LAogCiAgICAgX2NsZWFyVGltZWxpbmU6IGZ1bmN0aW9uKGV2ZW50KQpAQCAtNDM5 LDcgKzQ0Nyw3IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZUNvbnRlbnRWaWV3LnByb3RvdHlwZSA9 IHsKICAgICAgICAgdGhpcy5fc3RhcnRUaW1lTmVlZHNSZXNldCA9IHRydWU7CiAKICAgICAgICAg dGhpcy5fcmVjb3JkaW5nLnJlbW92ZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlRpbWVsaW5l UmVjb3JkaW5nLkV2ZW50LlRpbWVzVXBkYXRlZCwgdGhpcy5fcmVjb3JkaW5nVGltZXNVcGRhdGVk LCB0aGlzKTsKLSAgICAgICAgZGVsZXRlIHRoaXMuX3dhaXRpbmdUb1Jlc2V0Q3VycmVudFRpbWU7 CisgICAgICAgIHRoaXMuX3dhaXRpbmdUb1Jlc2V0Q3VycmVudFRpbWUgPSBmYWxzZTsKIAogICAg ICAgICB0aGlzLl9vdmVydmlld1RpbWVsaW5lVmlldy5yZXNldCgpOwogICAgICAgICBmb3IgKHZh ciB0aW1lbGluZVZpZXcgb2YgdGhpcy5fZGlzY3JldGVUaW1lbGluZVZpZXdNYXAudmFsdWVzKCkp CkBAIC00NDksNiArNDU3LDE0IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZUNvbnRlbnRWaWV3LnBy b3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5yZXNldCgpOwog ICAgIH0sCiAKKyAgICBfcmVjb3JkaW5nVW5sb2FkZWQ6IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsK KyAgICAgICAgY29uc29sZS5hc3NlcnQoIXRoaXMuX3VwZGF0aW5nKTsKKworICAgICAgICBXZWJJ bnNwZWN0b3IudGltZWxpbmVNYW5hZ2VyLnJlbW92ZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9y LlRpbWVsaW5lTWFuYWdlci5FdmVudC5DYXB0dXJpbmdTdGFydGVkLCB0aGlzLl9jYXB0dXJpbmdT dGFydGVkLCB0aGlzKTsKKyAgICAgICAgV2ViSW5zcGVjdG9yLnRpbWVsaW5lTWFuYWdlci5yZW1v dmVFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5UaW1lbGluZU1hbmFnZXIuRXZlbnQuQ2FwdHVy aW5nU3RvcHBlZCwgdGhpcy5fY2FwdHVyaW5nU3RvcHBlZCwgdGhpcyk7CisgICAgfSwKKwogICAg IF90aW1lUmFuZ2VTZWxlY3Rpb25DaGFuZ2VkOiBmdW5jdGlvbihldmVudCkKICAgICB7CiAgICAg ICAgIHRoaXMuX2N1cnJlbnRUaW1lbGluZVZpZXcuc3RhcnRUaW1lID0gdGhpcy5fdGltZWxpbmVP dmVydmlldy5zZWxlY3Rpb25TdGFydFRpbWU7Cg==