135941 2014-08-14 09:46:35 -0700 [Services with UI] Selection services don't work inside <iframes> 2014-08-14 11:37:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica thorton oldest_to_newest 1029109 0 236593 enrica 2014-08-14 09:46:35 -0700 Created attachment 236593 Test Use the attached test case. Select something inside the iframe. Hover to get the service UI. EXPECTED: The service UI appears and you can click on the arrow. ACTUAL: Nothing happens. <rdar://problem/17957690> 1029113 1 236595 enrica 2014-08-14 09:52:18 -0700 Created attachment 236595 Patch 1029134 2 236595 thorton 2014-08-14 10:53:55 -0700 Comment on attachment 236595 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236595&action=review > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:524 > + FrameView* viewForRange = selectionRange ? selectionRange->ownerDocument().view() : nullptr; You dereference this inside the loop; should we just bail if !selectionRange instead? 1029152 3 enrica 2014-08-14 11:37:55 -0700 Committed revision 172596. 236593 2014-08-14 09:46:35 -0700 2014-08-14 09:46:35 -0700 Test iframe.html text/html 155 enrica PGRpdiBzdHlsZT0iaGVpZ2h0OiAyMDBweDsgYm9yZGVyOiBzb2xpZCByZWQgMXB4Ij5UaGlzIGlz IHNvbWUgY29udGVudC48L2Rpdj4KPGlmcmFtZSBzcmM9Imh0dHA6Ly93d3cuYXBwbGUuY29tL2Nv bnRhY3QiIHdpZHRoPSI2MDAiIGhlaWdodD0iNjAwIj48L2lmcmFtZT4= 236595 2014-08-14 09:52:18 -0700 2014-08-14 10:53:54 -0700 Patch iframerects.txt text/plain 2820 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MjU5MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA4LTE0ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW1NlcnZpY2VzIHdpdGggVUld IFNlbGVjdGlvbiBzZXJ2aWNlcyBkb24ndCB3b3JrIGluc2lkZSA8aWZyYW1lcz4uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU5NDEKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzE3OTU3NjkwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE5lZWQgdG8gbWFwIHRoZSBzZWxlY3Rpb24gcmVjdGFuZ2xlcyB1 c2luZyB0aGUgY29ycmVjdCBGcmFtZVZpZXcuCisgICAgICAgIFdoZW4gaGFuZGxpbmcgdGhlIGNs aWNrLCB3ZSBtdXN0IHVzZSB0aGUgc2VsZWN0aW9uIGZyb20gdGhlIGZvY3VzZWQgZnJhbWUuCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xs ZXIubW06CisgICAgICAgIChXZWJLaXQ6OlNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXI6OmJ1aWxk U2VsZWN0aW9uSGlnaGxpZ2h0KToKKyAgICAgICAgKFdlYktpdDo6U2VydmljZXNPdmVybGF5Q29u dHJvbGxlcjo6aGFuZGxlQ2xpY2spOgorCiAyMDE0LTA4LTEzICBXZW5zb24gSHNpZWggIDx3ZW5z b25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIEVuYWJsZSBDU1NfU0NST0xMX1NOQVAgZm9y IGlPUwpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9TZXJ2aWNl c092ZXJsYXlDb250cm9sbGVyLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbQkocmV2aXNpb24g MTcyNTkwKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9TZXJ2aWNl c092ZXJsYXlDb250cm9sbGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01MTgsOCArNTE4LDE2IEBA IHZvaWQgU2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6YnVpbGRTZWwKICAgICBWZWN0b3I8Q0dS ZWN0PiBjZ1JlY3RzOwogICAgIGNnUmVjdHMucmVzZXJ2ZUNhcGFjaXR5KG1fY3VycmVudFNlbGVj dGlvblJlY3RzLnNpemUoKSk7CiAKLSAgICBmb3IgKGF1dG8mIHJlY3QgOiBtX2N1cnJlbnRTZWxl Y3Rpb25SZWN0cykKLSAgICAgICAgY2dSZWN0cy5hcHBlbmQoKENHUmVjdClwaXhlbFNuYXBwZWRJ bnRSZWN0KHJlY3QpKTsKKyAgICBGcmFtZSogbWFpbkZyYW1lID0gbV93ZWJQYWdlLm1haW5GcmFt ZSgpOworICAgIEZyYW1lVmlldyYgbWFpbkZyYW1lVmlldyA9ICptYWluRnJhbWUtPnZpZXcoKTsK KyAgICBSZWZQdHI8UmFuZ2U+IHNlbGVjdGlvblJhbmdlID0gbV93ZWJQYWdlLmNvcmVQYWdlKCkt PnNlbGVjdGlvbigpLmZpcnN0UmFuZ2UoKTsKKyAgICBGcmFtZVZpZXcqIHZpZXdGb3JSYW5nZSA9 IHNlbGVjdGlvblJhbmdlID8gc2VsZWN0aW9uUmFuZ2UtPm93bmVyRG9jdW1lbnQoKS52aWV3KCkg OiBudWxscHRyOworCisgICAgZm9yIChhdXRvJiByZWN0IDogbV9jdXJyZW50U2VsZWN0aW9uUmVj dHMpIHsKKyAgICAgICAgSW50UmVjdCBjdXJyZW50UmVjdCA9IHBpeGVsU25hcHBlZEludFJlY3Qo cmVjdCk7CisgICAgICAgIGN1cnJlbnRSZWN0LnNldExvY2F0aW9uKG1haW5GcmFtZVZpZXcud2lu ZG93VG9Db250ZW50cyh2aWV3Rm9yUmFuZ2UtPmNvbnRlbnRzVG9XaW5kb3coY3VycmVudFJlY3Qu bG9jYXRpb24oKSkpKTsKKyAgICAgICAgY2dSZWN0cy5hcHBlbmQoKENHUmVjdCljdXJyZW50UmVj dCk7CisgICAgfQogCiAgICAgaWYgKCFjZ1JlY3RzLmlzRW1wdHkoKSkgewogICAgICAgICBDR1Jl Y3QgdmlzaWJsZVJlY3QgPSBtX3dlYlBhZ2UuY29yZVBhZ2UoKS0+bWFpbkZyYW1lKCkudmlldygp LT52aXNpYmxlQ29udGVudFJlY3QoKTsKQEAgLTc0NSw3ICs3NTMsNyBAQCB2b2lkIFNlcnZpY2Vz T3ZlcmxheUNvbnRyb2xsZXI6OmhhbmRsZUNsCiAgICAgICAgIGZvciAoYXV0byYgcmFuZ2UgOiB0 ZWxlcGhvbmVOdW1iZXJSYW5nZXMpCiAgICAgICAgICAgICBzZWxlY3RlZFRlbGVwaG9uZU51bWJl cnMuYXBwZW5kKHJhbmdlLT50ZXh0KCkpOwogCi0gICAgICAgIG1fd2ViUGFnZS5oYW5kbGVTZWxl Y3Rpb25TZXJ2aWNlQ2xpY2sobV93ZWJQYWdlLmNvcmVQYWdlKCktPm1haW5GcmFtZSgpLnNlbGVj dGlvbigpLCBzZWxlY3RlZFRlbGVwaG9uZU51bWJlcnMsIHdpbmRvd1BvaW50KTsKKyAgICAgICAg bV93ZWJQYWdlLmhhbmRsZVNlbGVjdGlvblNlcnZpY2VDbGljayhtX3dlYlBhZ2UuY29yZVBhZ2Uo KS0+Zm9jdXNDb250cm9sbGVyKCkuZm9jdXNlZE9yTWFpbkZyYW1lKCkuc2VsZWN0aW9uKCksIHNl bGVjdGVkVGVsZXBob25lTnVtYmVycywgd2luZG93UG9pbnQpOwogICAgIH0gZWxzZSBpZiAoaGln aGxpZ2h0LnR5cGUoKSA9PSBIaWdobGlnaHQ6OlR5cGU6OlRlbGVwaG9uZU51bWJlcikKICAgICAg ICAgbV93ZWJQYWdlLmhhbmRsZVRlbGVwaG9uZU51bWJlckNsaWNrKGhpZ2hsaWdodC5yYW5nZSgp LT50ZXh0KCksIHdpbmRvd1BvaW50KTsKIH0K