135935 2014-08-14 04:47:55 -0700 srcset with w descriptor and sizes does not behave as expected 2014-08-14 12:47:03 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) iPhone / iPad Other RESOLVED FIXED http://software.hixie.ch/utilities/js/live-dom-viewer/saved/3119 InRadar P2 Normal --- 1 zcorpan webkit-unassigned commit-queue dino eoconnor esprehn+autocc gyuyoung.kim kling webkit-bug-importer yoav oldest_to_newest 1029065 0 zcorpan 2014-08-14 04:47:55 -0700 http://software.hixie.ch/utilities/js/live-dom-viewer/saved/3119 in Safari 8 in the iOS Simulator of XCode 6 beta 5 shows 'svg' for the first img, and 'image' for the second img. If sizes support is turned on, expected result is 'image' for the first img and 'svg' for the second img. If sizes is turned off, yoav says expected result is no image ('w' candidates should be dropped on the floor). Instead it seems all candidates are interpreted as 1x, so the first one in srcset gets chosen. 1029072 1 236587 yoav 2014-08-14 06:18:56 -0700 Created attachment 236587 Patch 1029165 2 webkit-bug-importer 2014-08-14 12:12:21 -0700 <rdar://problem/18021928> 1029174 3 236587 commit-queue 2014-08-14 12:47:00 -0700 Comment on attachment 236587 Patch Clearing flags on attachment: 236587 Committed r172600: <http://trac.webkit.org/changeset/172600> 1029175 4 commit-queue 2014-08-14 12:47:03 -0700 All reviewed patches have been landed. Closing bug. 236587 2014-08-14 06:18:56 -0700 2014-08-14 12:46:59 -0700 Patch bug-135935-20140814151845.patch text/plain 2877 yoav U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzM0MDQ2Yjc1YmQzNTZj YTljZDRjOTQ2MGM4MGEzYzMwOTRkMWVjMy4uYzUxNzc5OGJiYjRhZmJjYTg2NzVkMjI0NTE4ZTQw YjNiNTgzNGM4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE0LTA4LTE0ICBZb2F2 IFdlaXNzICA8eW9hdkB5b2F2LndzPgorCisgICAgICAgIHNyY3NldCB3aXRoIHcgZGVzY3JpcHRv ciBkb2Vzbid0IGJlaGF2ZSBhcyBleHBlY3RlZCB3aGVuIHNpemVzIGlzIG5vdCBzdXBwb3J0ZWQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU5MzUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBjdXJy ZW50IGltcGxlbWVudGF0aW9uLCBpZiBzaXplcyBpcyBub3Qgc3VwcG9ydGVkLCB3aGVuIGF1dGhv cnMgd291bGQgd3JpdGUKKyAgICAgICAgbWFya3VwIHN1Y2ggYXMgYDxpbWcgc3JjPWZhbGxiYWNr LmpwZyBzcmNzZXQ9IjEwMHB4LmpwZyAxMDB3LCA0MDBweC5qcGcgNDAwdyI+YAorICAgICAgICB0 aGUgZmlyc3QgY2FuZGlkYXRlIGluIHNyY3NldCB3b3VsZCBiZSBwaWNrZWQsIHJlZ2FyZGxlc3Mg b2YgaXRzIGRpbWVuc2lvbnMgCisgICAgICAgIFRoYXQgaXMgbGlrZWx5IHRvIGJlIGNvbmZ1c2lu ZyBmb3IgYXV0aG9ycy4KKyAgICAgICAgRHJvcHBpbmcgdGhlc2UgIm5vdCB5ZXQgc3VwcG9ydGVk IiBjYW5kaWRhdGVzIGlzIGxpa2VseSB0byBiZSBsZXNzIGNvbmZ1c2luZywKKyAgICAgICAgYW5k IHdpbGwgcmVzdWx0IGluIHRoZSAiZmFsbGJhY2suanBnIiBjYW5kaWRhdGUgYmVpbmcgcGlja2Vk LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSB0aGlzIGNoYW5nZSBvbmx5IGNvbmNlcm5z IGJ1aWxkcyB0aGF0IGFyZSBidWlsdAorICAgICAgICB3aXRoIHRoZSBQSUNUVVJFX1NJWkVTIGNv bXBpbGUgZmxhZyB0dXJuZWQgb2ZmLgorCisgICAgICAgICogaHRtbC9wYXJzZXIvSFRNTFNyY3Nl dFBhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwYXJzZURlc2NyaXB0b3JzKToKKyAgICAg ICAgRHJvcCBjYW5kaWRhdGVzIHRoYXQgaW5jbHVkZSBlaXRoZXIgJ3cnIG9yICdoJyBkZXNjcmlw dG9ycyB3aGVuIHRoZQorICAgICAgICBzaXplcyBmZWF0dXJlIGlzIG5vdCBzdXBwb3J0ZWQuCisK IDIwMTQtMDgtMTQgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAg ICAgIEltYWdlQnVmZmVyRGF0YUNhaXJvLmggaXMgbWlzc2luZyBoZWFkZXIgZ3VhcmRzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MU3Jjc2V0UGFyc2VyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxTcmNzZXRQYXJzZXIuY3BwCmluZGV4IGUy Njk2MWZkMGVkODljMmRhOWU4ODgzYzUwYzk5NzQ3NGU2Yzg0MjguLmYyZjFhNWYwMWMwNWVmYWRi NWVlZTRhYzUwMTQ3YzBlMGZjNjJkYjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv cGFyc2VyL0hUTUxTcmNzZXRQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFy c2VyL0hUTUxTcmNzZXRQYXJzZXIuY3BwCkBAIC0xNDAsMTMgKzE0MCwxOCBAQCBzdGF0aWMgYm9v bCBwYXJzZURlc2NyaXB0b3JzKFZlY3RvcjxTdHJpbmdWaWV3PiYgZGVzY3JpcHRvcnMsIERlc2Ny aXB0b3JQYXJzaW5nUgogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgICAg IHJlc3VsdC5zZXREZW5zaXR5KGRlbnNpdHkpOwogICAgICAgICB9IGVsc2UgaWYgKGRlc2NyaXB0 b3JDaGFyID09ICd3JykgeworI2lmIEVOQUJMRShQSUNUVVJFX1NJWkVTKQogICAgICAgICAgICAg aWYgKHJlc3VsdC5oYXNEZW5zaXR5KCkgfHwgcmVzdWx0Lmhhc1dpZHRoKCkpCiAgICAgICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAgICAgaW50IHJlc291cmNlV2lkdGggPSBkZXNj cmlwdG9yLnRvSW50KGlzVmFsaWQpOwogICAgICAgICAgICAgaWYgKCFpc1ZhbGlkIHx8IHJlc291 cmNlV2lkdGggPD0gMCkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgICAg ICByZXN1bHQuc2V0UmVzb3VyY2VXaWR0aChyZXNvdXJjZVdpZHRoKTsKKyNlbHNlCisgICAgICAg ICAgICByZXR1cm4gZmFsc2U7CisjZW5kaWYKICAgICAgICAgfSBlbHNlIGlmIChkZXNjcmlwdG9y Q2hhciA9PSAnaCcpIHsKKyNpZiBFTkFCTEUoUElDVFVSRV9TSVpFUykKICAgICAgICAgICAgIC8v IFRoaXMgaXMgaGVyZSBvbmx5IGZvciBmdXR1cmUgY29tcGF0IHB1cnBvc2VzLgogICAgICAgICAg ICAgLy8gVGhlIHZhbHVlIG9mIHRoZSAnaCcgZGVzY3JpcHRvciBpcyBub3QgdXNlZC4KICAgICAg ICAgICAgIGlmIChyZXN1bHQuaGFzRGVuc2l0eSgpIHx8IHJlc3VsdC5oYXNIZWlnaHQoKSkKQEAg LTE1NSw2ICsxNjAsOSBAQCBzdGF0aWMgYm9vbCBwYXJzZURlc2NyaXB0b3JzKFZlY3RvcjxTdHJp bmdWaWV3PiYgZGVzY3JpcHRvcnMsIERlc2NyaXB0b3JQYXJzaW5nUgogICAgICAgICAgICAgaWYg KCFpc1ZhbGlkIHx8IHJlc291cmNlSGVpZ2h0IDw9IDApCiAgICAgICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgICAgICAgICAgcmVzdWx0LnNldFJlc291cmNlSGVpZ2h0KHJlc291cmNlSGVp Z2h0KTsKKyNlbHNlCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisjZW5kaWYKICAgICAgICAg fQogICAgIH0KICAgICByZXR1cm4gdHJ1ZTsK