135919 2014-08-13 17:43:20 -0700 Add LayoutUnit argument coders to WebCoreArgumentCoders 2014-08-13 23:07:10 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Enhancement --- 1 wenson_hsieh webkit-unassigned ap thorton oldest_to_newest 1028985 0 wenson_hsieh 2014-08-13 17:43:20 -0700 Related to the encoding/decoding of snap offsets. LayoutUnits currently lack an implementation in WebCoreArgumentCoders. 1029017 1 236574 wenson_hsieh 2014-08-13 20:05:39 -0700 Created attachment 236574 Patch 1029021 2 236574 thorton 2014-08-13 21:07:08 -0700 Comment on attachment 236574 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236574&action=review > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:338 > + encoder << layoutUnit.toDouble(); Why toDouble instead of encoding raw LayoutUnit numerator/denominator? Is that safe? If so, why? That information should be in the changelog. 1029022 3 236576 wenson_hsieh 2014-08-13 21:23:42 -0700 Created attachment 236576 Patch 1029030 4 thorton 2014-08-13 21:54:33 -0700 I think we decided that you didn't need to do this? 1029038 5 236576 ap 2014-08-13 22:59:11 -0700 Comment on attachment 236576 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236576&action=review r- for using int. > Source/WebKit2/ChangeLog:3 > + Add LayoutUnit argument coders to WebCoreArgumentCoders It seems a little bit strange to expose internals of layout machinery even to WebKit, and more so to UI process. Can we use whatever type is exposed in API until we get down to WebCore? > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:343 > + int decodedRawValue; IPC always uses fixed size types, like uint64_t, not int. 1029039 6 thorton 2014-08-13 23:03:49 -0700 Indeed, and we (wenson/zalan mostly) already established that he doesn't need to do this anyway. 1029040 7 236576 wenson_hsieh 2014-08-13 23:07:10 -0700 Comment on attachment 236576 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236576&action=review Thanks for taking a look at this! However, after talking with Tim and Zalan, we've decided against IPC-ing LayoutUnit (if we ever do decide to do it though, we'll keep that in mind) >> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:343 >> + int decodedRawValue; > > IPC always uses fixed size types, like uint64_t, not int. Got it -- thanks for the tip. 236574 2014-08-13 20:05:39 -0700 2014-08-13 21:23:38 -0700 Patch bug-135919-20140813200529.patch text/plain 3126 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTBjMzkwYjYwMjEwNmU0 ODJkYTU0YzQyMWUzZGI0NTU4YTI0YmZlYy4uNjc5Njk1MmExNDgwYmJkN2RkZTViMWE5NzYwZGNi ODkxYjdkYjVlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTA4LTEzICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCisgICAgICAgIEFkZCBMYXlvdXRV bml0IGFyZ3VtZW50IGNvZGVycyB0byBXZWJDb3JlQXJndW1lbnRDb2RlcnMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTkxOQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0aGUgYWJpbGl0eSB0byBl bmNvZGUgYW5kIGRlY29kZSBMYXlvdXRVbml0IGFzIGRvdWJsZSB2YWx1ZXMuCisKKyAgICAgICAg KiBTaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcDoKKyAgICAgICAgKElQQzo6QXJndW1l bnRDb2RlcjxMYXlvdXRVbml0Pjo6ZW5jb2RlKToKKyAgICAgICAgKElQQzo6QXJndW1lbnRDb2Rl cjxMYXlvdXRVbml0Pjo6ZGVjb2RlKToKKyAgICAgICAgKiBTaGFyZWQvV2ViQ29yZUFyZ3VtZW50 Q29kZXJzLmg6CisKKzIwMTQtMDgtMTMgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBs ZS5jb20+CisKICAgICAgICAgRW5hYmxlIENTU19TQ1JPTExfU05BUCBmb3IgaU9TCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU5MTUKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcAppbmRleCAzNTk5 MmU1YmI0MzBmNjg1ZDE4NmNkZTQ4ZWEwODUwMGM1YmNjZWI1Li42NjU2Nzg2NDNjMDVmZjY2MDc1 ZjYyNzZmNWVhMjJmMjk2YzJiZDhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv V2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2Vi Q29yZUFyZ3VtZW50Q29kZXJzLmNwcApAQCAtNDgsNiArNDgsNyBAQAogI2luY2x1ZGUgPFdlYkNv cmUvSURCS2V5UGF0aC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvSURCS2V5UmFuZ2VEYXRhLmg+CiAj aW5jbHVkZSA8V2ViQ29yZS9JbWFnZS5oPgorI2luY2x1ZGUgPFdlYkNvcmUvTGF5b3V0VW5pdC5o PgogI2luY2x1ZGUgPFdlYkNvcmUvTGVuZ3RoLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9QbHVnaW5E YXRhLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9Qcm90ZWN0aW9uU3BhY2UuaD4KQEAgLTMzMiw2ICsz MzMsMjAgQEAgYm9vbCBBcmd1bWVudENvZGVyPFJlZ2lvbj46OmRlY29kZShBcmd1bWVudERlY29k ZXImIGRlY29kZXIsIFJlZ2lvbiYgcmVnaW9uKQogICAgIHJldHVybiB0cnVlOwogfQogCit2b2lk IEFyZ3VtZW50Q29kZXI8TGF5b3V0VW5pdD46OmVuY29kZShBcmd1bWVudEVuY29kZXImIGVuY29k ZXIsIGNvbnN0IExheW91dFVuaXQmIGxheW91dFVuaXQpCit7CisgICAgZW5jb2RlciA8PCBsYXlv dXRVbml0LnRvRG91YmxlKCk7Cit9CisKK2Jvb2wgQXJndW1lbnRDb2RlcjxMYXlvdXRVbml0Pjo6 ZGVjb2RlKEFyZ3VtZW50RGVjb2RlciYgZGVjb2RlciwgTGF5b3V0VW5pdCYgbGF5b3V0VW5pdCkK K3sKKyAgICBkb3VibGUgZGVjb2RlZFZhbHVlOworICAgIGlmICghZGVjb2Rlci5kZWNvZGUoZGVj b2RlZFZhbHVlKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGxheW91dFVuaXQgPSBkZWNv ZGVkVmFsdWU7CisgICAgcmV0dXJuIHRydWU7Cit9CisKIHZvaWQgQXJndW1lbnRDb2RlcjxMZW5n dGg+OjplbmNvZGUoQXJndW1lbnRFbmNvZGVyJiBlbmNvZGVyLCBjb25zdCBMZW5ndGgmIGxlbmd0 aCkKIHsKICAgICBTaW1wbGVBcmd1bWVudENvZGVyPExlbmd0aD46OmVuY29kZShlbmNvZGVyLCBs ZW5ndGgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVu dENvZGVycy5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5o CmluZGV4IDFiZWEwZDFiZDc5YjUyOTdkNDM1NGUyMzg0MjE1MGU5YmRiZGViOTIuLjYxMGJmZDk2 NGU3Y2ZkYTZhYWQ1ZTY3N2FjNmI2NjJjN2U3MWU4ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgKQEAgLTUxLDYgKzUxLDcgQEAgY2xhc3MgSW50 UG9pbnQ7CiBjbGFzcyBJbnRSZWN0OwogY2xhc3MgSW50U2l6ZTsKIGNsYXNzIEtleWZyYW1lVmFs dWVMaXN0OworY2xhc3MgTGF5b3V0VW5pdDsKIGNsYXNzIExpbmVhclRpbWluZ0Z1bmN0aW9uOwog Y2xhc3MgTm90aWZpY2F0aW9uOwogY2xhc3MgUHJvdGVjdGlvblNwYWNlOwpAQCAtMTk1LDYgKzE5 NiwxMSBAQCB0ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1bWVudENvZGVyPFdlYkNvcmU6OlJlZ2lvbj4g ewogICAgIHN0YXRpYyBib29sIGRlY29kZShBcmd1bWVudERlY29kZXImLCBXZWJDb3JlOjpSZWdp b24mKTsKIH07CiAKK3RlbXBsYXRlPD4gc3RydWN0IEFyZ3VtZW50Q29kZXI8V2ViQ29yZTo6TGF5 b3V0VW5pdD4geworICAgIHN0YXRpYyB2b2lkIGVuY29kZShBcmd1bWVudEVuY29kZXImLCBjb25z dCBXZWJDb3JlOjpMYXlvdXRVbml0Jik7CisgICAgc3RhdGljIGJvb2wgZGVjb2RlKEFyZ3VtZW50 RGVjb2RlciYsIFdlYkNvcmU6OkxheW91dFVuaXQmKTsKK307CisKIHRlbXBsYXRlPD4gc3RydWN0 IEFyZ3VtZW50Q29kZXI8V2ViQ29yZTo6TGVuZ3RoPiB7CiAgICAgc3RhdGljIHZvaWQgZW5jb2Rl KEFyZ3VtZW50RW5jb2RlciYsIGNvbnN0IFdlYkNvcmU6Okxlbmd0aCYpOwogICAgIHN0YXRpYyBi b29sIGRlY29kZShBcmd1bWVudERlY29kZXImLCBXZWJDb3JlOjpMZW5ndGgmKTsK 236576 2014-08-13 21:23:42 -0700 2014-08-13 23:07:10 -0700 Patch bug-135919-20140813212332.patch text/plain 3127 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTBjMzkwYjYwMjEwNmU0 ODJkYTU0YzQyMWUzZGI0NTU4YTI0YmZlYy4uNmRhODc3ZTk2ZTEzNWRlMGY2Y2EwNDFmZjIwNTFk MmMwY2UyMDAzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTA4LTEzICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCisgICAgICAgIEFkZCBMYXlvdXRV bml0IGFyZ3VtZW50IGNvZGVycyB0byBXZWJDb3JlQXJndW1lbnRDb2RlcnMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTkxOQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuY29kZSBhbmQgZGVjb2RlIGEg TGF5b3V0VW5pdCB2aWEgaXRzIHJhdyB2YWx1ZS4KKworICAgICAgICAqIFNoYXJlZC9XZWJDb3Jl QXJndW1lbnRDb2RlcnMuY3BwOgorICAgICAgICAoSVBDOjpBcmd1bWVudENvZGVyPExheW91dFVu aXQ+OjplbmNvZGUpOgorICAgICAgICAoSVBDOjpBcmd1bWVudENvZGVyPExheW91dFVuaXQ+Ojpk ZWNvZGUpOgorICAgICAgICAqIFNoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuaDoKKworMjAx NC0wOC0xMyAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KKwogICAgICAg ICBFbmFibGUgQ1NTX1NDUk9MTF9TTkFQIGZvciBpT1MKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTkxNQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1No YXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuY3BwCmluZGV4IDM1OTkyZTViYjQzMGY2ODVkMTg2 Y2RlNDhlYTA4NTAwYzViY2NlYjUuLjU0Nzc4ZTAzMjhjZWRiN2EyOTI2ZWIzZjhjZjE1MThhOTYx ZjY5ZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJndW1lbnRD b2RlcnMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2Rl cnMuY3BwCkBAIC00OCw2ICs0OCw3IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9JREJLZXlQYXRoLmg+ CiAjaW5jbHVkZSA8V2ViQ29yZS9JREJLZXlSYW5nZURhdGEuaD4KICNpbmNsdWRlIDxXZWJDb3Jl L0ltYWdlLmg+CisjaW5jbHVkZSA8V2ViQ29yZS9MYXlvdXRVbml0Lmg+CiAjaW5jbHVkZSA8V2Vi Q29yZS9MZW5ndGguaD4KICNpbmNsdWRlIDxXZWJDb3JlL1BsdWdpbkRhdGEuaD4KICNpbmNsdWRl IDxXZWJDb3JlL1Byb3RlY3Rpb25TcGFjZS5oPgpAQCAtMzMyLDYgKzMzMywyMCBAQCBib29sIEFy Z3VtZW50Q29kZXI8UmVnaW9uPjo6ZGVjb2RlKEFyZ3VtZW50RGVjb2RlciYgZGVjb2RlciwgUmVn aW9uJiByZWdpb24pCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKK3ZvaWQgQXJndW1lbnRDb2RlcjxM YXlvdXRVbml0Pjo6ZW5jb2RlKEFyZ3VtZW50RW5jb2RlciYgZW5jb2RlciwgY29uc3QgTGF5b3V0 VW5pdCYgbGF5b3V0VW5pdCkKK3sKKyAgICBlbmNvZGVyIDw8IGxheW91dFVuaXQucmF3VmFsdWUo KTsKK30KKworYm9vbCBBcmd1bWVudENvZGVyPExheW91dFVuaXQ+OjpkZWNvZGUoQXJndW1lbnRE ZWNvZGVyJiBkZWNvZGVyLCBMYXlvdXRVbml0JiBsYXlvdXRVbml0KQoreworICAgIGludCBkZWNv ZGVkUmF3VmFsdWU7CisgICAgaWYgKCFkZWNvZGVyLmRlY29kZShkZWNvZGVkUmF3VmFsdWUpKQor ICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgbGF5b3V0VW5pdC5zZXRSYXdWYWx1ZShkZWNvZGVk UmF3VmFsdWUpOworICAgIHJldHVybiB0cnVlOworfQorCiB2b2lkIEFyZ3VtZW50Q29kZXI8TGVu Z3RoPjo6ZW5jb2RlKEFyZ3VtZW50RW5jb2RlciYgZW5jb2RlciwgY29uc3QgTGVuZ3RoJiBsZW5n dGgpCiB7CiAgICAgU2ltcGxlQXJndW1lbnRDb2RlcjxMZW5ndGg+OjplbmNvZGUoZW5jb2Rlciwg bGVuZ3RoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJndW1l bnRDb2RlcnMuaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMu aAppbmRleCAxYmVhMGQxYmQ3OWI1Mjk3ZDQzNTRlMjM4NDIxNTBlOWJkYmRlYjkyLi42MTBiZmQ5 NjRlN2NmZGE2YWFkNWU2NzdhYzZiNjYyYzdlNzFlOGU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgKKysrIGIvU291cmNlL1dlYktpdDIv U2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5oCkBAIC01MSw2ICs1MSw3IEBAIGNsYXNzIElu dFBvaW50OwogY2xhc3MgSW50UmVjdDsKIGNsYXNzIEludFNpemU7CiBjbGFzcyBLZXlmcmFtZVZh bHVlTGlzdDsKK2NsYXNzIExheW91dFVuaXQ7CiBjbGFzcyBMaW5lYXJUaW1pbmdGdW5jdGlvbjsK IGNsYXNzIE5vdGlmaWNhdGlvbjsKIGNsYXNzIFByb3RlY3Rpb25TcGFjZTsKQEAgLTE5NSw2ICsx OTYsMTEgQEAgdGVtcGxhdGU8PiBzdHJ1Y3QgQXJndW1lbnRDb2RlcjxXZWJDb3JlOjpSZWdpb24+ IHsKICAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVyJiwgV2ViQ29yZTo6UmVn aW9uJik7CiB9OwogCit0ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1bWVudENvZGVyPFdlYkNvcmU6Okxh eW91dFVuaXQ+IHsKKyAgICBzdGF0aWMgdm9pZCBlbmNvZGUoQXJndW1lbnRFbmNvZGVyJiwgY29u c3QgV2ViQ29yZTo6TGF5b3V0VW5pdCYpOworICAgIHN0YXRpYyBib29sIGRlY29kZShBcmd1bWVu dERlY29kZXImLCBXZWJDb3JlOjpMYXlvdXRVbml0Jik7Cit9OworCiB0ZW1wbGF0ZTw+IHN0cnVj dCBBcmd1bWVudENvZGVyPFdlYkNvcmU6Okxlbmd0aD4gewogICAgIHN0YXRpYyB2b2lkIGVuY29k ZShBcmd1bWVudEVuY29kZXImLCBjb25zdCBXZWJDb3JlOjpMZW5ndGgmKTsKICAgICBzdGF0aWMg Ym9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVyJiwgV2ViQ29yZTo6TGVuZ3RoJik7Cg==