135918 2014-08-13 17:20:17 -0700 [Services with UI] Use a longer delay duration for editable content 2014-08-13 17:40:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 1028971 0 enrica 2014-08-13 17:20:17 -0700 Use a longer delay before showing the service UI. <rdar://problem/17998929> 1028972 1 236568 enrica 2014-08-13 17:22:46 -0700 Created attachment 236568 Patch 1028976 2 236568 thorton 2014-08-13 17:25:57 -0700 Comment on attachment 236568 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236568&action=review > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:408 > + std::chrono::steady_clock::duration minimumTimeUntilHighlightShouldBeShown = m_webPage.corePage()->focusController().focusedOrMainFrame().selection().selection().isContentEditable() ? 1000_ms : 200_ms; This line is crazy long; could we maybe pull the 'isContentEditable' check out onto its own line? Also, could we maybe move the two constants to the top of the file? 1028978 3 enrica 2014-08-13 17:33:29 -0700 (In reply to comment #2) > (From update of attachment 236568 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236568&action=review > > > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:408 > > + std::chrono::steady_clock::duration minimumTimeUntilHighlightShouldBeShown = m_webPage.corePage()->focusController().focusedOrMainFrame().selection().selection().isContentEditable() ? 1000_ms : 200_ms; > > This line is crazy long; could we maybe pull the 'isContentEditable' check out onto its own line? Also, could we maybe move the two constants to the top of the file? I can split the line. I prefer not to move the constants since they are only used in this method. 1028984 4 enrica 2014-08-13 17:40:09 -0700 Committed revision 172546. 236568 2014-08-13 17:22:46 -0700 2014-08-13 17:25:57 -0700 Patch delayforeditable.txt text/plain 1744 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MjU0MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA4LTEzICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW1NlcnZpY2VzIHdpdGggVUld IFVzZSBhIGxvbmdlciBkZWxheSBkdXJhdGlvbiBmb3IgZWRpdGFibGUgY29udGVudC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTkxOAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMTc5OTg5Mjk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVXNlIGEgMSBzZWNvbmQgZGVsYXkgZm9yIHNlbGVjdGlvbnMg aW4gZWRpdGFibGUgY29udGVudC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMv U2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbToKKyAgICAgICAgKFdlYktpdDo6U2VydmljZXNP dmVybGF5Q29udHJvbGxlcjo6cmVtYWluaW5nVGltZVVudGlsSGlnaGxpZ2h0U2hvdWxkQmVTaG93 bik6CisKIDIwMTQtMDgtMTMgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAg ICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM1OTExPiBXZWJLaXQgc2hvdWxkIGJ1aWxkIG9uIFlv c2VtaXRlIHdpdGggdGhlIHB1YmxpYyBTREsuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9TZXJ2aWNlc092ZXJsYXlD b250cm9sbGVyLm1tCShyZXZpc2lvbiAxNzI1MjQpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIubW0JKHdvcmtpbmcgY29w eSkKQEAgLTQwNSw3ICs0MDUsNyBAQCBzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRzIFNlcnZpY2Vz T3ZlcmxhCiAgICAgaWYgKGhpZ2hsaWdodC0+dHlwZSgpID09IEhpZ2hsaWdodDo6VHlwZTo6VGVs ZXBob25lTnVtYmVyKQogICAgICAgICByZXR1cm4gc3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kczo6 emVybygpOwogCi0gICAgc3RkOjpjaHJvbm86OnN0ZWFkeV9jbG9jazo6ZHVyYXRpb24gbWluaW11 bVRpbWVVbnRpbEhpZ2hsaWdodFNob3VsZEJlU2hvd24gPSAyMDBfbXM7CisgICAgc3RkOjpjaHJv bm86OnN0ZWFkeV9jbG9jazo6ZHVyYXRpb24gbWluaW11bVRpbWVVbnRpbEhpZ2hsaWdodFNob3Vs ZEJlU2hvd24gPSBtX3dlYlBhZ2UuY29yZVBhZ2UoKS0+Zm9jdXNDb250cm9sbGVyKCkuZm9jdXNl ZE9yTWFpbkZyYW1lKCkuc2VsZWN0aW9uKCkuc2VsZWN0aW9uKCkuaXNDb250ZW50RWRpdGFibGUo KSA/IDEwMDBfbXMgOiAyMDBfbXM7CiAKICAgICBhdXRvIG5vdyA9IHN0ZDo6Y2hyb25vOjpzdGVh ZHlfY2xvY2s6Om5vdygpOwogICAgIGF1dG8gdGltZVNpbmNlTGFzdFNlbGVjdGlvbkNoYW5nZSA9 IG5vdyAtIG1fbGFzdFNlbGVjdGlvbkNoYW5nZVRpbWU7Cg==