135910 2014-08-13 15:35:21 -0700 run-webkit-tests should skip 'support' directories 2014-08-15 12:04:24 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 135921 1 rhauck webkit-unassigned bjonesbe commit-queue glenn rniwa oldest_to_newest 1028933 0 rhauck 2014-08-13 15:35:21 -0700 We explicitly skip a whole bunch of directories known to not contain any test files (reference, resources, etc.). The W3C puts all support files in a directory named support, the runner should be updated to skip that, too so imported w3c tests needn't be modified. 1028944 1 236561 rhauck 2014-08-13 16:08:22 -0700 Created attachment 236561 Patch for the bug 1028947 2 bjonesbe 2014-08-13 16:14:48 -0700 r=me, we already have support directories in the tree, they just are lucky and don't contain anything that looks like a test. I'd like to double check with Ryosuke before landing, though. 1029397 3 236561 rniwa 2014-08-15 11:30:31 -0700 Comment on attachment 236561 Patch for the bug Looks great to me. 1029416 4 236561 commit-queue 2014-08-15 12:04:20 -0700 Comment on attachment 236561 Patch for the bug Clearing flags on attachment: 236561 Committed r172638: <http://trac.webkit.org/changeset/172638> 1029417 5 commit-queue 2014-08-15 12:04:24 -0700 All reviewed patches have been landed. Closing bug. 236561 2014-08-13 16:08:22 -0700 2014-08-15 12:04:19 -0700 Patch for the bug 135910.patch text/plain 1584 rhauck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhNzhl OGNmLi5mNThlM2M1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTQtMDgtMTMgIFJlYmVjY2EgSGF1Y2sgIDxyaGF1 Y2tAYWRvYmUuY29tPgorCisgICAgICAgIHJ1bi13ZWJraXQtdGVzdHMgc2hvdWxkIHNraXAgJ3N1 cHBvcnQnIGRpcmVjdG9yaWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzU5MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KyAgICAgICAgCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyB0aGUgJ3N1cHBvcnQnIGRpcmVjdG9y eSB0byB0aGUgbGlzdAorICAgICAgICBvZiBkaXJzIHRvIHNraXAgd2hlbiBsb29raW5nIGZvciBy dW5uYWJsZSB0ZXN0cy4KKyAgICAgICAgdGhlIFczQyB1c2VzIHRoaXMgbmFtZSBmb3Igc3VwcG9y dCBmaWxlcywgc28gdGVzdHMKKyAgICAgICAgaW1wb3J0ZWQgZnJvbSB0aGUgVzNDIHdpbGwgbm90 IHdvcmsgd2l0aG91dCB0aGlzIGNoYW5nZQorICAgICAgICBvciB3aXRob3V0IG1hbnkgZWRpdHMu CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weToKKyAgICAgICAgKFBv cnQuX3JlYWxfdGVzdHMpOgorCiAyMDE0LTA4LTEzICBSZW5hdG8gTmFneSAgPG5hZ3kucmVuYXRv QHN0dWQudS1zemVnZWQuaHU+CiAKICAgICAgICAgTWFrZSBjaGVjay13ZWJraXQtc3R5bGUgcnVu IHNvcnQtZXhwb3J0LWZpbGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9y dC9iYXNlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKaW5kZXggOWQ5 NjgyOC4uMzA3NjZkMSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jh c2UucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKQEAgLTU0Myw3 ICs1NDMsNyBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAKICAgICBkZWYgX3JlYWxfdGVzdHMoc2Vs ZiwgcGF0aHMpOgogICAgICAgICAjIFdoZW4gY29sbGVjdGluZyB0ZXN0IGNhc2VzLCBza2lwIHRo ZXNlIGRpcmVjdG9yaWVzCi0gICAgICAgIHNraXBwZWRfZGlyZWN0b3JpZXMgPSBzZXQoWycuc3Zu JywgJ19zdm4nLCAncmVzb3VyY2VzJywgJ3NjcmlwdC10ZXN0cycsICdyZWZlcmVuY2UnLCAncmVm dGVzdCddKQorICAgICAgICBza2lwcGVkX2RpcmVjdG9yaWVzID0gc2V0KFsnLnN2bicsICdfc3Zu JywgJ3Jlc291cmNlcycsICdzdXBwb3J0JywgJ3NjcmlwdC10ZXN0cycsICdyZWZlcmVuY2UnLCAn cmVmdGVzdCddKQogICAgICAgICBmaWxlcyA9IGZpbmRfZmlsZXMuZmluZChzZWxmLl9maWxlc3lz dGVtLCBzZWxmLmxheW91dF90ZXN0c19kaXIoKSwgcGF0aHMsIHNraXBwZWRfZGlyZWN0b3JpZXMs IFBvcnQuX2lzX3Rlc3RfZmlsZSwgc2VsZi50ZXN0X2tleSkKICAgICAgICAgcmV0dXJuIFtzZWxm LnJlbGF0aXZlX3Rlc3RfZmlsZW5hbWUoZikgZm9yIGYgaW4gZmlsZXNdCiAK