135906 2014-08-13 14:57:20 -0700 [JSC] Build error on ARM64 with gcc: JSC::ARM64Assembler::RegisterID coerced into 5-bit bit field 2014-08-21 02:01:00 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 akiss webkit-unassigned commit-queue msaboff ossy oldest_to_newest 1028915 0 akiss 2014-08-13 14:57:20 -0700 When compilig JSC for arm64 with gcc, the following error is raised: Source/JavaScriptCore/assembler/ARM64Assembler.h:629:48: error: 'JSC::ARM64Assembler::LinkRecord::<anonymous union>::RealTypes::m_compareRegister' is too small to hold all values of 'JSC::ARM64Assembler::RegisterID {aka enum JSC::ARM64Registers::RegisterID}' [-Werror] RegisterID m_compareRegister : 5; This is because zr = 0x3f in RegisterID, so at least 6 bits are needed, but we only have 5. CopyTypes, sharing an enum with RealTypes, is 3 x 64 bits, so increasing the size of the RealTypes::m_compareRegister bit field seems to be a valid solution. 1028916 1 236554 akiss 2014-08-13 15:06:41 -0700 Created attachment 236554 Proposed patch. 1028919 2 commit-queue 2014-08-13 15:07:36 -0700 Attachment 236554 did not pass style-queue: ERROR: Source/JavaScriptCore/assembler/ARM64Assembler.h:628: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] ERROR: Source/JavaScriptCore/assembler/ARM64Assembler.h:629: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1029035 3 236554 msaboff 2014-08-13 22:31:21 -0700 Comment on attachment 236554 Proposed patch. r=me 1029048 4 236554 commit-queue 2014-08-14 01:50:01 -0700 Comment on attachment 236554 Proposed patch. Clearing flags on attachment: 236554 Committed r172578: <http://trac.webkit.org/changeset/172578> 1029049 5 commit-queue 2014-08-14 01:50:04 -0700 All reviewed patches have been landed. Closing bug. 236554 2014-08-13 15:06:41 -0700 2014-08-14 01:50:01 -0700 Proposed patch. 0001-fix-JSC-ARM64Assembler-LinkRecord-RealTypes.patch text/plain 2023 akiss RnJvbSAyOTZkNzJlM2YwZjNjNGE0NmZiNDUyNTNlNzI4MTcxOTJiYjg5MTIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBa29zIEtpc3MgPGFraXNzQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogV2VkLCAxMyBBdWcgMjAxNCAyMjowMTowOSArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIGZpeCBK U0M6OkFSTTY0QXNzZW1ibGVyOjpMaW5rUmVjb3JkOjpSZWFsVHlwZXMKCi0tLQogU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgIHwgMTQgKysrKysrKysrKysr KysKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNNjRBc3NlbWJsZXIuaCB8ICA0 ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0ZDE3ODM1Li45NzYzMWVjIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNC0wOC0xMyAgQWtvcyBLaXNzICA8 YWtpc3NAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIEZpeCBKU0M6OkFSTTY0QXNzZW1ibGVy OjpMaW5rUmVjb3JkOjpSZWFsVHlwZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzNTkwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEpTQzo6QVJNNjRBc3NlbWJsZXI6OkxpbmtSZWNvcmQ6OlJlYWxUeXBl czo6bV9jb21wYXJlUmVnaXN0ZXIgaXMgZGVmaW5lZAorICAgICAgICB0byBvY2N1cHkgNSBiaXRz IGJ1dCBKU0M6OkFSTTY0QXNzZW1ibGVyOjpSZWdpc3RlcklEIG5lZWRzIDYgYml0cy4gU28sCisg ICAgICAgIGluY3JlYXNlIHRoZSBzaXplIG9mIHRoZSBiaXQgZmllbGQgYW5kIGFsc28gcmVvcmdh bml6ZSB0aGUgc3RydWN0IHRvIAorICAgICAgICBiZXR0ZXIgYWxpZ24gd2l0aCB3b3JkIGJvdW5k YXJpZXMuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvQVJNNjRBc3NlbWJsZXIuaDoKKwogMjAxNC0w OC0wNyAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAg IFNwZWN1bGF0ZUludDMyT3BlcmFuZCBpcyBzb21ldGltZXMgdXNlZCBpbiBhIDY0LWJpdCBjb250 ZXh0LCB3aGljaCBoYXMgdW5kZWZpbmVkIGJlaGF2aW9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTTY0QXNzZW1ibGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL0FSTTY0QXNzZW1ibGVyLmgKaW5kZXggZmYyNDc2OS4uN2EyNzNhYSAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk02NEFzc2VtYmxl ci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNNjRBc3NlbWJsZXIu aApAQCAtNjI0LDkgKzYyNCw5IEBAIHB1YmxpYzoKICAgICAgICAgICAgICAgICBKdW1wVHlwZSBt X3R5cGUgOiA4OwogICAgICAgICAgICAgICAgIEp1bXBMaW5rVHlwZSBtX2xpbmtUeXBlIDogODsK ICAgICAgICAgICAgICAgICBDb25kaXRpb24gbV9jb25kaXRpb24gOiA0OwotICAgICAgICAgICAg ICAgIGJvb2wgbV9pczY0Qml0IDogMTsKICAgICAgICAgICAgICAgICB1bnNpZ25lZCBtX2JpdE51 bWJlciA6IDY7Ci0gICAgICAgICAgICAgICAgUmVnaXN0ZXJJRCBtX2NvbXBhcmVSZWdpc3RlciA6 IDU7CisgICAgICAgICAgICAgICAgUmVnaXN0ZXJJRCBtX2NvbXBhcmVSZWdpc3RlciA6IDY7Cisg ICAgICAgICAgICAgICAgYm9vbCBtX2lzNjRCaXQgOiAxOwogICAgICAgICAgICAgfSByZWFsVHlw ZXM7CiAgICAgICAgICAgICBzdHJ1Y3QgQ29weVR5cGVzIHsKICAgICAgICAgICAgICAgICB1aW50 NjRfdCBjb250ZW50WzNdOwotLSAKMS45LjEKCg==