<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>135889</bug_id>
          
          <creation_ts>2014-08-13 11:07:53 -0700</creation_ts>
          <short_desc>Clean up build warnings: control reaches end of non-void function</short_desc>
          <delta_ts>2014-08-23 00:13:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yusuke Suzuki">ysuzuki</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          <cc>ap</cc>
    
    <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1028827</commentid>
    <comment_count>0</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2014-08-13 11:07:53 -0700</bug_when>
    <thetext>Clean up build warnings: control reaches end of non-void function</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1028828</commentid>
    <comment_count>1</comment_count>
      <attachid>236535</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2014-08-13 11:08:19 -0700</bug_when>
    <thetext>Created attachment 236535
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1028829</commentid>
    <comment_count>2</comment_count>
      <attachid>236536</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2014-08-13 11:18:10 -0700</bug_when>
    <thetext>Created attachment 236536
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029561</commentid>
    <comment_count>3</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-08-15 21:00:22 -0700</bug_when>
    <thetext>What compiler complains about this? These are strongly type enums, so I don&apos;t see how this is a valid warning. Perhaps it should be disabled instead?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029576</commentid>
    <comment_count>4</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2014-08-15 22:12:20 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; What compiler complains about this? These are strongly type enums, so I don&apos;t see how this is a valid warning. Perhaps it should be disabled instead?

Compiler version is gcc 4.9.1, that&apos;s a default compiler for Ubuntu 14.04.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029582</commentid>
    <comment_count>5</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-08-15 23:46:46 -0700</bug_when>
    <thetext>What do you think about disabling this warning? It seems clearly invalid to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029702</commentid>
    <comment_count>6</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2014-08-17 22:37:13 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; What do you think about disabling this warning? It seems clearly invalid to me.

We decided last year not to disable the warning for GCC. See the thread &apos;Can we disable &quot;control reaches end of non-void function&quot; warning on Qt?&apos; on webkit-dev.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029703</commentid>
    <comment_count>7</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-08-17 22:44:08 -0700</bug_when>
    <thetext>Wasn&apos;t that discussion about old-style enums, not strongly typed enums?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029705</commentid>
    <comment_count>8</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2014-08-17 22:56:20 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; Wasn&apos;t that discussion about old-style enums, not strongly typed enums?

Reading the thread, maybe that&apos;s correct.
My concern is that disabling this warning is not limited for strongly-typed enums. So personally I think disabling this causes issues when some non-strongly-typed enum value is appended to the existing enums. But I&apos;d like to hear Alexey and Benjamin&apos;s opinions :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029785</commentid>
    <comment_count>9</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-08-18 09:40:46 -0700</bug_when>
    <thetext>I don&apos;t have a strong opinion. Just like to keep the code clean.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029846</commentid>
    <comment_count>10</comment_count>
      <attachid>236536</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2014-08-18 13:33:01 -0700</bug_when>
    <thetext>Comment on attachment 236536
Patch

Replace ASSERT_NOT_REACHED with RELEASE_ASSERT_NOT_REACHED()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029882</commentid>
    <comment_count>11</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2014-08-18 14:37:37 -0700</bug_when>
    <thetext>(In reply to comment #10)
&gt; (From update of attachment 236536 [details])
&gt; Replace ASSERT_NOT_REACHED with RELEASE_ASSERT_NOT_REACHED()

Thanks for your review. That&apos;s reasonable and safe.
I&apos;ll change to it and update the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029890</commentid>
    <comment_count>12</comment_count>
      <attachid>236787</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2014-08-18 14:40:52 -0700</bug_when>
    <thetext>Created attachment 236787
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030215</commentid>
    <comment_count>13</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2014-08-19 22:54:57 -0700</bug_when>
    <thetext>I am okay with this.

Alexey?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030909</commentid>
    <comment_count>14</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2014-08-22 23:41:25 -0700</bug_when>
    <thetext>(In reply to comment #13)
&gt; I am okay with this.
&gt; 
&gt; Alexey?

Oh! I&apos;ve missed Alexey&apos;s r+. Thank you for the discussion Alexey and Benjamin. And thx for your review, Oliver.
I&apos;ll land it :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030912</commentid>
    <comment_count>15</comment_count>
      <attachid>236787</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-08-23 00:13:12 -0700</bug_when>
    <thetext>Comment on attachment 236787
Patch

Clearing flags on attachment: 236787

Committed r172886: &lt;http://trac.webkit.org/changeset/172886&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030913</commentid>
    <comment_count>16</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-08-23 00:13:16 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>236535</attachid>
            <date>2014-08-13 11:08:19 -0700</date>
            <delta_ts>2014-08-13 11:18:04 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-135889-20140814030912.patch</filename>
            <type>text/plain</type>
            <size>6296</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWYwOWI3Y2QwYzdjNTE5
ODAwYjM1Y2ViYTFhMjk4MTFkYmZiOWYwOC4uMjMxOWJhZGRmYTZmNTgwZmMyMTRiNDFmM2EzZjA1
NmI4ZmE2ZWU1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA4LTEzICBZdXN1
a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIENsZWFuIHVwIGJ1
aWxkIHdhcm5pbmdzOiBjb250cm9sIHJlYWNoZXMgZW5kIG9mIG5vbi12b2lkIGZ1bmN0aW9uCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU4ODkKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdz
L2pzL0pTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpK
U0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRlcnNGb3JFbmNyeXB0KToK
KyAgICAgICAgKFdlYkNvcmU6OkpTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFy
YW1ldGVyc0ZvckRlY3J5cHQpOgorICAgICAgICAoV2ViQ29yZTo6SlNDcnlwdG9BbGdvcml0aG1E
aWN0aW9uYXJ5OjpjcmVhdGVQYXJhbWV0ZXJzRm9yU2lnbik6CisgICAgICAgIChXZWJDb3JlOjpK
U0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRlcnNGb3JWZXJpZnkpOgor
ICAgICAgICAoV2ViQ29yZTo6SlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5OjpjcmVhdGVQYXJh
bWV0ZXJzRm9yRGlnZXN0KToKKyAgICAgICAgKFdlYkNvcmU6OkpTQ3J5cHRvQWxnb3JpdGhtRGlj
dGlvbmFyeTo6Y3JlYXRlUGFyYW1ldGVyc0ZvckdlbmVyYXRlS2V5KToKKyAgICAgICAgKFdlYkNv
cmU6OkpTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFyYW1ldGVyc0ZvckRlcml2
ZUtleSk6CisgICAgICAgIChXZWJDb3JlOjpKU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNy
ZWF0ZVBhcmFtZXRlcnNGb3JEZXJpdmVCaXRzKToKKyAgICAgICAgKFdlYkNvcmU6OkpTQ3J5cHRv
QWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFyYW1ldGVyc0ZvckltcG9ydEtleSk6CisgICAg
ICAgIChXZWJDb3JlOjpKU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRl
cnNGb3JFeHBvcnRLZXkpOgorICAgICAgICAqIGNyeXB0by9DcnlwdG9LZXkuY3BwOgorICAgICAg
ICAoV2ViQ29yZTo6Q3J5cHRvS2V5Ojp0eXBlKToKKwogMjAxNC0wOC0xMyAgQW50dGkgS29pdmlz
dG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgRG9uJ3QgcmVjdXJzZSBpbnRvIG5vbi1y
ZW5kZXJlZCBzdWJ0cmVlcyB3aGVuIGNvbXB1dGluZyBzdHlsZQpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYkNvcmUvYmluZGluZ3MvanMvSlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5LmNwcCBiL1Nv
dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeS5jcHAK
aW5kZXggZDk1YzE3MzFmNjdiYWQwMTM1ZmQ2YTdhZGUzYmEwYmRmYzMyYjg3My4uZjYxMDE0YzYy
MDA0MDYwYWI2M2ZjNjRiZDgwYmRjNjE1MzQ5OGVmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvYmluZGluZ3MvanMvSlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5LmNwcAorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnkuY3BwCkBA
IC0zMzUsNiArMzM1LDggQEAgc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdvcml0aG1Q
YXJhbWV0ZXJzPiBjcmVhdGVSc2FTc2FQYXJhbXMoRXhlY1N0YXRlKgogICAgICAgICBzZXRET01F
eGNlcHRpb24oZXhlYywgTk9UX1NVUFBPUlRFRF9FUlIpOwogICAgICAgICByZXR1cm4gbnVsbHB0
cjsKICAgICB9CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIG51bGxwdHI7
CiB9CiAKIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdvcml0aG1QYXJhbWV0ZXJzPiBKU0NyeXB0
b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRlcnNGb3JEZWNyeXB0KEV4ZWNTdGF0
ZSogZXhlYywgQ3J5cHRvQWxnb3JpdGhtSWRlbnRpZmllciBhbGdvcml0aG0sIEpTVmFsdWUgdmFs
dWUpCkBAIC0zNzUsNiArMzc3LDggQEAgc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdv
cml0aG1QYXJhbWV0ZXJzPiBjcmVhdGVSc2FTc2FQYXJhbXMoRXhlY1N0YXRlKgogICAgICAgICBz
ZXRET01FeGNlcHRpb24oZXhlYywgTk9UX1NVUFBPUlRFRF9FUlIpOwogICAgICAgICByZXR1cm4g
bnVsbHB0cjsKICAgICB9CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIG51
bGxwdHI7CiB9CiAKIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdvcml0aG1QYXJhbWV0ZXJzPiBK
U0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRlcnNGb3JTaWduKEV4ZWNT
dGF0ZSogZXhlYywgQ3J5cHRvQWxnb3JpdGhtSWRlbnRpZmllciBhbGdvcml0aG0sIEpTVmFsdWUg
dmFsdWUpCkBAIC00MTEsNiArNDE1LDggQEAgc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9B
bGdvcml0aG1QYXJhbWV0ZXJzPiBjcmVhdGVSc2FTc2FQYXJhbXMoRXhlY1N0YXRlKgogICAgICAg
ICBzZXRET01FeGNlcHRpb24oZXhlYywgTk9UX1NVUFBPUlRFRF9FUlIpOwogICAgICAgICByZXR1
cm4gbnVsbHB0cjsKICAgICB9CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJu
IG51bGxwdHI7CiB9CiAKIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdvcml0aG1QYXJhbWV0ZXJz
PiBKU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRlcnNGb3JWZXJpZnko
RXhlY1N0YXRlKiBleGVjLCBDcnlwdG9BbGdvcml0aG1JZGVudGlmaWVyIGFsZ29yaXRobSwgSlNW
YWx1ZSB2YWx1ZSkKQEAgLTQ0Nyw2ICs0NTMsOCBAQCBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPENy
eXB0b0FsZ29yaXRobVBhcmFtZXRlcnM+IGNyZWF0ZVJzYVNzYVBhcmFtcyhFeGVjU3RhdGUqCiAg
ICAgICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBOT1RfU1VQUE9SVEVEX0VSUik7CiAgICAgICAg
IHJldHVybiBudWxscHRyOwogICAgIH0KKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICBy
ZXR1cm4gbnVsbHB0cjsKIH0KIAogc3RkOjp1bmlxdWVfcHRyPENyeXB0b0FsZ29yaXRobVBhcmFt
ZXRlcnM+IEpTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFyYW1ldGVyc0ZvckRp
Z2VzdChFeGVjU3RhdGUqIGV4ZWMsIENyeXB0b0FsZ29yaXRobUlkZW50aWZpZXIgYWxnb3JpdGht
LCBKU1ZhbHVlKQpAQCAtNDgwLDYgKzQ4OCw4IEBAIHN0YXRpYyBzdGQ6OnVuaXF1ZV9wdHI8Q3J5
cHRvQWxnb3JpdGhtUGFyYW1ldGVycz4gY3JlYXRlUnNhU3NhUGFyYW1zKEV4ZWNTdGF0ZSoKICAg
ICAgICAgc2V0RE9NRXhjZXB0aW9uKGV4ZWMsIE5PVF9TVVBQT1JURURfRVJSKTsKICAgICAgICAg
cmV0dXJuIG51bGxwdHI7CiAgICAgfQorICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJl
dHVybiBudWxscHRyOwogfQogCiBzdGQ6OnVuaXF1ZV9wdHI8Q3J5cHRvQWxnb3JpdGhtUGFyYW1l
dGVycz4gSlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5OjpjcmVhdGVQYXJhbWV0ZXJzRm9yR2Vu
ZXJhdGVLZXkoRXhlY1N0YXRlKiBleGVjLCBDcnlwdG9BbGdvcml0aG1JZGVudGlmaWVyIGFsZ29y
aXRobSwgSlNWYWx1ZSB2YWx1ZSkKQEAgLTUxNSw2ICs1MjUsOCBAQCBzdGF0aWMgc3RkOjp1bmlx
dWVfcHRyPENyeXB0b0FsZ29yaXRobVBhcmFtZXRlcnM+IGNyZWF0ZVJzYVNzYVBhcmFtcyhFeGVj
U3RhdGUqCiAgICAgICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBOT1RfU1VQUE9SVEVEX0VSUik7
CiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIH0KKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQo
KTsKKyAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAogc3RkOjp1bmlxdWVfcHRyPENyeXB0b0FsZ29y
aXRobVBhcmFtZXRlcnM+IEpTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFyYW1l
dGVyc0ZvckRlcml2ZUtleShFeGVjU3RhdGUqIGV4ZWMsIENyeXB0b0FsZ29yaXRobUlkZW50aWZp
ZXIgYWxnb3JpdGhtLCBKU1ZhbHVlKQpAQCAtNTQ1LDYgKzU1Nyw4IEBAIHN0YXRpYyBzdGQ6OnVu
aXF1ZV9wdHI8Q3J5cHRvQWxnb3JpdGhtUGFyYW1ldGVycz4gY3JlYXRlUnNhU3NhUGFyYW1zKEV4
ZWNTdGF0ZSoKICAgICAgICAgc2V0RE9NRXhjZXB0aW9uKGV4ZWMsIE5PVF9TVVBQT1JURURfRVJS
KTsKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfQorICAgIEFTU0VSVF9OT1RfUkVBQ0hF
RCgpOworICAgIHJldHVybiBudWxscHRyOwogfQogCiBzdGQ6OnVuaXF1ZV9wdHI8Q3J5cHRvQWxn
b3JpdGhtUGFyYW1ldGVycz4gSlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5OjpjcmVhdGVQYXJh
bWV0ZXJzRm9yRGVyaXZlQml0cyhFeGVjU3RhdGUqIGV4ZWMsIENyeXB0b0FsZ29yaXRobUlkZW50
aWZpZXIgYWxnb3JpdGhtLCBKU1ZhbHVlKQpAQCAtNTc1LDYgKzU4OSw4IEBAIHN0YXRpYyBzdGQ6
OnVuaXF1ZV9wdHI8Q3J5cHRvQWxnb3JpdGhtUGFyYW1ldGVycz4gY3JlYXRlUnNhU3NhUGFyYW1z
KEV4ZWNTdGF0ZSoKICAgICAgICAgc2V0RE9NRXhjZXB0aW9uKGV4ZWMsIE5PVF9TVVBQT1JURURf
RVJSKTsKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfQorICAgIEFTU0VSVF9OT1RfUkVB
Q0hFRCgpOworICAgIHJldHVybiBudWxscHRyOwogfQogCiBzdGQ6OnVuaXF1ZV9wdHI8Q3J5cHRv
QWxnb3JpdGhtUGFyYW1ldGVycz4gSlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5OjpjcmVhdGVQ
YXJhbWV0ZXJzRm9ySW1wb3J0S2V5KEV4ZWNTdGF0ZSogZXhlYywgQ3J5cHRvQWxnb3JpdGhtSWRl
bnRpZmllciBhbGdvcml0aG0sIEpTVmFsdWUgdmFsdWUpCkBAIC02MTIsNiArNjI4LDggQEAgc3Rh
dGljIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdvcml0aG1QYXJhbWV0ZXJzPiBjcmVhdGVSc2FT
c2FQYXJhbXMoRXhlY1N0YXRlKgogICAgICAgICBzZXRET01FeGNlcHRpb24oZXhlYywgTk9UX1NV
UFBPUlRFRF9FUlIpOwogICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICB9CisgICAgQVNTRVJU
X05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKIHN0ZDo6dW5pcXVlX3B0
cjxDcnlwdG9BbGdvcml0aG1QYXJhbWV0ZXJzPiBKU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6
OmNyZWF0ZVBhcmFtZXRlcnNGb3JFeHBvcnRLZXkoRXhlY1N0YXRlKiBleGVjLCBDcnlwdG9BbGdv
cml0aG1JZGVudGlmaWVyIGFsZ29yaXRobSwgSlNWYWx1ZSkKQEAgLTY0Myw2ICs2NjEsOCBAQCBz
dGF0aWMgc3RkOjp1bmlxdWVfcHRyPENyeXB0b0FsZ29yaXRobVBhcmFtZXRlcnM+IGNyZWF0ZVJz
YVNzYVBhcmFtcyhFeGVjU3RhdGUqCiAgICAgICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBOT1Rf
U1VQUE9SVEVEX0VSUik7CiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIH0KKyAgICBBU1NF
UlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAogfQpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvY3J5cHRvL0NyeXB0b0tleS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9j
cnlwdG8vQ3J5cHRvS2V5LmNwcAppbmRleCAxZWY5NTM5YmZhZjBmOGE4YmVkM2QyNzVhNWE0ZGEx
ZDQ4MmJiNjUxLi4yYmIyOGNhMzA4OWJkZmExMThjZjliMGMwN2VhNGU1NzM1YWUzNWZhIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8vQ3J5cHRvS2V5LmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9jcnlwdG8vQ3J5cHRvS2V5LmNwcApAQCAtNTcsNiArNTcsOCBAQCBTdHJpbmcgQ3J5
cHRvS2V5Ojp0eXBlKCkgY29uc3QKICAgICBjYXNlIENyeXB0b0tleVR5cGU6OlByaXZhdGU6CiAg
ICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoInByaXZhdGUiKTsKICAgICB9CisgICAgQVNTRVJU
X05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIGVtcHR5U3RyaW5nKCkKIH0KIAogdm9pZCBDcnlw
dG9LZXk6OmJ1aWxkQWxnb3JpdGhtRGVzY3JpcHRpb24oQ3J5cHRvQWxnb3JpdGhtRGVzY3JpcHRp
b25CdWlsZGVyJiBidWlsZGVyKSBjb25zdAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>236536</attachid>
            <date>2014-08-13 11:18:10 -0700</date>
            <delta_ts>2014-08-18 14:40:48 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-135889-20140814031903.patch</filename>
            <type>text/plain</type>
            <size>6297</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWYwOWI3Y2QwYzdjNTE5
ODAwYjM1Y2ViYTFhMjk4MTFkYmZiOWYwOC4uMjMxOWJhZGRmYTZmNTgwZmMyMTRiNDFmM2EzZjA1
NmI4ZmE2ZWU1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA4LTEzICBZdXN1
a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIENsZWFuIHVwIGJ1
aWxkIHdhcm5pbmdzOiBjb250cm9sIHJlYWNoZXMgZW5kIG9mIG5vbi12b2lkIGZ1bmN0aW9uCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU4ODkKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdz
L2pzL0pTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpK
U0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRlcnNGb3JFbmNyeXB0KToK
KyAgICAgICAgKFdlYkNvcmU6OkpTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFy
YW1ldGVyc0ZvckRlY3J5cHQpOgorICAgICAgICAoV2ViQ29yZTo6SlNDcnlwdG9BbGdvcml0aG1E
aWN0aW9uYXJ5OjpjcmVhdGVQYXJhbWV0ZXJzRm9yU2lnbik6CisgICAgICAgIChXZWJDb3JlOjpK
U0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRlcnNGb3JWZXJpZnkpOgor
ICAgICAgICAoV2ViQ29yZTo6SlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5OjpjcmVhdGVQYXJh
bWV0ZXJzRm9yRGlnZXN0KToKKyAgICAgICAgKFdlYkNvcmU6OkpTQ3J5cHRvQWxnb3JpdGhtRGlj
dGlvbmFyeTo6Y3JlYXRlUGFyYW1ldGVyc0ZvckdlbmVyYXRlS2V5KToKKyAgICAgICAgKFdlYkNv
cmU6OkpTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFyYW1ldGVyc0ZvckRlcml2
ZUtleSk6CisgICAgICAgIChXZWJDb3JlOjpKU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNy
ZWF0ZVBhcmFtZXRlcnNGb3JEZXJpdmVCaXRzKToKKyAgICAgICAgKFdlYkNvcmU6OkpTQ3J5cHRv
QWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFyYW1ldGVyc0ZvckltcG9ydEtleSk6CisgICAg
ICAgIChXZWJDb3JlOjpKU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRl
cnNGb3JFeHBvcnRLZXkpOgorICAgICAgICAqIGNyeXB0by9DcnlwdG9LZXkuY3BwOgorICAgICAg
ICAoV2ViQ29yZTo6Q3J5cHRvS2V5Ojp0eXBlKToKKwogMjAxNC0wOC0xMyAgQW50dGkgS29pdmlz
dG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgRG9uJ3QgcmVjdXJzZSBpbnRvIG5vbi1y
ZW5kZXJlZCBzdWJ0cmVlcyB3aGVuIGNvbXB1dGluZyBzdHlsZQpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYkNvcmUvYmluZGluZ3MvanMvSlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5LmNwcCBiL1Nv
dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeS5jcHAK
aW5kZXggZDk1YzE3MzFmNjdiYWQwMTM1ZmQ2YTdhZGUzYmEwYmRmYzMyYjg3My4uZjYxMDE0YzYy
MDA0MDYwYWI2M2ZjNjRiZDgwYmRjNjE1MzQ5OGVmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvYmluZGluZ3MvanMvSlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5LmNwcAorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnkuY3BwCkBA
IC0zMzUsNiArMzM1LDggQEAgc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdvcml0aG1Q
YXJhbWV0ZXJzPiBjcmVhdGVSc2FTc2FQYXJhbXMoRXhlY1N0YXRlKgogICAgICAgICBzZXRET01F
eGNlcHRpb24oZXhlYywgTk9UX1NVUFBPUlRFRF9FUlIpOwogICAgICAgICByZXR1cm4gbnVsbHB0
cjsKICAgICB9CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIG51bGxwdHI7
CiB9CiAKIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdvcml0aG1QYXJhbWV0ZXJzPiBKU0NyeXB0
b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRlcnNGb3JEZWNyeXB0KEV4ZWNTdGF0
ZSogZXhlYywgQ3J5cHRvQWxnb3JpdGhtSWRlbnRpZmllciBhbGdvcml0aG0sIEpTVmFsdWUgdmFs
dWUpCkBAIC0zNzUsNiArMzc3LDggQEAgc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdv
cml0aG1QYXJhbWV0ZXJzPiBjcmVhdGVSc2FTc2FQYXJhbXMoRXhlY1N0YXRlKgogICAgICAgICBz
ZXRET01FeGNlcHRpb24oZXhlYywgTk9UX1NVUFBPUlRFRF9FUlIpOwogICAgICAgICByZXR1cm4g
bnVsbHB0cjsKICAgICB9CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIG51
bGxwdHI7CiB9CiAKIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdvcml0aG1QYXJhbWV0ZXJzPiBK
U0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRlcnNGb3JTaWduKEV4ZWNT
dGF0ZSogZXhlYywgQ3J5cHRvQWxnb3JpdGhtSWRlbnRpZmllciBhbGdvcml0aG0sIEpTVmFsdWUg
dmFsdWUpCkBAIC00MTEsNiArNDE1LDggQEAgc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9B
bGdvcml0aG1QYXJhbWV0ZXJzPiBjcmVhdGVSc2FTc2FQYXJhbXMoRXhlY1N0YXRlKgogICAgICAg
ICBzZXRET01FeGNlcHRpb24oZXhlYywgTk9UX1NVUFBPUlRFRF9FUlIpOwogICAgICAgICByZXR1
cm4gbnVsbHB0cjsKICAgICB9CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJu
IG51bGxwdHI7CiB9CiAKIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdvcml0aG1QYXJhbWV0ZXJz
PiBKU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRlcnNGb3JWZXJpZnko
RXhlY1N0YXRlKiBleGVjLCBDcnlwdG9BbGdvcml0aG1JZGVudGlmaWVyIGFsZ29yaXRobSwgSlNW
YWx1ZSB2YWx1ZSkKQEAgLTQ0Nyw2ICs0NTMsOCBAQCBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPENy
eXB0b0FsZ29yaXRobVBhcmFtZXRlcnM+IGNyZWF0ZVJzYVNzYVBhcmFtcyhFeGVjU3RhdGUqCiAg
ICAgICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBOT1RfU1VQUE9SVEVEX0VSUik7CiAgICAgICAg
IHJldHVybiBudWxscHRyOwogICAgIH0KKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICBy
ZXR1cm4gbnVsbHB0cjsKIH0KIAogc3RkOjp1bmlxdWVfcHRyPENyeXB0b0FsZ29yaXRobVBhcmFt
ZXRlcnM+IEpTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFyYW1ldGVyc0ZvckRp
Z2VzdChFeGVjU3RhdGUqIGV4ZWMsIENyeXB0b0FsZ29yaXRobUlkZW50aWZpZXIgYWxnb3JpdGht
LCBKU1ZhbHVlKQpAQCAtNDgwLDYgKzQ4OCw4IEBAIHN0YXRpYyBzdGQ6OnVuaXF1ZV9wdHI8Q3J5
cHRvQWxnb3JpdGhtUGFyYW1ldGVycz4gY3JlYXRlUnNhU3NhUGFyYW1zKEV4ZWNTdGF0ZSoKICAg
ICAgICAgc2V0RE9NRXhjZXB0aW9uKGV4ZWMsIE5PVF9TVVBQT1JURURfRVJSKTsKICAgICAgICAg
cmV0dXJuIG51bGxwdHI7CiAgICAgfQorICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJl
dHVybiBudWxscHRyOwogfQogCiBzdGQ6OnVuaXF1ZV9wdHI8Q3J5cHRvQWxnb3JpdGhtUGFyYW1l
dGVycz4gSlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5OjpjcmVhdGVQYXJhbWV0ZXJzRm9yR2Vu
ZXJhdGVLZXkoRXhlY1N0YXRlKiBleGVjLCBDcnlwdG9BbGdvcml0aG1JZGVudGlmaWVyIGFsZ29y
aXRobSwgSlNWYWx1ZSB2YWx1ZSkKQEAgLTUxNSw2ICs1MjUsOCBAQCBzdGF0aWMgc3RkOjp1bmlx
dWVfcHRyPENyeXB0b0FsZ29yaXRobVBhcmFtZXRlcnM+IGNyZWF0ZVJzYVNzYVBhcmFtcyhFeGVj
U3RhdGUqCiAgICAgICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBOT1RfU1VQUE9SVEVEX0VSUik7
CiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIH0KKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQo
KTsKKyAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAogc3RkOjp1bmlxdWVfcHRyPENyeXB0b0FsZ29y
aXRobVBhcmFtZXRlcnM+IEpTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFyYW1l
dGVyc0ZvckRlcml2ZUtleShFeGVjU3RhdGUqIGV4ZWMsIENyeXB0b0FsZ29yaXRobUlkZW50aWZp
ZXIgYWxnb3JpdGhtLCBKU1ZhbHVlKQpAQCAtNTQ1LDYgKzU1Nyw4IEBAIHN0YXRpYyBzdGQ6OnVu
aXF1ZV9wdHI8Q3J5cHRvQWxnb3JpdGhtUGFyYW1ldGVycz4gY3JlYXRlUnNhU3NhUGFyYW1zKEV4
ZWNTdGF0ZSoKICAgICAgICAgc2V0RE9NRXhjZXB0aW9uKGV4ZWMsIE5PVF9TVVBQT1JURURfRVJS
KTsKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfQorICAgIEFTU0VSVF9OT1RfUkVBQ0hF
RCgpOworICAgIHJldHVybiBudWxscHRyOwogfQogCiBzdGQ6OnVuaXF1ZV9wdHI8Q3J5cHRvQWxn
b3JpdGhtUGFyYW1ldGVycz4gSlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5OjpjcmVhdGVQYXJh
bWV0ZXJzRm9yRGVyaXZlQml0cyhFeGVjU3RhdGUqIGV4ZWMsIENyeXB0b0FsZ29yaXRobUlkZW50
aWZpZXIgYWxnb3JpdGhtLCBKU1ZhbHVlKQpAQCAtNTc1LDYgKzU4OSw4IEBAIHN0YXRpYyBzdGQ6
OnVuaXF1ZV9wdHI8Q3J5cHRvQWxnb3JpdGhtUGFyYW1ldGVycz4gY3JlYXRlUnNhU3NhUGFyYW1z
KEV4ZWNTdGF0ZSoKICAgICAgICAgc2V0RE9NRXhjZXB0aW9uKGV4ZWMsIE5PVF9TVVBQT1JURURf
RVJSKTsKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfQorICAgIEFTU0VSVF9OT1RfUkVB
Q0hFRCgpOworICAgIHJldHVybiBudWxscHRyOwogfQogCiBzdGQ6OnVuaXF1ZV9wdHI8Q3J5cHRv
QWxnb3JpdGhtUGFyYW1ldGVycz4gSlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5OjpjcmVhdGVQ
YXJhbWV0ZXJzRm9ySW1wb3J0S2V5KEV4ZWNTdGF0ZSogZXhlYywgQ3J5cHRvQWxnb3JpdGhtSWRl
bnRpZmllciBhbGdvcml0aG0sIEpTVmFsdWUgdmFsdWUpCkBAIC02MTIsNiArNjI4LDggQEAgc3Rh
dGljIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdvcml0aG1QYXJhbWV0ZXJzPiBjcmVhdGVSc2FT
c2FQYXJhbXMoRXhlY1N0YXRlKgogICAgICAgICBzZXRET01FeGNlcHRpb24oZXhlYywgTk9UX1NV
UFBPUlRFRF9FUlIpOwogICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICB9CisgICAgQVNTRVJU
X05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKIHN0ZDo6dW5pcXVlX3B0
cjxDcnlwdG9BbGdvcml0aG1QYXJhbWV0ZXJzPiBKU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6
OmNyZWF0ZVBhcmFtZXRlcnNGb3JFeHBvcnRLZXkoRXhlY1N0YXRlKiBleGVjLCBDcnlwdG9BbGdv
cml0aG1JZGVudGlmaWVyIGFsZ29yaXRobSwgSlNWYWx1ZSkKQEAgLTY0Myw2ICs2NjEsOCBAQCBz
dGF0aWMgc3RkOjp1bmlxdWVfcHRyPENyeXB0b0FsZ29yaXRobVBhcmFtZXRlcnM+IGNyZWF0ZVJz
YVNzYVBhcmFtcyhFeGVjU3RhdGUqCiAgICAgICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBOT1Rf
U1VQUE9SVEVEX0VSUik7CiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIH0KKyAgICBBU1NF
UlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAogfQpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvY3J5cHRvL0NyeXB0b0tleS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9j
cnlwdG8vQ3J5cHRvS2V5LmNwcAppbmRleCAxZWY5NTM5YmZhZjBmOGE4YmVkM2QyNzVhNWE0ZGEx
ZDQ4MmJiNjUxLi4wNzIyYTZkOTVhY2RlOWEyOTQ2ZjgzYTc3YjU3N2Y2NjlhOTk4NWZhIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8vQ3J5cHRvS2V5LmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9jcnlwdG8vQ3J5cHRvS2V5LmNwcApAQCAtNTcsNiArNTcsOCBAQCBTdHJpbmcgQ3J5
cHRvS2V5Ojp0eXBlKCkgY29uc3QKICAgICBjYXNlIENyeXB0b0tleVR5cGU6OlByaXZhdGU6CiAg
ICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoInByaXZhdGUiKTsKICAgICB9CisgICAgQVNTRVJU
X05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIGVtcHR5U3RyaW5nKCk7CiB9CiAKIHZvaWQgQ3J5
cHRvS2V5OjpidWlsZEFsZ29yaXRobURlc2NyaXB0aW9uKENyeXB0b0FsZ29yaXRobURlc2NyaXB0
aW9uQnVpbGRlciYgYnVpbGRlcikgY29uc3QK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>236787</attachid>
            <date>2014-08-18 14:40:52 -0700</date>
            <delta_ts>2014-08-23 00:13:12 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-135889-20140819064052.patch</filename>
            <type>text/plain</type>
            <size>6385</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWNkN2VhNDkwZmEyMDIz
NDFjYWFkODAyMDcxZGVjYTI4Y2YxZDA0Ni4uNjEwMTIxNjk2ODdiYTczZjAxNTA5NzE0MmExM2Q5
MDQxZTIyZWM4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA4LTEzICBZdXN1
a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIENsZWFuIHVwIGJ1
aWxkIHdhcm5pbmdzOiBjb250cm9sIHJlYWNoZXMgZW5kIG9mIG5vbi12b2lkIGZ1bmN0aW9uCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU4ODkKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdz
L2pzL0pTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpK
U0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRlcnNGb3JFbmNyeXB0KToK
KyAgICAgICAgKFdlYkNvcmU6OkpTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFy
YW1ldGVyc0ZvckRlY3J5cHQpOgorICAgICAgICAoV2ViQ29yZTo6SlNDcnlwdG9BbGdvcml0aG1E
aWN0aW9uYXJ5OjpjcmVhdGVQYXJhbWV0ZXJzRm9yU2lnbik6CisgICAgICAgIChXZWJDb3JlOjpK
U0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRlcnNGb3JWZXJpZnkpOgor
ICAgICAgICAoV2ViQ29yZTo6SlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5OjpjcmVhdGVQYXJh
bWV0ZXJzRm9yRGlnZXN0KToKKyAgICAgICAgKFdlYkNvcmU6OkpTQ3J5cHRvQWxnb3JpdGhtRGlj
dGlvbmFyeTo6Y3JlYXRlUGFyYW1ldGVyc0ZvckdlbmVyYXRlS2V5KToKKyAgICAgICAgKFdlYkNv
cmU6OkpTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFyYW1ldGVyc0ZvckRlcml2
ZUtleSk6CisgICAgICAgIChXZWJDb3JlOjpKU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNy
ZWF0ZVBhcmFtZXRlcnNGb3JEZXJpdmVCaXRzKToKKyAgICAgICAgKFdlYkNvcmU6OkpTQ3J5cHRv
QWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFyYW1ldGVyc0ZvckltcG9ydEtleSk6CisgICAg
ICAgIChXZWJDb3JlOjpKU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRl
cnNGb3JFeHBvcnRLZXkpOgorICAgICAgICAqIGNyeXB0by9DcnlwdG9LZXkuY3BwOgorICAgICAg
ICAoV2ViQ29yZTo6Q3J5cHRvS2V5Ojp0eXBlKToKKwogMjAxNC0wOC0xOCAgUHJ6ZW15c2xhdyBL
dWN6eW5za2kgIDxwLmt1Y3p5bnNraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBGaXggdW5pbnRl
bnRpb25hbCBpbnRlZ2VyIG92ZXJmbG93IGJlZm9yZSB3aWRlbgpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYkNvcmUvYmluZGluZ3MvanMvSlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5LmNwcCBiL1Nv
dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeS5jcHAK
aW5kZXggZDk1YzE3MzFmNjdiYWQwMTM1ZmQ2YTdhZGUzYmEwYmRmYzMyYjg3My4uNzY5ZDcyZGUw
ODhhMTc0ZWNjMDNjOGY3M2QxMjY0ZGYzZDRhMTQyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvYmluZGluZ3MvanMvSlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5LmNwcAorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnkuY3BwCkBA
IC0zMzUsNiArMzM1LDggQEAgc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdvcml0aG1Q
YXJhbWV0ZXJzPiBjcmVhdGVSc2FTc2FQYXJhbXMoRXhlY1N0YXRlKgogICAgICAgICBzZXRET01F
eGNlcHRpb24oZXhlYywgTk9UX1NVUFBPUlRFRF9FUlIpOwogICAgICAgICByZXR1cm4gbnVsbHB0
cjsKICAgICB9CisgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4g
bnVsbHB0cjsKIH0KIAogc3RkOjp1bmlxdWVfcHRyPENyeXB0b0FsZ29yaXRobVBhcmFtZXRlcnM+
IEpTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFyYW1ldGVyc0ZvckRlY3J5cHQo
RXhlY1N0YXRlKiBleGVjLCBDcnlwdG9BbGdvcml0aG1JZGVudGlmaWVyIGFsZ29yaXRobSwgSlNW
YWx1ZSB2YWx1ZSkKQEAgLTM3NSw2ICszNzcsOCBAQCBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPENy
eXB0b0FsZ29yaXRobVBhcmFtZXRlcnM+IGNyZWF0ZVJzYVNzYVBhcmFtcyhFeGVjU3RhdGUqCiAg
ICAgICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBOT1RfU1VQUE9SVEVEX0VSUik7CiAgICAgICAg
IHJldHVybiBudWxscHRyOwogICAgIH0KKyAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgp
OworICAgIHJldHVybiBudWxscHRyOwogfQogCiBzdGQ6OnVuaXF1ZV9wdHI8Q3J5cHRvQWxnb3Jp
dGhtUGFyYW1ldGVycz4gSlNDcnlwdG9BbGdvcml0aG1EaWN0aW9uYXJ5OjpjcmVhdGVQYXJhbWV0
ZXJzRm9yU2lnbihFeGVjU3RhdGUqIGV4ZWMsIENyeXB0b0FsZ29yaXRobUlkZW50aWZpZXIgYWxn
b3JpdGhtLCBKU1ZhbHVlIHZhbHVlKQpAQCAtNDExLDYgKzQxNSw4IEBAIHN0YXRpYyBzdGQ6OnVu
aXF1ZV9wdHI8Q3J5cHRvQWxnb3JpdGhtUGFyYW1ldGVycz4gY3JlYXRlUnNhU3NhUGFyYW1zKEV4
ZWNTdGF0ZSoKICAgICAgICAgc2V0RE9NRXhjZXB0aW9uKGV4ZWMsIE5PVF9TVVBQT1JURURfRVJS
KTsKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfQorICAgIFJFTEVBU0VfQVNTRVJUX05P
VF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKIHN0ZDo6dW5pcXVlX3B0cjxD
cnlwdG9BbGdvcml0aG1QYXJhbWV0ZXJzPiBKU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNy
ZWF0ZVBhcmFtZXRlcnNGb3JWZXJpZnkoRXhlY1N0YXRlKiBleGVjLCBDcnlwdG9BbGdvcml0aG1J
ZGVudGlmaWVyIGFsZ29yaXRobSwgSlNWYWx1ZSB2YWx1ZSkKQEAgLTQ0Nyw2ICs0NTMsOCBAQCBz
dGF0aWMgc3RkOjp1bmlxdWVfcHRyPENyeXB0b0FsZ29yaXRobVBhcmFtZXRlcnM+IGNyZWF0ZVJz
YVNzYVBhcmFtcyhFeGVjU3RhdGUqCiAgICAgICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBOT1Rf
U1VQUE9SVEVEX0VSUik7CiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIH0KKyAgICBSRUxF
QVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiBudWxscHRyOwogfQogCiBzdGQ6
OnVuaXF1ZV9wdHI8Q3J5cHRvQWxnb3JpdGhtUGFyYW1ldGVycz4gSlNDcnlwdG9BbGdvcml0aG1E
aWN0aW9uYXJ5OjpjcmVhdGVQYXJhbWV0ZXJzRm9yRGlnZXN0KEV4ZWNTdGF0ZSogZXhlYywgQ3J5
cHRvQWxnb3JpdGhtSWRlbnRpZmllciBhbGdvcml0aG0sIEpTVmFsdWUpCkBAIC00ODAsNiArNDg4
LDggQEAgc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdvcml0aG1QYXJhbWV0ZXJzPiBj
cmVhdGVSc2FTc2FQYXJhbXMoRXhlY1N0YXRlKgogICAgICAgICBzZXRET01FeGNlcHRpb24oZXhl
YywgTk9UX1NVUFBPUlRFRF9FUlIpOwogICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICB9Cisg
ICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gbnVsbHB0cjsKIH0K
IAogc3RkOjp1bmlxdWVfcHRyPENyeXB0b0FsZ29yaXRobVBhcmFtZXRlcnM+IEpTQ3J5cHRvQWxn
b3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFyYW1ldGVyc0ZvckdlbmVyYXRlS2V5KEV4ZWNTdGF0
ZSogZXhlYywgQ3J5cHRvQWxnb3JpdGhtSWRlbnRpZmllciBhbGdvcml0aG0sIEpTVmFsdWUgdmFs
dWUpCkBAIC01MTUsNiArNTI1LDggQEAgc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdv
cml0aG1QYXJhbWV0ZXJzPiBjcmVhdGVSc2FTc2FQYXJhbXMoRXhlY1N0YXRlKgogICAgICAgICBz
ZXRET01FeGNlcHRpb24oZXhlYywgTk9UX1NVUFBPUlRFRF9FUlIpOwogICAgICAgICByZXR1cm4g
bnVsbHB0cjsKICAgICB9CisgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICBy
ZXR1cm4gbnVsbHB0cjsKIH0KIAogc3RkOjp1bmlxdWVfcHRyPENyeXB0b0FsZ29yaXRobVBhcmFt
ZXRlcnM+IEpTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeTo6Y3JlYXRlUGFyYW1ldGVyc0ZvckRl
cml2ZUtleShFeGVjU3RhdGUqIGV4ZWMsIENyeXB0b0FsZ29yaXRobUlkZW50aWZpZXIgYWxnb3Jp
dGhtLCBKU1ZhbHVlKQpAQCAtNTQ1LDYgKzU1Nyw4IEBAIHN0YXRpYyBzdGQ6OnVuaXF1ZV9wdHI8
Q3J5cHRvQWxnb3JpdGhtUGFyYW1ldGVycz4gY3JlYXRlUnNhU3NhUGFyYW1zKEV4ZWNTdGF0ZSoK
ICAgICAgICAgc2V0RE9NRXhjZXB0aW9uKGV4ZWMsIE5PVF9TVVBQT1JURURfRVJSKTsKICAgICAg
ICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfQorICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVE
KCk7CisgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKIHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdv
cml0aG1QYXJhbWV0ZXJzPiBKU0NyeXB0b0FsZ29yaXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFt
ZXRlcnNGb3JEZXJpdmVCaXRzKEV4ZWNTdGF0ZSogZXhlYywgQ3J5cHRvQWxnb3JpdGhtSWRlbnRp
ZmllciBhbGdvcml0aG0sIEpTVmFsdWUpCkBAIC01NzUsNiArNTg5LDggQEAgc3RhdGljIHN0ZDo6
dW5pcXVlX3B0cjxDcnlwdG9BbGdvcml0aG1QYXJhbWV0ZXJzPiBjcmVhdGVSc2FTc2FQYXJhbXMo
RXhlY1N0YXRlKgogICAgICAgICBzZXRET01FeGNlcHRpb24oZXhlYywgTk9UX1NVUFBPUlRFRF9F
UlIpOwogICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICB9CisgICAgUkVMRUFTRV9BU1NFUlRf
Tk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAogc3RkOjp1bmlxdWVfcHRy
PENyeXB0b0FsZ29yaXRobVBhcmFtZXRlcnM+IEpTQ3J5cHRvQWxnb3JpdGhtRGljdGlvbmFyeTo6
Y3JlYXRlUGFyYW1ldGVyc0ZvckltcG9ydEtleShFeGVjU3RhdGUqIGV4ZWMsIENyeXB0b0FsZ29y
aXRobUlkZW50aWZpZXIgYWxnb3JpdGhtLCBKU1ZhbHVlIHZhbHVlKQpAQCAtNjEyLDYgKzYyOCw4
IEBAIHN0YXRpYyBzdGQ6OnVuaXF1ZV9wdHI8Q3J5cHRvQWxnb3JpdGhtUGFyYW1ldGVycz4gY3Jl
YXRlUnNhU3NhUGFyYW1zKEV4ZWNTdGF0ZSoKICAgICAgICAgc2V0RE9NRXhjZXB0aW9uKGV4ZWMs
IE5PVF9TVVBQT1JURURfRVJSKTsKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfQorICAg
IFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAK
IHN0ZDo6dW5pcXVlX3B0cjxDcnlwdG9BbGdvcml0aG1QYXJhbWV0ZXJzPiBKU0NyeXB0b0FsZ29y
aXRobURpY3Rpb25hcnk6OmNyZWF0ZVBhcmFtZXRlcnNGb3JFeHBvcnRLZXkoRXhlY1N0YXRlKiBl
eGVjLCBDcnlwdG9BbGdvcml0aG1JZGVudGlmaWVyIGFsZ29yaXRobSwgSlNWYWx1ZSkKQEAgLTY0
Myw2ICs2NjEsOCBAQCBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPENyeXB0b0FsZ29yaXRobVBhcmFt
ZXRlcnM+IGNyZWF0ZVJzYVNzYVBhcmFtcyhFeGVjU3RhdGUqCiAgICAgICAgIHNldERPTUV4Y2Vw
dGlvbihleGVjLCBOT1RfU1VQUE9SVEVEX0VSUik7CiAgICAgICAgIHJldHVybiBudWxscHRyOwog
ICAgIH0KKyAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiBudWxs
cHRyOwogfQogCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8vQ3J5cHRvS2V5
LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2NyeXB0by9DcnlwdG9LZXkuY3BwCmluZGV4IDFlZjk1Mzli
ZmFmMGY4YThiZWQzZDI3NWE1YTRkYTFkNDgyYmI2NTEuLmJhMmYwMmE5YWQ1YmRlZTlmNzZkOWQ2
NzQxMDIxOWI0NzgyNTlhNjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2NyeXB0by9Dcnlw
dG9LZXkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2NyeXB0by9DcnlwdG9LZXkuY3BwCkBAIC01
Nyw2ICs1Nyw4IEBAIFN0cmluZyBDcnlwdG9LZXk6OnR5cGUoKSBjb25zdAogICAgIGNhc2UgQ3J5
cHRvS2V5VHlwZTo6UHJpdmF0ZToKICAgICAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgicHJpdmF0
ZSIpOwogICAgIH0KKyAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVy
biBlbXB0eVN0cmluZygpOwogfQogCiB2b2lkIENyeXB0b0tleTo6YnVpbGRBbGdvcml0aG1EZXNj
cmlwdGlvbihDcnlwdG9BbGdvcml0aG1EZXNjcmlwdGlvbkJ1aWxkZXImIGJ1aWxkZXIpIGNvbnN0
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>