135888 2014-08-13 10:41:42 -0700 enable llint on Windows CMake build 2014-08-19 10:37:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen bfulgham bunhere commit-queue gyuyoung.kim laszlo.gombos mrobinson rakuco sergio oldest_to_newest 1028822 0 achristensen 2014-08-13 10:41:42 -0700 Windows puts assembly in a separate file instead of LLIntAssembly.h because of string length limits (2^16-1) in Visual Studio. The CMake build needs to be tweaked to do this, too. 1028823 1 236534 achristensen 2014-08-13 10:47:11 -0700 Created attachment 236534 Patch 1029894 2 236534 bfulgham 2014-08-18 14:45:40 -0700 Comment on attachment 236534 Patch Looks good to me, too. 1030057 3 236534 commit-queue 2014-08-19 10:37:13 -0700 Comment on attachment 236534 Patch Clearing flags on attachment: 236534 Committed r172754: <http://trac.webkit.org/changeset/172754> 1030058 4 commit-queue 2014-08-19 10:37:17 -0700 All reviewed patches have been landed. Closing bug. 236534 2014-08-13 10:47:11 -0700 2014-08-19 10:37:13 -0700 Patch bug-135888-20140813104702.patch text/plain 4827 achristensen SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyNTIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE0LTA4LTEzICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgW0NNYWtlXSBHZW5lcmF0ZSBMTEludCBhc3NlbWJseSBjb3JyZWN0bHkgb24g V2luZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzNTg4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQ01ha2VMaXN0cy50eHQ6CisgICAgICAgIEdlbmVyYXRlIExvd0xldmVsSW50ZXJwcmV0ZXJX aW4uYXNtIGluc3RlYWQgb2YgTExJbnRBc3NlbWJseS5oIG9uIFdpbmRvd3MgbGlrZSB0aGUgZXhp c3RpbmcgYnVpbGQgc3lzdGVtLgorICAgICAgICAqIFBsYXRmb3JtV2luLmNtYWtlOgorICAgICAg ICBEb24ndCBidWlsZCBKU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIuY3BwIG9uIFdp bmRvd3MuCisgICAgICAgICogb2ZmbGluZWFzbS94ODYucmI6CisgICAgICAgIERldGVjdCBub24t Y3lnd2luIHJ1YnkgaW5zdGFsbGF0aW9ucyBjb3JyZWN0bHkuCisKIDIwMTQtMDgtMTIgIFBleXRv biBSYW5kb2xwaCAgPHByYW5kb2xwaEBhcHBsZS5jb20+CiAKICAgICAgICAgUnVudGltZSBzd2l0 Y2ggZm9yIGxvbmcgbW91c2UgcHJlc3MgZ2VzdHVyZS4gUGFydCBvZiAxMzUyNTcgLSBBZGQgbG9u ZyBtb3VzZSBwcmVzcyBnZXN0dXJlLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtl TGlzdHMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3Rz LnR4dAkocmV2aXNpb24gMTcyNTIxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlz dHMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC02NjksMjEgKzY2OSw0MCBAQCB0YXJnZXRfbGlua19s aWJyYXJpZXMoTExJbnRPZmZzZXRzRXh0cmFjCiAjIExMSW50T2Zmc2V0c0V4dHJhY3RvciBtYXRj aGVzLCBubyBvdXRwdXQgaXMgZ2VuZXJhdGVkLiBUbyBtYWtlIHRoaXMgdGFyZ2V0IGNvbnNpc3Rl bnQgYW5kIGF2b2lkCiAjIHJ1bm5pbmcgdGhpcyBjb21tYW5kIGZvciBldmVyeSBidWlsZCwgd2Ug YXJ0aWZpY2lhbGx5IHVwZGF0ZSBMTEludEFzc2VtYmx5LmgncyBtdGltZSAodXNpbmcgdG91Y2gp CiAjIGFmdGVyIGV2ZXJ5IGFzbS5yYiBydW4uCitpZiAoTVNWQykKKyAgICBzZXQoTExJbnRPdXRw dXQgTG93TGV2ZWxJbnRlcnByZXRlcldpbi5hc20pCitlbHNlICgpCisgICAgc2V0KExMSW50T3V0 cHV0IExMSW50QXNzZW1ibHkuaCkKK2VuZGlmICgpCisKIGFkZF9jdXN0b21fY29tbWFuZCgKLSAg ICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS9MTEludEFzc2Vt Ymx5LmgKKyAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS8k e0xMSW50T3V0cHV0fQogICAgIE1BSU5fREVQRU5ERU5DWSAke0pBVkFTQ1JJUFRDT1JFX0RJUn0v b2ZmbGluZWFzbS9hc20ucmIKICAgICBERVBFTkRTIExMSW50T2Zmc2V0c0V4dHJhY3RvciAke0xM SU5UX0FTTX0gJHtPRkZMSU5FX0FTTX0gJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVf RElSfS9Jbml0Qnl0ZWNvZGVzLmFzbQotICAgIENPTU1BTkQgJHtSVUJZX0VYRUNVVEFCTEV9ICR7 SkFWQVNDUklQVENPUkVfRElSfS9vZmZsaW5lYXNtL2FzbS5yYiAtSSR7REVSSVZFRF9TT1VSQ0VT X0pBVkFTQ1JJUFRDT1JFX0RJUn0vICR7SkFWQVNDUklQVENPUkVfRElSfS9sbGludC9Mb3dMZXZl bEludGVycHJldGVyLmFzbSAkPFRBUkdFVF9GSUxFOkxMSW50T2Zmc2V0c0V4dHJhY3Rvcj4gJHtE RVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS9MTEludEFzc2VtYmx5LmgKLSAgICBD T01NQU5EICR7Q01BS0VfQ09NTUFORH0gLUUgdG91Y2hfbm9jcmVhdGUgJHtERVJJVkVEX1NPVVJD RVNfSkFWQVNDUklQVENPUkVfRElSfS9MTEludEFzc2VtYmx5LmgKKyAgICBDT01NQU5EICR7UlVC WV9FWEVDVVRBQkxFfSAke0pBVkFTQ1JJUFRDT1JFX0RJUn0vb2ZmbGluZWFzbS9hc20ucmIgLUkk e0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9LyAke0pBVkFTQ1JJUFRDT1JFX0RJ Un0vbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20gJDxUQVJHRVRfRklMRTpMTEludE9mZnNl dHNFeHRyYWN0b3I+ICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vJHtMTElu dE91dHB1dH0KKyAgICBDT01NQU5EICR7Q01BS0VfQ09NTUFORH0gLUUgdG91Y2hfbm9jcmVhdGUg JHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS8ke0xMSW50T3V0cHV0fQogICAg IFZFUkJBVElNKQogCiAjIFRoZSBleHBsYW5hdGlvbiBmb3Igbm90IG1ha2luZyBMTEludEFzc2Vt Ymx5LmggcGFydCBvZiB0aGUgT0JKRUNUX0RFUEVORFMgcHJvcGVydHkgb2Ygc29tZSBvZgogIyB0 aGUgLmNwcCBmaWxlcyBiZWxvdyBpcyBzaW1pbGFyIHRvIHRoZSBvbmUgaW4gdGhlIHByZXZpb3Vz IGNvbW1lbnQuIEhvd2V2ZXIsIHNpbmNlIHRoZXNlIC5jcHAKICMgZmlsZXMgYXJlIHVzZWQgdG8g YnVpbGQgSmF2YVNjcmlwdENvcmUgaXRzZWxmLCB3ZSBjYW4ganVzdCBhZGQgTExJbnRBc3NlbWJs eS5oIHRvIEpTQ19IRUFERVJTCiAjIHNpbmNlIGl0IGlzIHVzZWQgaW4gdGhlIGFkZF9saWJyYXJ5 KCkgY2FsbCBhdCB0aGUgZW5kIG9mIHRoaXMgZmlsZS4KLWxpc3QoQVBQRU5EIEphdmFTY3JpcHRD b3JlX0hFQURFUlMKLSAgICAke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9L0xM SW50QXNzZW1ibHkuaAotKQoraWYgKE1TVkMpCisgICAgbGlzdChBUFBFTkQgSmF2YVNjcmlwdENv cmVfU09VUkNFUworICAgICAgICAke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9 L0xvd0xldmVsSW50ZXJwcmV0ZXJXaW4uYXNtCisgICAgKQorICAgICMgV2luMzIgbmVlZHMgL3Nh ZmVzZWggd2l0aCBhc3NlbWJseSwgYnV0IFdpbjY0IGRvZXMgbm90LgorICAgIGlmIChDTUFLRV9T SVpFT0ZfVk9JRF9QIEVRVUFMIDQpCisgICAgICAgIHNldF9zb3VyY2VfZmlsZXNfcHJvcGVydGll cygke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9L0xvd0xldmVsSW50ZXJwcmV0 ZXJXaW4uYXNtCisgICAgICAgICAgICBQUk9QRVJUSUVTIENPTVBJTEVfRkxBR1MgICIvc2FmZXNl aCIKKyAgICAgICAgKQorICAgIGVuZGlmICgpCitlbHNlICgpCisgICAgbGlzdChBUFBFTkQgSmF2 YVNjcmlwdENvcmVfSEVBREVSUworICAgICAgICAke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBU Q09SRV9ESVJ9L0xMSW50QXNzZW1ibHkuaAorICAgICkKK2VuZGlmICgpCisKIGxpc3QoQVBQRU5E IEphdmFTY3JpcHRDb3JlX1NPVVJDRVMKICAgICBsbGludC9MTEludENMb29wLmNwcAogICAgIGxs aW50L0xMSW50RGF0YS5jcHAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9QbGF0Zm9ybVdp bi5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1XaW4u Y21ha2UJKHJldmlzaW9uIDE3MjUyMSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9QbGF0Zm9y bVdpbi5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtMjIsNCArMjIsOCBAQCBpZiAoTVNWQyBBTkQg IiR7SmF2YVNjcmlwdENvcmVfTElCUkFSWV9UCiAgICAgICAgIENPTU1BTkQgJHtQWVRIT05fRVhF Q1VUQUJMRX0gJHtUT09MU19ESVJ9L1NjcmlwdHMvZ2VuZXJhdGUtd2luMzItZXhwb3J0LWZvcndh cmRzICR7V1RGX0xJQlJBUllfTE9DQVRJT059ICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRD T1JFX0RJUn0vZm9yd2FyZGVkLWV4cG9ydHMuY3BwCiAgICAgICAgIFZFUkJBVElNKQogICAgIGxp c3QoQVBQRU5EIEphdmFTY3JpcHRDb3JlX1NPVVJDRVMgJHtERVJJVkVEX1NPVVJDRVNfSkFWQVND UklQVENPUkVfRElSfS9mb3J3YXJkZWQtZXhwb3J0cy5jcHApCi1lbmRpZiAoKQpcIE5vIG5ld2xp bmUgYXQgZW5kIG9mIGZpbGUKK2VuZGlmICgpCisKK2xpc3QoUkVNT1ZFX0lURU0gSmF2YVNjcmlw dENvcmVfU09VUkNFUworICAgIGluc3BlY3Rvci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRy b2xsZXIuY3BwCispCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS94ODYu cmIKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20veDg2LnJi CShyZXZpc2lvbiAxNzI1MjEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS94 ODYucmIJKHdvcmtpbmcgY29weSkKQEAgLTU1LDcgKzU1LDcgQEAgZGVmIHVzZVg4NwogZW5kCiAK IGRlZiBpc1dpbmRvd3MKLSAgICBSVUJZX1BMQVRGT1JNID1+IC9jeWd3aW4vaQorICAgIEVOVlsn T1MnXSA9PSAnV2luZG93c19OVCcKIGVuZAogCiBkZWYgaXNHQ0MK