135875 2014-08-12 22:54:04 -0700 [EFL] Sets the persistent storage for cookies in MiniBrowser 2014-08-13 05:11:08 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song commit-queue g.czajkowski lucas.de.marchi oldest_to_newest 1028726 0 jinwoo7.song 2014-08-12 22:54:04 -0700 SSIA. 1028728 1 236499 jinwoo7.song 2014-08-12 22:57:44 -0700 Created attachment 236499 Patch 1028741 2 236499 gyuyoung.kim 2014-08-13 00:07:01 -0700 Comment on attachment 236499 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236499&action=review > Tools/MiniBrowser/efl/main.c:2106 > ewk_cookie_manager_accept_policy_set(ewk_context_cookie_manager_get(context), parse_cookies_policy(cookies_policy_string)); parse_cookies_policy() is called twice. So, how about changing as below ? if (cookies_policy_string) { Ewk_Cookie_Accept_Policy cookie_policy = parse_cookies_policy(cookies_policy_string); ewk_cookie_manager_accept_policy_set(ewk_context_cookie_manager_get(context), cookie_policy); if (cookie_policy == EWK_COOKIE_ACCEPT_POLICY_ALWAYS) { char storageDirectory[] = "/tmp/ewebkit2_minibrowser_cookie"; mkdir(storageDirectory, S_IRWXU); char textStorage[64]; snprintf(textStorage, sizeof(textStorage), "%s/txt-cookie", storageDirectory); ewk_cookie_manager_persistent_storage_set(ewk_context_cookie_manager_get(context), textStorage, EWK_COOKIE_PERSISTENT_STORAGE_TEXT); } } 1028743 3 236499 g.czajkowski 2014-08-13 00:25:25 -0700 Comment on attachment 236499 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236499&action=review > Tools/MiniBrowser/efl/main.c:2108 > + if (parse_cookies_policy(cookies_policy_string) == EWK_COOKIE_ACCEPT_POLICY_ALWAYS) { parse_cookies_policy() assumes non-null string. I also suggest merging this block with above one. > Tools/MiniBrowser/efl/main.c:2109 > + char storageDirectory[] = "/tmp/ewebkit2_minibrowser_cookie"; 1) nit: const, 2) cookieStorageDirectory ? 3) Would be nice to end the string with '/' as this is directory. > Tools/MiniBrowser/efl/main.c:2111 > + char textStorage[64]; storageName ? 1028744 4 236503 jinwoo7.song 2014-08-13 00:34:45 -0700 Created attachment 236503 Patch Applied Gyuyoung's comment. 1028765 5 236512 jinwoo7.song 2014-08-13 03:56:03 -0700 Created attachment 236512 Patch Applied Grzeg's comments. 1028767 6 g.czajkowski 2014-08-13 04:07:29 -0700 Thanks for the changes. LGTM as well 1028775 7 236512 commit-queue 2014-08-13 05:11:02 -0700 Comment on attachment 236512 Patch Clearing flags on attachment: 236512 Committed r172519: <http://trac.webkit.org/changeset/172519> 1028776 8 commit-queue 2014-08-13 05:11:08 -0700 All reviewed patches have been landed. Closing bug. 236499 2014-08-12 22:57:44 -0700 2014-08-13 00:34:38 -0700 Patch bug-135875-20140813145724.patch text/plain 1843 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNTAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2I4YmVlOGYyMmI0ZGUxNmVhNTBjY2ZmZGRiOWJjOTA3 MzkzN2UwNS4uM2E1MDA4Njg5YmFkNjBkYmE4NTY5NDllMzY4ZWQ3ZTk2NWQxYzMyYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTA4LTEyICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXSBTZXRzIHRoZSBwZXJzaXN0ZW50IHN0b3JhZ2UgZm9yIGNvb2tpZXMg aW4gTWluaUJyb3dzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzNTg3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEluIGNhc2Ugb2YgRVdLX0NPT0tJRV9BQ0NFUFRfUE9MSUNZX0FMV0FZUywgc2V0cyB0 aGUgcGVyc2lzdGVudCBzdG9yYWdlCisgICAgICAgIGZvciBub24tc2Vzc2lvbiBjb29raWVzIGNh biBiZSBzdG9yZWQgcGVyc2lzdGVudGx5LgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21h aW4uYzoKKyAgICAgICAgKGVsbV9tYWluKToKKwogMjAxNC0wOC0xMiAgWXVzdWtlIFN1enVraSAg PHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGRzIGRlcGVuZGVuY3kg Zm9yIEdudVRMUyAzLjArIGV4cGxpY2l0bHkgaW4gZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCmRp ZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dz ZXIvZWZsL21haW4uYwppbmRleCBiZGNhMjU3ODg0NmE5NGQ0MWQzMTBlM2EzNjVmMzk0MDRjNDk3 MTMzLi4wMTNmNzcwNTM1ZmYzY2RjMGI3OTU0MzMxNzY0MjM0MmJkZTMyMTc4IDEwMDY0NAotLS0g YS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2Vm bC9tYWluLmMKQEAgLTIxMDUsNiArMjEwNSwxNCBAQCBlbG1fbWFpbihpbnQgYXJnYywgY2hhciAq YXJndltdKQogICAgIGlmIChjb29raWVzX3BvbGljeV9zdHJpbmcpCiAgICAgICAgIGV3a19jb29r aWVfbWFuYWdlcl9hY2NlcHRfcG9saWN5X3NldChld2tfY29udGV4dF9jb29raWVfbWFuYWdlcl9n ZXQoY29udGV4dCksIHBhcnNlX2Nvb2tpZXNfcG9saWN5KGNvb2tpZXNfcG9saWN5X3N0cmluZykp OwogCisgICAgaWYgKHBhcnNlX2Nvb2tpZXNfcG9saWN5KGNvb2tpZXNfcG9saWN5X3N0cmluZykg PT0gRVdLX0NPT0tJRV9BQ0NFUFRfUE9MSUNZX0FMV0FZUykgeworICAgICAgICBjaGFyIHN0b3Jh Z2VEaXJlY3RvcnlbXSA9ICIvdG1wL2V3ZWJraXQyX21pbmlicm93c2VyX2Nvb2tpZSI7CisgICAg ICAgIG1rZGlyKHN0b3JhZ2VEaXJlY3RvcnksIFNfSVJXWFUpOworICAgICAgICBjaGFyIHRleHRT dG9yYWdlWzY0XTsKKyAgICAgICAgc25wcmludGYodGV4dFN0b3JhZ2UsIHNpemVvZih0ZXh0U3Rv cmFnZSksICIlcy90eHQtY29va2llIiwgc3RvcmFnZURpcmVjdG9yeSk7CisgICAgICAgIGV3a19j b29raWVfbWFuYWdlcl9wZXJzaXN0ZW50X3N0b3JhZ2Vfc2V0KGV3a19jb250ZXh0X2Nvb2tpZV9t YW5hZ2VyX2dldChjb250ZXh0KSwgdGV4dFN0b3JhZ2UsIEVXS19DT09LSUVfUEVSU0lTVEVOVF9T VE9SQUdFX1RFWFQpOworICAgIH0KKwogICAgIGlmICh3aW5kb3dfc2l6ZV9zdHJpbmcpCiAgICAg ICAgIHBhcnNlX3dpbmRvd19zaXplKHdpbmRvd19zaXplX3N0cmluZywgJndpbmRvd193aWR0aCwg JndpbmRvd19oZWlnaHQpOwogCg== 236503 2014-08-13 00:34:45 -0700 2014-08-13 03:55:57 -0700 Patch bug-135875-20140813163425.patch text/plain 2177 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNTAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2I4YmVlOGYyMmI0ZGUxNmVhNTBjY2ZmZGRiOWJjOTA3 MzkzN2UwNS4uM2E1MDA4Njg5YmFkNjBkYmE4NTY5NDllMzY4ZWQ3ZTk2NWQxYzMyYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTA4LTEyICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXSBTZXRzIHRoZSBwZXJzaXN0ZW50IHN0b3JhZ2UgZm9yIGNvb2tpZXMg aW4gTWluaUJyb3dzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzNTg3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEluIGNhc2Ugb2YgRVdLX0NPT0tJRV9BQ0NFUFRfUE9MSUNZX0FMV0FZUywgc2V0cyB0 aGUgcGVyc2lzdGVudCBzdG9yYWdlCisgICAgICAgIGZvciBub24tc2Vzc2lvbiBjb29raWVzIGNh biBiZSBzdG9yZWQgcGVyc2lzdGVudGx5LgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21h aW4uYzoKKyAgICAgICAgKGVsbV9tYWluKToKKwogMjAxNC0wOC0xMiAgWXVzdWtlIFN1enVraSAg PHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGRzIGRlcGVuZGVuY3kg Zm9yIEdudVRMUyAzLjArIGV4cGxpY2l0bHkgaW4gZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCmRp ZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dz ZXIvZWZsL21haW4uYwppbmRleCBiZGNhMjU3ODg0NmE5NGQ0MWQzMTBlM2EzNjVmMzk0MDRjNDk3 MTMzLi45NTMwYzgyNjFlZDBhZjI4YjRhYmY3MGFjYjZkNmY4MjdmNGQ3NzE5IDEwMDY0NAotLS0g YS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2Vm bC9tYWluLmMKQEAgLTIxMDIsOCArMjEwMiwxOCBAQCBlbG1fbWFpbihpbnQgYXJnYywgY2hhciAq YXJndltdKQogICAgIC8vIEVuYWJsZSBmYXZpY29uIGRhdGFiYXNlLgogICAgIGV3a19jb250ZXh0 X2Zhdmljb25fZGF0YWJhc2VfZGlyZWN0b3J5X3NldChjb250ZXh0LCBOVUxMKTsKIAotICAgIGlm IChjb29raWVzX3BvbGljeV9zdHJpbmcpCi0gICAgICAgIGV3a19jb29raWVfbWFuYWdlcl9hY2Nl cHRfcG9saWN5X3NldChld2tfY29udGV4dF9jb29raWVfbWFuYWdlcl9nZXQoY29udGV4dCksIHBh cnNlX2Nvb2tpZXNfcG9saWN5KGNvb2tpZXNfcG9saWN5X3N0cmluZykpOworICAgIGlmIChjb29r aWVzX3BvbGljeV9zdHJpbmcpIHsKKyAgICAgICAgRXdrX0Nvb2tpZV9BY2NlcHRfUG9saWN5IGNv b2tpZV9wb2xpY3kgPSBwYXJzZV9jb29raWVzX3BvbGljeShjb29raWVzX3BvbGljeV9zdHJpbmcp OworICAgICAgICBld2tfY29va2llX21hbmFnZXJfYWNjZXB0X3BvbGljeV9zZXQoZXdrX2NvbnRl eHRfY29va2llX21hbmFnZXJfZ2V0KGNvbnRleHQpLCBjb29raWVfcG9saWN5KTsKKworICAgICAg ICBpZiAoY29va2llX3BvbGljeSA9PSBFV0tfQ09PS0lFX0FDQ0VQVF9QT0xJQ1lfQUxXQVlTKSB7 CisgICAgICAgICAgICBjaGFyIHN0b3JhZ2VEaXJlY3RvcnlbXSA9ICIvdG1wL2V3ZWJraXQyX21p bmlicm93c2VyX2Nvb2tpZSI7CisgICAgICAgICAgICBta2RpcihzdG9yYWdlRGlyZWN0b3J5LCBT X0lSV1hVKTsKKyAgICAgICAgICAgIGNoYXIgdGV4dFN0b3JhZ2VbNjRdOworICAgICAgICAgICAg c25wcmludGYodGV4dFN0b3JhZ2UsIHNpemVvZih0ZXh0U3RvcmFnZSksICIlcy90eHQtY29va2ll Iiwgc3RvcmFnZURpcmVjdG9yeSk7CisgICAgICAgICAgICBld2tfY29va2llX21hbmFnZXJfcGVy c2lzdGVudF9zdG9yYWdlX3NldChld2tfY29udGV4dF9jb29raWVfbWFuYWdlcl9nZXQoY29udGV4 dCksIHRleHRTdG9yYWdlLCBFV0tfQ09PS0lFX1BFUlNJU1RFTlRfU1RPUkFHRV9URVhUKTsKKyAg ICAgICAgfQorICAgIH0KIAogICAgIGlmICh3aW5kb3dfc2l6ZV9zdHJpbmcpCiAgICAgICAgIHBh cnNlX3dpbmRvd19zaXplKHdpbmRvd19zaXplX3N0cmluZywgJndpbmRvd193aWR0aCwgJndpbmRv d19oZWlnaHQpOwo= 236512 2014-08-13 03:56:03 -0700 2014-08-13 05:11:02 -0700 Patch bug-135875-20140813195543.patch text/plain 2211 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNTAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2I4YmVlOGYyMmI0ZGUxNmVhNTBjY2ZmZGRiOWJjOTA3 MzkzN2UwNS4uM2E1MDA4Njg5YmFkNjBkYmE4NTY5NDllMzY4ZWQ3ZTk2NWQxYzMyYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTA4LTEyICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXSBTZXRzIHRoZSBwZXJzaXN0ZW50IHN0b3JhZ2UgZm9yIGNvb2tpZXMg aW4gTWluaUJyb3dzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzNTg3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEluIGNhc2Ugb2YgRVdLX0NPT0tJRV9BQ0NFUFRfUE9MSUNZX0FMV0FZUywgc2V0cyB0 aGUgcGVyc2lzdGVudCBzdG9yYWdlCisgICAgICAgIGZvciBub24tc2Vzc2lvbiBjb29raWVzIGNh biBiZSBzdG9yZWQgcGVyc2lzdGVudGx5LgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21h aW4uYzoKKyAgICAgICAgKGVsbV9tYWluKToKKwogMjAxNC0wOC0xMiAgWXVzdWtlIFN1enVraSAg PHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGRzIGRlcGVuZGVuY3kg Zm9yIEdudVRMUyAzLjArIGV4cGxpY2l0bHkgaW4gZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCmRp ZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dz ZXIvZWZsL21haW4uYwppbmRleCBiZGNhMjU3ODg0NmE5NGQ0MWQzMTBlM2EzNjVmMzk0MDRjNDk3 MTMzLi41NmZjZjQ3MDdiYzJlMDVhNzc5YjI1NzQwMGE4N2U1MjEwM2VjZWFjIDEwMDY0NAotLS0g YS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2Vm bC9tYWluLmMKQEAgLTIxMDIsOCArMjEwMiwxOCBAQCBlbG1fbWFpbihpbnQgYXJnYywgY2hhciAq YXJndltdKQogICAgIC8vIEVuYWJsZSBmYXZpY29uIGRhdGFiYXNlLgogICAgIGV3a19jb250ZXh0 X2Zhdmljb25fZGF0YWJhc2VfZGlyZWN0b3J5X3NldChjb250ZXh0LCBOVUxMKTsKIAotICAgIGlm IChjb29raWVzX3BvbGljeV9zdHJpbmcpCi0gICAgICAgIGV3a19jb29raWVfbWFuYWdlcl9hY2Nl cHRfcG9saWN5X3NldChld2tfY29udGV4dF9jb29raWVfbWFuYWdlcl9nZXQoY29udGV4dCksIHBh cnNlX2Nvb2tpZXNfcG9saWN5KGNvb2tpZXNfcG9saWN5X3N0cmluZykpOworICAgIGlmIChjb29r aWVzX3BvbGljeV9zdHJpbmcpIHsKKyAgICAgICAgRXdrX0Nvb2tpZV9BY2NlcHRfUG9saWN5IGNv b2tpZV9wb2xpY3kgPSBwYXJzZV9jb29raWVzX3BvbGljeShjb29raWVzX3BvbGljeV9zdHJpbmcp OworICAgICAgICBld2tfY29va2llX21hbmFnZXJfYWNjZXB0X3BvbGljeV9zZXQoZXdrX2NvbnRl eHRfY29va2llX21hbmFnZXJfZ2V0KGNvbnRleHQpLCBjb29raWVfcG9saWN5KTsKKworICAgICAg ICBpZiAoY29va2llX3BvbGljeSA9PSBFV0tfQ09PS0lFX0FDQ0VQVF9QT0xJQ1lfQUxXQVlTKSB7 CisgICAgICAgICAgICBjb25zdCBjaGFyIGNvb2tpZV9zdG9yYWdlX2RpcmVjdG9yeVtdID0gIi90 bXAvZXdlYmtpdDJfbWluaWJyb3dzZXJfY29va2llLyI7CisgICAgICAgICAgICBta2Rpcihjb29r aWVfc3RvcmFnZV9kaXJlY3RvcnksIFNfSVJXWFUpOworICAgICAgICAgICAgY2hhciBzdG9yYWdl X25hbWVbNjRdOworICAgICAgICAgICAgc25wcmludGYoc3RvcmFnZV9uYW1lLCBzaXplb2Yoc3Rv cmFnZV9uYW1lKSwgIiVzdHh0LWNvb2tpZSIsIGNvb2tpZV9zdG9yYWdlX2RpcmVjdG9yeSk7Cisg ICAgICAgICAgICBld2tfY29va2llX21hbmFnZXJfcGVyc2lzdGVudF9zdG9yYWdlX3NldChld2tf Y29udGV4dF9jb29raWVfbWFuYWdlcl9nZXQoY29udGV4dCksIHN0b3JhZ2VfbmFtZSwgRVdLX0NP T0tJRV9QRVJTSVNURU5UX1NUT1JBR0VfVEVYVCk7CisgICAgICAgIH0KKyAgICB9CiAKICAgICBp ZiAod2luZG93X3NpemVfc3RyaW5nKQogICAgICAgICBwYXJzZV93aW5kb3dfc2l6ZSh3aW5kb3df c2l6ZV9zdHJpbmcsICZ3aW5kb3dfd2lkdGgsICZ3aW5kb3dfaGVpZ2h0KTsK