135872 2014-08-12 19:53:51 -0700 Avoid making new active service overlay highlights while the mouse is down 2014-08-13 12:04:26 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton beidson enrica oldest_to_newest 1028703 0 thorton 2014-08-12 19:53:51 -0700 While the mouse is down, we shouldn't show new active highlights. <rdar://problem/17982341> 1028704 1 236494 thorton 2014-08-12 20:00:13 -0700 Created attachment 236494 patch 1028705 2 236495 thorton 2014-08-12 20:00:13 -0700 Created attachment 236495 1028851 3 thorton 2014-08-13 12:04:26 -0700 http://trac.webkit.org/changeset/172528 236494 2014-08-12 20:00:13 -0700 2014-08-13 11:49:16 -0700 patch mousedown.diff text/plain 4727 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1Y2E3OTYxLi45YjViNDZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDgtMTIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgQXZvaWQgbWFraW5nIG5ldyBhY3RpdmUgc2VydmljZSBvdmVybGF5IGhpZ2hsaWdo dHMgd2hpbGUgdGhlIG1vdXNlIGlzIGRvd24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzNTg3MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTc5ODIz NDE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBX ZWJQcm9jZXNzL1dlYlBhZ2UvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5oOgorICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbToKKyAg ICAgICAgKFdlYktpdDo6U2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6cmVtYWluaW5nVGltZVVu dGlsSGlnaGxpZ2h0U2hvdWxkQmVTaG93bik6CisgICAgICAgIChXZWJLaXQ6OlNlcnZpY2VzT3Zl cmxheUNvbnRyb2xsZXI6Om1vdXNlRXZlbnQpOgorICAgICAgICBJZiB0aGUgbW91c2UgaXMgcHJl c3NlZCBvciBpdCdzIGJlZW4gbGVzcyB0aGFuIDIwMG1zIHNpbmNlIHRoZSBtb3VzZSB3ZW50IHVw LAorICAgICAgICBkb24ndCBhbGxvdyB0aGUgaGlnaGxpZ2h0IHRvIGNoYW5nZS4gV2UgYXBwbHkg dGhlIG1vdXNlLWlzLXByZXNzZWQgcnVsZSB0byB0ZWxlcGhvbmUKKyAgICAgICAgbnVtYmVyIGhp Z2hsaWdodHMgYXMgd2VsbCwgdW5saWtlIHRoZSByZXN0IG9mIHRoZSBoeXN0ZXJlc2lzIGxvZ2lj LgorCiAyMDE0LTA4LTEyICBQZXl0b24gUmFuZG9scGggIDxwcmFuZG9scGhAYXBwbGUuY29tPgog CiAgICAgICAgIFJ1bnRpbWUgc3dpdGNoIGZvciBsb25nIG1vdXNlIHByZXNzIGdlc3R1cmUuIFBh cnQgb2YgMTM1MjU3IC0gQWRkIGxvbmcgbW91c2UgcHJlc3MgZ2VzdHVyZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xs ZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9TZXJ2aWNlc092ZXJsYXlD b250cm9sbGVyLmgKaW5kZXggODY0M2EzZC4uNDNiODZhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIuaAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvU2VydmljZXNPdmVybGF5Q29udHJv bGxlci5oCkBAIC0xNTEsNiArMTUxLDcgQEAgcHJpdmF0ZToKIAogICAgIHN0ZDo6Y2hyb25vOjpz dGVhZHlfY2xvY2s6OnRpbWVfcG9pbnQgbV9sYXN0U2VsZWN0aW9uQ2hhbmdlVGltZTsKICAgICBz dGQ6OmNocm9ubzo6c3RlYWR5X2Nsb2NrOjp0aW1lX3BvaW50IG1fbmV4dEFjdGl2ZUhpZ2hsaWdo dENoYW5nZVRpbWU7CisgICAgc3RkOjpjaHJvbm86OnN0ZWFkeV9jbG9jazo6dGltZV9wb2ludCBt X2xhc3RNb3VzZVVwVGltZTsKIAogICAgIFJlZlB0cjxIaWdobGlnaHQ+IG1fY3VycmVudE1vdXNl RG93bk9uQnV0dG9uSGlnaGxpZ2h0OwogICAgIFdlYkNvcmU6OkludFBvaW50IG1fbW91c2VQb3Np dGlvbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMv U2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbQppbmRleCBiMTAyODg3Li5l OWFkOWU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFj L1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL21hYy9TZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyLm1tCkBAIC0zMyw2ICsz Myw3IEBACiAjaW1wb3J0ICJXZWJQcm9jZXNzLmgiCiAjaW1wb3J0IDxRdWFydHpDb3JlL1F1YXJ0 ekNvcmUuaD4KICNpbXBvcnQgPFdlYkNvcmUvRG9jdW1lbnQuaD4KKyNpbXBvcnQgPFdlYkNvcmUv RXZlbnRIYW5kbGVyLmg+CiAjaW1wb3J0IDxXZWJDb3JlL0Zsb2F0UXVhZC5oPgogI2ltcG9ydCA8 V2ViQ29yZS9Gb2N1c0NvbnRyb2xsZXIuaD4KICNpbXBvcnQgPFdlYkNvcmUvRnJhbWVWaWV3Lmg+ CkBAIC00MDAsMTggKzQwMSwyNSBAQCBzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRzIFNlcnZpY2Vz T3ZlcmxheUNvbnRyb2xsZXI6OnJlbWFpbmluZ1RpbWVVbnRpbEhpZ2hsaWdodAogICAgIGlmICgh aGlnaGxpZ2h0KQogICAgICAgICByZXR1cm4gc3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kczo6emVy bygpOwogCisgICAgYXV0byBtaW5pbXVtVGltZVVudGlsSGlnaGxpZ2h0U2hvdWxkQmVTaG93biA9 IDIwMF9tczsKKworICAgIGJvb2wgbW91c2VQcmVzc2VkID0gZmFsc2U7CisgICAgaWYgKEZyYW1l KiBtYWluRnJhbWUgPSBtX3dlYlBhZ2UubWFpbkZyYW1lKCkpCisgICAgICAgIG1vdXNlUHJlc3Nl ZCA9IG1haW5GcmFtZS0+ZXZlbnRIYW5kbGVyKCkubW91c2VQcmVzc2VkKCk7CisKICAgICAvLyBI aWdobGlnaHQgaHlzdGVyZXNpcyBpcyBvbmx5IGZvciBzZWxlY3Rpb24gc2VydmljZXMsIGJlY2F1 c2UgdGVsZXBob25lIG51bWJlciBoaWdobGlnaHRzIGFyZSBhbHJlYWR5IG11Y2ggbW9yZSBzdGFi bGUKLSAgICAvLyBieSB2aXJ0dWUgb2YgYmVpbmcgZXhwYW5kZWQgdG8gaW5jbHVkZSB0aGUgZW50 aXJlIHRlbGVwaG9uZSBudW1iZXIuCisgICAgLy8gYnkgdmlydHVlIG9mIGJlaW5nIGV4cGFuZGVk IHRvIGluY2x1ZGUgdGhlIGVudGlyZSB0ZWxlcGhvbmUgbnVtYmVyLiBIb3dldmVyLCB3ZSB3aWxs IHN0aWxsIGF2b2lkIGhpZ2hsaWdodGluZworICAgIC8vIHRlbGVwaG9uZSBudW1iZXJzIHdoaWxl IHRoZSBtb3VzZSBpcyBkb3duLgogICAgIGlmIChoaWdobGlnaHQtPnR5cGUoKSA9PSBIaWdobGln aHQ6OlR5cGU6OlRlbGVwaG9uZU51bWJlcikKLSAgICAgICAgcmV0dXJuIHN0ZDo6Y2hyb25vOjpt aWxsaXNlY29uZHM6Onplcm8oKTsKLQotICAgIHN0ZDo6Y2hyb25vOjpzdGVhZHlfY2xvY2s6OmR1 cmF0aW9uIG1pbmltdW1UaW1lVW50aWxIaWdobGlnaHRTaG91bGRCZVNob3duID0gMjAwX21zOwor ICAgICAgICByZXR1cm4gbW91c2VQcmVzc2VkID8gbWluaW11bVRpbWVVbnRpbEhpZ2hsaWdodFNo b3VsZEJlU2hvd24gOiAwX21zOwogCiAgICAgYXV0byBub3cgPSBzdGQ6OmNocm9ubzo6c3RlYWR5 X2Nsb2NrOjpub3coKTsKICAgICBhdXRvIHRpbWVTaW5jZUxhc3RTZWxlY3Rpb25DaGFuZ2UgPSBu b3cgLSBtX2xhc3RTZWxlY3Rpb25DaGFuZ2VUaW1lOwogICAgIGF1dG8gdGltZVNpbmNlSGlnaGxp Z2h0QmVjYW1lQWN0aXZlID0gbm93IC0gbV9uZXh0QWN0aXZlSGlnaGxpZ2h0Q2hhbmdlVGltZTsK KyAgICBhdXRvIHRpbWVTaW5jZUxhc3RNb3VzZVVwID0gbW91c2VQcmVzc2VkID8gMF9tcyA6IG5v dyAtIG1fbGFzdE1vdXNlVXBUaW1lOwogCi0gICAgcmV0dXJuIHN0ZDo6Y2hyb25vOjpkdXJhdGlv bl9jYXN0PHN0ZDo6Y2hyb25vOjptaWxsaXNlY29uZHM+KHN0ZDo6bWF4KG1pbmltdW1UaW1lVW50 aWxIaWdobGlnaHRTaG91bGRCZVNob3duIC0gdGltZVNpbmNlTGFzdFNlbGVjdGlvbkNoYW5nZSwg bWluaW11bVRpbWVVbnRpbEhpZ2hsaWdodFNob3VsZEJlU2hvd24gLSB0aW1lU2luY2VIaWdobGln aHRCZWNhbWVBY3RpdmUpKTsKKyAgICBhdXRvIHJlbWFpbmluZ0RlbGF5ID0gbWluaW11bVRpbWVV bnRpbEhpZ2hsaWdodFNob3VsZEJlU2hvd24gLSBzdGQ6Om1pbihzdGQ6Om1pbih0aW1lU2luY2VM YXN0U2VsZWN0aW9uQ2hhbmdlLCB0aW1lU2luY2VIaWdobGlnaHRCZWNhbWVBY3RpdmUpLCB0aW1l U2luY2VMYXN0TW91c2VVcCk7CisgICAgcmV0dXJuIHN0ZDo6Y2hyb25vOjpkdXJhdGlvbl9jYXN0 PHN0ZDo6Y2hyb25vOjptaWxsaXNlY29uZHM+KHJlbWFpbmluZ0RlbGF5KTsKIH0KIAogdm9pZCBT ZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyOjpkZXRlcm1pbmVBY3RpdmVIaWdobGlnaHRUaW1lckZp cmVkKFRpbWVyPFNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXI+JikKQEAgLTY4OCw2ICs2OTYsOCBA QCBib29sIFNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXI6Om1vdXNlRXZlbnQoUGFnZU92ZXJsYXkq LCBjb25zdCBXZWJNb3VzZUV2ZW50JiBldgogICAgICAgICBSZWZQdHI8SGlnaGxpZ2h0PiBtb3Vz ZURvd25IaWdobGlnaHQgPSBtX2N1cnJlbnRNb3VzZURvd25PbkJ1dHRvbkhpZ2hsaWdodDsKICAg ICAgICAgbV9jdXJyZW50TW91c2VEb3duT25CdXR0b25IaWdobGlnaHQgPSBudWxscHRyOwogCisg ICAgICAgIG1fbGFzdE1vdXNlVXBUaW1lID0gc3RkOjpjaHJvbm86OnN0ZWFkeV9jbG9jazo6bm93 KCk7CisKICAgICAgICAgaWYgKG1vdXNlSXNPdmVyQWN0aXZlSGlnaGxpZ2h0QnV0dG9uICYmIG1v dXNlRG93bkhpZ2hsaWdodCkgewogICAgICAgICAgICAgaGFuZGxlQ2xpY2sobV9tb3VzZVBvc2l0 aW9uLCAqbW91c2VEb3duSGlnaGxpZ2h0KTsKICAgICAgICAgICAgIHJldHVybiB0cnVlOwo=