<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>135861</bug_id>
          
          <creation_ts>2014-08-12 15:39:26 -0700</creation_ts>
          <short_desc>Generate WTFHeaderDetection.h and WebCoreHeaderDetection.h with CMake on Windows</short_desc>
          <delta_ts>2015-09-21 10:01:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alex Christensen">achristensen</reporter>
          <assigned_to name="Alex Christensen">achristensen</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>roger_fong</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1028633</commentid>
    <comment_count>0</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2014-08-12 15:39:26 -0700</bug_when>
    <thetext>I implemented stubs in https://bugs.webkit.org/show_bug.cgi?id=135807 but that does not do the same checks as the Visual Studio build system does.  Someone with access to the AppleWin internal build system needs to add the needed behavior.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1127479</commentid>
    <comment_count>1</comment_count>
      <attachid>261604</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-09-20 00:06:31 -0700</bug_when>
    <thetext>Created attachment 261604
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1127664</commentid>
    <comment_count>2</comment_count>
      <attachid>261604</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-09-21 09:59:19 -0700</bug_when>
    <thetext>Comment on attachment 261604
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1127665</commentid>
    <comment_count>3</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-09-21 10:01:19 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/190059</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>261604</attachid>
            <date>2015-09-20 00:06:31 -0700</date>
            <delta_ts>2015-09-21 09:59:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-135861-20150920000616.patch</filename>
            <type>text/plain</type>
            <size>4358</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MDAyMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE1LTA5LTIwICBBbGV4IENo
cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgR2VuZXJhdGUg
V2ViQ29yZUhlYWRlckRldGVjdGlvbi5oIHdpdGggQ01ha2Ugb24gV2luZG93cworICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1ODYxCisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBmaXhlcyBtYW55IG9m
IHRoZSBmYWlsaW5nIG1lZGlhIHRlc3RzLgorCisgICAgICAgICogQVZGb3VuZGF0aW9uU3VwcG9y
dC5weToKKyAgICAgICAgKGxvb2tGb3IpOgorICAgICAgICAoZmlsZUNvbnRhaW5zKToKKyAgICAg
ICAgVXNlIGEgY29tbWFuZCBsaW5lIHBhcmFtZXRlciBmb3IgdGhlIFdlYktpdExpYnJhcmllcyBk
aXJlY3RvcnkgCisgICAgICAgIHRvIG5vdCByZXF1aXJlIHRoZSBXRUJLSVRfTElCUkFSSUVTIGVu
dmlyb25tZW50IHZhcmlhYmxlIHdpdGggdGhlIENNYWtlIGJ1aWxkLgorICAgICAgICAqIERlcml2
ZWRTb3VyY2VzLm1ha2U6CisgICAgICAgIFBhc3MgV0VCS0lUX0xJQlJBUklFUyBhcyBhIGNvbW1h
bmQgbGluZSBwYXJhbWV0ZXIuCisgICAgICAgICogUGxhdGZvcm1BcHBsZVdpbi5jbWFrZToKKyAg
ICAgICAgQWRkZWQgbWlzc2luZyBzb3VyY2VzIGZvciB2aWRlby4KKyAgICAgICAgKiBQbGF0Zm9y
bVdpbi5jbWFrZToKKyAgICAgICAgR2VuZXJhdGUgV2ViQ29yZUhlYWRlckRldGVjdGlvbi5oIGNv
cnJlY3RseSBhbmQgY29weSB0aGUgbWVkaWEgY29udHJvbHMgc291cmNlcyB0byBXZWJLaXQucmVz
b3VyY2VzLgorCiAyMDE1LTA5LTE5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAK
ICAgICAgICAgW1dlYiBJRExdIEFkZCBzdXBwb3J0IGZvciBbUHV0Rm9yd2FyZHM9WFhYXSBJREwg
ZXh0ZW5kZWQgYXR0cmlidXRlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9BVkZvdW5kYXRpb25TdXBw
b3J0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0FWRm91bmRhdGlvblN1cHBvcnQu
cHkJKHJldmlzaW9uIDE4OTkzNikKKysrIFNvdXJjZS9XZWJDb3JlL0FWRm91bmRhdGlvblN1cHBv
cnQucHkJKHdvcmtpbmcgY29weSkKQEAgLTMxLDExICszMSwxMSBAQCBpbXBvcnQgc3lzCiBpbXBv
cnQgb3MKIAogZGVmIGxvb2tGb3IocmVsYXRpdmVQYXRoKToKLSAgICByZXR1cm4gb3MucGF0aC5p
c2ZpbGUob3MuZW52aXJvblsnV0VCS0lUX0xJQlJBUklFUyddICsgcmVsYXRpdmVQYXRoKQorICAg
IHJldHVybiBvcy5wYXRoLmlzZmlsZShzeXMuYXJndlsxXSArIHJlbGF0aXZlUGF0aCkKIAogCiBk
ZWYgZmlsZUNvbnRhaW5zKHJlbGF0aXZlUGF0aCwgcmVnZXhwKToKLSAgICB3aXRoIG9wZW4ob3Mu
ZW52aXJvblsnV0VCS0lUX0xJQlJBUklFUyddICsgcmVsYXRpdmVQYXRoKSBhcyBmaWxlOgorICAg
IHdpdGggb3BlbihzeXMuYXJndlsxXSArIHJlbGF0aXZlUGF0aCkgYXMgZmlsZToKICAgICAgICAg
Zm9yIGxpbmUgaW4gZmlsZToKICAgICAgICAgICAgIGlmIHJlZ2V4cC5zZWFyY2gobGluZSk6CiAg
ICAgICAgICAgICAgICAgcmV0dXJuIFRydWUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0Rlcml2ZWRT
b3VyY2VzLm1ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMu
bWFrZQkocmV2aXNpb24gMTg5OTM2KQorKysgU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMu
bWFrZQkod29ya2luZyBjb3B5KQpAQCAtMTI5NCw2ICsxMjk0LDYgQEAgaWZlcSAoJChPUyksV2lu
ZG93c19OVCkKIGFsbCA6IFdlYkNvcmVIZWFkZXJEZXRlY3Rpb24uaAogCiBXZWJDb3JlSGVhZGVy
RGV0ZWN0aW9uLmggOiAkKFdlYkNvcmUpL0FWRm91bmRhdGlvblN1cHBvcnQucHkgRGVyaXZlZFNv
dXJjZXMubWFrZQotCSQoUFlUSE9OKSAkKFdlYkNvcmUpL0FWRm91bmRhdGlvblN1cHBvcnQucHkg
PiAkQAorCSQoUFlUSE9OKSAkKFdlYkNvcmUpL0FWRm91bmRhdGlvblN1cHBvcnQucHkgJChXRUJL
SVRfTElCUkFSSUVTKSA+ICRACiAKIGVuZGlmICMgV2luZG93c19OVApJbmRleDogU291cmNlL1dl
YkNvcmUvUGxhdGZvcm1BcHBsZVdpbi5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y
ZS9QbGF0Zm9ybUFwcGxlV2luLmNtYWtlCShyZXZpc2lvbiAxODk5MzYpCisrKyBTb3VyY2UvV2Vi
Q29yZS9QbGF0Zm9ybUFwcGxlV2luLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC0xNyw5ICsxNywx
MyBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKIAogICAgIGxvYWRlci9jZi9SZXNvdXJj
ZUxvYWRlckNGTmV0LmNwcAogCisgICAgcGFnZS9DYXB0aW9uVXNlclByZWZlcmVuY2VzTWVkaWFB
Ri5jcHAKKwogICAgIHBhZ2Uvd2luL0ZyYW1lQ0dXaW4uY3BwCiAKICAgICBwbGF0Zm9ybS9jZi9D
RlVSTEV4dHJhcy5jcHAKKyAgICBwbGF0Zm9ybS9jZi9Db3JlTWVkaWFTb2Z0TGluay5jcHAKKyAg
ICBwbGF0Zm9ybS9jZi9NZWRpYUFjY2Vzc2liaWxpdHlTb2Z0TGluay5jcHAKICAgICBwbGF0Zm9y
bS9jZi9VUkxDRi5jcHAKIAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9JbmJh
bmRNZXRhZGF0YVRleHRUcmFja1ByaXZhdGVBVkYuY3BwCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Q
bGF0Zm9ybVdpbi5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdp
bi5jbWFrZQkocmV2aXNpb24gMTg5OTM2KQorKysgU291cmNlL1dlYkNvcmUvUGxhdGZvcm1XaW4u
Y21ha2UJKHdvcmtpbmcgY29weSkKQEAgLTI0OCwxMiArMjQ4LDEwIEBAIGVsc2UgKCkKICAgICBp
bmNsdWRlKFBsYXRmb3JtQXBwbGVXaW4uY21ha2UpCiBlbmRpZiAoKQogCi0jIEZJWE1FOiBUaGlz
IHNob3VsZCB0ZXN0IGlmIEFWRiBoZWFkZXJzIGFyZSBhdmFpbGFibGUuCi0jIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU4NjEKIGFkZF9jdXN0b21fY29tbWFuZCgK
ICAgICBPVVRQVVQgIiR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9XZWJDb3JlSGVhZGVy
RGV0ZWN0aW9uLmgiCiAgICAgV09SS0lOR19ESVJFQ1RPUlkgIiR7REVSSVZFRF9TT1VSQ0VTX1dF
QkNPUkVfRElSfSIKLSAgICBDT01NQU5EIGVjaG8gLyogSWRlbnRpZnlpbmcgQVZGb3VuZGF0aW9u
IFN1cHBvcnQgKi8gPiBXZWJDb3JlSGVhZGVyRGV0ZWN0aW9uLmgKKyAgICBDT01NQU5EICR7UFlU
SE9OX0VYRUNVVEFCTEV9ICR7V0VCQ09SRV9ESVJ9L0FWRm91bmRhdGlvblN1cHBvcnQucHkgJHtX
RUJLSVRfTElCUkFSSUVTX0RJUn0gPiBXZWJDb3JlSGVhZGVyRGV0ZWN0aW9uLmgKICAgICBWRVJC
QVRJTSkKIAogbWFrZV9kaXJlY3RvcnkoJHtDTUFLRV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUll9
L1dlYktpdC5yZXNvdXJjZXMvZW4ubHByb2opCkBAIC0yNjMsNiArMjYxLDEyIEBAIGZpbGUoQ09Q
WQogICAgIERFU1RJTkFUSU9OCiAgICAgJHtDTUFLRV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUll9
L1dlYktpdC5yZXNvdXJjZXMvZW4ubHByb2oKICkKK2ZpbGUoQ09QWQorICAgICIke1dFQkNPUkVf
RElSfS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmNzcyIKKyAgICAi
JHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5q
cyIKKyAgICBERVNUSU5BVElPTgorICAgICR7Q01BS0VfUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZ
fS9XZWJLaXQucmVzb3VyY2VzCispCiBpZiAoV1RGX1BMQVRGT1JNX1dJTl9DQUlSTyBBTkQgRVhJ
U1RTICR7V0VCS0lUX0xJQlJBUklFU19ESVJ9L2NhY2VydC5wZW0pCiAgICAgbWFrZV9kaXJlY3Rv
cnkoJHtDTUFLRV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUll9L1dlYktpdC5yZXNvdXJjZXMvY2Vy
dGlmaWNhdGVzKQogICAgIGZpbGUoQ09QWQo=
</data>
<flag name="review"
          id="286793"
          type_id="1"
          status="+"
          setter="bfulgham"
    />
          </attachment>
      

    </bug>

</bugzilla>