135854 2014-08-12 14:48:16 -0700 REGRESSION (r172424): Extra menu header in combined telephone number menu when no phone paired 2014-08-12 15:43:17 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton beidson enrica webkit-bug-importer oldest_to_newest 1028610 0 thorton 2014-08-12 14:48:16 -0700 There's a "Call with iPhone" header and no phone numbers if you don't have a phone paired. 1028611 1 webkit-bug-importer 2014-08-12 14:48:34 -0700 <rdar://problem/17996339> 1028614 2 236470 thorton 2014-08-12 14:51:04 -0700 Created attachment 236470 patch 1028634 3 236470 enrica 2014-08-12 15:39:32 -0700 Comment on attachment 236470 patch Sure. Sorry about that. 1028635 4 thorton 2014-08-12 15:43:17 -0700 http://trac.webkit.org/changeset/172498 236470 2014-08-12 14:51:04 -0700 2014-08-12 15:39:31 -0700 patch phone.diff text/plain 2974 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxOTZjNTMyLi4wYmVjOTE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTQtMDgtMTIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK KyAgICAgICAgUkVHUkVTU0lPTiAocjE3MjQyNCk6IEV4dHJhIG1lbnUgaGVhZGVyIGluIGNvbWJp bmVkIHRlbGVwaG9uZSBudW1iZXIgbWVudSB3aGVuIG5vIHBob25lIHBhaXJlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1ODU0CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xNzk5NjMzOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1lbnVQcm94eU1hYy5t bToKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dE1lbnVQcm94eU1hYzo6c2V0dXBTZXJ2aWNl c01lbnUpOgorICAgICAgICBHZXQgYWxsIHRoZSBtZW51IGl0ZW1zIGFoZWFkIG9mIHRpbWUsIGFu ZCBvbmx5IGFkZCB0aGUgc2hhcmVkIGhlYWRlcgorICAgICAgICBpZiB0aGVyZSBhcmUgYW55IHRl bGVwaG9uZSBudW1iZXIgbWVudSBpdGVtcy4KKworMjAxNC0wOC0xMiAgVGltIEhvcnRvbiAgPHRp bW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKwogICAgICAgICBTbWFsbCByZWdpb24gKH4xcHggdGFs bCkgd2hlcmUgeW91IGdldCB0aGUgc2VsZWN0aW9uIGJ1dHRvbiBpbnN0ZWFkIG9mIHRoZSBwaG9u ZSBudW1iZXIgb3ZlcmxheQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM1ODUyCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzk5Mjc5NT4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1lbnVQcm94eU1h Yy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1lbnVQcm94eU1h Yy5tbQppbmRleCAwYzdkZGFiLi5iMjBmOTZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvbWFjL1dlYkNvbnRleHRNZW51UHJveHlNYWMubW0KKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL21hYy9XZWJDb250ZXh0TWVudVByb3h5TWFjLm1tCkBAIC00MDUsNyArNDA1 LDE1IEBAIHZvaWQgV2ViQ29udGV4dE1lbnVQcm94eU1hYzo6c2V0dXBTZXJ2aWNlc01lbnUoY29u c3QgQ29udGV4dE1lbnVDb250ZXh0RGF0YSYgY29uCiAKICAgICAvLyBFeHBsaWNpdGx5IGFkZCBh IG1lbnUgaXRlbSBmb3IgZWFjaCB0ZWxlcGhvbmUgbnVtYmVyIHRoYXQgaXMgaW4gdGhlIHNlbGVj dGlvbi4KICAgICBjb25zdCBWZWN0b3I8U3RyaW5nPiYgc2VsZWN0ZWRUZWxlcGhvbmVOdW1iZXJz ID0gY29udGV4dC5zZWxlY3RlZFRlbGVwaG9uZU51bWJlcnMoKTsKLSAgICBpZiAoIXNlbGVjdGVk VGVsZXBob25lTnVtYmVycy5pc0VtcHR5KCkpIHsKKyAgICBWZWN0b3I8UmV0YWluUHRyPE5TTWVu dUl0ZW0+PiB0ZWxlcGhvbmVOdW1iZXJNZW51SXRlbXM7CisgICAgZm9yIChhdXRvJiB0ZWxlcGhv bmVOdW1iZXIgOiBzZWxlY3RlZFRlbGVwaG9uZU51bWJlcnMpIHsKKyAgICAgICAgaWYgKE5TTWVu dUl0ZW0gKml0ZW0gPSBtZW51SXRlbUZvclRlbGVwaG9uZU51bWJlcih0ZWxlcGhvbmVOdW1iZXIp KSB7CisgICAgICAgICAgICBbaXRlbSBzZXRJbmRlbnRhdGlvbkxldmVsOjFdOworICAgICAgICAg ICAgdGVsZXBob25lTnVtYmVyTWVudUl0ZW1zLmFwcGVuZChpdGVtKTsKKyAgICAgICAgfQorICAg IH0KKworICAgIGlmICghdGVsZXBob25lTnVtYmVyTWVudUl0ZW1zLmlzRW1wdHkoKSkgewogICAg ICAgICBpZiAobV9zZXJ2aWNlc01lbnUpCiAgICAgICAgICAgICBbbV9zZXJ2aWNlc01lbnUgaW5z ZXJ0SXRlbTpbTlNNZW51SXRlbSBzZXBhcmF0b3JJdGVtXSBhdEluZGV4OjBdOwogICAgICAgICBl bHNlCkBAIC00MTQsMTIgKzQyMiw4IEBAIHZvaWQgV2ViQ29udGV4dE1lbnVQcm94eU1hYzo6c2V0 dXBTZXJ2aWNlc01lbnUoY29uc3QgQ29udGV4dE1lbnVDb250ZXh0RGF0YSYgY29uCiAgICAgICAg IE5TTWVudUl0ZW0gKmdyb3VwRW50cnkgPSBbW05TTWVudUl0ZW0gYWxsb2NdIGluaXRXaXRoVGl0 bGU6bWVudUl0ZW1UaXRsZUZvclRlbGVwaG9uZU51bWJlckdyb3VwKCkgYWN0aW9uOm5pbCBrZXlF cXVpdmFsZW50OkAiIl07CiAgICAgICAgIFtncm91cEVudHJ5IHNldEVuYWJsZWQ6Tk9dOwogICAg ICAgICBbbV9zZXJ2aWNlc01lbnUgaW5zZXJ0SXRlbTpncm91cEVudHJ5IGF0SW5kZXg6aXRlbVBv c2l0aW9uKytdOwotICAgICAgICBmb3IgKGF1dG8mIHRlbGVwaG9uZU51bWJlciA6IHNlbGVjdGVk VGVsZXBob25lTnVtYmVycykgewotICAgICAgICAgICAgaWYgKE5TTWVudUl0ZW0gKml0ZW0gPSBt ZW51SXRlbUZvclRlbGVwaG9uZU51bWJlcih0ZWxlcGhvbmVOdW1iZXIpKSB7Ci0gICAgICAgICAg ICAgICAgW2l0ZW0gc2V0SW5kZW50YXRpb25MZXZlbDoxXTsKLSAgICAgICAgICAgICAgICBbbV9z ZXJ2aWNlc01lbnUgaW5zZXJ0SXRlbTppdGVtIGF0SW5kZXg6aXRlbVBvc2l0aW9uKytdOwotICAg ICAgICAgICAgfQotICAgICAgICB9CisgICAgICAgIGZvciAoYXV0byYgbWVudUl0ZW0gOiB0ZWxl cGhvbmVOdW1iZXJNZW51SXRlbXMpCisgICAgICAgICAgICBbbV9zZXJ2aWNlc01lbnUgaW5zZXJ0 SXRlbTptZW51SXRlbS5nZXQoKSBhdEluZGV4Oml0ZW1Qb3NpdGlvbisrXTsKICAgICB9CiAKICAg ICAvLyBJZiB0aGVyZSBpcyBubyBzZXJ2aWNlcyBtZW51LCB0aGVuIHRoZSBleGlzdGluZyBzZXJ2 aWNlcyBvbiB0aGUgc3lzdGVtIGhhdmUgY2hhbmdlZCwgc28gcmVmcmVzaCB0aGF0IGxpc3Qgb2Yg c2VydmljZXMuCg==